@lightningjs/blits 0.5.3 → 0.5.4

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+# v0.5.4
+
+_5 dec 2023_
+
+- Fixed issue with Components and Elements not always being cleaned up in forloop
+- Added support for nested children inside a forloop on an Element
+
 # v0.5.3
 
 _4 dec 2023_

package/boilerplate/package.json

@@ -31,6 +31,6 @@
     "vite": "^4.0.4"
   },
   "dependencies": {
-    "@lightningjs/blits": "^0.5.3"
+    "@lightningjs/blits": "^0.5.4"
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/blits",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "description": "Blits: The Lightning 3 App Development Framework",
   "bin": "bin/index.cjs",
   "exports": {

package/src/lib/codegenerator/generator.js

@@ -106,7 +106,7 @@ const generateElementCode = function (
   `)
 
   if (children) {
-    generateCode.call(this, { children }, `elms[${counter}]`)
+    generateCode.call(this, { children }, `${elm}`, options)
   }
 }
 
@@ -181,7 +181,6 @@ const generateComponentCode = function (
     }
   `)
 
-  counter++
   if (children) {
     generateElementCode.call(this, { children }, false, { ...options })
   }
@@ -217,6 +216,7 @@ const generateForLoopCode = function (templateObject, parent) {
     const keys = []
     for(let __index = 0; __index < collection.length; __index++) {
       parent = ${parent}
+      if(!component.key) keys.length = 0
       const scope = Object.assign(component, {
         key: Math.random(),
         ${index}: __index,
@@ -264,7 +264,7 @@ const generateForLoopCode = function (templateObject, parent) {
   this.effectsCode.push(ctx.renderCode.join('\n'))
 }
 
-const generateCode = function (templateObject, parent = false) {
+const generateCode = function (templateObject, parent = false, options = {}) {
   templateObject.children &&
     templateObject.children.forEach((childTemplateObject) => {
       counter++
@@ -273,9 +273,9 @@ const generateCode = function (templateObject, parent = false) {
         generateForLoopCode.call(this, childTemplateObject, parent)
       } else {
         if (childTemplateObject.type === 'Element' || childTemplateObject.type === 'Slot') {
-          generateElementCode.call(this, childTemplateObject, parent)
+          generateElementCode.call(this, childTemplateObject, parent, options)
         } else {
-          generateComponentCode.call(this, childTemplateObject, parent)
+          generateComponentCode.call(this, childTemplateObject, parent, options)
         }
       }
     })