@lightdash/common 0.1470.0 → 0.1472.0

package/dist/index.d.ts

@@ -130,6 +130,7 @@ export * from './types/userAttributes';
 export * from './types/userWarehouseCredentials';
 export * from './types/validation';
 export * from './types/warehouse';
+export * from './utils/accessors';
 export * from './utils/additionalMetrics';
 export * from './utils/api';
 export { default as assertUnreachable } from './utils/assertUnreachable';

package/dist/index.js

@@ -97,6 +97,7 @@ tslib_1.__exportStar(require("./types/userAttributes"), exports);
 tslib_1.__exportStar(require("./types/userWarehouseCredentials"), exports);
 tslib_1.__exportStar(require("./types/validation"), exports);
 tslib_1.__exportStar(require("./types/warehouse"), exports);
+tslib_1.__exportStar(require("./utils/accessors"), exports);
 tslib_1.__exportStar(require("./utils/additionalMetrics"), exports);
 tslib_1.__exportStar(require("./utils/api"), exports);
 var assertUnreachable_1 = require("./utils/assertUnreachable");
@@ -340,14 +341,13 @@ const getDateGroupLabel = (axisItem) => {
 };
 exports.getDateGroupLabel = getDateGroupLabel;
 const getAxisName = ({ isAxisTheSameForAllSeries, selectedAxisIndex, axisReference, axisIndex, axisName, series, itemsMap, }) => {
-    const defaultItem = itemsMap
-        ? itemsMap[(series || [])[0]?.encode[axisReference].field]
-        : undefined;
+    const itemIndex = (series || [])[0]?.encode[axisReference].field;
+    const defaultItem = itemsMap && itemIndex ? itemsMap[itemIndex] : undefined;
     const dateGroupName = defaultItem
         ? (0, exports.getDateGroupLabel)(defaultItem)
         : undefined;
     const fallbackSeriesName = series && series.length === 1
-        ? series[0].name ||
+        ? series[0]?.name ||
             (defaultItem && (0, item_1.getItemLabelWithoutTableName)(defaultItem))
         : undefined;
     return !isAxisTheSameForAllSeries || selectedAxisIndex === axisIndex

package/dist/pivotTable/pivotQueryResults.js

@@ -4,7 +4,9 @@ exports.pivotResultsAsCsv = exports.pivotQueryResults = void 0;
 const tslib_1 = require("tslib");
 const isNumber_1 = tslib_1.__importDefault(require("lodash/isNumber"));
 const last_1 = tslib_1.__importDefault(require("lodash/last"));
+const errors_1 = require("../types/errors");
 const field_1 = require("../types/field");
+const accessors_1 = require("../utils/accessors");
 const formatting_1 = require("../utils/formatting");
 const isRecursiveRecord = (value) => typeof value === 'object' && value !== null;
 const create2DArray = (rows, columns, value = null) => Array.from({ length: rows }, () => Array.from({ length: columns }, () => value));
@@ -19,6 +21,9 @@ const setIndexByKey = (obj, keys, value) => {
         return false;
     }
     const [key, ...rest] = keys;
+    if (key === undefined) {
+        throw new errors_1.UnexpectedIndexError(`setIndexByKey: Cannot get key from keys ${keys.length}`);
+    }
     if (rest.length === 0) {
         if (obj[key] === undefined) {
             // eslint-disable-next-line no-param-reassign
@@ -42,6 +47,9 @@ const getIndexByKey = (obj, keys) => {
         throw new Error('Cannot get key from empty keys array');
     }
     const [key, ...rest] = keys;
+    if (key === undefined) {
+        throw new errors_1.UnexpectedServerError(`getIndexByKey: Cannot get key from keys ${keys.length}`);
+    }
     if (rest.length === 0) {
         const value = obj[key];
         if (typeof value !== 'number') {
@@ -79,8 +87,11 @@ const getAllIndices = (obj) => Object.values(obj).reduce((acc, value) => {
 }, []);
 const getAllIndicesByKey = (obj, keys) => {
     const [key, ...rest] = keys;
+    if (key === undefined) {
+        throw new errors_1.UnexpectedIndexError('Cannot set key on undefined');
+    }
     if (rest.length === 0) {
-        const value = obj[key];
+        const value = (0, accessors_1.getObjectValue)(obj, key);
         if ((0, isNumber_1.default)(value)) {
             return [value];
         }
@@ -119,7 +130,10 @@ const getColSpanByKey = (currentColumnPosition, obj, keys) => {
 const combinedRetrofit = (data, getField, getFieldLabel) => {
     const indexValues = data.indexValues.length ? data.indexValues : [[]];
     const baseIdInfo = (0, last_1.default)(data.headerValues);
-    const uniqueIdsForDataValueColumns = Array(data.headerValues[0].length);
+    if (data.headerValues[0] === undefined) {
+        throw new errors_1.UnexpectedIndexError('combinedRetrofit: Cannot get header values');
+    }
+    const uniqueIdsForDataValueColumns = Array((0, accessors_1.getArrayValue)(data.headerValues, 0).length);
     data.headerValues.forEach((headerRow) => {
         headerRow.forEach((headerColValue, colIndex) => {
             uniqueIdsForDataValueColumns[colIndex] = `${(uniqueIdsForDataValueColumns[colIndex] ?? '') +
@@ -170,12 +184,13 @@ const combinedRetrofit = (data, getField, getFieldLabel) => {
                 columnType: 'indexValue',
             };
         });
-        const remappedDataValues = data.dataValues[rowIndex].map((dataValue, colIndex) => {
+        const remappedDataValues = (0, accessors_1.getArrayValue)(data.dataValues, rowIndex).map((dataValue, colIndex) => {
             const baseIdInfoForCol = baseIdInfo
                 ? baseIdInfo[colIndex]
                 : undefined;
             const baseId = baseIdInfoForCol?.fieldId;
-            const id = uniqueIdsForDataValueColumns[colIndex] + colIndex;
+            const id = (0, accessors_1.getArrayValue)(uniqueIdsForDataValueColumns, colIndex) +
+                colIndex;
             return {
                 baseId,
                 fieldId: id,
@@ -286,19 +301,19 @@ const pivotQueryResults = ({ pivotConfig, metricQuery, rows, options, getField,
     for (let nRow = 0; nRow < N_ROWS; nRow += 1) {
         const row = rows[nRow];
         for (let nMetric = 0; nMetric < metrics.length; nMetric += 1) {
-            const metric = metrics[nMetric];
             const indexRowValues = indexDimensions
                 .map((fieldId) => ({
                 type: 'value',
                 fieldId,
-                value: row[fieldId].value,
+                value: (0, accessors_1.getObjectValue)(row, fieldId).value,
                 colSpan: 1,
             }))
                 .concat(pivotConfig.metricsAsRows
                 ? [
                     {
                         type: 'label',
-                        fieldId: metric.fieldId,
+                        fieldId: (0, accessors_1.getArrayValue)(metrics, nMetric)
+                            .fieldId,
                     },
                 ]
                 : []);
@@ -306,7 +321,7 @@ const pivotQueryResults = ({ pivotConfig, metricQuery, rows, options, getField,
                 .map((fieldId) => ({
                 type: 'value',
                 fieldId,
-                value: row[fieldId].value,
+                value: (0, accessors_1.getObjectValue)(row, fieldId).value,
                 colSpan: 1,
             }))
                 .concat(pivotConfig.metricsAsRows
@@ -314,7 +329,8 @@ const pivotQueryResults = ({ pivotConfig, metricQuery, rows, options, getField,
                 : [
                     {
                         type: 'label',
-                        fieldId: metric.fieldId,
+                        fieldId: (0, accessors_1.getArrayValue)(metrics, nMetric)
+                            .fieldId,
                     },
                 ]);
             // Write the index values
@@ -333,7 +349,7 @@ const pivotQueryResults = ({ pivotConfig, metricQuery, rows, options, getField,
         }
     }
     const headerValues = headerValuesT[0]?.map((_, colIndex) => headerValuesT.map((row, rowIndex) => {
-        const cell = row[colIndex];
+        const cell = (0, accessors_1.getArrayValue)(row, colIndex);
         if (cell.type === 'label') {
             return cell;
         }
@@ -363,7 +379,7 @@ const pivotQueryResults = ({ pivotConfig, metricQuery, rows, options, getField,
         const row = rows[nRow];
         for (let nMetric = 0; nMetric < metrics.length; nMetric += 1) {
             const metric = metrics[nMetric];
-            const { value } = row[metric.fieldId];
+            const { value } = row?.[metric.fieldId] ?? {};
             const rowKeys = [
                 ...indexDimensions.map((d) => row[d].value.raw),
                 ...(pivotConfig.metricsAsRows ? [metric.fieldId] : []),

package/dist/types/errors.d.ts

@@ -57,6 +57,11 @@ export declare class UnexpectedServerError extends LightdashError {
         [key: string]: AnyType;
     });
 }
+export declare class UnexpectedIndexError extends LightdashError {
+    constructor(message?: string, data?: {
+        [key: string]: AnyType;
+    });
+}
 export declare class UnexpectedGitError extends LightdashError {
     constructor(message?: string, data?: {
         [key: string]: AnyType;

package/dist/types/errors.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getErrorMessage = exports.UnexpectedGoogleSheetsError = exports.SlackInstallationNotFoundError = exports.KnexPaginationError = exports.NotEnoughResults = exports.MissingConfigError = exports.AlreadyExistsError = exports.AlreadyProcessingError = exports.SmptError = exports.WarehouseQueryError = exports.WarehouseConnectionError = exports.InvalidUser = exports.NotFoundError = exports.DbtError = exports.FieldReferenceError = exports.CompileError = exports.ParseError = exports.UnexpectedDatabaseError = exports.UnexpectedGitError = exports.UnexpectedServerError = exports.MissingWarehouseCredentialsError = exports.MissingCatalogEntryError = exports.NonCompiledModelError = exports.ParameterError = exports.ExpiredError = exports.NotExistsError = exports.AuthorizationError = exports.DeactivatedAccountError = exports.ForbiddenError = exports.LightdashError = void 0;
+exports.getErrorMessage = exports.UnexpectedGoogleSheetsError = exports.SlackInstallationNotFoundError = exports.KnexPaginationError = exports.NotEnoughResults = exports.MissingConfigError = exports.AlreadyExistsError = exports.AlreadyProcessingError = exports.SmptError = exports.WarehouseQueryError = exports.WarehouseConnectionError = exports.InvalidUser = exports.NotFoundError = exports.DbtError = exports.FieldReferenceError = exports.CompileError = exports.ParseError = exports.UnexpectedDatabaseError = exports.UnexpectedGitError = exports.UnexpectedIndexError = exports.UnexpectedServerError = exports.MissingWarehouseCredentialsError = exports.MissingCatalogEntryError = exports.NonCompiledModelError = exports.ParameterError = exports.ExpiredError = exports.NotExistsError = exports.AuthorizationError = exports.DeactivatedAccountError = exports.ForbiddenError = exports.LightdashError = void 0;
 class LightdashError extends Error {
     constructor({ message, name, statusCode, data }) {
         super(message);
@@ -120,6 +120,17 @@ class UnexpectedServerError extends LightdashError {
     }
 }
 exports.UnexpectedServerError = UnexpectedServerError;
+class UnexpectedIndexError extends LightdashError {
+    constructor(message = 'Invalid index in array.', data = {}) {
+        super({
+            message,
+            name: 'UnexpectedIndexError',
+            statusCode: 500,
+            data,
+        });
+    }
+}
+exports.UnexpectedIndexError = UnexpectedIndexError;
 class UnexpectedGitError extends LightdashError {
     constructor(message = 'Unexpected error in Git adapter', data = {}) {
         super({

package/dist/types/projects.d.ts

@@ -174,6 +174,7 @@ export interface DbtCloudIDEProjectConfig extends DbtProjectConfigBase {
     api_key: string;
     environment_id: string;
     discovery_api_endpoint?: string;
+    tags?: string[];
 }
 export interface DbtGithubProjectConfig extends DbtProjectCompilerBase {
     type: DbtProjectType.GITHUB;

package/dist/utils/accessors.d.ts

@@ -0,0 +1,2 @@
+export declare const getArrayValue: <T>(obj: ArrayLike<T> | undefined, key: number, errorMessage?: string) => T;
+export declare const getObjectValue: <T>(obj: Record<string | number, T> | undefined, key: string | number, errorMessage?: string) => T;

package/dist/utils/accessors.js

@@ -0,0 +1,28 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.getObjectValue = exports.getArrayValue = void 0;
+const errors_1 = require("../types/errors");
+const getArrayValue = (obj, key, errorMessage) => {
+    if (obj === undefined) {
+        throw new errors_1.UnexpectedIndexError(errorMessage || `Cannot get key "${key}" value from empty array`);
+    }
+    const value = obj[key];
+    if (value === undefined) {
+        console.trace();
+        throw new errors_1.UnexpectedIndexError(errorMessage || `Cannot get key "${key}" value from array`);
+    }
+    return value;
+};
+exports.getArrayValue = getArrayValue;
+const getObjectValue = (obj, key, errorMessage) => {
+    if (obj === undefined) {
+        throw new errors_1.UnexpectedIndexError(errorMessage || `Cannot get key "${key}" value from empty object`);
+    }
+    const value = obj[key];
+    if (value === undefined) {
+        console.trace();
+        throw new errors_1.UnexpectedIndexError(errorMessage || `Cannot get key "${key}" value from object`);
+    }
+    return value;
+};
+exports.getObjectValue = getObjectValue;

package/dist/utils/scheduler.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.isValidTimezone = exports.isValidFrequency = exports.getHumanReadableCronExpression = exports.getTimezoneLabel = exports.formatMinutesOffset = exports.getTzMinutesOffset = void 0;
 const tslib_1 = require("tslib");
 const cronstrue_1 = tslib_1.__importDefault(require("cronstrue"));
+const accessors_1 = require("./accessors");
 function getTzMinutesOffset(oldTz, newTz) {
     const date = new Date();
     const oldFormattedString = date.toLocaleString('en-US', {
@@ -48,7 +49,8 @@ function getHumanReadableCronExpression(cronExpression, timezone) {
     const valueWithTimezone = value
         .replaceAll(' PM', ` PM (UTC ${offsetString})`)
         .replaceAll(' AM', ` AM (UTC ${offsetString})`);
-    return valueWithTimezone[0].toLowerCase() + valueWithTimezone.slice(1);
+    return ((0, accessors_1.getArrayValue)(valueWithTimezone, 0).toLowerCase() +
+        valueWithTimezone.slice(1));
 }
 exports.getHumanReadableCronExpression = getHumanReadableCronExpression;
 function isValidFrequency(cronExpression) {
@@ -62,6 +64,9 @@ function isValidFrequency(cronExpression) {
         return false;
     }
     const [minutePart] = cronParts;
+    if (minutePart === undefined) {
+        return false;
+    }
     if (minutePart.includes('/') ||
         minutePart.includes(',') ||
         minutePart.includes('-')) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightdash/common",
-  "version": "0.1470.0",
+  "version": "0.1472.0",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "files": [