@lightdash/common 0.1377.0 → 0.1377.2

package/dist/types/savedCharts.d.ts

@@ -333,7 +333,7 @@ export declare const getDefaultSeriesColor: (index: number) => string;
 export declare const isSeriesWithMixedChartTypes: (series: Series[] | undefined) => boolean;
 export declare const getChartType: (chartKind: ChartKind | undefined) => ChartType;
 export declare const getChartKind: (chartType: ChartType, value: ChartConfig['config']) => ChartKind | undefined;
-export declare const getEChartsChartTypeFromChartKind: (chartKind: ChartKind.VERTICAL_BAR | ChartKind.LINE | ChartKind.AREA | ChartKind.SCATTER) => CartesianSeriesType;
+export declare const getEChartsChartTypeFromChartKind: (chartKind: ChartKind) => CartesianSeriesType;
 export type ChartSummary = Pick<SavedChart, 'uuid' | 'name' | 'description' | 'spaceName' | 'spaceUuid' | 'projectUuid' | 'organizationUuid' | 'pinnedListUuid' | 'dashboardUuid' | 'dashboardName' | 'slug'> & {
     chartType?: ChartType | undefined;
     chartKind?: ChartKind | undefined;

package/dist/types/savedCharts.js

@@ -195,7 +195,7 @@ const getEChartsChartTypeFromChartKind = (chartKind) => {
         case ChartKind.SCATTER:
             return CartesianSeriesType.SCATTER;
         default:
-            return (0, assertUnreachable_1.default)(chartKind, `Unknown chart kind: ${chartKind}`);
+            return CartesianSeriesType.BAR;
     }
 };
 exports.getEChartsChartTypeFromChartKind = getEChartsChartTypeFromChartKind;

package/dist/visualizations/CartesianChartDataModel.d.ts

@@ -1,7 +1,7 @@
 import { Format } from '../types/field';
 import { type Organization } from '../types/organization';
 import { type RawResultRow } from '../types/results';
-import { ChartKind } from '../types/savedCharts';
+import { ChartKind, type CartesianSeriesType } from '../types/savedCharts';
 import { type SemanticLayerQuery } from '../types/semanticLayer';
 import { VizIndexType, type PivotChartData, type PivotChartLayout, type VizCartesianChartConfig, type VizCartesianChartOptions } from './types';
 import { type IResultsRunner } from './types/IResultsRunner';
@@ -69,7 +69,7 @@ export type CartesianChartDisplay = {
             format?: Format;
             yAxisIndex?: number;
             color?: string;
-            type?: ChartKind.LINE | ChartKind.VERTICAL_BAR;
+            type?: CartesianSeriesType.LINE | CartesianSeriesType.BAR;
             valueLabelPosition?: ValueLabelPositionOptions;
         };
     };

package/dist/visualizations/CartesianChartDataModel.js

@@ -296,21 +296,24 @@ class CartesianChartDataModel {
         const shouldStack = display?.stack === true;
         const xAxisReference = transformedData.indexColumn?.reference;
         const series = transformedData.valuesColumns.map((seriesColumn, index) => {
-            const seriesFormat = Object.values(display?.series || {}).find((s) => s.yAxisIndex === index)?.format ?? display?.yAxis?.[0]?.format; // TODO: don't always use the first y-axis format once there are multiple y-axes
+            const seriesDisplay = Object.values(display?.series || {}).find((s) => s.yAxisIndex === index);
+            const seriesFormat = seriesDisplay?.format ?? display?.yAxis?.[0]?.format; // TODO: don't always use the first y-axis format once there are multiple y-axes;
+            const seriesColor = seriesDisplay?.color;
+            const seriesValueLabelPosition = seriesDisplay?.valueLabelPosition;
+            const seriesType = seriesDisplay?.type ?? defaultSeriesType;
             const singleYAxisLabel = 
             // NOTE: When there's only one y-axis left, set the label on the series as well
             transformedData.valuesColumns.length === 1 &&
                 display?.yAxis?.[0]?.label
                 ? display.yAxis[0].label
                 : undefined;
-            const seriesLabel = singleYAxisLabel ??
-                Object.values(display?.series || {}).find((s) => s.yAxisIndex === index)?.label;
-            const seriesColor = Object.values(display?.series || {}).find((s) => s.yAxisIndex === index)?.color;
-            const seriesValueLabelPosition = Object.values(display?.series || {}).find((s) => s.yAxisIndex === index)?.valueLabelPosition;
+            const seriesLabel = singleYAxisLabel ?? seriesDisplay?.label;
             return {
                 dimensions: [xAxisReference, seriesColumn],
-                type: defaultSeriesType,
-                stack: shouldStack ? 'stack-all-series' : undefined,
+                type: seriesType ?? defaultSeriesType,
+                stack: shouldStack && seriesType === 'bar'
+                    ? 'stack-all-series'
+                    : undefined,
                 name: seriesLabel ||
                     (0, field_1.capitalize)(seriesColumn.toLowerCase()).replaceAll('_', ' '),
                 encode: {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@lightdash/common",
-    "version": "0.1377.0",
+    "version": "0.1377.2",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "files": [