@lightdash/cli 2.228.1 → 2.229.1

package/dist/handlers/apps/appCodeFiles.test.js

@@ -1,391 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const tslib_1 = require("tslib");
-const fs_1 = require("fs");
-const os = tslib_1.__importStar(require("os"));
-const path = tslib_1.__importStar(require("path"));
-const appCodeFiles_1 = require("./appCodeFiles");
-const makeCode = (appUuid, projectUuid) => ({
-    manifest: {
-        codeVersion: 1,
-        appUuid,
-        projectUuid,
-        version: 3,
-        name: 'My App',
-        description: '',
-        template: null,
-        downloadedAt: '2026-06-25T00:00:00.000Z',
-    },
-    files: [],
-});
-describe('buildImportBody', () => {
-    it('sets targetAppUuid from manifest when uploading to the same project', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {});
-        expect(body.targetAppUuid).toBe('app-uuid-1');
-    });
-    it('leaves targetAppUuid undefined when uploading to a different project', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-OTHER', {});
-        expect(body.targetAppUuid).toBeUndefined();
-    });
-    it('uses --app option regardless of project match', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {
-            app: 'explicit-app-uuid',
-        });
-        expect(body.targetAppUuid).toBe('explicit-app-uuid');
-    });
-    it('uses --app option even when project differs', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-OTHER', {
-            app: 'explicit-app-uuid',
-        });
-        expect(body.targetAppUuid).toBe('explicit-app-uuid');
-    });
-    it('passes spaceUuid when --space is provided', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {
-            space: 'space-uuid-1',
-        });
-        expect(body.spaceUuid).toBe('space-uuid-1');
-    });
-    it('leaves spaceUuid undefined when --space is not provided', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {});
-        expect(body.spaceUuid).toBeUndefined();
-    });
-    it('includes the full code bundle in the body', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {});
-        expect(body.code).toBe(code);
-    });
-    it('forces a create when createNew is set, even in the same project', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', { createNew: true });
-        expect(body.targetAppUuid).toBeUndefined();
-    });
-    it('createNew overrides an explicit app target', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {
-            app: 'explicit-app-uuid',
-            createNew: true,
-        });
-        expect(body.targetAppUuid).toBeUndefined();
-    });
-    it('includes createNew: true in the body when the flag is set', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', { createNew: true });
-        expect(body.createNew).toBe(true);
-        expect(body.targetAppUuid).toBeUndefined();
-    });
-    it('omits the createNew key entirely when the flag is not set', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        const body = (0, appCodeFiles_1.buildImportBody)(code, 'proj-uuid-1', {});
-        expect('createNew' in body).toBe(false);
-    });
-});
-const bundle = {
-    manifest: {
-        codeVersion: 1,
-        appUuid: 'a',
-        projectUuid: 'p',
-        version: 1,
-        name: 'N',
-        description: '',
-        template: null,
-        downloadedAt: '2026-06-30T00:00:00.000Z',
-    },
-    files: [
-        {
-            path: 'src/assets/app.js',
-            contentBase64: Buffer.from('console.log(1)').toString('base64'),
-        },
-        {
-            path: 'src/index.html',
-            contentBase64: Buffer.from('<html>').toString('base64'),
-        },
-    ],
-};
-it('readManifestFromDir returns just the manifest', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await (0, appCodeFiles_1.writeBundleToDir)(dir, bundle);
-    const manifest = await (0, appCodeFiles_1.readManifestFromDir)(dir);
-    expect(manifest).toEqual(bundle.manifest);
-});
-it('writes then reads back an identical bundle', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await (0, appCodeFiles_1.writeBundleToDir)(dir, bundle);
-    expect(await fs_1.promises.readFile(path.join(dir, 'src/assets/app.js'), 'utf-8')).toBe('console.log(1)');
-    const read = await (0, appCodeFiles_1.readBundleFromDir)(dir);
-    expect(read).toEqual(bundle);
-});
-it('refuses to write a file whose path escapes the target directory', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await expect((0, appCodeFiles_1.writeBundleToDir)(dir, {
-        ...bundle,
-        files: [
-            {
-                path: '../escape.js',
-                contentBase64: Buffer.from('x').toString('base64'),
-            },
-        ],
-    })).rejects.toThrow(/outside the target directory/);
-});
-it('writes a manifest-only bundle with no files', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await (0, appCodeFiles_1.writeBundleToDir)(dir, { ...bundle, files: [] });
-    const read = await (0, appCodeFiles_1.readBundleFromDir)(dir);
-    expect(read).toEqual({ ...bundle, files: [] });
-});
-it('upload reads back only src/ files, ignoring scaffolding and context', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await (0, appCodeFiles_1.writeBundleToDir)(dir, bundle); // bundle.files are src/*
-    // simulate Phase 2 extra files on disk:
-    await fs_1.promises.mkdir(path.join(dir, '.lightdash/context'), { recursive: true });
-    await fs_1.promises.mkdir(path.join(dir, '.claude/skills/x'), { recursive: true });
-    await fs_1.promises.writeFile(path.join(dir, 'package.json'), '{"name":"x"}');
-    await fs_1.promises.writeFile(path.join(dir, '.lightdash/context/semantic-layer.yml'), 'models: []');
-    await fs_1.promises.writeFile(path.join(dir, '.claude/skills/x/SKILL.md'), '# skill');
-    await fs_1.promises.writeFile(path.join(dir, '.env.local'), 'VITE_LIGHTDASH_API_KEY=secret');
-    const read = await (0, appCodeFiles_1.readBundleFromDir)(dir);
-    expect(read.files.every((f) => f.path.startsWith('src/'))).toBe(true);
-    expect(read.files.map((f) => f.path)).not.toContain('.env.local');
-    expect(read.files.map((f) => f.path).sort()).toEqual(bundle.files.map((f) => f.path).sort());
-});
-it('throws a clear error when the manifest is not valid YAML', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-app-'));
-    await fs_1.promises.writeFile(path.join(dir, 'lightdash-app.yml'), 'foo: [bar', 'utf-8');
-    await expect((0, appCodeFiles_1.readBundleFromDir)(dir)).rejects.toThrow(/Could not parse lightdash-app\.yml/);
-});
-it('writes context files under .lightdash/context and skips null parameters', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-ctx-'));
-    await (0, appCodeFiles_1.writeContextToDir)(dir, {
-        semanticLayer: {
-            path: '.lightdash/context/semantic-layer.yml',
-            contentBase64: Buffer.from('models: []').toString('base64'),
-        },
-        parameters: null,
-        promptHistory: {
-            path: '.lightdash/context/prompt-history.md',
-            contentBase64: Buffer.from('# prompts').toString('base64'),
-        },
-        theme: {
-            instructions: {
-                path: '.lightdash/context/theme/instructions.md',
-                contentBase64: Buffer.from('# theme').toString('base64'),
-            },
-            assets: [],
-            skippedAssetCount: 0,
-        },
-    });
-    expect(await fs_1.promises.readFile(path.join(dir, '.lightdash/context/semantic-layer.yml'), 'utf-8')).toBe('models: []');
-    expect(await fs_1.promises.readFile(path.join(dir, '.lightdash/context/theme/instructions.md'), 'utf-8')).toBe('# theme');
-    await expect(fs_1.promises.access(path.join(dir, '.lightdash/context/parameters.yml'))).rejects.toThrow();
-});
-it('writes sharded semantic layer files and clears the previous context snapshot', async () => {
-    const dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-ctx-'));
-    await fs_1.promises.mkdir(path.join(dir, '.lightdash/context/models'), {
-        recursive: true,
-    });
-    await fs_1.promises.writeFile(path.join(dir, '.lightdash/context/models/deleted_model.yml'), 'models: []');
-    await fs_1.promises.writeFile(path.join(dir, '.lightdash/context/parameters.yml'), 'parameters: {}');
-    await fs_1.promises.mkdir(path.join(dir, 'src'), { recursive: true });
-    await fs_1.promises.writeFile(path.join(dir, 'src/App.tsx'), '// keep');
-    await (0, appCodeFiles_1.writeContextToDir)(dir, {
-        semanticLayer: {
-            path: '.lightdash/context/semantic-layer.yml',
-            contentBase64: Buffer.from('# see models/').toString('base64'),
-        },
-        semanticLayerFiles: [
-            {
-                path: '.lightdash/context/models/orders.yml',
-                contentBase64: Buffer.from('models: []').toString('base64'),
-            },
-        ],
-        parameters: null,
-        promptHistory: {
-            path: '.lightdash/context/prompt-history.md',
-            contentBase64: Buffer.from('# prompts').toString('base64'),
-        },
-        theme: { instructions: null, assets: [], skippedAssetCount: 0 },
-    });
-    expect(await fs_1.promises.readFile(path.join(dir, '.lightdash/context/models/orders.yml'), 'utf-8')).toBe('models: []');
-    await expect(fs_1.promises.access(path.join(dir, '.lightdash/context/models/deleted_model.yml'))).rejects.toThrow();
-    await expect(fs_1.promises.access(path.join(dir, '.lightdash/context/parameters.yml'))).rejects.toThrow();
-    expect(await fs_1.promises.readFile(path.join(dir, 'src/App.tsx'), 'utf-8')).toBe('// keep');
-});
-describe('appFolderName', () => {
-    it('returns the slugified name when no collision', () => {
-        const taken = new Set();
-        expect((0, appCodeFiles_1.appFolderName)('My Sales App', 'abcd1234-ef56-7890-ab12-cdef01234567', taken)).toBe('my-sales-app');
-    });
-    it('returns uuid-suffixed name on collision (first 8 chars of UUID)', () => {
-        const taken = new Set(['my-sales-app']);
-        // UUID first 8 chars: 'abcd1234'
-        expect((0, appCodeFiles_1.appFolderName)('My Sales App', 'abcd1234-ef56-7890-ab12-cdef01234567', taken)).toBe('my-sales-app-abcd1234');
-    });
-    it('produces distinct names for two colliding apps with different UUIDs', () => {
-        const taken = new Set(['my-sales-app']);
-        // First UUID: 'aaaa1111-...' → suffix 'aaaa1111'
-        const first = (0, appCodeFiles_1.appFolderName)('My Sales App', 'aaaa1111-bbbb-cccc-dddd-eeeeeeeeeeee', taken);
-        taken.add(first);
-        // Second UUID: 'cccc2222-...' → suffix 'cccc2222'
-        const second = (0, appCodeFiles_1.appFolderName)('My Sales App', 'cccc2222-dddd-eeee-ffff-000000000000', taken);
-        expect(first).not.toBe(second);
-        expect(first).toBe('my-sales-app-aaaa1111');
-        expect(second).toBe('my-sales-app-cccc2222');
-    });
-    // generateSlug returns a RANDOM string for names that sanitize to nothing,
-    // which would give an unnamed app a different folder on every download.
-    it('uses a stable untitled-app-<uuid8> folder for an empty name', () => {
-        const uuid = 'abcd1234-ef56-7890-ab12-cdef01234567';
-        expect((0, appCodeFiles_1.appFolderName)('', uuid, new Set())).toBe('untitled-app-abcd1234');
-        // Deterministic: a re-download must land in the same folder.
-        expect((0, appCodeFiles_1.appFolderName)('', uuid, new Set())).toBe('untitled-app-abcd1234');
-    });
-    it('uses the stable fallback for a name with no alphanumeric characters', () => {
-        expect((0, appCodeFiles_1.appFolderName)('!!!', 'abcd1234-ef56-7890-ab12-cdef01234567', new Set())).toBe('untitled-app-abcd1234');
-    });
-});
-describe('resolveAppFolderName', () => {
-    it('uses the manifest slug when present', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        expect((0, appCodeFiles_1.resolveAppFolderName)({ ...code.manifest, slug: 'sales-app' }, new Set())).toBe('sales-app');
-    });
-    it('falls back to appFolderName when the manifest has no slug', () => {
-        const uuid = 'abcd1234-ef56-7890-ab12-cdef01234567';
-        const code = makeCode(uuid, 'proj-uuid-1');
-        expect((0, appCodeFiles_1.resolveAppFolderName)(code.manifest, new Set())).toBe((0, appCodeFiles_1.appFolderName)(code.manifest.name, uuid, new Set()));
-    });
-    it('uses the slug for uuid-free manifests (slug-aware servers)', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        expect((0, appCodeFiles_1.resolveAppFolderName)({ ...code.manifest, appUuid: undefined, slug: 'sales-app' }, new Set())).toBe('sales-app');
-    });
-    // Defense-in-depth: a tampered manifest (or a server of unknown version)
-    // must not be able to steer the write path via an invalid slug.
-    it('falls back to appFolderName when the slug is a path-traversal attempt', () => {
-        const uuid = 'abcd1234-ef56-7890-ab12-cdef01234567';
-        const code = makeCode(uuid, 'proj-uuid-1');
-        expect((0, appCodeFiles_1.resolveAppFolderName)({ ...code.manifest, slug: '../../../../tmp/evil' }, new Set())).toBe((0, appCodeFiles_1.appFolderName)(code.manifest.name, uuid, new Set()));
-    });
-    it('still uses a valid manifest slug (unaffected by the new validation)', () => {
-        const code = makeCode('app-uuid-1', 'proj-uuid-1');
-        expect((0, appCodeFiles_1.resolveAppFolderName)({ ...code.manifest, slug: 'sales-app-2' }, new Set())).toBe('sales-app-2');
-    });
-});
-// ─── readDependenciesFromDir ──────────────────────────────────────────────────
-const makePackageJson = (deps = {}) => JSON.stringify({ name: 'test-app', dependencies: deps });
-const LOCKFILE_CONTENT = 'lockfileVersion: 9.0\n\npackages:\n  react@19.0.0:\n';
-describe('readDependenciesFromDir', () => {
-    let dir;
-    beforeEach(async () => {
-        dir = await fs_1.promises.mkdtemp(path.join(os.tmpdir(), 'ld-deps-'));
-    });
-    afterEach(async () => {
-        await fs_1.promises.rm(dir, { recursive: true, force: true });
-    });
-    it('returns null when neither package.json nor pnpm-lock.yaml exist', async () => {
-        expect(await (0, appCodeFiles_1.readDependenciesFromDir)(dir)).toBeNull();
-    });
-    it('returns the deps pair when both files are present', async () => {
-        await fs_1.promises.writeFile(path.join(dir, 'package.json'), makePackageJson());
-        await fs_1.promises.writeFile(path.join(dir, 'pnpm-lock.yaml'), LOCKFILE_CONTENT);
-        const result = await (0, appCodeFiles_1.readDependenciesFromDir)(dir);
-        expect(result).not.toBeNull();
-        expect(result?.packageJson).toBe(makePackageJson());
-        expect(result?.lockfile).toBe(LOCKFILE_CONTENT);
-        expect(result?.hasNpmLockfile).toBe(false);
-    });
-    // The download scaffold always writes package.json but never a lockfile,
-    // so this state is every freshly downloaded template-only app — it must
-    // read back cleanly, not throw.
-    it('returns the package.json with a null lockfile when pnpm-lock.yaml is absent', async () => {
-        await fs_1.promises.writeFile(path.join(dir, 'package.json'), makePackageJson());
-        const result = await (0, appCodeFiles_1.readDependenciesFromDir)(dir);
-        expect(result).not.toBeNull();
-        expect(result?.packageJson).toBe(makePackageJson());
-        expect(result?.lockfile).toBeNull();
-    });
-    it('throws when pnpm-lock.yaml exists but package.json is absent', async () => {
-        await fs_1.promises.writeFile(path.join(dir, 'pnpm-lock.yaml'), LOCKFILE_CONTENT);
-        await expect((0, appCodeFiles_1.readDependenciesFromDir)(dir)).rejects.toThrow(/package\.json/);
-    });
-    it('flags a stray package-lock.json when the pnpm lockfile is absent', async () => {
-        await fs_1.promises.writeFile(path.join(dir, 'package.json'), makePackageJson());
-        await fs_1.promises.writeFile(path.join(dir, 'package-lock.json'), '{}');
-        const result = await (0, appCodeFiles_1.readDependenciesFromDir)(dir);
-        expect(result?.lockfile).toBeNull();
-        expect(result?.hasNpmLockfile).toBe(true);
-    });
-});
-// ─── buildDepsWarningLines ────────────────────────────────────────────────────
-describe('buildDepsWarningLines', () => {
-    const TEMPLATE = {
-        react: '19.2.5',
-        lodash: '4.17.21',
-    };
-    it('labels a brand-new package as "not in default template"', () => {
-        const lines = (0, appCodeFiles_1.buildDepsWarningLines)({ 'my-lib': '^2.0.0' }, TEMPLATE);
-        expect(lines).toHaveLength(1);
-        expect(lines[0]).toContain('my-lib@^2.0.0');
-        expect(lines[0]).toContain('not in default template');
-    });
-    it('labels a version override with the template version', () => {
-        const lines = (0, appCodeFiles_1.buildDepsWarningLines)({ react: '18.3.1' }, TEMPLATE);
-        expect(lines).toHaveLength(1);
-        expect(lines[0]).toContain('react@18.3.1');
-        expect(lines[0]).toContain('overrides template 19.2.5');
-    });
-    it('returns one line per custom package', () => {
-        const custom = { 'pkg-a': '^1.0.0', 'pkg-b': '2.0.0' };
-        const lines = (0, appCodeFiles_1.buildDepsWarningLines)(custom, TEMPLATE);
-        expect(lines).toHaveLength(2);
-    });
-    it('returns an empty array when there are no custom deps', () => {
-        expect((0, appCodeFiles_1.buildDepsWarningLines)({}, TEMPLATE)).toEqual([]);
-    });
-});
-// ─── attachDependenciesToCode ─────────────────────────────────────────────────
-describe('attachDependenciesToCode', () => {
-    const baseCode = makeCode('app-1', 'proj-1');
-    const deps = {
-        packageJson: makePackageJson({ react: '18.3.1' }),
-        lockfile: LOCKFILE_CONTENT,
-    };
-    it('returns the original code object (by reference) when customDeps is empty', () => {
-        const result = (0, appCodeFiles_1.attachDependenciesToCode)(baseCode, {}, deps);
-        expect(result).toBe(baseCode);
-        expect(result.dependencies).toBeUndefined();
-    });
-    it('returns a new code object with dependencies attached when customDeps is non-empty', () => {
-        const result = (0, appCodeFiles_1.attachDependenciesToCode)(baseCode, { react: '18.3.1' }, deps);
-        expect(result).not.toBe(baseCode);
-        expect(result.dependencies).toEqual(deps);
-    });
-    it('preserves all other code fields when attaching dependencies', () => {
-        const result = (0, appCodeFiles_1.attachDependenciesToCode)(baseCode, { react: '18.3.1' }, deps);
-        expect(result.manifest).toBe(baseCode.manifest);
-        expect(result.files).toBe(baseCode.files);
-    });
-});
-describe('applySdkMirrorToTemplateDeps', () => {
-    const template = {
-        '@lightdash/query-sdk': '0.3326.1',
-        react: '19.2.5',
-    };
-    it('mirrors the declared SDK spec so an older pin never counts as custom', () => {
-        const result = (0, appCodeFiles_1.applySdkMirrorToTemplateDeps)(template, JSON.stringify({
-            dependencies: { '@lightdash/query-sdk': '0.3315.3' },
-        }));
-        expect(result['@lightdash/query-sdk']).toBe('0.3315.3');
-        expect(result.react).toBe('19.2.5');
-    });
-    it('leaves the baseline untouched when the SDK is not declared', () => {
-        const result = (0, appCodeFiles_1.applySdkMirrorToTemplateDeps)(template, JSON.stringify({ dependencies: { react: '19.2.5' } }));
-        expect(result).toEqual(template);
-    });
-    it('leaves the baseline untouched for unparseable packageJson', () => {
-        expect((0, appCodeFiles_1.applySdkMirrorToTemplateDeps)(template, 'not-json')).toEqual(template);
-    });
-});

package/dist/handlers/apps/appsDownload.test.d.ts

@@ -1,2 +0,0 @@
-export {};
-//# sourceMappingURL=appsDownload.test.d.ts.map

package/dist/handlers/apps/appsDownload.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"appsDownload.test.d.ts","sourceRoot":"","sources":["../../../src/handlers/apps/appsDownload.test.ts"],"names":[],"mappings":""}