@lightdash/cli 2.228.1 → 2.229.0

package/dist/handlers/compileWarehouseColumnValidation.test.js

@@ -1,493 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const tslib_1 = require("tslib");
-const common_1 = require("@lightdash/common");
-const warehouses_1 = require("@lightdash/warehouses");
-const promises_1 = tslib_1.__importDefault(require("fs/promises"));
-const os = tslib_1.__importStar(require("os"));
-const path = tslib_1.__importStar(require("path"));
-const context_1 = require("../dbt/context");
-const manifest_1 = require("../dbt/manifest");
-const validation_1 = require("../dbt/validation");
-const loader_1 = require("../lightdash/loader");
-const compile_1 = require("./compile");
-const apiClient_1 = require("./dbt/apiClient");
-const compile_2 = require("./dbt/compile");
-const getDbtVersion_1 = require("./dbt/getDbtVersion");
-const getWarehouseClient_1 = tslib_1.__importDefault(require("./dbt/getWarehouseClient"));
-const deploy_1 = require("./deploy");
-vi.mock('../analytics/analytics');
-vi.mock('../config', () => ({
-    getConfig: vi.fn().mockResolvedValue({ user: null, context: null }),
-}));
-vi.mock('../dbt/context');
-vi.mock('../dbt/manifest');
-vi.mock('../dbt/validation');
-vi.mock('../lightdash/loader');
-vi.mock('./dbt/compile');
-vi.mock('./dbt/apiClient', async (importOriginal) => {
-    const original = await importOriginal();
-    return { ...original, lightdashApi: vi.fn().mockResolvedValue(undefined) };
-});
-vi.mock('./dbt/getDbtVersion');
-vi.mock('./dbt/getWarehouseClient');
-vi.mock('@lightdash/warehouses', async (importOriginal) => {
-    const original = await importOriginal();
-    return {
-        ...original,
-        validateWarehouseColumnReferences: vi.fn(),
-    };
-});
-const model = {
-    checksum: { name: '', checksum: '' },
-    fqn: [],
-    language: '',
-    package_name: '',
-    path: '',
-    raw_code: '',
-    compiled: true,
-    unique_id: 'model.test.my_model',
-    description: '',
-    resource_type: 'model',
-    columns: {
-        id: {
-            name: 'id',
-            data_type: common_1.DimensionType.NUMBER,
-            meta: {},
-        },
-    },
-    meta: {},
-    database: 'my_database',
-    schema: 'my_schema',
-    name: 'my_model',
-    alias: 'my_model',
-    tags: [],
-    relation_name: '"my_database"."my_schema"."my_model"',
-    depends_on: { nodes: [] },
-    patch_path: null,
-    original_file_path: '',
-};
-// Metric name collides with the `id` dimension, producing an unconditional
-// DUPLICATE_FIELD_NAME warning even when partial compilation is disabled
-const modelWithDuplicateMetricName = {
-    ...model,
-    columns: {
-        id: {
-            name: 'id',
-            data_type: common_1.DimensionType.NUMBER,
-            meta: { metrics: { id: { type: common_1.MetricType.COUNT } } },
-        },
-    },
-};
-const lightdashYmlModel = {
-    type: 'model',
-    name: 'yml_model',
-    sql_from: '"my_database"."my_schema"."yml_model"',
-    dimensions: [{ name: 'id', type: common_1.DimensionType.NUMBER, sql: 'id' }],
-};
-// Models are injected through the mocked validateDbtModel, so nodes stay empty
-const manifest = {
-    nodes: {},
-    metadata: {
-        dbt_schema_version: 'https://schemas.getdbt.com/dbt/manifest/v12.json',
-        generated_at: '2026-01-01T00:00:00Z',
-        adapter_type: 'postgres',
-    },
-    metrics: {},
-    docs: {},
-};
-const baseOptions = (projectDir) => ({
-    projectDir,
-    profilesDir: '',
-    target: undefined,
-    profile: undefined,
-    vars: undefined,
-    verbose: false,
-    startOfWeek: 0,
-    skipWarehouseCatalog: undefined,
-    skipDbtCompile: true,
-    useDbtList: false,
-    select: undefined,
-    models: undefined,
-    threads: undefined,
-    noVersionCheck: false,
-    exclude: undefined,
-    selector: undefined,
-    state: undefined,
-    fullRefresh: false,
-    defer: false,
-    targetPath: undefined,
-    favorState: false,
-    combineManifest: undefined,
-    warehouseCredentials: false,
-    disableTimestampConversion: false,
-});
-const SKIP_WARNING = 'Skipping warehouse column validation because the warehouse catalog is skipped';
-const YML_SKIP_WARNING = 'Skipping warehouse column validation because it is not supported for Lightdash YAML projects';
-const DBT_CLOUD_SKIP_WARNING = 'Skipping warehouse column validation because dbt Cloud CLI cannot run warehouse queries';
-const setupWarehouseClient = () => {
-    const credentials = {
-        type: common_1.WarehouseTypes.POSTGRES,
-        host: 'localhost',
-        user: 'test_user',
-        password: 'test_password',
-        port: 5432,
-        dbname: 'my_database',
-        schema: 'my_schema',
-    };
-    const warehouseClient = new warehouses_1.PostgresWarehouseClient(credentials);
-    vi.spyOn(warehouseClient, 'getCatalog').mockResolvedValue({});
-    vi.mocked(getWarehouseClient_1.default).mockResolvedValue({
-        warehouseClient,
-        credentials,
-    });
-    return warehouseClient;
-};
-const mockProberToAppendWarning = (message) => {
-    vi.mocked(warehouses_1.validateWarehouseColumnReferences).mockImplementation(async ({ explores }) => explores.map((explore) => (0, common_1.isExploreError)(explore)
-        ? explore
-        : {
-            ...explore,
-            warnings: [
-                ...(explore.warnings ?? []),
-                {
-                    type: common_1.InlineErrorType.WAREHOUSE_COLUMN_ERROR,
-                    message,
-                },
-            ],
-        }));
-};
-describe('compile warehouse column validation', () => {
-    let tempDir;
-    let errorOutput;
-    beforeEach(async () => {
-        vi.clearAllMocks();
-        tempDir = await promises_1.default.mkdtemp(path.join(os.tmpdir(), 'lightdash-compile-validation-test-'));
-        vi.mocked(getDbtVersion_1.tryGetDbtVersion).mockResolvedValue({
-            success: true,
-            version: {
-                verboseVersion: '1.8.0',
-                versionOption: common_1.SupportedDbtVersions.V1_8,
-                isDbtCloudCLI: false,
-                isDbtFusion: false,
-            },
-        });
-        vi.mocked(context_1.getDbtContext).mockResolvedValue({
-            projectName: 'test_project',
-            profileName: 'test_profile',
-            targetDir: path.join(tempDir, 'target'),
-            modelsDir: 'models',
-        });
-        vi.mocked(compile_2.maybeCompileModelsAndJoins).mockResolvedValue({
-            compiledModelIds: undefined,
-            originallySelectedModelIds: undefined,
-        });
-        vi.mocked(manifest_1.loadManifest).mockResolvedValue(manifest);
-        vi.mocked(loader_1.loadLightdashModels).mockResolvedValue([]);
-        vi.mocked(validation_1.validateDbtModel).mockResolvedValue({
-            valid: [model],
-            invalid: [],
-            skipped: [],
-        });
-        vi.mocked(warehouses_1.validateWarehouseColumnReferences).mockImplementation(async ({ explores }) => explores);
-        errorOutput = [];
-        vi.spyOn(console, 'error').mockImplementation((...args) => {
-            errorOutput.push(args.map(String).join(' '));
-        });
-    });
-    afterEach(async () => {
-        vi.restoreAllMocks();
-        await promises_1.default.rm(tempDir, { recursive: true, force: true });
-    });
-    test('skips warehouse client and column validation when skipWarehouseCatalog is set', async () => {
-        const result = await (0, compile_1.compile)({
-            ...baseOptions(tempDir),
-            skipWarehouseCatalog: true,
-            validateWarehouseColumns: true,
-        });
-        // Credential-less CI flow: no warehouse client is ever created
-        expect(getWarehouseClient_1.default).not.toHaveBeenCalled();
-        expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-        expect(result.filter(common_1.isExploreError)).toEqual([]);
-        expect(result.map((explore) => explore.name)).toEqual(['my_model']);
-        expect(errorOutput).toEqual(expect.arrayContaining([expect.stringContaining(SKIP_WARNING)]));
-    });
-    test('validates warehouse column references when warehouse catalog is not skipped', async () => {
-        const warehouseClient = setupWarehouseClient();
-        const result = await (0, compile_1.compile)({
-            ...baseOptions(tempDir),
-            skipWarehouseCatalog: false,
-            validateWarehouseColumns: true,
-        });
-        expect(getWarehouseClient_1.default).toHaveBeenCalledTimes(1);
-        expect(warehouseClient.getCatalog).toHaveBeenCalledTimes(1);
-        expect(warehouses_1.validateWarehouseColumnReferences).toHaveBeenCalledTimes(1);
-        expect(warehouses_1.validateWarehouseColumnReferences).toHaveBeenCalledWith(expect.objectContaining({ client: warehouseClient }));
-        expect(result.filter(common_1.isExploreError)).toEqual([]);
-        expect(errorOutput).not.toEqual(expect.arrayContaining([
-            expect.stringContaining('Skipping warehouse column validation'),
-        ]));
-    });
-    test('does not warn about column validation when it was not requested', async () => {
-        const result = await (0, compile_1.compile)({
-            ...baseOptions(tempDir),
-            skipWarehouseCatalog: true,
-        });
-        expect(getWarehouseClient_1.default).not.toHaveBeenCalled();
-        expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-        expect(result.filter(common_1.isExploreError)).toEqual([]);
-        expect(errorOutput).not.toEqual(expect.arrayContaining([expect.stringContaining(SKIP_WARNING)]));
-    });
-    describe('compile output for warehouse column warnings', () => {
-        const WAREHOUSE_WARNING = 'Warehouse rejected column reference TABLE.rolling_30d_avg_sales in model "my_model"';
-        test('renders ERROR for a warehouse rejection by default', async () => {
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(`- ERROR> my_model : ${WAREHOUSE_WARNING}`),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=0 ERRORS=1'),
-            ]));
-        });
-        test('renders ERROR for a warehouse rejection when partial compilation is disabled', async () => {
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            const result = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-                partialCompilation: false,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(`- ERROR> my_model : ${WAREHOUSE_WARNING}`),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=0 ERRORS=1'),
-            ]));
-            // The typed diagnostic must still reach backend validation untouched
-            expect(result.filter(common_1.isExploreError)).toEqual([]);
-            const warningTypes = result.flatMap((explore) => (0, common_1.isExploreError)(explore)
-                ? []
-                : (explore.warnings ?? []).map((warning) => warning.type));
-            expect(warningTypes).toEqual([
-                common_1.InlineErrorType.WAREHOUSE_COLUMN_ERROR,
-            ]);
-            expect(result.filter(compile_1.hasBlockingCompileError)).toHaveLength(1);
-            expect(result
-                .map(compile_1.stripWarehouseColumnErrors)
-                .flatMap((explore) => (0, common_1.isExploreError)(explore) ? [] : (explore.warnings ?? []))).toEqual([]);
-        });
-        test('blocks deploy when the warehouse rejects a column', async () => {
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            const explores = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            vi.spyOn(process, 'exit').mockImplementation(() => {
-                throw new Error('process.exit');
-            });
-            await expect((0, deploy_1.deploy)(explores, {
-                ...baseOptions(tempDir),
-                projectUuid: 'projectUuid',
-                ignoreErrors: false,
-                validateWarehouseColumns: true,
-            })).rejects.toThrow('process.exit');
-            expect(process.exit).toHaveBeenCalledWith(1);
-        });
-        test('does not persist warehouse diagnostics when deploy errors are ignored', async () => {
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            const explores = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            await (0, deploy_1.deploy)(explores, {
-                ...baseOptions(tempDir),
-                projectUuid: 'projectUuid',
-                ignoreErrors: true,
-                validateWarehouseColumns: true,
-                batchedDeploy: false,
-            });
-            const deployRequest = vi
-                .mocked(apiClient_1.lightdashApi)
-                .mock.calls.find(([request]) => request.url ===
-                '/api/v1/projects/projectUuid/explores?complete=false');
-            if (deployRequest === undefined) {
-                throw new Error('Expected explores deploy request');
-            }
-            expect(deployRequest[0].body).not.toContain(common_1.InlineErrorType.WAREHOUSE_COLUMN_ERROR);
-        });
-        test('keeps generic warnings hidden when partial compilation is disabled', async () => {
-            vi.mocked(validation_1.validateDbtModel).mockResolvedValue({
-                valid: [modelWithDuplicateMetricName],
-                invalid: [],
-                skipped: [],
-            });
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                skipWarehouseCatalog: true,
-                partialCompilation: false,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining('- SUCCESS> my_model'),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=1 ERRORS=0'),
-            ]));
-            expect(errorOutput).not.toEqual(expect.arrayContaining([
-                expect.stringContaining('PARTIAL_SUCCESS'),
-            ]));
-            expect(errorOutput).not.toEqual(expect.arrayContaining([
-                expect.stringContaining('Skipped metric "id"'),
-            ]));
-        });
-        test('renders generic warnings by default', async () => {
-            vi.mocked(validation_1.validateDbtModel).mockResolvedValue({
-                valid: [modelWithDuplicateMetricName],
-                invalid: [],
-                skipped: [],
-            });
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                skipWarehouseCatalog: true,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining('- PARTIAL_SUCCESS> my_model'),
-                expect.stringContaining('Skipped metric "id"'),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=0 PARTIAL_SUCCESS=1 ERRORS=0'),
-            ]));
-        });
-        test('renders the warehouse error and generic warnings by default', async () => {
-            vi.mocked(validation_1.validateDbtModel).mockResolvedValue({
-                valid: [modelWithDuplicateMetricName],
-                invalid: [],
-                skipped: [],
-            });
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            const result = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(`- ERROR> my_model : ${WAREHOUSE_WARNING}`),
-                expect.stringContaining('Skipped metric "id"'),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=0 ERRORS=1'),
-            ]));
-            expect(result
-                .map(compile_1.stripWarehouseColumnErrors)
-                .flatMap((explore) => (0, common_1.isExploreError)(explore)
-                ? []
-                : (explore.warnings ?? []).map((warning) => warning.type))).toEqual([common_1.InlineErrorType.DUPLICATE_FIELD_NAME]);
-        });
-        test('renders only the warehouse error when partial compilation is disabled', async () => {
-            vi.mocked(validation_1.validateDbtModel).mockResolvedValue({
-                valid: [modelWithDuplicateMetricName],
-                invalid: [],
-                skipped: [],
-            });
-            setupWarehouseClient();
-            mockProberToAppendWarning(WAREHOUSE_WARNING);
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-                partialCompilation: false,
-            });
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(`- ERROR> my_model : ${WAREHOUSE_WARNING}`),
-                expect.stringContaining('Compiled 1 explores, SUCCESS=0 ERRORS=1'),
-            ]));
-            expect(errorOutput).not.toEqual(expect.arrayContaining([
-                expect.stringContaining('Skipped metric "id"'),
-            ]));
-        });
-    });
-    describe('dbt cloud cli', () => {
-        beforeEach(() => {
-            vi.mocked(getDbtVersion_1.tryGetDbtVersion).mockResolvedValue({
-                success: true,
-                version: {
-                    verboseVersion: 'dbt Cloud CLI - 0.38.0',
-                    versionOption: common_1.DbtVersionOptionLatest.LATEST,
-                    isDbtCloudCLI: true,
-                    isDbtFusion: false,
-                },
-            });
-        });
-        test('skips column probing and warns when validation was requested', async () => {
-            const warehouseClient = setupWarehouseClient();
-            const result = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            // Catalog fetching required by dbt Cloud CLI is preserved
-            expect(getWarehouseClient_1.default).toHaveBeenCalledWith(expect.objectContaining({ isDbtCloudCLI: true }));
-            expect(warehouseClient.getCatalog).toHaveBeenCalledTimes(1);
-            expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-            expect(result.filter(common_1.isExploreError)).toEqual([]);
-            expect(result.map((explore) => explore.name)).toEqual(['my_model']);
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(DBT_CLOUD_SKIP_WARNING),
-            ]));
-        });
-        test('does not warn or probe when validation was not requested', async () => {
-            const warehouseClient = setupWarehouseClient();
-            await (0, compile_1.compile)(baseOptions(tempDir));
-            expect(warehouseClient.getCatalog).toHaveBeenCalledTimes(1);
-            expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-            expect(errorOutput).not.toEqual(expect.arrayContaining([
-                expect.stringContaining('Skipping warehouse column validation'),
-            ]));
-        });
-        test('prefers the skip-warehouse-catalog warning when both apply', async () => {
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                skipWarehouseCatalog: true,
-                validateWarehouseColumns: true,
-            });
-            expect(getWarehouseClient_1.default).not.toHaveBeenCalled();
-            expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-            const skipWarnings = errorOutput.filter((line) => line.includes('Skipping warehouse column validation'));
-            expect(skipWarnings).toHaveLength(1);
-            expect(skipWarnings[0]).toContain(SKIP_WARNING);
-        });
-    });
-    describe('lightdash yml projects', () => {
-        beforeEach(async () => {
-            vi.mocked(loader_1.loadLightdashModels).mockResolvedValue([
-                { ...lightdashYmlModel, sourcePath: 'models/test_model.yml' },
-            ]);
-            await promises_1.default.writeFile(path.join(tempDir, 'lightdash.config.yml'), 'warehouse:\n  type: postgres\n');
-        });
-        test('warns that warehouse column validation is not supported', async () => {
-            const result = await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                validateWarehouseColumns: true,
-            });
-            expect(result.filter(common_1.isExploreError)).toEqual([]);
-            expect(result.map((explore) => explore.name)).toEqual([
-                'yml_model',
-            ]);
-            expect(getWarehouseClient_1.default).not.toHaveBeenCalled();
-            expect(warehouses_1.validateWarehouseColumnReferences).not.toHaveBeenCalled();
-            expect(errorOutput).toEqual(expect.arrayContaining([
-                expect.stringContaining(YML_SKIP_WARNING),
-            ]));
-        });
-        test('does not warn when warehouse column validation was not requested', async () => {
-            await (0, compile_1.compile)(baseOptions(tempDir));
-            expect(errorOutput).not.toEqual(expect.arrayContaining([
-                expect.stringContaining('Skipping warehouse column validation'),
-            ]));
-        });
-        test('warns exactly once when --skip-warehouse-catalog is also supplied', async () => {
-            await (0, compile_1.compile)({
-                ...baseOptions(tempDir),
-                skipWarehouseCatalog: true,
-                validateWarehouseColumns: true,
-            });
-            const skipWarnings = errorOutput.filter((line) => line.includes('Skipping warehouse column validation'));
-            expect(skipWarnings).toHaveLength(1);
-            expect(skipWarnings[0]).toContain(YML_SKIP_WARNING);
-        });
-    });
-});

package/dist/handlers/connectSnowflake.test.d.ts

@@ -1,2 +0,0 @@
-export {};
-//# sourceMappingURL=connectSnowflake.test.d.ts.map

package/dist/handlers/connectSnowflake.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"connectSnowflake.test.d.ts","sourceRoot":"","sources":["../../src/handlers/connectSnowflake.test.ts"],"names":[],"mappings":""}