@lightdash/cli 2.18.2 → 2.20.0

package/dist/handlers/validate.d.ts

@@ -10,6 +10,7 @@ export declare const getJobState: (jobUuid: string) => Promise<{
 export declare const getValidation: (projectUuid: string, jobId: string) => Promise<import("@lightdash/common").ValidationResponse[]>;
 export declare const VALIDATION_SEVERITIES: readonly ['error', 'warning'];
 export type ValidationSeverity = (typeof VALIDATION_SEVERITIES)[number];
+export declare const SHOW_CHART_CONFIGURATION_WARNINGS_DEPRECATION = "`--show-chart-configuration-warnings` is deprecated. Use `--severity warning` instead.";
 type ValidateHandlerOptions = CompileHandlerOptions & {
     project?: string;
     verbose: boolean;
@@ -17,9 +18,11 @@ type ValidateHandlerOptions = CompileHandlerOptions & {
     only: ValidationTarget[];
     validateWarehouseColumns: boolean;
     severity?: ValidationSeverity;
+    showChartConfigurationWarnings?: boolean;
     includeSpaces?: string[];
     excludeSpaces?: string[];
 };
+export declare function resolveValidateSeverity(options: Pick<ValidateHandlerOptions, 'severity' | 'showChartConfigurationWarnings'>): ValidationSeverity;
 type WaitUntilFinishedOptions = {
     jobUuid: string;
     refetchIntervalMs: number;

package/dist/handlers/validate.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../../src/handlers/validate.ts"],"names":[],"mappings":"AAAA,OAAO,EAKH,OAAO,EACP,YAAY,EASZ,kBAAkB,EAElB,gBAAgB,EACnB,MAAM,mBAAmB,CAAC;AAO3B,OAAO,EAAW,qBAAqB,EAAE,MAAM,WAAW,CAAC;AAS3D,eAAO,MAAM,iBAAiB,gBACb,MAAM,YACT,CAAC,OAAO,GAAG,YAAY,CAAC,EAAE,qBACjB,gBAAgB,EAAE;;EAMnC,CAAC;AAEP,eAAO,MAAM,WAAW,YAAmB,MAAM;;;EAK3C,CAAC;AAEP,eAAO,MAAM,aAAa,gBAAuB,MAAM,SAAS,MAAM,8DAKhE,CAAC;AAmCP,eAAO,MAAM,qBAAqB,YAAI,OAAO,EAAE,SAAS,CAAU,CAAC;AACnE,MAAM,MAAM,kBAAkB,GAAG,CAAC,OAAO,qBAAqB,CAAC,CAAC,MAAM,CAAC,CAAC;AAExE,KAAK,sBAAsB,GAAG,qBAAqB,GAAG;IAClD,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,IAAI,EAAE,gBAAgB,EAAE,CAAC;IACzB,wBAAwB,EAAE,OAAO,CAAC;IAClC,QAAQ,CAAC,EAAE,kBAAkB,CAAC;IAC9B,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;CAC5B,CAAC;AAEF,KAAK,wBAAwB,GAAG;IAC5B,OAAO,EAAE,MAAM,CAAC;IAChB,iBAAiB,EAAE,MAAM,CAAC;IAC1B,WAAW,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,KAAK,CAAC;CAC5C,CAAC;AAEF,eAAO,MAAM,iBAAiB,iDAI3B,wBAAwB,KAAG,OAAO,CAAC,MAAM,CAY3C,CAAC;AAEF,eAAO,MAAM,eAAe,oBACP,sBAAsB,kBAiY1C,CAAC"}
+{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../../src/handlers/validate.ts"],"names":[],"mappings":"AAAA,OAAO,EAKH,OAAO,EACP,YAAY,EASZ,kBAAkB,EAElB,gBAAgB,EACnB,MAAM,mBAAmB,CAAC;AAO3B,OAAO,EAAW,qBAAqB,EAAE,MAAM,WAAW,CAAC;AAS3D,eAAO,MAAM,iBAAiB,gBACb,MAAM,YACT,CAAC,OAAO,GAAG,YAAY,CAAC,EAAE,qBACjB,gBAAgB,EAAE;;EAMnC,CAAC;AAEP,eAAO,MAAM,WAAW,YAAmB,MAAM;;;EAK3C,CAAC;AAEP,eAAO,MAAM,aAAa,gBAAuB,MAAM,SAAS,MAAM,8DAKhE,CAAC;AAmCP,eAAO,MAAM,qBAAqB,YAAI,OAAO,EAAE,SAAS,CAAU,CAAC;AACnE,MAAM,MAAM,kBAAkB,GAAG,CAAC,OAAO,qBAAqB,CAAC,CAAC,MAAM,CAAC,CAAC;AAExE,eAAO,MAAM,6CAA6C,2FACkC,CAAC;AAE7F,KAAK,sBAAsB,GAAG,qBAAqB,GAAG;IAClD,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,IAAI,EAAE,gBAAgB,EAAE,CAAC;IACzB,wBAAwB,EAAE,OAAO,CAAC;IAClC,QAAQ,CAAC,EAAE,kBAAkB,CAAC;IAC9B,8BAA8B,CAAC,EAAE,OAAO,CAAC;IACzC,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;CAC5B,CAAC;AAEF,wBAAgB,uBAAuB,CACnC,OAAO,EAAE,IAAI,CACT,sBAAsB,EACtB,UAAU,GAAG,gCAAgC,CAChD,GACF,kBAAkB,CAKpB;AAED,KAAK,wBAAwB,GAAG;IAC5B,OAAO,EAAE,MAAM,CAAC;IAChB,iBAAiB,EAAE,MAAM,CAAC;IAC1B,WAAW,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,KAAK,CAAC;CAC5C,CAAC;AAEF,eAAO,MAAM,iBAAiB,iDAI3B,wBAAwB,KAAG,OAAO,CAAC,MAAM,CAY3C,CAAC;AAEF,eAAO,MAAM,eAAe,oBACP,sBAAsB,kBAqY1C,CAAC"}

package/dist/handlers/validate.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.validateHandler = exports.waitUntilFinished = exports.VALIDATION_SEVERITIES = exports.getValidation = exports.getJobState = exports.requestValidation = void 0;
+exports.validateHandler = exports.waitUntilFinished = exports.SHOW_CHART_CONFIGURATION_WARNINGS_DEPRECATION = exports.VALIDATION_SEVERITIES = exports.getValidation = exports.getJobState = exports.requestValidation = void 0;
+exports.resolveValidateSeverity = resolveValidateSeverity;
 const tslib_1 = require("tslib");
 const common_1 = require("@lightdash/common");
 const columnify_1 = tslib_1.__importDefault(require("columnify"));
@@ -57,6 +58,13 @@ function styleIssueCounts(errorCount, warningCount) {
 }
 const REFETCH_JOB_INTERVAL = 3000;
 exports.VALIDATION_SEVERITIES = ['error', 'warning'];
+exports.SHOW_CHART_CONFIGURATION_WARNINGS_DEPRECATION = '`--show-chart-configuration-warnings` is deprecated. Use `--severity warning` instead.';
+function resolveValidateSeverity(options) {
+    if (options.showChartConfigurationWarnings) {
+        return 'warning';
+    }
+    return options.severity ?? 'error';
+}
 const waitUntilFinished = async ({ jobUuid, refetchIntervalMs, createError, }) => {
     const job = await (0, exports.getJobState)(jobUuid);
     if (job.status === common_1.SchedulerJobStatus.COMPLETED) {
@@ -71,6 +79,10 @@ exports.waitUntilFinished = waitUntilFinished;
 const validateHandler = async (originalOptions) => {
     const options = { ...originalOptions };
     globalState_1.default.setVerbose(options.verbose);
+    if (options.showChartConfigurationWarnings) {
+        console.error(styles.warning(exports.SHOW_CHART_CONFIGURATION_WARNINGS_DEPRECATION));
+    }
+    const severity = resolveValidateSeverity(options);
     await (0, apiClient_1.checkLightdashVersion)();
     if (options.includeSpaces?.length && options.excludeSpaces?.length) {
         throw new common_1.ParameterError('Cannot use --include-spaces and --exclude-spaces together');
@@ -121,7 +133,6 @@ const validateHandler = async (originalOptions) => {
                 : validationTargets.filter((target) => target !== common_1.ValidationTarget.APPS);
         console.error(styles.warning('> Skipping data app validation because dbt model selection flags produce a partial semantic layer'));
     }
-    const severity = options.severity ?? 'error';
     await analytics_1.LightdashAnalytics.track({
         event: 'validate.started',
         properties: {

package/dist/handlers/validate.test.js

@@ -250,6 +250,29 @@ describe('validateHandler warehouse column validation', () => {
         expect(output).toContain('orders.unused_dim');
         expect(output).toContain('1 warning');
     });
+    test('fails when deprecated --show-chart-configuration-warnings is set and warnings exist', async () => {
+        validationResults = [chartConfigurationWarning];
+        vi.spyOn(process, 'exit').mockImplementation(() => undefined);
+        await (0, validate_1.validateHandler)({
+            ...baseOptions,
+            showChartConfigurationWarnings: true,
+        });
+        expect(process.exit).toHaveBeenCalledWith(1);
+        const output = errorOutput.join('\n');
+        expect(output).toContain(validate_1.SHOW_CHART_CONFIGURATION_WARNINGS_DEPRECATION);
+        expect(output).toContain('Chart configuration warning');
+        expect(output).toContain('orders.unused_dim');
+        expect(output).toContain('1 warning');
+    });
+    test('treats the deprecated flag as --severity warning even when severity defaults to error', async () => {
+        expect((0, validate_1.resolveValidateSeverity)({
+            severity: 'error',
+            showChartConfigurationWarnings: true,
+        })).toBe('warning');
+        expect((0, validate_1.resolveValidateSeverity)({
+            severity: 'error',
+        })).toBe('error');
+    });
     test('fails on blocking errors even when warnings stay hidden', async () => {
         validationResults = [brokenChartError, chartConfigurationWarning];
         vi.spyOn(process, 'exit').mockImplementation(() => undefined);

package/dist/index.js

@@ -552,6 +552,7 @@ commander_1.program
     .addOption(new commander_1.Option('--severity <level>', 'Minimum issue level that fails the command. "error" (default) only fails on errors. "warning" shows chart configuration warnings and treats them as errors.')
     .choices([...validate_2.VALIDATION_SEVERITIES])
     .default('error'))
+    .addOption(new commander_1.Option('--show-chart-configuration-warnings', '(deprecated) Alias for --severity warning. Shows chart configuration warnings and treats them as errors.'))
     .addOption(new commander_1.Option('--only <elems...>', 'Specify project elements to validate')
     .choices(Object.values(common_1.ValidationTarget))
     .default(Object.values(common_1.ValidationTarget)))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightdash/cli",
-  "version": "2.18.2",
+  "version": "2.20.0",
   "description": "Lightdash CLI tool",
   "license": "MIT",
   "repository": {
@@ -45,8 +45,8 @@
     "unique-names-generator": "4.7.1",
     "uuid": "11.1.1",
     "yaml": "2.8.3",
-    "@lightdash/common": "2.18.2",
-    "@lightdash/warehouses": "2.18.2"
+    "@lightdash/common": "2.20.0",
+    "@lightdash/warehouses": "2.20.0"
   },
   "devDependencies": {
     "@types/inquirer": "8.2.4",