@lightdash/cli 1.95.0 → 1.96.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -1,8 +1,8 @@
|
|
|
1
1
|
# Client-side PDF downloads (html-to-image + jspdf)
|
|
2
2
|
|
|
3
|
-
> Read this for PDF Report templates or whenever the user asks for a PDF download.
|
|
3
|
+
> Read this for PDF Report templates, for any report/printable/document-shaped app, or whenever the user asks for a PDF download.
|
|
4
4
|
|
|
5
|
-
|
|
5
|
+
Every PDF or printable report app includes a visible Download PDF button — the app is incomplete without one, on first generation and after every edit. Use the pre-installed `html-to-image` and `jspdf` packages. Do not load PDF libraries from a CDN or ask to install packages.
|
|
6
6
|
|
|
7
7
|
PDF downloads are image-based: they preserve the visible report exactly, but the exported text is not selectable/searchable. Keep `window.print()` only as a secondary Print action if useful; the Download PDF button should save a file directly.
|
|
8
8
|
|
|
@@ -458,7 +458,9 @@ When the user asks for "Open in Google Sheets" (or any Sheets destination), read
|
|
|
458
458
|
|
|
459
459
|
### Client-side PDF downloads
|
|
460
460
|
|
|
461
|
-
|
|
461
|
+
A PDF or printable report app always includes a visible **Download PDF** button — the export action is part of the report shape, not an optional extra, and `window.print()` is only ever a secondary Print action. This applies whenever the app is report-shaped, whatever the request's wording: the PDF Report starter template, a "printable" / "document" / "report to share" ask, or an app that already renders `.pdf-page` sections. On edit turns, keep the existing Download PDF button working — an edit that removes it is a regression.
|
|
462
|
+
|
|
463
|
+
Before wiring the button, read `/app/references/pdf-downloads.md` — it has the required `html-to-image` + `jspdf` pattern and page-capture rules.
|
|
462
464
|
|
|
463
465
|
### Underlying data
|
|
464
466
|
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@lightdash/cli",
|
|
3
|
-
"version": "1.
|
|
3
|
+
"version": "1.96.0",
|
|
4
4
|
"description": "Lightdash CLI tool",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"repository": {
|
|
@@ -41,8 +41,8 @@
|
|
|
41
41
|
"unique-names-generator": "4.7.1",
|
|
42
42
|
"uuid": "11.1.1",
|
|
43
43
|
"yaml": "2.8.3",
|
|
44
|
-
"@lightdash/common": "1.
|
|
45
|
-
"@lightdash/warehouses": "1.
|
|
44
|
+
"@lightdash/common": "1.96.0",
|
|
45
|
+
"@lightdash/warehouses": "1.96.0"
|
|
46
46
|
},
|
|
47
47
|
"devDependencies": {
|
|
48
48
|
"@types/inquirer": "8.2.4",
|