@lightdash/cli 1.33.0 → 1.35.0

package/dist/terminal/contentAsCodeOutput.test.js

@@ -125,6 +125,49 @@ describe('content as code terminal output', () => {
         vi.unstubAllEnvs();
         vi.restoreAllMocks();
     });
+    it('pauses the spinner around a prompt and resumes with progress text', async () => {
+        const originalIsTTY = process.stderr.isTTY;
+        Object.defineProperty(process.stderr, 'isTTY', {
+            configurable: true,
+            value: true,
+        });
+        vi.stubEnv('CI', 'false');
+        vi.stubEnv('TERM', 'xterm');
+        vi.stubEnv('NO_UNICODE', 'false');
+        const spinner = {
+            text: '',
+            start: vi.fn(),
+            succeed: vi.fn(),
+            warn: vi.fn(),
+            stop: vi.fn(),
+            fail: vi.fn(),
+        };
+        vi.spyOn(globalState_1.default, 'startSpinner').mockReturnValue(spinner);
+        const output = (0, contentAsCodeOutput_1.createContentAsCodeOutput)({
+            operation: 'upload',
+            scope: 'project',
+        });
+        output.startItem('Data apps');
+        // The spinner must be stopped BEFORE the prompt runs (a spinning
+        // repaint hides the prompt and the command looks hung).
+        const answer = await output.promptWhilePaused(() => {
+            expect(spinner.stop).toHaveBeenCalledOnce();
+            expect(spinner.start).not.toHaveBeenCalled();
+            return Promise.resolve('yes');
+        });
+        expect(answer).toBe('yes');
+        expect(spinner.start).toHaveBeenCalledOnce();
+        expect(String(spinner.start.mock.calls[0][0])).toContain('Data apps');
+        // A rejecting prompt still resumes the spinner.
+        await expect(output.promptWhilePaused(() => Promise.reject(new Error('nope')))).rejects.toThrow('nope');
+        expect(spinner.start).toHaveBeenCalledTimes(2);
+        Object.defineProperty(process.stderr, 'isTTY', {
+            configurable: true,
+            value: originalIsTTY,
+        });
+        vi.unstubAllEnvs();
+        vi.restoreAllMocks();
+    });
     it('updates the active tree item with resource progress', () => {
         const originalIsTTY = process.stderr.isTTY;
         Object.defineProperty(process.stderr, 'isTTY', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightdash/cli",
-  "version": "1.33.0",
+  "version": "1.35.0",
   "description": "Lightdash CLI tool",
   "license": "MIT",
   "repository": {
@@ -41,8 +41,8 @@
     "unique-names-generator": "4.7.1",
     "uuid": "11.1.1",
     "yaml": "2.8.3",
-    "@lightdash/common": "1.33.0",
-    "@lightdash/warehouses": "1.33.0"
+    "@lightdash/common": "1.35.0",
+    "@lightdash/warehouses": "1.35.0"
   },
   "devDependencies": {
     "@types/inquirer": "8.2.4",