@lifesavertech/archguard-rules-react 2.0.0 → 2.2.0

package/dist/index.d.ts

@@ -1,6 +1,7 @@
 /** React-specific rule implementations. */
 import { Rule } from "@lifesavertech/archguard-core";
 export declare function createLayerImportBoundaryRule(): Rule;
+export declare function createBarrelBoundaryBypassRule(): Rule;
 export declare function createBusinessLogicInComponentsRule(): Rule;
 export declare function createDataFetchingInUIRule(): Rule;
 export declare function createCircularDependencyRule(): Rule;

package/dist/index.js

@@ -35,6 +35,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.createLayerImportBoundaryRule = createLayerImportBoundaryRule;
+exports.createBarrelBoundaryBypassRule = createBarrelBoundaryBypassRule;
 exports.createBusinessLogicInComponentsRule = createBusinessLogicInComponentsRule;
 exports.createDataFetchingInUIRule = createDataFetchingInUIRule;
 exports.createCircularDependencyRule = createCircularDependencyRule;
@@ -61,7 +62,7 @@ function createLayerImportBoundaryRule() {
                 return { violations: [], passed: true };
             }
             const filePath = context.filePath;
-            const layerName = (0, archguard_core_1.detectLayerFromPath)(filePath, context.architecture.layers);
+            const layerName = (0, archguard_core_1.detectLayerFromPath)(filePath, context.architecture, context.projectRoot);
             if (!layerName) {
                 return { violations: [], passed: true };
             }
@@ -74,7 +75,7 @@ function createLayerImportBoundaryRule() {
                 if (imp.isTypeOnly) {
                     continue;
                 }
-                const importedLayer = detectLayerFromImport(imp, filePath, context.architecture.layers);
+                const importedLayer = detectLayerFromImport(imp, filePath, context.architecture, context.projectRoot);
                 if (importedLayer && importedLayer !== layerName) {
                     if (!allowedLayers.has(importedLayer)) {
                         const sourceFile = (0, archguard_core_1.parseTypeScript)(context.sourceCode, context.filePath);
@@ -90,6 +91,12 @@ function createLayerImportBoundaryRule() {
                                 column: character + 1,
                                 message: `Layer '${layerName}' cannot import from '${importedLayer}'. Import from allowed layers only: ${allowedList}. Move the imported code to an allowed layer or restructure dependencies.`,
                                 rule: "layer-import-boundary",
+                                fix: `Move the imported symbol to an allowed layer (${allowedList}) or add '${importedLayer}' to ${layerName}.allowedImports if intentional.`,
+                                context: {
+                                    sourceLayer: layerName,
+                                    targetLayer: importedLayer,
+                                    importPath: imp.from,
+                                },
                             });
                         }
                     }
@@ -102,6 +109,73 @@ function createLayerImportBoundaryRule() {
         },
     };
 }
+function createBarrelBoundaryBypassRule() {
+    return {
+        name: "no-barrel-boundary-bypass",
+        description: "Detects layer boundary bypass through barrel re-exports",
+        execute(context) {
+            const violations = [];
+            if (!(0, archguard_core_1.isBarrelBoundaryBypassEnabled)(context.architecture.rules)) {
+                return { violations: [], passed: true };
+            }
+            const layerName = (0, archguard_core_1.detectLayerFromPath)(context.filePath, context.architecture, context.projectRoot);
+            if (!layerName) {
+                return { violations: [], passed: true };
+            }
+            const layerConfig = context.architecture.layers[layerName];
+            if (!layerConfig) {
+                return { violations: [], passed: true };
+            }
+            const allowedLayers = new Set(layerConfig.allowedImports);
+            const projectRoot = context.projectRoot ?? process.cwd();
+            const resolver = (0, archguard_core_1.createImportResolver)(projectRoot);
+            for (const imp of context.imports) {
+                const resolvedPath = imp.resolvedPath ?? resolver.resolve(imp.from, context.filePath);
+                if (!resolvedPath) {
+                    continue;
+                }
+                const leaks = (0, archguard_core_1.collectBarrelLeaks)({
+                    barrelPath: resolvedPath,
+                    importerLayer: layerName,
+                    allowedLayers,
+                    architecture: context.architecture,
+                    projectRoot,
+                    resolver,
+                });
+                if (leaks.length === 0) {
+                    continue;
+                }
+                const sourceFile = (0, archguard_core_1.parseTypeScript)(context.sourceCode, context.filePath);
+                const importNode = findImportNode(sourceFile, imp.from);
+                if (!importNode) {
+                    continue;
+                }
+                const { line, character } = sourceFile.getLineAndCharacterOfPosition(importNode.getStart());
+                for (const leak of leaks) {
+                    const chain = (0, archguard_core_1.formatBarrelChain)(leak.chain, projectRoot);
+                    violations.push({
+                        file: context.filePath,
+                        line: line + 1,
+                        column: character + 1,
+                        message: `Layer '${layerName}' accesses '${leak.leakedLayer}' through a barrel re-export (${chain}). Import from allowed layers only or remove the re-export.`,
+                        rule: "no-barrel-boundary-bypass",
+                        fix: `Stop re-exporting '${leak.leakedLayer}' through this barrel, or expose a facade in an allowed layer (${[...allowedLayers].join(", ") || "none"}).`,
+                        context: {
+                            sourceLayer: layerName,
+                            targetLayer: leak.leakedLayer,
+                            importPath: imp.from,
+                            reexportChain: chain,
+                        },
+                    });
+                }
+            }
+            return {
+                violations,
+                passed: violations.length === 0,
+            };
+        },
+    };
+}
 function createBusinessLogicInComponentsRule() {
     return {
         name: "no-business-logic-in-components",
@@ -111,7 +185,7 @@ function createBusinessLogicInComponentsRule() {
             if (!context.architecture.rules.noBusinessLogicInComponents) {
                 return { violations: [], passed: true };
             }
-            if (!(0, archguard_core_1.fileBelongsToUiLayer)(context.filePath, context.architecture)) {
+            if (!(0, archguard_core_1.fileBelongsToUiLayer)(context.filePath, context.architecture, context.projectRoot)) {
                 return { violations: [], passed: true };
             }
             const sourceFile = (0, archguard_core_1.parseTypeScript)(context.sourceCode, context.filePath);
@@ -138,7 +212,7 @@ function createDataFetchingInUIRule() {
             if (!context.architecture.rules.noDataFetchingInUI) {
                 return { violations: [], passed: true };
             }
-            if (!(0, archguard_core_1.fileBelongsToUiLayer)(context.filePath, context.architecture)) {
+            if (!(0, archguard_core_1.fileBelongsToUiLayer)(context.filePath, context.architecture, context.projectRoot)) {
                 return { violations: [], passed: true };
             }
             const sourceFile = (0, archguard_core_1.parseTypeScript)(context.sourceCode, context.filePath);
@@ -225,12 +299,12 @@ function detectCycles(graph) {
     }
     return cycles;
 }
-function detectLayerFromImport(importedModule, fromFile, layers) {
+function detectLayerFromImport(importedModule, fromFile, architecture, projectRoot) {
     if (importedModule.resolvedPath) {
-        return (0, archguard_core_1.detectLayerFromPath)(importedModule.resolvedPath, layers);
+        return (0, archguard_core_1.detectLayerFromPath)(importedModule.resolvedPath, architecture, projectRoot);
     }
     if (isRelativeImport(importedModule.from)) {
-        return detectLayerFromImportPath(importedModule.from, fromFile, layers);
+        return detectLayerFromImportPath(importedModule.from, fromFile, architecture, projectRoot);
     }
     return null;
 }
@@ -244,9 +318,9 @@ function formatProjectRelativePath(filePath, projectRoot) {
     }
     return filePath.replace(/\\/g, "/");
 }
-function detectLayerFromImportPath(importPath, fromFile, layers) {
+function detectLayerFromImportPath(importPath, fromFile, architecture, projectRoot) {
     const resolvedPath = path.resolve(path.dirname(fromFile), importPath);
-    return (0, archguard_core_1.detectLayerFromPath)(resolvedPath, layers);
+    return (0, archguard_core_1.detectLayerFromPath)(resolvedPath, architecture, projectRoot);
 }
 function isRelativeImport(importPath) {
     return importPath.startsWith(".") || importPath.startsWith("/");
@@ -358,7 +432,7 @@ function buildImportedSymbolLayers(context) {
         if (imp.isTypeOnly) {
             continue;
         }
-        const importedLayer = detectLayerFromImport(imp, context.filePath, context.architecture.layers);
+        const importedLayer = detectLayerFromImport(imp, context.filePath, context.architecture, context.projectRoot);
         for (const specifier of imp.specifiers) {
             importedSymbols.set(specifier, importedLayer);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lifesavertech/archguard-rules-react",
-  "version": "2.0.0",
+  "version": "2.2.0",
   "description": "React-specific rules for ArchGuard",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -25,7 +25,7 @@
     "test": "npm run build:test && node --test dist-test/index.test.js"
   },
   "dependencies": {
-    "@lifesavertech/archguard-core": "2.0.0",
+    "@lifesavertech/archguard-core": "2.2.0",
     "typescript": "^5.0.0"
   },
   "devDependencies": {