@lifeaitools/rdc-skills 0.9.5 → 0.9.7

package/.github/workflows/publish.yml

@@ -31,4 +31,4 @@ jobs:
           STATUS="${{ job.status }}"
           curl -s -X POST "${{ secrets.CLAUTH_CHANNEL_URL }}" \
             -H "Content-Type: application/json" \
-            -d "{\"text\":\"rdc-skills v${VERSION} npm publish: ${STATUS}\",\"source\":\"github-actions\"}"
+            -d "{\"event\":\"npm-publish\",\"package\":\"rdc-skills\",\"version\":\"${VERSION}\",\"status\":\"${STATUS}\",\"source\":\"github-actions\"}"

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lifeaitools/rdc-skills",
-  "version": "0.9.5",
-  "description": "RDC typed-agent dispatch skill suite for Claude Code — plan, build, review, overnight builds",
+  "version": "0.9.7",
+  "description": "RDC typed-agent dispatch skill suite for Claude Code \u00e2\u20ac\u201d plan, build, review, overnight builds",
   "keywords": [
     "claude-code",
     "claude-code-plugin",
@@ -19,7 +19,7 @@
     "type": "plugin",
     "skills": "skills/",
     "guides": "guides/",
-    "version": "0.9.5",
+    "version": "0.9.6",
     "commands": "commands/"
   },
   "scripts": {

package/scripts/install-rdc-skills.js

@@ -120,6 +120,63 @@ function buildPluginCache(cacheDir, version, gitSha) {
   }
 }
 
+// ── User-skills cleanup ───────────────────────────────────────────────────────
+// Older installer versions wrote skill files directly to ~/.claude/skills/user/.
+// Claude Code loads that directory AND the plugin cache, so any rdc skills left
+// there produce duplicate registrations and break the resolver.
+// This function nukes any entry whose frontmatter name starts with "rdc:".
+function cleanUserSkills(userSkillsDir) {
+  if (!fs.existsSync(userSkillsDir)) return 0;
+  let removed = 0;
+  for (const entry of fs.readdirSync(userSkillsDir, { withFileTypes: true })) {
+    const candidate = path.join(userSkillsDir, entry.name);
+    let skillFile = null;
+    if (entry.isDirectory()) {
+      // New format: <name>/SKILL.md or <name>/skill.md
+      for (const sf of ['SKILL.md', 'skill.md']) {
+        const p = path.join(candidate, sf);
+        if (fs.existsSync(p)) { skillFile = p; break; }
+      }
+    } else if (entry.isFile() && entry.name.endsWith('.md') && entry.name !== 'skill.md' && entry.name !== 'SKILL.md' && entry.name !== 'README.md') {
+      // Old format: rdc-deploy.md flat file
+      skillFile = candidate;
+    }
+    if (!skillFile) continue;
+    const fm = readFrontmatter(skillFile);
+    if (fm.name && fm.name.startsWith('rdc:')) {
+      try {
+        if (entry.isDirectory()) fs.rmSync(candidate, { recursive: true, force: true });
+        else fs.unlinkSync(candidate);
+        removed++;
+      } catch {}
+    }
+  }
+  return removed;
+}
+
+// ── Stale hook cleanup ────────────────────────────────────────────────────────
+// Remove hook files from ~/.claude/hooks/ that are no longer in the source hooks/ dir.
+// Prevents orphaned hooks (removed from source but still installed) from misfiring.
+function cleanStaleHooks(hooksDstDir, hooksSrcDir) {
+  if (!fs.existsSync(hooksDstDir) || !fs.existsSync(hooksSrcDir)) return 0;
+  const sourceFiles = new Set(fs.readdirSync(hooksSrcDir).filter(f => f.endsWith('.js')));
+  // These hooks were written by us (rdc-skills) — safe to remove if no longer in source.
+  // We only manage our own hooks; never touch hooks we didn't install.
+  const knownHooks = [
+    'check-cwd.js', 'check-stale-work-items.js', 'check-services.js',
+    'precompact-log.js', 'postcompact-log.js', 'restart-brief.js',
+    'rate-limit-retry.js', 'post-work-check.js', 'no-stop-open-epics.js',
+    'require-work-item-on-commit.js', 'verify-rdc-skills.js',
+  ];
+  let removed = 0;
+  for (const f of knownHooks) {
+    if (!sourceFiles.has(f) && fs.existsSync(path.join(hooksDstDir, f))) {
+      try { fs.unlinkSync(path.join(hooksDstDir, f)); removed++; } catch {}
+    }
+  }
+  return removed;
+}
+
 // ── Cache flush helper ────────────────────────────────────────────────────────
 function flushOldCaches(cacheBase, keepVersion) {
   if (!fs.existsSync(cacheBase)) return 0;
@@ -480,6 +537,20 @@ async function main() {
     warn('[0/6] git pull failed — installing from local copy');
   }
 
+  // 0.5a. User-skills cleanup — remove any rdc: skills from ~/.claude/skills/user/
+  // (older installer versions wrote there; plugin cache is the only authoritative source)
+  {
+    const userSkillsDir = path.join(claudeHome, 'skills', 'user');
+    const purged = cleanUserSkills(userSkillsDir);
+    if (purged > 0) ok(`[0.5a] Skills cleanup — removed ${purged} stale rdc: skill(s) from skills/user/`);
+  }
+
+  // 0.5b. Stale hook cleanup — remove hooks we no longer ship
+  {
+    const staleRemoved = cleanStaleHooks(hooksDst, hooksSrc);
+    if (staleRemoved > 0) ok(`[0.5b] Hook cleanup — removed ${staleRemoved} orphaned hook file(s)`);
+  }
+
   // 0.5. Legacy cleanup — remove old commands/rdc/ (pre-plugin-system format)
   const legacyCommandsDir = path.join(claudeHome, 'commands', 'rdc');
   if (fs.existsSync(legacyCommandsDir)) {

package/skills/plan/SKILL.md

@@ -96,3 +96,41 @@ choose the most conservative/reversible approach and document the decision.
 - Reference affected CLAUDE.md files in each work package description
 - Reference the relevant guide file from `.rdc/guides/` (fallback: `.rdc/guides/`) for agent context
 - **If a work package involves creating a new deployed app:** the task description MUST say "Use `rdc:deploy new <slug>` — do NOT create the Coolify app manually. Read `docs/runbooks/coolify-app-templates.json` first." Assign it to an `infra` agent. This is a hard rule — manually created apps have consistently been misconfigured.
+
+## New App Q&A (mandatory before writing any infra task that creates a Coolify app)
+
+If the plan includes deploying a new app, these questions MUST be answered — in interactive mode, ask the user; in unattended mode, escalate via advisor. Do NOT write the infra task until all answers are locked in. Record answers in the plan doc and embed them directly in the task description.
+
+**Never guess. Wrong project = delete and recreate. There is no move operation in Coolify.**
+
+```
+Q1. Which Coolify project does this app belong to?
+    → Read docs/runbooks/coolify-app-templates.json → _infrastructure.projects
+    → Match by area: design-system / prt / rdc / rdc-marketing / zoen / lifeai / place-fund / infrastructure / ai-platform
+    → If unsure: ASK. Do not infer from app name alone.
+    → Record: project_uuid + environment_uuid (staging or production)
+
+Q2. What is the domain?
+    → *.dev.place.fund subdomain? (staging / internal tools)
+    → Custom subdomain on an existing zone? (e.g. app.regendevcorp.com)
+    → Apex domain? (e.g. place.fund itself)
+    → Domain on a different zone entirely? (e.g. skymesasouth.com)
+
+Q3. Is this domain already in our Cloudflare account?
+    → Yes, zone exists → which zone?
+    → No → who controls the nameservers? Does the registrar point NS to Cloudflare?
+    → If NS not delegated to Cloudflare: A record in Cloudflare does nothing — must go to registrar
+
+Q4. Does this app need Cloudflare proxy (orange cloud)?
+    → *.dev.place.fund: NEVER proxy — breaks Traefik Let's Encrypt HTTP-01 cert provisioning
+    → Custom domain needing DDoS/CDN: proxy OK only if SSL mode = Full (strict) + origin cert provisioned
+    → Any doubt: start unproxied, add proxy after confirming SSL works
+
+Q5. What SSL path?
+    → Traefik + Let's Encrypt (default for all unproxied): automatic, no action needed
+    → Cloudflare proxy + Full (strict): need origin cert from Cloudflare dashboard first
+    → Nixpacks build pack: DO NOT USE for any app that needs custom SSL setup — nixpacks
+      containers have incompatible SSL configuration requirements. Use dockerfile build pack only.
+```
+
+Embed all five answers into the infra task description verbatim before handing to the agent.