@lifeaitools/rdc-skills 0.9.33 → 0.9.34

package/skills/report/SKILL.md

@@ -1,100 +1,100 @@
----
-name: rdc:report
-description: "Usage `rdc:report` — Write the nightly session summary to .rdc/reports/YYYY-MM-DD.md covering completed work, open items, per-project progress, and infra status. Call at session end."
----
-
-> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
-> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
-> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
-
-> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
-
-> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag. Git push is skipped under `RDC_TEST=1`.
-
-
-# rdc:report — Nightly Report
-
-## When to Use
-- End of a build session
-- Project lead asks for a report or summary
-- Nightly scheduled task
-- Before handing off to another session
-- Called by `rdc:overnight` at the end of every session
-
-## Arguments
-- `rdc:report` — interactive, prints summary to conversation
-- `rdc:report --unattended` — silent mode, writes file only, returns status block
-
-## Procedure
-
-1. **Query completed work (last 24h or since last report):**
-   ```sql
-   SELECT title, labels, completed_at, notes
-   FROM work_items
-   WHERE completed_at > now() - interval '24 hours'
-   ORDER BY completed_at;
-   ```
-
-2. **Query open work:**
-   ```sql
-   SELECT title, status, priority, labels
-   FROM work_items
-   WHERE status IN ('todo', 'in_progress', 'blocked')
-   ORDER BY priority, created_at;
-   ```
-
-3. **Git stats (since last report or last 24h):**
-   ```bash
-   git log --since="24 hours ago" --shortstat --oneline
-   git diff --shortstat HEAD~N  # where N = commits in window
-   ```
-
-4. **Infrastructure deployment snapshot** (if MCP available):
-   - List all apps with current status
-   - Flag any failures
-
-5. **Write report** to `.rdc/reports/YYYY-MM-DD.md` (fallback: `.rdc/reports/YYYY-MM-DD.md` if `.rdc/` does not exist):
-   ```markdown
-   # Daily Report — YYYY-MM-DD
-
-   ## Completed Today
-   | Item | Project | Priority |
-
-   ## Git Activity
-   - Commits: N
-   - Files changed: N
-   - Lines: +N / -N
-
-   ## Open Work
-   ### Urgent (N)
-   ### High (N)
-   ### Normal (N)
-
-   ## Deployment Status
-   | App | Domain | Status |
-
-   ## Blockers
-   <any blocked items or failed deploys>
-
-   ## Next Session Recommendation
-   <highest priority unstarted work>
-   ```
-
-6. **Check if weekly rollup needed** (if today is Sunday):
-   - Aggregate daily reports for the week
-   - Write `.rdc/reports/week-YYYY-WNN.md` (fallback: `.rdc/reports/week-YYYY-WNN.md`)
-
-7. **Report results:**
-   - Interactive: print summary to conversation
-   - Unattended: no interactive output, emit status block only:
-     ```
-     REPORT_STATUS: { report_path, completed_count, open_count, blockers_count }
-     ```
-
-## Rules
-- Reports go in `.rdc/reports/` (fallback: `.rdc/reports/`) — create dir if missing
-- One report per day — overwrite if re-run same day
-- Keep under 100 lines — scannable, not exhaustive
-- Include links to relevant CLAUDE.md files where helpful
-- Always end with "Next Session Recommendation"
-- Unattended: NEVER print to conversation — write file only
+---
+name: rdc:report
+description: "Usage `rdc:report` — Write the nightly session summary to .rdc/reports/YYYY-MM-DD.md covering completed work, open items, per-project progress, and infra status. Call at session end."
+---
+
+> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
+> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
+> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
+
+> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
+
+> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag. Git push is skipped under `RDC_TEST=1`.
+
+
+# rdc:report — Nightly Report
+
+## When to Use
+- End of a build session
+- Project lead asks for a report or summary
+- Nightly scheduled task
+- Before handing off to another session
+- Called by `rdc:overnight` at the end of every session
+
+## Arguments
+- `rdc:report` — interactive, prints summary to conversation
+- `rdc:report --unattended` — silent mode, writes file only, returns status block
+
+## Procedure
+
+1. **Query completed work (last 24h or since last report):**
+   ```sql
+   SELECT title, labels, completed_at, notes
+   FROM work_items
+   WHERE completed_at > now() - interval '24 hours'
+   ORDER BY completed_at;
+   ```
+
+2. **Query open work:**
+   ```sql
+   SELECT title, status, priority, labels
+   FROM work_items
+   WHERE status IN ('todo', 'in_progress', 'blocked')
+   ORDER BY priority, created_at;
+   ```
+
+3. **Git stats (since last report or last 24h):**
+   ```bash
+   git log --since="24 hours ago" --shortstat --oneline
+   git diff --shortstat HEAD~N  # where N = commits in window
+   ```
+
+4. **Infrastructure deployment snapshot** (if MCP available):
+   - List all apps with current status
+   - Flag any failures
+
+5. **Write report** to `.rdc/reports/YYYY-MM-DD.md` (fallback: `.rdc/reports/YYYY-MM-DD.md` if `.rdc/` does not exist):
+   ```markdown
+   # Daily Report — YYYY-MM-DD
+
+   ## Completed Today
+   | Item | Project | Priority |
+
+   ## Git Activity
+   - Commits: N
+   - Files changed: N
+   - Lines: +N / -N
+
+   ## Open Work
+   ### Urgent (N)
+   ### High (N)
+   ### Normal (N)
+
+   ## Deployment Status
+   | App | Domain | Status |
+
+   ## Blockers
+   <any blocked items or failed deploys>
+
+   ## Next Session Recommendation
+   <highest priority unstarted work>
+   ```
+
+6. **Check if weekly rollup needed** (if today is Sunday):
+   - Aggregate daily reports for the week
+   - Write `.rdc/reports/week-YYYY-WNN.md` (fallback: `.rdc/reports/week-YYYY-WNN.md`)
+
+7. **Report results:**
+   - Interactive: print summary to conversation
+   - Unattended: no interactive output, emit status block only:
+     ```
+     REPORT_STATUS: { report_path, completed_count, open_count, blockers_count }
+     ```
+
+## Rules
+- Reports go in `.rdc/reports/` (fallback: `.rdc/reports/`) — create dir if missing
+- One report per day — overwrite if re-run same day
+- Keep under 100 lines — scannable, not exhaustive
+- Include links to relevant CLAUDE.md files where helpful
+- Always end with "Next Session Recommendation"
+- Unattended: NEVER print to conversation — write file only

package/skills/review/SKILL.md

@@ -1,121 +1,122 @@
----
-name: rdc:review
-description: "Usage `rdc:review [--unattended]` — Post-build quality gate: tsc, tests, stale docs, export conflicts across modified packages. Fixes what it can automatically, escalates the rest. Call after rdc:build and before merging to main."
----
-
-> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
-> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
-> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
-
-> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
-
-> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag.
-
-
-# rdc:review — Quality Gate
-
-## When to Use
-- After a build session (especially overnight builds)
-- Before merging development → main/production
-- Project lead asks "review the work", "is everything clean"
-- Before any production deployment
-- Called by `rdc:overnight` after each epic build completes
-
-## Arguments
-- `rdc:review` — interactive review, pauses on issues needing judgment
-- `rdc:review --unattended` — silent mode, auto-fixes everything fixable
-
-## Procedure
-
-1. **Identify modified packages:**
-   ```bash
-   git diff --name-only origin/main...HEAD | grep "^packages/" | cut -d/ -f2 | sort -u
-   ```
-
-2. **Run tests for each modified package:**
-   ```bash
-   cd packages/<name> && npx vitest run 2>&1 | tail -10
-   ```
-   Report: package → test count → pass/fail → new tests added
-
-   **IMPORTANT:** `pnpm build` must NEVER be run (crashes system). Use `npx tsc --noEmit --project <path>/tsconfig.json` for typecheck instead. For packages without tests, typecheck is the verification method. Do NOT run vitest across the entire monorepo — check only modified packages individually.
-
-3. **Check test coverage delta:**
-   ```bash
-   git diff origin/main...HEAD -- packages/*/src/ | grep -c "^+" | head -5
-   git diff origin/main...HEAD -- packages/*/test* packages/*/src/**/*.test.* packages/*/src/**/*.spec.* 2>/dev/null | grep -c "^+" || echo 0
-   ```
-   Flag any package where implementation lines added > 50 but test lines added = 0.
-
-4. **Check for export conflicts:**
-   - Read `packages/*/src/index.ts` for any package with new exports
-   - Look for duplicate export names across the barrel
-   - Verify aliased exports don't shadow each other
-
-5. **Check for TODO/FIXME/HACK:**
-   ```bash
-   grep -rn "TODO\|FIXME\|HACK\|XXX" packages/*/src/ --include="*.ts" --include="*.tsx"
-   ```
-
-6. **Check package versions:**
-   - Any package with significant new code should have a version bump
-   - Compare package.json versions to what's in `docs/SYSTEM-STATE.md`
-
-7. **Check for stale CLAUDE.md:**
-   - If new modules were added to a package, does its CLAUDE.md mention them?
-   - Flag any package where exports grew by >10 lines but CLAUDE.md wasn't updated
-
-8. **Orphan work item audit:**
-   ```sql
-   SELECT id, title, item_type, status, source, created_at::date
-   FROM work_items
-   WHERE parent_id IS NULL
-     AND item_type NOT IN ('epic', 'bug')
-     AND status NOT IN ('done', 'archived')
-   ORDER BY created_at DESC;
-   ```
-   For each orphaned task found:
-   - If it clearly belongs to an open epic → **do not run raw SQL**. No RPC exists for re-parenting. Create a work item: `SELECT insert_work_item(p_title := 'Re-parent orphaned task <task-id> to epic <epic-id>', p_priority := 'normal', p_source := 'agent')` and flag for supervisor to re-parent manually.
-   - If unclear → report (interactive) or flag in REVIEW_STATUS (unattended)
-   - Never silently leave orphaned tasks
-   - **⛔ Raw `UPDATE work_items SET parent_id = ...` is forbidden** — bypasses RLS and all constraint checks
-
-9. **Verification gate — dispatch the verify agent:**
-   After any fixes land, run the verify gate on every touched package. See `guides/agents/verify.md`.
-   **Iron Law: no CLEAN verdict without fresh evidence.** Quote the checklist decomposition verdict, vitest output, and tsc output in the report.
-   The verify agent must reject any work item that lacks passed `decomp-*` checklist rows or whose rows are too coarse to prove one observable behavior at a time.
-   If verify fails → do NOT emit CLEAN. Loop back, fix, re-run verify.
-
-10. **Fix issues found:**
-   - Failing tests → fix and commit
-   - Export conflicts → resolve and commit
-   - Missing version bumps → bump and commit
-   - All fixes as separate commits with descriptive messages
-
-   **Judgment calls:**
-   - Interactive: report — don't guess
-   - Unattended: escalate via advisor tool with: error message, surrounding context,
-     two most likely fix paths. Resume with advisor's recommendation.
-     If advisor unavailable: take the most conservative path, flag in status block.
-
-11. **Report:**
-    - Interactive:
-      ```
-      ## Review Results
-      | Package | Tests | Pass/Fail | New Tests | Issues |
-      ## Fixed
-      ## Remaining Issues
-      ## Verdict: CLEAN / HAS ISSUES
-      ```
-    - Unattended: emit status block only:
-      ```
-      REVIEW_STATUS: { verdict: "CLEAN|HAS_ISSUES", packages_checked, tests_passed, tests_failed, new_tests_added, fixes_applied, escalations }
-      ```
-
-## Rules
-- Do NOT run `pnpm build` (crashes system) — vitest only
-- Interactive: fix what you can, flag what needs decision
-- Unattended: fix everything fixable; escalate judgment calls to advisor
-- Each fix is a separate commit (not batched)
-- Always push fixes to origin after committing *(skip if `$RDC_TEST=1` — echo `[RDC_TEST] skipping git push` instead)*
-- Unattended: NEVER pause for input
+---
+name: rdc:review
+description: "Usage `rdc:review [--unattended]` — Post-build quality gate: tsc, tests, stale docs, export conflicts across modified packages. Fixes what it can automatically, escalates the rest. Call after rdc:build and before merging to main."
+---
+
+> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
+> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
+> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
+
+> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`), then `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md` (fallback: `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md`).
+
+> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag.
+
+
+# rdc:review — Quality Gate
+
+## When to Use
+- After a build session (especially overnight builds)
+- Before merging development → main/production
+- Project lead asks "review the work", "is everything clean"
+- Before any production deployment
+- Called by `rdc:overnight` after each epic build completes
+
+## Arguments
+- `rdc:review` — interactive review, pauses on issues needing judgment
+- `rdc:review --unattended` — silent mode, auto-fixes everything fixable
+
+## Procedure
+
+1. **Identify modified packages:**
+   ```bash
+   git diff --name-only origin/main...HEAD | grep "^packages/" | cut -d/ -f2 | sort -u
+   ```
+
+2. **Run tests for each modified package:**
+   ```bash
+   cd packages/<name> && npx vitest run 2>&1 | tail -10
+   ```
+   Report: package → test count → pass/fail → new tests added
+
+   **IMPORTANT:** `pnpm build` must NEVER be run (crashes system). Use `npx tsc --noEmit --project <path>/tsconfig.json` for typecheck instead. For packages without tests, typecheck is the verification method. Do NOT run vitest across the entire monorepo — check only modified packages individually.
+
+3. **Check test coverage delta:**
+   ```bash
+   git diff origin/main...HEAD -- packages/*/src/ | grep -c "^+" | head -5
+   git diff origin/main...HEAD -- packages/*/test* packages/*/src/**/*.test.* packages/*/src/**/*.spec.* 2>/dev/null | grep -c "^+" || echo 0
+   ```
+   Flag any package where implementation lines added > 50 but test lines added = 0.
+
+4. **Check for export conflicts:**
+   - Read `packages/*/src/index.ts` for any package with new exports
+   - Look for duplicate export names across the barrel
+   - Verify aliased exports don't shadow each other
+
+5. **Check for TODO/FIXME/HACK:**
+   ```bash
+   grep -rn "TODO\|FIXME\|HACK\|XXX" packages/*/src/ --include="*.ts" --include="*.tsx"
+   ```
+
+6. **Check package versions:**
+   - Any package with significant new code should have a version bump
+   - Compare package.json versions to what's in `docs/SYSTEM-STATE.md`
+
+7. **Check for stale CLAUDE.md:**
+   - If new modules were added to a package, does its CLAUDE.md mention them?
+   - Flag any package where exports grew by >10 lines but CLAUDE.md wasn't updated
+
+8. **Orphan work item audit:**
+   ```sql
+   SELECT id, title, item_type, status, source, created_at::date
+   FROM work_items
+   WHERE parent_id IS NULL
+     AND item_type NOT IN ('epic', 'bug')
+     AND status NOT IN ('done', 'archived')
+   ORDER BY created_at DESC;
+   ```
+   For each orphaned task found:
+   - If it clearly belongs to an open epic → **do not run raw SQL**. No RPC exists for re-parenting. Create a work item: `SELECT insert_work_item(p_title := 'Re-parent orphaned task <task-id> to epic <epic-id>', p_priority := 'normal', p_source := 'agent')` and flag for supervisor to re-parent manually.
+   - If unclear → report (interactive) or flag in REVIEW_STATUS (unattended)
+   - Never silently leave orphaned tasks
+   - **⛔ Raw `UPDATE work_items SET parent_id = ...` is forbidden** — bypasses RLS and all constraint checks
+
+9. **Verification gate — dispatch the verify agent:**
+   After any fixes land, run the verify gate on every touched package. See `guides/agents/verify.md`.
+   Apply `guides/engineering-behavior.md` while reviewing: flag unnecessary abstraction, drive-by refactors, missing assumptions, hidden uncertainty, out-of-scope edits, and prose-only verification.
+   **Iron Law: no CLEAN verdict without fresh evidence.** Quote the checklist decomposition verdict, vitest output, and tsc output in the report.
+   The verify agent must reject any work item that lacks passed `decomp-*` checklist rows or whose rows are too coarse to prove one observable behavior at a time.
+   If verify fails → do NOT emit CLEAN. Loop back, fix, re-run verify.
+
+10. **Fix issues found:**
+   - Failing tests → fix and commit
+   - Export conflicts → resolve and commit
+   - Missing version bumps → bump and commit
+   - All fixes as separate commits with descriptive messages
+
+   **Judgment calls:**
+   - Interactive: report — don't guess
+   - Unattended: escalate via advisor tool with: error message, surrounding context,
+     two most likely fix paths. Resume with advisor's recommendation.
+     If advisor unavailable: take the most conservative path, flag in status block.
+
+11. **Report:**
+    - Interactive:
+      ```
+      ## Review Results
+      | Package | Tests | Pass/Fail | New Tests | Issues |
+      ## Fixed
+      ## Remaining Issues
+      ## Verdict: CLEAN / HAS ISSUES
+      ```
+    - Unattended: emit status block only:
+      ```
+      REVIEW_STATUS: { verdict: "CLEAN|HAS_ISSUES", packages_checked, tests_passed, tests_failed, new_tests_added, fixes_applied, escalations }
+      ```
+
+## Rules
+- Do NOT run `pnpm build` (crashes system) — vitest only
+- Interactive: fix what you can, flag what needs decision
+- Unattended: fix everything fixable; escalate judgment calls to advisor
+- Each fix is a separate commit (not batched)
+- Always push fixes to origin after committing *(skip if `$RDC_TEST=1` — echo `[RDC_TEST] skipping git push` instead)*
+- Unattended: NEVER pause for input