@lifeaitools/rdc-skills 0.9.29 → 0.9.31

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "rdc",
-  "version": "0.9.28",
+  "version": "0.9.31",
   "description": "RDC typed-agent dispatch skill suite for Claude Code — plan, build, review, overnight unattended builds with work-item tracking and TDD enforcement.",
   "author": {
     "name": "LIFEAI",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lifeaitools/rdc-skills",
-  "version": "0.9.29",
+  "version": "0.9.31",
   "description": "RDC typed-agent dispatch skill suite for Claude Code — plan, build, review, overnight builds",
   "keywords": [
     "claude-code",

package/scripts/install-rdc-skills.js

@@ -140,30 +140,53 @@ function buildPluginCache(cacheDir, version, gitSha) {
 // Claude Code loads that directory AND the plugin cache, so any rdc skills left
 // there produce duplicate registrations and break the resolver.
 // This function nukes any entry whose frontmatter name starts with "rdc:".
+// Scans BOTH the immediate dir and nested .md files (e.g. `user/skill.md`,
+// `user/rdc-build/SKILL.md`) so pre-plugin orphans are caught regardless of
+// naming convention.
 function cleanUserSkills(userSkillsDir) {
   if (!fs.existsSync(userSkillsDir)) return 0;
   let removed = 0;
   for (const entry of fs.readdirSync(userSkillsDir, { withFileTypes: true })) {
     const candidate = path.join(userSkillsDir, entry.name);
-    let skillFile = null;
     if (entry.isDirectory()) {
-      // New format: <name>/SKILL.md or <name>/skill.md
+      // Subdir form: <name>/SKILL.md or <name>/skill.md
+      let skillFile = null;
       for (const sf of ['SKILL.md', 'skill.md']) {
         const p = path.join(candidate, sf);
         if (fs.existsSync(p)) { skillFile = p; break; }
       }
-    } else if (entry.isFile() && entry.name.endsWith('.md') && entry.name !== 'skill.md' && entry.name !== 'SKILL.md' && entry.name !== 'README.md') {
-      // Old format: rdc-deploy.md flat file
-      skillFile = candidate;
+      if (!skillFile) continue;
+      const fm = readFrontmatter(skillFile);
+      if (fm.name && fm.name.startsWith('rdc:')) {
+        try { fs.rmSync(candidate, { recursive: true, force: true }); removed++; } catch {}
+      }
+    } else if (entry.isFile() && entry.name.endsWith('.md')) {
+      // ANY .md file at this level — including skill.md / SKILL.md / README.md
+      // if their frontmatter declares an rdc:* skill. A previous version skipped
+      // those names; that left an orphan rdc:build copy at user/skill.md which
+      // registered as a duplicate "user" skill.
+      const fm = readFrontmatter(candidate);
+      if (fm.name && fm.name.startsWith('rdc:')) {
+        try { fs.unlinkSync(candidate); removed++; } catch {}
+      }
     }
-    if (!skillFile) continue;
-    const fm = readFrontmatter(skillFile);
-    if (fm.name && fm.name.startsWith('rdc:')) {
-      try {
-        if (entry.isDirectory()) fs.rmSync(candidate, { recursive: true, force: true });
-        else fs.unlinkSync(candidate);
-        removed++;
-      } catch {}
+  }
+  return removed;
+}
+
+// Scrub legacy rdc orphans from ~/.claude/skills/ (top-level), not just user/.
+// Some older installs landed flat skill files alongside the plugin tree.
+function cleanGlobalSkillsRoot(skillsDir) {
+  if (!fs.existsSync(skillsDir)) return 0;
+  let removed = 0;
+  for (const entry of fs.readdirSync(skillsDir, { withFileTypes: true })) {
+    if (entry.name === 'user') continue; // handled separately
+    const candidate = path.join(skillsDir, entry.name);
+    if (entry.isFile() && entry.name.endsWith('.md')) {
+      const fm = readFrontmatter(candidate);
+      if (fm.name && fm.name.startsWith('rdc:')) {
+        try { fs.unlinkSync(candidate); removed++; } catch {}
+      }
     }
   }
   return removed;
@@ -192,11 +215,14 @@ function cleanStaleHooks(hooksDstDir) {
 }
 
 // ── Cache flush helper ────────────────────────────────────────────────────────
-function flushOldCaches(cacheBase, keepVersion) {
+// Only `latest/` is ever kept. Earlier versions wrote BOTH `<version>/` and
+// `latest/`, which caused the plugin loader to scan and register every rdc:*
+// skill twice (once per directory). The fix is permanent single-dir layout.
+function flushOldCaches(cacheBase /* keepVersion intentionally unused */) {
   if (!fs.existsSync(cacheBase)) return 0;
   let flushed = 0;
   for (const entry of fs.readdirSync(cacheBase)) {
-    if (entry === keepVersion || entry === 'latest') continue;
+    if (entry === 'latest') continue;
     try {
       fs.rmSync(path.join(cacheBase, entry), { recursive: true, force: true });
       flushed++;
@@ -211,7 +237,6 @@ function registerCLI(version, gitSha) {
   const mktDir     = path.join(pluginDir, 'marketplaces', MARKETPLACE);
   const mktPlugDir = path.join(mktDir, '.claude-plugin');
   const cacheBase  = path.join(pluginDir, 'cache', MARKETPLACE, 'rdc-skills');
-  const cacheDir   = path.join(cacheBase, version);
   const latestDir  = path.join(cacheBase, 'latest');
 
   // 1. Marketplace manifest
@@ -224,12 +249,11 @@ function registerCLI(version, gitSha) {
   knownMp[MARKETPLACE] = { source: { source: 'github', repo: 'LIFEAI/rdc-skills' }, installLocation: mktDir, lastUpdated: new Date().toISOString() };
   writeJson(kmpPath, knownMp, 4);
 
-  // 3. Flush stale version caches, then write versioned + stable latest
-  const flushed = flushOldCaches(cacheBase, version);
+  // 3. Flush every cache dir except `latest/`, then rewrite `latest/`. We
+  // intentionally do NOT keep a versioned dir — the plugin loader registers
+  // every dir it finds, so two dirs = duplicate skills.
+  const flushed = flushOldCaches(cacheBase);
   if (flushed > 0) info(`       flushed  : ${flushed} stale cache dir(s)`);
-  buildPluginCache(cacheDir, version, gitSha);
-  // Write to stable 'latest/' so open terminals can pick up changes if they
-  // re-read installed_plugins.json between skill invocations.
   if (fs.existsSync(latestDir)) fs.rmSync(latestDir, { recursive: true, force: true });
   buildPluginCache(latestDir, version, gitSha);
 
@@ -312,7 +336,6 @@ function registerCowork(version, gitSha) {
   for (const { dir, settingsFile } of bases) {
     const pluginsDir = path.join(dir, 'cowork_plugins');
     const cacheBase  = path.join(pluginsDir, 'cache', MARKETPLACE, 'rdc-skills');
-    const cacheDir   = path.join(cacheBase, version);
     const latestDir  = path.join(cacheBase, 'latest');
     const mktDir     = path.join(pluginsDir, 'marketplaces', MARKETPLACE);
     const mktPlugDir = path.join(mktDir, '.claude-plugin');
@@ -327,9 +350,8 @@ function registerCowork(version, gitSha) {
     knownMp[MARKETPLACE] = { source: { source: 'github', repo: 'LIFEAI/rdc-skills' }, installLocation: mktDir, lastUpdated: new Date().toISOString() };
     writeJson(kmpPath, knownMp, 4);
 
-    // Flush stale caches, write versioned + stable latest
-    flushOldCaches(cacheBase, version);
-    buildPluginCache(cacheDir, version, gitSha);
+    // Flush all non-latest caches and rewrite `latest/` only — single-dir layout
+    flushOldCaches(cacheBase);
     if (fs.existsSync(latestDir)) fs.rmSync(latestDir, { recursive: true, force: true });
     buildPluginCache(latestDir, version, gitSha);
 
@@ -622,6 +644,10 @@ async function main() {
     const userSkillsDir = path.join(claudeHome, 'skills', 'user');
     const purged = cleanUserSkills(userSkillsDir);
     if (purged > 0) ok(`[0.5a] Skills cleanup — removed ${purged} stale rdc: skill(s) from skills/user/`);
+    // Also scan the parent ~/.claude/skills/ for any flat-file rdc orphans.
+    const skillsRoot = path.join(claudeHome, 'skills');
+    const rootPurged = cleanGlobalSkillsRoot(skillsRoot);
+    if (rootPurged > 0) ok(`[0.5a] Skills cleanup — removed ${rootPurged} stale rdc: file(s) from skills/`);
   }
 
   // 0.5b. Stale hook cleanup — remove hooks we no longer ship
@@ -742,6 +768,53 @@ async function main() {
   console.log('  \x1b[36mPreflight:\x1b[0m');
   runPreflight();
 
+  // 6.5 Post-install verification — duplication guard
+  console.log('');
+  console.log('  \x1b[36mPost-install verification:\x1b[0m');
+  let verifyFailed = false;
+  {
+    const cacheBase = path.join(claudeHome, 'plugins', 'cache', MARKETPLACE, 'rdc-skills');
+    const cacheDirs = fs.existsSync(cacheBase) ? fs.readdirSync(cacheBase) : [];
+    if (cacheDirs.length === 1 && cacheDirs[0] === 'latest') {
+      ok(`plugin cache    : 1 dir (latest/)`);
+    } else {
+      fail(`plugin cache    : expected exactly [latest/], found [${cacheDirs.join(', ')}]`);
+      verifyFailed = true;
+    }
+    const ipPath    = path.join(claudeHome, 'plugins', 'installed_plugins.json');
+    const installed = readJson(ipPath, { plugins: {} });
+    const rdcEntries = installed.plugins[PLUGIN_KEY] || [];
+    if (rdcEntries.length === 1) {
+      ok(`installed_plugins: 1 entry for ${PLUGIN_KEY}`);
+    } else {
+      fail(`installed_plugins: expected 1 entry, found ${rdcEntries.length}`);
+      verifyFailed = true;
+    }
+    const userSkillsDir = path.join(claudeHome, 'skills', 'user');
+    const stillThere = fs.existsSync(userSkillsDir)
+      ? fs.readdirSync(userSkillsDir).filter(f => {
+          const p = path.join(userSkillsDir, f);
+          const skillFile = fs.statSync(p).isDirectory()
+            ? ['SKILL.md','skill.md'].map(s => path.join(p, s)).find(fs.existsSync)
+            : (f.endsWith('.md') ? p : null);
+          if (!skillFile) return false;
+          const fm = readFrontmatter(skillFile);
+          return fm.name && fm.name.startsWith('rdc:');
+        })
+      : [];
+    if (stillThere.length === 0) {
+      ok(`skills/user/    : no rdc: orphans`);
+    } else {
+      fail(`skills/user/    : still has rdc: orphans: ${stillThere.join(', ')}`);
+      verifyFailed = true;
+    }
+  }
+  if (verifyFailed) {
+    console.log('');
+    fail('Post-install verification FAILED — duplicates or orphans remain. Investigate.');
+    process.exit(2);
+  }
+
   // Done
   console.log('');
   console.log('  \x1b[32mDone!\x1b[0m');

package/skills/terminal-config/SKILL.md

@@ -0,0 +1,217 @@
+---
+name: terminal-config
+description: "Read and safely modify Windows Terminal settings and cell startup sequencing. Contains the canonical file locations, profile GUIDs, keybinding map, and what NEVER to change."
+---
+
+> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
+> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
+> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
+
+# terminal-config — Windows Terminal & Cell Startup Reference
+
+## When to Use
+- Before modifying any terminal setting, profile, or keybinding
+- When setting up a new profile (Claude, Codex, cell cells)
+- When cell startup is broken (wrong `--append-system-prompt`, wrong cwd, wrong CELL_ROLE)
+- When keybindings conflict or are missing
+
+## ⛔ ABSOLUTE RULES — READ BEFORE TOUCHING ANYTHING
+
+1. **NEVER change profile GUIDs** — Windows Terminal uses these as identity. Changing a GUID orphans all pinned shortcuts and window layouts.
+2. **NEVER remove `"id": null` keybinding entries** — these intentionally UNBIND enter/shift-enter/ctrl-enter so Claude Code's interactive prompt works without the terminal swallowing keystrokes.
+3. **NEVER change `firstWindowPreference`** — it's `persistedWindowLayout`, which restores Dave's exact pane/tab layout on restart.
+4. **NEVER change `defaultProfile`** — it's `{574e775e-...}` (PowerShell Core). Changing it breaks new-tab behavior.
+5. **ALWAYS read the file before editing** — never write from memory.
+6. **ALWAYS validate JSON** before saving — a syntax error silently resets all settings on next Terminal launch (no error shown, settings wiped).
+
+---
+
+## File Locations
+
+| File | Path | Purpose |
+|------|------|---------|
+| **Terminal settings** | `C:\Users\DaveLadouceur\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json` | Main config — profiles, keybindings, color schemes |
+| **Cell init script** | `C:\Dev\regen-root\scripts\cell-init.cmd` | Launched by each cell profile. Sets CELL_ROLE, prints banner, runs `claude --append-system-prompt` |
+| **Cell state dir** | `C:\Dev\regen-root\.cell-state\` | PID lockfiles per cell (`sv.lock`, `cell-portal.lock`, etc.) |
+| **Claude keybindings** | `C:\Users\DaveLadouceur\.claude\keybindings.json` | Claude Code keybindings (separate from Terminal) |
+| **Claude settings** | `C:\Dev\regen-root\.claude\settings.json` | Project-level Claude Code settings, hooks, permissions |
+| **Claude user settings** | `C:\Users\DaveLadouceur\.claude\settings.json` | User-level Claude Code settings |
+
+---
+
+## Profile Inventory
+
+Every profile has a fixed GUID. Do not change them.
+
+| GUID | Name | Tab Color | Purpose |
+|------|------|-----------|---------|
+| `{574e775e-4f2a-5b96-ac1e-a2962a402336}` | PowerShell | — | **Default profile** — PowerShell 7 Core |
+| `{e7c1128b-e51f-4eba-bcdb-85f550c31b97}` | SV | `#1A6B3C` (green) | Supervisor cell — full repo access, runs `cell-init.cmd sv` |
+| `{190a2f39-f6ad-4638-8fef-e4c7aa58c349}` | Claude | `#B91C1C` (red) | Claude conversation cell, runs `cell-init.cmd sv` |
+| `{2d0248ef-7bb7-4b9e-b381-c4aa1f570f49}` | Codex | `#0F766E` (teal) | Codex AI cell — runs `powershell -NoLogo -NoExit -Command codex` |
+| `{767642b0-606c-468c-89a0-4573df6fcdaf}` | VS Code | `#2D5986` (blue) | Launches `code-safe C:\Dev\regen-root` |
+| `{6cbd327a-5b5e-4e83-96f6-041615382d36}` | PowerShell (Admin) | `#1E3A5F` (dark blue) | Elevated PowerShell — uses `LIFEAI Slate` color scheme |
+| `{0caa0dad-35be-5f56-a8ff-afceeeaa6101}` | Command Prompt | — | Legacy CMD — visible but rarely used |
+| `{574e775e...}` and others | `hidden: true` | — | Windows PowerShell, Azure Shell, VS DevTools — all hidden |
+
+### Profile commandlines
+
+```
+SV / Claude:   cmd.exe /k "C:\Dev\regen-root\scripts\cell-init.cmd" sv
+Codex:         powershell.exe -NoLogo -NoExit -Command codex
+VS Code:       cmd.exe /c start "" code-safe C:\Dev\regen-root
+Admin PS:      powershell.exe -NoLogo   (+ elevate: true)
+```
+
+All cell profiles set `"startingDirectory": "C:\\Dev\\regen-root"`.
+
+---
+
+## Keybinding Map
+
+### Critical: intentionally unbound keys (never restore these)
+
+```json
+{ "id": null, "keys": "shift+enter" }
+{ "id": null, "keys": "ctrl+enter" }
+{ "id": null, "keys": "enter" }
+```
+
+**Why:** Without these null bindings, Windows Terminal intercepts Enter/Shift-Enter/Ctrl-Enter before Claude Code's interactive prompt sees them. Sessions break silently.
+
+### Pane navigation (safe to change)
+
+| Keys | Action |
+|------|--------|
+| `ctrl+alt+v` | Split pane right (duplicate) |
+| `ctrl+alt+h` | Split pane down (duplicate) |
+| `ctrl+alt+left/right/up/down` | Move focus between panes |
+| `ctrl+alt+shift+left/right` | Resize pane |
+| `ctrl+shift+z` | Toggle pane zoom |
+| `ctrl+shift+w` | Close pane |
+| `alt+shift+d` | Split pane auto (duplicate) |
+
+### Standard overrides
+
+| Keys | Action |
+|------|--------|
+| `ctrl+c` | Copy (singleLine: false) |
+| `ctrl+v` | Paste |
+| `ctrl+shift+f` | Find |
+
+---
+
+## Color Schemes
+
+Four custom schemes live in the `schemes` array. Do not rename them — profiles reference by name.
+
+| Name | Background | Used by |
+|------|-----------|---------|
+| `Dimidium` | `#282A36` (dark purple) | Default for all cell profiles |
+| `LIFEAI Claude` | `#1A0F0A` (dark brown) | Available, not currently assigned |
+| `LIFEAI Dark` | `#0D1F17` (dark green) | Available, not currently assigned |
+| `LIFEAI Slate` | `#0F1923` (dark blue) | PowerShell Admin profile |
+| `Dracula` | `#282A36` | Available, not currently assigned |
+
+---
+
+## Global Settings (safe reference)
+
+```json
+"copyOnSelect": true          // highlight = copied. Don't change — muscle memory.
+"copyFormatting": "all"       // preserves ANSI colors on copy
+"firstWindowPreference": "persistedWindowLayout"  // restores last layout on open. NEVER CHANGE.
+"defaultProfile": "{574e775e-4f2a-5b96-ac1e-a2962a402336}"  // PowerShell Core. NEVER CHANGE.
+"theme": "dark"
+"showTabsFullscreen": true
+"initialRows": 40
+```
+
+Font defaults (in `profiles.defaults`):
+```json
+"face": "Consolas"
+"size": 12
+"cellHeight": "1.2"
+"cellWidth": "0.6"
+"weight": "normal"
+```
+
+---
+
+## Cell Startup Sequencing
+
+`cell-init.cmd` is the startup script for all cell profiles. It:
+
+1. Accepts `ROLE` arg (`sv`, `cell-portal`, `cell-data`, `cell-cs2`, `cell-mktg`, `cell-infra`, `specialist`)
+2. Looks up `LABEL`, `COLOR`, `SCOPE`, `PATHS`, `PROMPT_SCOPE` from a role table
+3. Prints a colored banner
+4. Writes a PID lockfile to `.cell-state\<role>.lock`
+5. Runs `git log` filtered to that cell's path scope
+6. Opens VS Code for the project
+7. Launches: `claude --append-system-prompt "<PROMPT_SCOPE>"`
+
+### Cell role → prompt scope mapping
+
+| Role arg | Claude system prompt |
+|----------|---------------------|
+| `sv` | "You are the SUPERVISOR cell. You have full repo access. Coordinate across all packages and apps." |
+| `cell-portal` | Portal cell — frontend apps only (apps/prt, apps/rdc, packages/ui, models/) |
+| `cell-data` | Data cell — packages/supabase, virtue-engine, pal, hail, daf-intelligence |
+| `cell-cs2` | CS2 cell — packages/cs2, quad-pixel, planetary-ontology, models/ |
+| `cell-mktg` | Marketing cell — rdc-marketing-engine, canvas, sites/, email-templates |
+| `cell-infra` | Infra cell — Coolify, CI/CD, root config, scripts/ |
+| `specialist` | Specialist cell — repo-wide reviews, cleanup, docs, audits |
+
+---
+
+## Safe Edit Procedure
+
+### When adding or modifying a profile
+
+1. Read the current file first (never edit from memory)
+2. Generate a new GUID with: `[System.Guid]::NewGuid().ToString('B')` (PowerShell) — wrap in `{}`
+3. Copy the SV profile as a template
+4. Set `commandline`, `startingDirectory`, `environment`, `tabColor`, `icon`, `name`
+5. Do NOT set `guid` to an existing value
+6. Validate JSON: `Get-Content settings.json | ConvertFrom-Json` (errors = syntax problem)
+7. Save and reopen Terminal to verify
+
+### When adding a keybinding
+
+1. Add to the `keybindings` array
+2. Check for conflicts with the null-bound keys (`enter`, `shift+enter`, `ctrl+enter`) — NEVER override them
+3. Validate JSON before saving
+
+### When editing cell startup
+
+Edit `C:\Dev\regen-root\scripts\cell-init.cmd` — it's in the repo, so changes are tracked.
+- Adding a new role: add a new `if "%ROLE%"=="..."` block with all five vars
+- Changing scope: update `PATHS` and `PROMPT_SCOPE` only — don't touch banner/lockfile/git logic
+
+---
+
+## Validation Commands
+
+```powershell
+# Validate JSON syntax before saving
+Get-Content "$env:LOCALAPPDATA\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json" | ConvertFrom-Json
+
+# Check cell lockfiles
+Get-Content C:\Dev\regen-root\.cell-state\sv.lock
+
+# Generate a new GUID for a profile
+"{$([System.Guid]::NewGuid().ToString())}"
+```
+
+---
+
+## WezTerm Alternative
+
+If Windows Terminal settings keep getting corrupted or misedited, **WezTerm** is the recommended migration:
+- Config is a Lua file (`~/.wezterm.lua` or `C:\Users\<user>\.config\wezterm\wezterm.lua`)
+- Committed to git — every change is a reviewable diff, not an opaque JSON blob
+- Startup layouts (tabs, panes, commands) are defined programmatically
+- Equivalent to current setup: `wezterm.mux.spawn_window()` per cell with `args` set to `cmd.exe /k cell-init.cmd <role>`
+- Download: https://wezfurlong.org/wezterm/installation.html
+
+Migration path: copy existing color schemes as `wezterm.color.get_default_colors()` override tables, map keybindings to `config.keys` array, define tab bar with cell roles.