@lifeaitools/rdc-skills 0.35.9 → 0.35.12

package/tests/completion-gate-supervisor-admission.test.mjs

@@ -8,11 +8,12 @@ const served = (name) => {
   return body;
 };
 
-test('live rdc_skill_get planning body creates executable work through the durable admission contract', () => {
+test('live rdc_skill_get planning body makes Design Review explicit opt-in', () => {
   const plan = served('rdc:plan');
   assert.match(plan, /upsert_admitted_work_item/);
-  assert.match(plan, /Design Review contract/);
-  assert.match(plan, /needs_human/);
+  assert.match(plan, /p_design_review := NULL/);
+  assert.match(plan, /Dave explicitly requests Design Review/);
+  assert.match(plan, /ordinary work reaches `rdc:review`/);
   assert.doesNotMatch(plan, /One task per work package via `insert_work_item/);
 });
 

package/tests/install-rdc-skills.test.mjs

@@ -60,15 +60,33 @@ assert.equal(
   realSkillDirs.length,
   `plugin.json skills_meta (${skillCount}) must match the actual skill directories on disk (${realSkillDirs.length}): ${realSkillDirs.join(', ')}`,
 );
+// The listing must report EVERY /rdc:* verb, and say which surface each comes
+// from. It used to enumerate commands/ only, which was harmless while every verb
+// shipped as both a command and a skill — and became actively misleading the
+// moment the duplicates were removed (2026-08-29): the printed surface fell from
+// 32 to 13 while the real surface was unchanged, because a skill provides the
+// slash form on its own (verified live: commands/status.md deleted, rdc:status
+// still resolved). A listing that under-reports by 43 verbs reads as "those
+// commands are gone".
 assert.match(
   source,
-  /Available MCP skills.*\/rdc:\* command shorthands/,
-  'installer should distinguish the full MCP skill catalog from slash-command shorthands',
+  /Available \/rdc:\* verbs/,
+  'installer should list every /rdc:* verb, not only the command-backed ones',
 );
 assert.match(
   source,
-  /Object\.keys\(plugin\.skills_meta\)\.length/,
-  'installer should count object-shaped skills_meta manifests',
+  /command, \$\{[^}]*\} skill/,
+  'installer should say how many verbs come from commands and how many from skills',
+);
+assert.match(
+  source,
+  /readdirSync\(skillDir, \{ withFileTypes: true \}\)/,
+  'installer should enumerate the real skill directories, not a manifest count that can drift from disk',
+);
+assert.match(
+  source,
+  /SKILL\.md'\)\)\) continue/,
+  'installer must skip a directory with no SKILL.md — tests/ is a fixture dir, not a skill',
 );
 assert.match(
   source,