@lifeaitools/rdc-skills 0.35.21 → 0.35.23

package/guides/agents/verify.md

@@ -1,38 +1,38 @@
-> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
-> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
-> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
-
-
-# rdc:verify — Verification Before Completion
-
-> Adapted from obra/superpowers `verification-before-completion`.
-> Stack-specific: uses `npx vitest run` + `npx tsc --noEmit`. NEVER `pnpm build` (crashes machine — 800MB/process).
-
-## The Iron Law
-
-**NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**
-
-You may not say "done", "complete", "working", "fixed", "passing", or imply success until you have:
-
-1. **Identified** the exact commands that prove the claim
-2. **Run** those commands fresh in the current state (not memory, not "earlier", not "should")
-3. **Read** the full output
-4. **Verified** the output matches the claim
-5. Only THEN made the claim, quoting the evidence
-
-If you cannot run the commands, say so explicitly. Do not substitute reasoning for evidence.
-
-## Red Flags — Stop and Verify
-
-If you're about to write any of these, STOP:
-
-- "should work" / "should pass" / "should be fine"
-- "probably" / "seems to" / "looks good"
-- "I think the tests pass"
-- "the types check out" (without running tsc)
-- "everything compiles" (without fresh output)
-- Expressing satisfaction or wrapping up before the gate ran
-
+> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
+> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
+> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
+
+
+# rdc:verify — Verification Before Completion
+
+> Adapted from obra/superpowers `verification-before-completion`.
+> Stack-specific: uses `npx vitest run` + `npx tsc --noEmit`. NEVER `pnpm build` (crashes machine — 800MB/process).
+
+## The Iron Law
+
+**NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**
+
+You may not say "done", "complete", "working", "fixed", "passing", or imply success until you have:
+
+1. **Identified** the exact commands that prove the claim
+2. **Run** those commands fresh in the current state (not memory, not "earlier", not "should")
+3. **Read** the full output
+4. **Verified** the output matches the claim
+5. Only THEN made the claim, quoting the evidence
+
+If you cannot run the commands, say so explicitly. Do not substitute reasoning for evidence.
+
+## Red Flags — Stop and Verify
+
+If you're about to write any of these, STOP:
+
+- "should work" / "should pass" / "should be fine"
+- "probably" / "seems to" / "looks good"
+- "I think the tests pass"
+- "the types check out" (without running tsc)
+- "everything compiles" (without fresh output)
+- Expressing satisfaction or wrapping up before the gate ran
+
 ## The Gate — Commands for This Stack
 
 Run these in order. All must pass. Capture output.
@@ -55,97 +55,97 @@ Required work item evidence:
 If this check fails, stop validation for that item and reopen it. Do not mark a work item `done` when the checklist itself is not decomposed enough to prove completion.
 
 ### 1. Per-package vitest (every package touched)
-
-```bash
-cd <repo-root>
-for pkg in <changed-packages>; do
-  npx vitest run --dir packages/$pkg 2>&1 | tee /tmp/verify-$pkg.log
-done
-```
-
-Or for a single package:
-```bash
-npx vitest run --dir packages/<pkg>
-npx vitest run --dir apps/<app>
-```
-
-**NEVER** run `pnpm build` or `pnpm test` at the repo root — spawns 5-7 node processes at 800MB each and crashes the machine.
-
-### 2. Typecheck per package
-
-```bash
-npx tsc --noEmit --project packages/<pkg>/tsconfig.json
-npx tsc --noEmit --project apps/<app>/tsconfig.json
-```
-
-One package at a time. Read the full output — zero errors required.
-
-### 3. Lint (if configured for the package)
-
-```bash
-npx eslint <paths> --max-warnings=0
-```
-
-### 4. Smoke check exports (if package adds public API)
-
-```bash
-node -e "const m = require('<pkg>'); console.log(Object.keys(m));"
-```
-
-Or for ESM:
-```bash
-node --input-type=module -e "import * as m from '<pkg>'; console.log(Object.keys(m));"
-```
-
-## Rationalization Prevention
-
-| You're tempted to think... | Reality |
-|---|---|
-| "Tests passed earlier, should still pass" | Run them now. Code changed. |
-| "TypeScript is strict, if it built it works" | You didn't build. Run tsc. |
-| "Small change, no need to retest" | Small changes are where regressions hide. |
-| "I'll note it as pending verification" | No. Verify now or mark incomplete. |
-| "The test file looks right" | Reading ≠ running. Run it. |
-
-## Output Format — Required
-
-When reporting completion, use this structure:
-
-```
-## Verification Evidence
-
-### vitest
-$ npx vitest run --dir packages/hail
- Test Files  12 passed (12)
-      Tests  147 passed (147)
-
-### tsc
-$ npx tsc --noEmit --project packages/hail/tsconfig.json
-(no output — clean)
-
+
+```bash
+cd <repo-root>
+for pkg in <changed-packages>; do
+  npx vitest run --dir packages/$pkg 2>&1 | tee /tmp/verify-$pkg.log
+done
+```
+
+Or for a single package:
+```bash
+npx vitest run --dir packages/<pkg>
+npx vitest run --dir apps/<app>
+```
+
+**NEVER** run `pnpm build` or `pnpm test` at the repo root — spawns 5-7 node processes at 800MB each and crashes the machine.
+
+### 2. Typecheck per package
+
+```bash
+npx tsc --noEmit --project packages/<pkg>/tsconfig.json
+npx tsc --noEmit --project apps/<app>/tsconfig.json
+```
+
+One package at a time. Read the full output — zero errors required.
+
+### 3. Lint (if configured for the package)
+
+```bash
+npx eslint <paths> --max-warnings=0
+```
+
+### 4. Smoke check exports (if package adds public API)
+
+```bash
+node -e "const m = require('<pkg>'); console.log(Object.keys(m));"
+```
+
+Or for ESM:
+```bash
+node --input-type=module -e "import * as m from '<pkg>'; console.log(Object.keys(m));"
+```
+
+## Rationalization Prevention
+
+| You're tempted to think... | Reality |
+|---|---|
+| "Tests passed earlier, should still pass" | Run them now. Code changed. |
+| "TypeScript is strict, if it built it works" | You didn't build. Run tsc. |
+| "Small change, no need to retest" | Small changes are where regressions hide. |
+| "I'll note it as pending verification" | No. Verify now or mark incomplete. |
+| "The test file looks right" | Reading ≠ running. Run it. |
+
+## Output Format — Required
+
+When reporting completion, use this structure:
+
+```
+## Verification Evidence
+
+### vitest
+$ npx vitest run --dir packages/hail
+ Test Files  12 passed (12)
+      Tests  147 passed (147)
+
+### tsc
+$ npx tsc --noEmit --project packages/hail/tsconfig.json
+(no output — clean)
+
 ### Status
 Checklist quality: PASS
 PASS — safe to mark tasks done.
 ```
 
 If any step fails: do NOT claim completion. Report the failure, fix it, re-run the entire gate.
-
-## When to Invoke
-
-- **End of `/rdc:build`** — mandatory final phase before marking epic done
-- **During `/rdc:review`** — verification gate after fixes applied
-- **Before any "done" declaration** — if an agent or supervisor is about to say work is complete
-- **After merging waves** — when parallel agents finish and their work is combined
-
-## Agent Delegation
-
-When dispatching a verification agent, give them:
-- Exact list of packages/apps to verify
+
+## When to Invoke
+
+- **End of `/rdc:build`** — mandatory final phase before marking epic done
+- **During `/rdc:review`** — verification gate after fixes applied
+- **Before any "done" declaration** — if an agent or supervisor is about to say work is complete
+- **After merging waves** — when parallel agents finish and their work is combined
+
+## Agent Delegation
+
+When dispatching a verification agent, give them:
+- Exact list of packages/apps to verify
 - Explicit ban on `pnpm build` / `pnpm test` / `pnpm -r`
 - Work item checklists and the matching plan doc so `decomp-*` quality can be verified first
 - Required output format (above)
 - Instruction: "If any command fails, STOP and report. Do not fix. Do not continue."
-
-## The Bottom Line
-
-Evidence before claims. Fresh evidence, not remembered evidence. Full output, not selective reading. If you skip the gate, you are lying about the work being done.
+
+## The Bottom Line
+
+Evidence before claims. Fresh evidence, not remembered evidence. Full output, not selective reading. If you skip the gate, you are lying about the work being done.

package/guides/agents/viz.md

@@ -1,106 +1,106 @@
-> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
-> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
-> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
-
-> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
-
-
-# rdc:viz — Visualization Agent
-
-## Mandatory First Steps
-
-Read BOTH guides before ANY code:
-```
-{PROJECT_ROOT}/.rdc/guides/frontend.md (fallback: {PROJECT_ROOT}/.rdc/guides/frontend.md)
-{PROJECT_ROOT}/.rdc/guides/design.md (fallback: {PROJECT_ROOT}/.rdc/guides/design.md)
-```
-
-## Before Writing Any Code
-
-1. **Check for existing prototypes:**
-   ```sql
-   SELECT name, component, source_path, status, notes
-   FROM prototype_registry
-   WHERE status IN ('prototype', 'converting')
-   ORDER BY created_at DESC;
-   ```
-   Source path is usually `docs/source/`. **Read it first.**
-
-2. **Check design decisions:**
-   ```sql
-   SELECT topic, summary FROM design_context
-   WHERE topic ILIKE '%<viz-name>%';
-   ```
-
-## SVG Layout Patterns
-
-When building new SVG-based viz:
-- Define all layout constants at top (`W`, `H`, column x-centers, box dimensions)
-- Build path builders as pure functions
-- Separate data from rendering
-- Use `viewBox` for responsive scaling
-- Animate with appropriate motion libraries
-
-```tsx
-const W = 980, H = 570;
-const COL_A = 80, COL_B = 240, COL_C = 435;
-
-function pathTo(x1: number, y1: number, x2: number, y2: number): string {
-  const mx = (x1 + x2) / 2;
-  return `M ${x1} ${y1} C ${mx} ${y1} ${mx} ${y2} ${x2} ${y2}`;
-}
-```
-
-## Viz Component Contract
-
-```tsx
-"use client";
-import * as React from "react";
-import { cva, type VariantProps } from "class-variance-authority";
-import { cn } from "../lib/utils";
-
-// CVA variants required on every new viz component
-const myVizVariants = cva("relative w-full", {
-  variants: {
-    layout: { single: "", double: "flex flex-col", grid: "" },
-    density: { compact: "", comfortable: "", spacious: "" },
-  },
-  defaultVariants: { layout: "single", density: "comfortable" },
-});
-
-interface MyVizProps
-  extends React.HTMLAttributes<HTMLDivElement>,
-    VariantProps<typeof myVizVariants> {}
-
-const MyViz = React.forwardRef<HTMLDivElement, MyVizProps>(
-  ({ className, layout, density, ...props }, ref) => (
-    <div ref={ref} className={cn(myVizVariants({ layout, density }), className)} {...props} />
-  )
-);
-MyViz.displayName = "MyViz";
-export { MyViz, myVizVariants };
-```
-
-Export from package's index after building.
-
-## Registering New Viz Components
-
-After completing:
-```sql
-INSERT INTO prototype_registry (name, component, source_path, notes, created_by)
-VALUES (
-  'MyViz v1.0',
-  'MyViz',
-  'packages/ui/src/components/my-viz.tsx',
-  'Production component. Props: <list key props>',
-  'agent'
-);
-```
-
-## Safety Rules
-
-- Branch: development branch — auto-commit
-- NEVER run `pnpm build`
-- Reduce motion: always wrap animations with appropriate hooks
-- NEVER overlap with other agents on the same component file
-- Write tests FIRST — red → implement → green
+> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
+> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
+> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
+
+> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
+
+
+# rdc:viz — Visualization Agent
+
+## Mandatory First Steps
+
+Read BOTH guides before ANY code:
+```
+{PROJECT_ROOT}/.rdc/guides/frontend.md (fallback: {PROJECT_ROOT}/.rdc/guides/frontend.md)
+{PROJECT_ROOT}/.rdc/guides/design.md (fallback: {PROJECT_ROOT}/.rdc/guides/design.md)
+```
+
+## Before Writing Any Code
+
+1. **Check for existing prototypes:**
+   ```sql
+   SELECT name, component, source_path, status, notes
+   FROM prototype_registry
+   WHERE status IN ('prototype', 'converting')
+   ORDER BY created_at DESC;
+   ```
+   Source path is usually `docs/source/`. **Read it first.**
+
+2. **Check design decisions:**
+   ```sql
+   SELECT topic, summary FROM design_context
+   WHERE topic ILIKE '%<viz-name>%';
+   ```
+
+## SVG Layout Patterns
+
+When building new SVG-based viz:
+- Define all layout constants at top (`W`, `H`, column x-centers, box dimensions)
+- Build path builders as pure functions
+- Separate data from rendering
+- Use `viewBox` for responsive scaling
+- Animate with appropriate motion libraries
+
+```tsx
+const W = 980, H = 570;
+const COL_A = 80, COL_B = 240, COL_C = 435;
+
+function pathTo(x1: number, y1: number, x2: number, y2: number): string {
+  const mx = (x1 + x2) / 2;
+  return `M ${x1} ${y1} C ${mx} ${y1} ${mx} ${y2} ${x2} ${y2}`;
+}
+```
+
+## Viz Component Contract
+
+```tsx
+"use client";
+import * as React from "react";
+import { cva, type VariantProps } from "class-variance-authority";
+import { cn } from "../lib/utils";
+
+// CVA variants required on every new viz component
+const myVizVariants = cva("relative w-full", {
+  variants: {
+    layout: { single: "", double: "flex flex-col", grid: "" },
+    density: { compact: "", comfortable: "", spacious: "" },
+  },
+  defaultVariants: { layout: "single", density: "comfortable" },
+});
+
+interface MyVizProps
+  extends React.HTMLAttributes<HTMLDivElement>,
+    VariantProps<typeof myVizVariants> {}
+
+const MyViz = React.forwardRef<HTMLDivElement, MyVizProps>(
+  ({ className, layout, density, ...props }, ref) => (
+    <div ref={ref} className={cn(myVizVariants({ layout, density }), className)} {...props} />
+  )
+);
+MyViz.displayName = "MyViz";
+export { MyViz, myVizVariants };
+```
+
+Export from package's index after building.
+
+## Registering New Viz Components
+
+After completing:
+```sql
+INSERT INTO prototype_registry (name, component, source_path, notes, created_by)
+VALUES (
+  'MyViz v1.0',
+  'MyViz',
+  'packages/ui/src/components/my-viz.tsx',
+  'Production component. Props: <list key props>',
+  'agent'
+);
+```
+
+## Safety Rules
+
+- Branch: development branch — auto-commit
+- NEVER run `pnpm build`
+- Reduce motion: always wrap animations with appropriate hooks
+- NEVER overlap with other agents on the same component file
+- Write tests FIRST — red → implement → green

package/guides/orchestration-epic.md

@@ -1,17 +1,17 @@
-# Orchestration Epic Guide
-
-An orchestration epic governs a repeatable build, test, or delivery workflow
-rather than one feature. It must define:
-
-1. Exact trigger surfaces and deterministic scope classification.
-2. The isolated environment model and live-system boundaries.
-3. Happy, repair, rollback, and block paths.
-4. A suite matrix with machine-checkable evidence.
-5. Bounded repair attempts and semantic escalation.
-6. Definition-of-Done, exit gates, and a durable receipt schema.
-7. The hook, skill, validator, commit gate, or deployment gate that prevents bypass.
-8. How RDC planning, build, refactor, review, and validators discover it.
-
-At minimum, prove trigger clarity, worker isolation, subsystem coverage,
-bounded repair, evidence-preserving block behavior, durable receipts, active
-enforcement, and closure with no pending required work.
+# Orchestration Epic Guide
+
+An orchestration epic governs a repeatable build, test, or delivery workflow
+rather than one feature. It must define:
+
+1. Exact trigger surfaces and deterministic scope classification.
+2. The isolated environment model and live-system boundaries.
+3. Happy, repair, rollback, and block paths.
+4. A suite matrix with machine-checkable evidence.
+5. Bounded repair attempts and semantic escalation.
+6. Definition-of-Done, exit gates, and a durable receipt schema.
+7. The hook, skill, validator, commit gate, or deployment gate that prevents bypass.
+8. How RDC planning, build, refactor, review, and validators discover it.
+
+At minimum, prove trigger clarity, worker isolation, subsystem coverage,
+bounded repair, evidence-preserving block behavior, durable receipts, active
+enforcement, and closure with no pending required work.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lifeaitools/rdc-skills",
-  "version": "0.35.21",
+  "version": "0.35.23",
   "description": "RDC typed-agent dispatch skill suite for Claude Code - plan, build, review, overnight builds",
   "keywords": [
     "claude-code",

package/scripts/lib/runner.mjs

@@ -70,7 +70,7 @@ function filesModifiedSince(cwd, baseSha) {
   const tracked = gitIn(cwd, ["diff", "--name-only", `${baseSha}..HEAD`]);
   const untracked = gitIn(cwd, ["ls-files", "--others", "--exclude-standard"]);
   const set = new Set();
-  for (const line of (tracked + "\n" + untracked).split(/\r?\n/)) {
+  for (const line of `${tracked}\n${untracked}`.split(/\r?\n/)) {
     const p = line.trim();
     if (p) set.add(p.replace(/\\/g, "/"));
   }
@@ -87,7 +87,17 @@ function writePreconditionFiles(worktreePath, files) {
   }
 }
 
-function spawnHiddenShell(command, args, { cwd, env, timeoutMs }) {
+// Exported so other callers that need the same Windows-safe spawn+quote+timeout
+// behavior (e.g. scripts/rdc-design-compare-cli.mjs dispatching a design brief to
+// both engines) reuse this instead of reimplementing argv quoting. See
+// agent-bootstrap.md §Reuse Existing Subsystem APIs.
+//
+// `stdin`, when provided, is written to the child's stdin and the pipe is then
+// closed — this is how a large prompt (bigger than Windows' ~8191-char command
+// line limit) gets to the child without going through argv at all. When
+// `stdin` is omitted, the child's stdin is closed immediately (`"ignore"`),
+// preserving the exact prior behavior for existing callers (spawnClaude/spawnCodex).
+export function spawnHiddenShell(command, args, { cwd, env, timeoutMs, stdin }) {
   return new Promise((resolve) => {
     let settled = false;
     let stdout = "";
@@ -99,11 +109,16 @@ function spawnHiddenShell(command, args, { cwd, env, timeoutMs }) {
       // which is harmless here. Quote each arg so the shell preserves prompts
       // with spaces/metacharacters as single argv tokens.
       const safeArgs = args.map((arg) => JSON.stringify(String(arg)));
-      child = spawn(command, safeArgs, { cwd, env, shell: true, windowsHide: true, stdio: ["ignore", "pipe", "pipe"] });
+      const stdioIn = typeof stdin === "string" ? "pipe" : "ignore";
+      child = spawn(command, safeArgs, { cwd, env, shell: true, windowsHide: true, stdio: [stdioIn, "pipe", "pipe"] });
     } catch (e) {
       resolve({ exit: -1, stdout: "", stderr: `spawn failed: ${e.message}`, timedOut: false });
       return;
     }
+    if (typeof stdin === "string") {
+      child.stdin.on("error", () => {}); // EPIPE if the child exits before we finish writing
+      child.stdin.end(stdin);
+    }
     const timer = setTimeout(() => {
       if (settled) return;
       try { child.kill("SIGKILL"); } catch {}
@@ -116,7 +131,7 @@ function spawnHiddenShell(command, args, { cwd, env, timeoutMs }) {
       if (settled) return;
       clearTimeout(timer);
       settled = true;
-      resolve({ exit: -1, stdout, stderr: stderr + `\nspawn error: ${e.message}`, timedOut: false });
+      resolve({ exit: -1, stdout, stderr: `${stderr}\nspawn error: ${e.message}`, timedOut: false });
     });
     child.on("close", (code) => {
       if (settled) return;
@@ -172,7 +187,7 @@ export function parseContentRange(header) {
   const m = header.match(/\/(\d+|\*)\s*$/);
   if (!m) return 0;
   if (m[1] === "*") return 0;
-  const n = parseInt(m[1], 10);
+  const n = Number.parseInt(m[1], 10);
   return Number.isFinite(n) ? n : 0;
 }