@lifeaitools/rdc-skills 0.25.5 → 0.25.10
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/plugin.json +1550 -1550
- package/.github/workflows/self-test.yml +34 -34
- package/CHANGELOG.md +319 -319
- package/MANIFEST.md +224 -224
- package/README.md +367 -367
- package/commands/build.md +181 -181
- package/commands/collab.md +180 -180
- package/commands/deploy.md +148 -148
- package/commands/fixit.md +150 -150
- package/commands/handoff.md +173 -173
- package/commands/overnight.md +220 -220
- package/commands/plan.md +158 -158
- package/commands/preplan.md +131 -131
- package/commands/prototype.md +145 -145
- package/commands/report.md +99 -99
- package/commands/review.md +120 -120
- package/commands/status.md +86 -86
- package/commands/workitems.md +127 -127
- package/git-sha.json +1 -1
- package/guides/agent-bootstrap.md +195 -195
- package/guides/agents/backend.md +102 -102
- package/guides/agents/content.md +94 -94
- package/guides/agents/cs2.md +56 -56
- package/guides/agents/data.md +86 -86
- package/guides/agents/design.md +77 -77
- package/guides/agents/frontend.md +91 -91
- package/guides/agents/infrastructure.md +81 -81
- package/guides/agents/setup.md +272 -272
- package/guides/agents/verify.md +119 -119
- package/guides/agents/viz.md +106 -106
- package/hooks/check-rdc-environment.js +378 -164
- package/hooks/lib/box-lock.js +207 -0
- package/package.json +1 -1
- package/scripts/install-rdc-skills.js +97 -8
- package/scripts/local-install-with-stop.sh +41 -0
- package/scripts/probe-box-lock.mjs +179 -0
- package/scripts/probe-installed-hooks.mjs +60 -0
- package/scripts/probe-lock-holders.mjs +36 -0
- package/scripts/self-test.mjs +1459 -1459
- package/scripts/validate-publish-manifests.js +502 -502
- package/skills/build/SKILL.md +578 -578
- package/skills/channel-formatter/SKILL.md +538 -538
- package/skills/collab/SKILL.md +239 -239
- package/skills/convert/SKILL.md +138 -138
- package/skills/deploy/SKILL.md +541 -541
- package/skills/design/SKILL.md +205 -205
- package/skills/env/SKILL.md +139 -139
- package/skills/fixit/SKILL.md +203 -203
- package/skills/handoff/SKILL.md +236 -236
- package/skills/housekeeping/SKILL.md +189 -189
- package/skills/onramp/SKILL.md +1459 -1459
- package/skills/overnight/SKILL.md +251 -251
- package/skills/plan/SKILL.md +345 -345
- package/skills/preplan/SKILL.md +90 -90
- package/skills/prototype/SKILL.md +150 -150
- package/skills/regen-media/SKILL.md +94 -94
- package/skills/release/SKILL.md +140 -140
- package/skills/report/SKILL.md +100 -100
- package/skills/review/SKILL.md +151 -151
- package/skills/self-test/SKILL.md +108 -108
- package/skills/status/SKILL.md +99 -99
- package/skills/tests/MATRIX.md +55 -55
- package/skills/tests/onramp.test.json +87 -87
- package/skills/tests/rdc-regen-media.test.json +29 -29
- package/skills/watch/SKILL.md +84 -84
- package/skills/workitems/SKILL.md +151 -151
package/skills/report/SKILL.md
CHANGED
|
@@ -1,100 +1,100 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: rdc:report
|
|
3
|
-
description: "Usage `rdc:report` — Write the nightly session summary to .rdc/reports/YYYY-MM-DD.md covering completed work, open items, per-project progress, and infra status. Call at session end."
|
|
4
|
-
---
|
|
5
|
-
|
|
6
|
-
> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
|
|
7
|
-
> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
|
|
8
|
-
> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
|
|
9
|
-
|
|
10
|
-
> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
|
|
11
|
-
|
|
12
|
-
> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag. Git push is skipped under `RDC_TEST=1`.
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
# rdc:report — Nightly Report
|
|
16
|
-
|
|
17
|
-
## When to Use
|
|
18
|
-
- End of a build session
|
|
19
|
-
- Project lead asks for a report or summary
|
|
20
|
-
- Nightly scheduled task
|
|
21
|
-
- Before handing off to another session
|
|
22
|
-
- Called by `rdc:overnight` at the end of every session
|
|
23
|
-
|
|
24
|
-
## Arguments
|
|
25
|
-
- `rdc:report` — interactive, prints summary to conversation
|
|
26
|
-
- `rdc:report --unattended` — silent mode, writes file only, returns status block
|
|
27
|
-
|
|
28
|
-
## Procedure
|
|
29
|
-
|
|
30
|
-
1. **Query completed work (last 24h or since last report):**
|
|
31
|
-
```sql
|
|
32
|
-
SELECT title, labels, completed_at, notes
|
|
33
|
-
FROM work_items
|
|
34
|
-
WHERE completed_at > now() - interval '24 hours'
|
|
35
|
-
ORDER BY completed_at;
|
|
36
|
-
```
|
|
37
|
-
|
|
38
|
-
2. **Query open work:**
|
|
39
|
-
```sql
|
|
40
|
-
SELECT title, status, priority, labels
|
|
41
|
-
FROM work_items
|
|
42
|
-
WHERE status IN ('todo', 'in_progress', 'blocked')
|
|
43
|
-
ORDER BY priority, created_at;
|
|
44
|
-
```
|
|
45
|
-
|
|
46
|
-
3. **Git stats (since last report or last 24h):**
|
|
47
|
-
```bash
|
|
48
|
-
git log --since="24 hours ago" --shortstat --oneline
|
|
49
|
-
git diff --shortstat HEAD~N # where N = commits in window
|
|
50
|
-
```
|
|
51
|
-
|
|
52
|
-
4. **Infrastructure deployment snapshot** (if MCP available):
|
|
53
|
-
- List all apps with current status
|
|
54
|
-
- Flag any failures
|
|
55
|
-
|
|
56
|
-
5. **Write report** to `.rdc/reports/YYYY-MM-DD.md` (fallback: `.rdc/reports/YYYY-MM-DD.md` if `.rdc/` does not exist):
|
|
57
|
-
```markdown
|
|
58
|
-
# Daily Report — YYYY-MM-DD
|
|
59
|
-
|
|
60
|
-
## Completed Today
|
|
61
|
-
| Item | Project | Priority |
|
|
62
|
-
|
|
63
|
-
## Git Activity
|
|
64
|
-
- Commits: N
|
|
65
|
-
- Files changed: N
|
|
66
|
-
- Lines: +N / -N
|
|
67
|
-
|
|
68
|
-
## Open Work
|
|
69
|
-
### Urgent (N)
|
|
70
|
-
### High (N)
|
|
71
|
-
### Normal (N)
|
|
72
|
-
|
|
73
|
-
## Deployment Status
|
|
74
|
-
| App | Domain | Status |
|
|
75
|
-
|
|
76
|
-
## Blockers
|
|
77
|
-
<any blocked items or failed deploys>
|
|
78
|
-
|
|
79
|
-
## Next Session Recommendation
|
|
80
|
-
<highest priority unstarted work>
|
|
81
|
-
```
|
|
82
|
-
|
|
83
|
-
6. **Check if weekly rollup needed** (if today is Sunday):
|
|
84
|
-
- Aggregate daily reports for the week
|
|
85
|
-
- Write `.rdc/reports/week-YYYY-WNN.md` (fallback: `.rdc/reports/week-YYYY-WNN.md`)
|
|
86
|
-
|
|
87
|
-
7. **Report results:**
|
|
88
|
-
- Interactive: print summary to conversation
|
|
89
|
-
- Unattended: no interactive output, emit status block only:
|
|
90
|
-
```
|
|
91
|
-
REPORT_STATUS: { report_path, completed_count, open_count, blockers_count }
|
|
92
|
-
```
|
|
93
|
-
|
|
94
|
-
## Rules
|
|
95
|
-
- Reports go in `.rdc/reports/` (fallback: `.rdc/reports/`) — create dir if missing
|
|
96
|
-
- One report per day — overwrite if re-run same day
|
|
97
|
-
- Keep under 100 lines — scannable, not exhaustive
|
|
98
|
-
- Include links to relevant CLAUDE.md files where helpful
|
|
99
|
-
- Always end with "Next Session Recommendation"
|
|
100
|
-
- Unattended: NEVER print to conversation — write file only
|
|
1
|
+
---
|
|
2
|
+
name: rdc:report
|
|
3
|
+
description: "Usage `rdc:report` — Write the nightly session summary to .rdc/reports/YYYY-MM-DD.md covering completed work, open items, per-project progress, and infra status. Call at session end."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
|
|
7
|
+
> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
|
|
8
|
+
> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
|
|
9
|
+
|
|
10
|
+
> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`).
|
|
11
|
+
|
|
12
|
+
> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag. Git push is skipped under `RDC_TEST=1`.
|
|
13
|
+
|
|
14
|
+
|
|
15
|
+
# rdc:report — Nightly Report
|
|
16
|
+
|
|
17
|
+
## When to Use
|
|
18
|
+
- End of a build session
|
|
19
|
+
- Project lead asks for a report or summary
|
|
20
|
+
- Nightly scheduled task
|
|
21
|
+
- Before handing off to another session
|
|
22
|
+
- Called by `rdc:overnight` at the end of every session
|
|
23
|
+
|
|
24
|
+
## Arguments
|
|
25
|
+
- `rdc:report` — interactive, prints summary to conversation
|
|
26
|
+
- `rdc:report --unattended` — silent mode, writes file only, returns status block
|
|
27
|
+
|
|
28
|
+
## Procedure
|
|
29
|
+
|
|
30
|
+
1. **Query completed work (last 24h or since last report):**
|
|
31
|
+
```sql
|
|
32
|
+
SELECT title, labels, completed_at, notes
|
|
33
|
+
FROM work_items
|
|
34
|
+
WHERE completed_at > now() - interval '24 hours'
|
|
35
|
+
ORDER BY completed_at;
|
|
36
|
+
```
|
|
37
|
+
|
|
38
|
+
2. **Query open work:**
|
|
39
|
+
```sql
|
|
40
|
+
SELECT title, status, priority, labels
|
|
41
|
+
FROM work_items
|
|
42
|
+
WHERE status IN ('todo', 'in_progress', 'blocked')
|
|
43
|
+
ORDER BY priority, created_at;
|
|
44
|
+
```
|
|
45
|
+
|
|
46
|
+
3. **Git stats (since last report or last 24h):**
|
|
47
|
+
```bash
|
|
48
|
+
git log --since="24 hours ago" --shortstat --oneline
|
|
49
|
+
git diff --shortstat HEAD~N # where N = commits in window
|
|
50
|
+
```
|
|
51
|
+
|
|
52
|
+
4. **Infrastructure deployment snapshot** (if MCP available):
|
|
53
|
+
- List all apps with current status
|
|
54
|
+
- Flag any failures
|
|
55
|
+
|
|
56
|
+
5. **Write report** to `.rdc/reports/YYYY-MM-DD.md` (fallback: `.rdc/reports/YYYY-MM-DD.md` if `.rdc/` does not exist):
|
|
57
|
+
```markdown
|
|
58
|
+
# Daily Report — YYYY-MM-DD
|
|
59
|
+
|
|
60
|
+
## Completed Today
|
|
61
|
+
| Item | Project | Priority |
|
|
62
|
+
|
|
63
|
+
## Git Activity
|
|
64
|
+
- Commits: N
|
|
65
|
+
- Files changed: N
|
|
66
|
+
- Lines: +N / -N
|
|
67
|
+
|
|
68
|
+
## Open Work
|
|
69
|
+
### Urgent (N)
|
|
70
|
+
### High (N)
|
|
71
|
+
### Normal (N)
|
|
72
|
+
|
|
73
|
+
## Deployment Status
|
|
74
|
+
| App | Domain | Status |
|
|
75
|
+
|
|
76
|
+
## Blockers
|
|
77
|
+
<any blocked items or failed deploys>
|
|
78
|
+
|
|
79
|
+
## Next Session Recommendation
|
|
80
|
+
<highest priority unstarted work>
|
|
81
|
+
```
|
|
82
|
+
|
|
83
|
+
6. **Check if weekly rollup needed** (if today is Sunday):
|
|
84
|
+
- Aggregate daily reports for the week
|
|
85
|
+
- Write `.rdc/reports/week-YYYY-WNN.md` (fallback: `.rdc/reports/week-YYYY-WNN.md`)
|
|
86
|
+
|
|
87
|
+
7. **Report results:**
|
|
88
|
+
- Interactive: print summary to conversation
|
|
89
|
+
- Unattended: no interactive output, emit status block only:
|
|
90
|
+
```
|
|
91
|
+
REPORT_STATUS: { report_path, completed_count, open_count, blockers_count }
|
|
92
|
+
```
|
|
93
|
+
|
|
94
|
+
## Rules
|
|
95
|
+
- Reports go in `.rdc/reports/` (fallback: `.rdc/reports/`) — create dir if missing
|
|
96
|
+
- One report per day — overwrite if re-run same day
|
|
97
|
+
- Keep under 100 lines — scannable, not exhaustive
|
|
98
|
+
- Include links to relevant CLAUDE.md files where helpful
|
|
99
|
+
- Always end with "Next Session Recommendation"
|
|
100
|
+
- Unattended: NEVER print to conversation — write file only
|
package/skills/review/SKILL.md
CHANGED
|
@@ -1,115 +1,115 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: rdc:review
|
|
3
|
-
description: "Usage `rdc:review [--unattended]` — Post-build quality gate: tsc, tests, stale docs, export conflicts, and a mandatory pr-review-toolkit:code-reviewer pass across modified packages. Fixes what it can automatically, escalates the rest. Call after rdc:build and before merging to main."
|
|
4
|
-
---
|
|
5
|
-
|
|
6
|
-
> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
|
|
7
|
-
> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
|
|
8
|
-
> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
|
|
9
|
-
|
|
10
|
-
> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`), then `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md` (fallback: `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md`).
|
|
11
|
-
|
|
12
|
-
> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag.
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
# rdc:review — Quality Gate
|
|
16
|
-
|
|
17
|
-
## When to Use
|
|
18
|
-
- After a build session (especially overnight builds)
|
|
19
|
-
- Before merging development → main/production
|
|
20
|
-
- Project lead asks "review the work", "is everything clean"
|
|
21
|
-
- Before any production deployment
|
|
22
|
-
- Called by `rdc:overnight` after each epic build completes
|
|
23
|
-
|
|
24
|
-
## Arguments
|
|
25
|
-
- `rdc:review` — interactive review, pauses on issues needing judgment
|
|
26
|
-
- `rdc:review --unattended` — silent mode, auto-fixes everything fixable
|
|
27
|
-
|
|
28
|
-
## Procedure
|
|
29
|
-
|
|
30
|
-
1. **Identify modified packages:**
|
|
31
|
-
```bash
|
|
32
|
-
git diff --name-only origin/main...HEAD | grep "^packages/" | cut -d/ -f2 | sort -u
|
|
33
|
-
```
|
|
34
|
-
|
|
35
|
-
2. **Run tests for each modified package:**
|
|
36
|
-
```bash
|
|
37
|
-
cd packages/<name> && npx vitest run 2>&1 | tail -10
|
|
38
|
-
```
|
|
39
|
-
Report: package → test count → pass/fail → new tests added
|
|
40
|
-
|
|
41
|
-
**IMPORTANT:** `pnpm build` must NEVER be run (crashes system). Use `npx tsc --noEmit --project <path>/tsconfig.json` for typecheck instead. For packages without tests, typecheck is the verification method. Do NOT run vitest across the entire monorepo — check only modified packages individually.
|
|
42
|
-
|
|
43
|
-
3. **Check test coverage delta:**
|
|
44
|
-
```bash
|
|
45
|
-
git diff origin/main...HEAD -- packages/*/src/ | grep -c "^+" | head -5
|
|
46
|
-
git diff origin/main...HEAD -- packages/*/test* packages/*/src/**/*.test.* packages/*/src/**/*.spec.* 2>/dev/null | grep -c "^+" || echo 0
|
|
47
|
-
```
|
|
48
|
-
Flag any package where implementation lines added > 50 but test lines added = 0.
|
|
49
|
-
|
|
50
|
-
4. **Check for export conflicts:**
|
|
51
|
-
- Read `packages/*/src/index.ts` for any package with new exports
|
|
52
|
-
- Look for duplicate export names across the barrel
|
|
53
|
-
- Verify aliased exports don't shadow each other
|
|
54
|
-
|
|
55
|
-
5. **Check for TODO/FIXME/HACK:**
|
|
56
|
-
```bash
|
|
57
|
-
grep -rn "TODO\|FIXME\|HACK\|XXX" packages/*/src/ --include="*.ts" --include="*.tsx"
|
|
58
|
-
```
|
|
59
|
-
|
|
60
|
-
6. **Check package versions:**
|
|
61
|
-
- Any package with significant new code should have a version bump
|
|
62
|
-
- Compare package.json versions to what's in `docs/SYSTEM-STATE.md`
|
|
63
|
-
|
|
64
|
-
7. **Check for stale CLAUDE.md:**
|
|
65
|
-
- If new modules were added to a package, does its CLAUDE.md mention them?
|
|
66
|
-
- Flag any package where exports grew by >10 lines but CLAUDE.md wasn't updated
|
|
67
|
-
|
|
68
|
-
8. **Orphan work item audit:**
|
|
69
|
-
```sql
|
|
70
|
-
SELECT id, title, item_type, status, source, created_at::date
|
|
71
|
-
FROM work_items
|
|
72
|
-
WHERE parent_id IS NULL
|
|
73
|
-
AND item_type NOT IN ('epic', 'bug')
|
|
74
|
-
AND status NOT IN ('done', 'archived')
|
|
75
|
-
ORDER BY created_at DESC;
|
|
76
|
-
```
|
|
77
|
-
For each orphaned task found:
|
|
78
|
-
- If it clearly belongs to an open epic → **do not run raw SQL**. No RPC exists for re-parenting. Create a work item: `SELECT insert_work_item(p_title := 'Re-parent orphaned task <task-id> to epic <epic-id>', p_priority := 'normal', p_source := 'agent')` and flag for supervisor to re-parent manually.
|
|
79
|
-
- If unclear → report (interactive) or flag in REVIEW_STATUS (unattended)
|
|
80
|
-
- Never silently leave orphaned tasks
|
|
81
|
-
- **⛔ Raw `UPDATE work_items SET parent_id = ...` is forbidden** — bypasses RLS and all constraint checks
|
|
82
|
-
|
|
83
|
-
8b. **Mandatory code-review gate — dispatch pr-review-toolkit:code-reviewer:**
|
|
84
|
-
|
|
85
|
-
⛔ **No CLEAN verdict without a code-review pass.** This is the second half of the quality gate; tsc/vitest catch type and behavior errors, code-reviewer catches logic, security, and convention drift.
|
|
86
|
-
|
|
87
|
-
Dispatch ONE `pr-review-toolkit:code-reviewer` agent on the full diff under review:
|
|
88
|
-
|
|
89
|
-
```
|
|
90
|
-
Agent({
|
|
91
|
-
subagent_type: "pr-review-toolkit:code-reviewer",
|
|
92
|
-
description: "rdc:review code-review pass",
|
|
93
|
-
prompt: "Review `git diff origin/main...HEAD` on the development branch.
|
|
94
|
-
Focus on: bugs, logic errors, security vulnerabilities, project-convention
|
|
95
|
-
adherence (.claude/rules/*, CLAUDE.md, engineering-behavior.md).
|
|
96
|
-
Confidence-based filtering — high-confidence findings only.
|
|
97
|
-
Return CODE_REVIEW_COMPLETE with: { critical_count, high_count, medium_count,
|
|
98
|
-
low_count, findings: [{severity, file:line, issue, suggested_fix}] }."
|
|
99
|
-
})
|
|
100
|
-
```
|
|
101
|
-
|
|
102
|
-
**Severity gate:**
|
|
103
|
-
- `critical` or `high` → verdict cannot be CLEAN. Interactive: report and pause. Unattended: auto-fix if mechanical (rename, missing await, obvious null check), otherwise escalate via advisor and mark HAS_ISSUES.
|
|
104
|
-
- `medium` or `low` → record in the review report's "Issues" section; verdict can still be CLEAN.
|
|
105
|
-
- Zero findings → log `CODE_REVIEW: CLEAN` and continue.
|
|
106
|
-
|
|
107
|
-
Under `RDC_TEST=1`: echo `[RDC_TEST] skipping code-review dispatch` and continue.
|
|
108
|
-
|
|
109
|
-
9. **Verification gate — dispatch the verify agent:**
|
|
110
|
-
After any fixes land, run the verify gate on every touched package. See `guides/agents/verify.md`.
|
|
111
|
-
Apply `guides/engineering-behavior.md` while reviewing: flag unnecessary abstraction, drive-by refactors, missing assumptions, hidden uncertainty, out-of-scope edits, and prose-only verification.
|
|
112
|
-
**Iron Law: no CLEAN verdict without fresh evidence.** Quote the checklist decomposition verdict, vitest output, and tsc output in the report.
|
|
1
|
+
---
|
|
2
|
+
name: rdc:review
|
|
3
|
+
description: "Usage `rdc:review [--unattended]` — Post-build quality gate: tsc, tests, stale docs, export conflicts, and a mandatory pr-review-toolkit:code-reviewer pass across modified packages. Fixes what it can automatically, escalates the rest. Call after rdc:build and before merging to main."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
> **⚠️ OUTPUT CONTRACT (READ FIRST):** `guides/output-contract.md`
|
|
7
|
+
> Checklist-only output. No tool-call narration. No raw MCP/JSON/log dumps.
|
|
8
|
+
> One checklist upfront, updated in place, shown again at end with a 1-line verdict.
|
|
9
|
+
|
|
10
|
+
> If dispatching subagents or running as a subagent: read `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md` first (fallback: `{PROJECT_ROOT}/.rdc/guides/agent-bootstrap.md`), then `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md` (fallback: `{PROJECT_ROOT}/.rdc/guides/engineering-behavior.md`).
|
|
11
|
+
|
|
12
|
+
> **Sandbox contract:** This skill honors `RDC_TEST=1` per `guides/agent-bootstrap.md` § RDC_TEST Sandbox Contract. Destructive external calls short-circuit under the flag.
|
|
13
|
+
|
|
14
|
+
|
|
15
|
+
# rdc:review — Quality Gate
|
|
16
|
+
|
|
17
|
+
## When to Use
|
|
18
|
+
- After a build session (especially overnight builds)
|
|
19
|
+
- Before merging development → main/production
|
|
20
|
+
- Project lead asks "review the work", "is everything clean"
|
|
21
|
+
- Before any production deployment
|
|
22
|
+
- Called by `rdc:overnight` after each epic build completes
|
|
23
|
+
|
|
24
|
+
## Arguments
|
|
25
|
+
- `rdc:review` — interactive review, pauses on issues needing judgment
|
|
26
|
+
- `rdc:review --unattended` — silent mode, auto-fixes everything fixable
|
|
27
|
+
|
|
28
|
+
## Procedure
|
|
29
|
+
|
|
30
|
+
1. **Identify modified packages:**
|
|
31
|
+
```bash
|
|
32
|
+
git diff --name-only origin/main...HEAD | grep "^packages/" | cut -d/ -f2 | sort -u
|
|
33
|
+
```
|
|
34
|
+
|
|
35
|
+
2. **Run tests for each modified package:**
|
|
36
|
+
```bash
|
|
37
|
+
cd packages/<name> && npx vitest run 2>&1 | tail -10
|
|
38
|
+
```
|
|
39
|
+
Report: package → test count → pass/fail → new tests added
|
|
40
|
+
|
|
41
|
+
**IMPORTANT:** `pnpm build` must NEVER be run (crashes system). Use `npx tsc --noEmit --project <path>/tsconfig.json` for typecheck instead. For packages without tests, typecheck is the verification method. Do NOT run vitest across the entire monorepo — check only modified packages individually.
|
|
42
|
+
|
|
43
|
+
3. **Check test coverage delta:**
|
|
44
|
+
```bash
|
|
45
|
+
git diff origin/main...HEAD -- packages/*/src/ | grep -c "^+" | head -5
|
|
46
|
+
git diff origin/main...HEAD -- packages/*/test* packages/*/src/**/*.test.* packages/*/src/**/*.spec.* 2>/dev/null | grep -c "^+" || echo 0
|
|
47
|
+
```
|
|
48
|
+
Flag any package where implementation lines added > 50 but test lines added = 0.
|
|
49
|
+
|
|
50
|
+
4. **Check for export conflicts:**
|
|
51
|
+
- Read `packages/*/src/index.ts` for any package with new exports
|
|
52
|
+
- Look for duplicate export names across the barrel
|
|
53
|
+
- Verify aliased exports don't shadow each other
|
|
54
|
+
|
|
55
|
+
5. **Check for TODO/FIXME/HACK:**
|
|
56
|
+
```bash
|
|
57
|
+
grep -rn "TODO\|FIXME\|HACK\|XXX" packages/*/src/ --include="*.ts" --include="*.tsx"
|
|
58
|
+
```
|
|
59
|
+
|
|
60
|
+
6. **Check package versions:**
|
|
61
|
+
- Any package with significant new code should have a version bump
|
|
62
|
+
- Compare package.json versions to what's in `docs/SYSTEM-STATE.md`
|
|
63
|
+
|
|
64
|
+
7. **Check for stale CLAUDE.md:**
|
|
65
|
+
- If new modules were added to a package, does its CLAUDE.md mention them?
|
|
66
|
+
- Flag any package where exports grew by >10 lines but CLAUDE.md wasn't updated
|
|
67
|
+
|
|
68
|
+
8. **Orphan work item audit:**
|
|
69
|
+
```sql
|
|
70
|
+
SELECT id, title, item_type, status, source, created_at::date
|
|
71
|
+
FROM work_items
|
|
72
|
+
WHERE parent_id IS NULL
|
|
73
|
+
AND item_type NOT IN ('epic', 'bug')
|
|
74
|
+
AND status NOT IN ('done', 'archived')
|
|
75
|
+
ORDER BY created_at DESC;
|
|
76
|
+
```
|
|
77
|
+
For each orphaned task found:
|
|
78
|
+
- If it clearly belongs to an open epic → **do not run raw SQL**. No RPC exists for re-parenting. Create a work item: `SELECT insert_work_item(p_title := 'Re-parent orphaned task <task-id> to epic <epic-id>', p_priority := 'normal', p_source := 'agent')` and flag for supervisor to re-parent manually.
|
|
79
|
+
- If unclear → report (interactive) or flag in REVIEW_STATUS (unattended)
|
|
80
|
+
- Never silently leave orphaned tasks
|
|
81
|
+
- **⛔ Raw `UPDATE work_items SET parent_id = ...` is forbidden** — bypasses RLS and all constraint checks
|
|
82
|
+
|
|
83
|
+
8b. **Mandatory code-review gate — dispatch pr-review-toolkit:code-reviewer:**
|
|
84
|
+
|
|
85
|
+
⛔ **No CLEAN verdict without a code-review pass.** This is the second half of the quality gate; tsc/vitest catch type and behavior errors, code-reviewer catches logic, security, and convention drift.
|
|
86
|
+
|
|
87
|
+
Dispatch ONE `pr-review-toolkit:code-reviewer` agent on the full diff under review:
|
|
88
|
+
|
|
89
|
+
```
|
|
90
|
+
Agent({
|
|
91
|
+
subagent_type: "pr-review-toolkit:code-reviewer",
|
|
92
|
+
description: "rdc:review code-review pass",
|
|
93
|
+
prompt: "Review `git diff origin/main...HEAD` on the development branch.
|
|
94
|
+
Focus on: bugs, logic errors, security vulnerabilities, project-convention
|
|
95
|
+
adherence (.claude/rules/*, CLAUDE.md, engineering-behavior.md).
|
|
96
|
+
Confidence-based filtering — high-confidence findings only.
|
|
97
|
+
Return CODE_REVIEW_COMPLETE with: { critical_count, high_count, medium_count,
|
|
98
|
+
low_count, findings: [{severity, file:line, issue, suggested_fix}] }."
|
|
99
|
+
})
|
|
100
|
+
```
|
|
101
|
+
|
|
102
|
+
**Severity gate:**
|
|
103
|
+
- `critical` or `high` → verdict cannot be CLEAN. Interactive: report and pause. Unattended: auto-fix if mechanical (rename, missing await, obvious null check), otherwise escalate via advisor and mark HAS_ISSUES.
|
|
104
|
+
- `medium` or `low` → record in the review report's "Issues" section; verdict can still be CLEAN.
|
|
105
|
+
- Zero findings → log `CODE_REVIEW: CLEAN` and continue.
|
|
106
|
+
|
|
107
|
+
Under `RDC_TEST=1`: echo `[RDC_TEST] skipping code-review dispatch` and continue.
|
|
108
|
+
|
|
109
|
+
9. **Verification gate — dispatch the verify agent:**
|
|
110
|
+
After any fixes land, run the verify gate on every touched package. See `guides/agents/verify.md`.
|
|
111
|
+
Apply `guides/engineering-behavior.md` while reviewing: flag unnecessary abstraction, drive-by refactors, missing assumptions, hidden uncertainty, out-of-scope edits, and prose-only verification.
|
|
112
|
+
**Iron Law: no CLEAN verdict without fresh evidence.** Quote the checklist decomposition verdict, vitest output, and tsc output in the report.
|
|
113
113
|
The verify agent must reject any work item that lacks passed `decomp-*` checklist rows, whose rows are too coarse to prove one observable behavior at a time, OR whose checklist falls below the per-surface completeness floor (a feature WP with 5-6 rows where its surfaces demand 12-20 attested rows is a REJECT).
|
|
114
114
|
**Durable workflow hard gate:** If the diff adds or changes a queue/job,
|
|
115
115
|
background worker, storage hand-off, retry/lease, webhook, or async
|
|
@@ -119,42 +119,42 @@ description: "Usage `rdc:review [--unattended]` — Post-build quality gate: tsc
|
|
|
119
119
|
verify every persisted output, and prove `finally` cleanup. Unit tests,
|
|
120
120
|
mocks, migrations, Docker construction, and route-health probes are not
|
|
121
121
|
substitutes; missing evidence means `HAS_ISSUES`, never `CLEAN`.
|
|
122
|
-
If verify fails → do NOT emit CLEAN. Loop back, fix, re-run verify.
|
|
123
|
-
|
|
124
|
-
10. **Fix issues found:**
|
|
125
|
-
- Failing tests → fix and commit
|
|
126
|
-
- Export conflicts → resolve and commit
|
|
127
|
-
- Missing version bumps → bump and commit
|
|
128
|
-
- All fixes as separate commits with descriptive messages
|
|
129
|
-
|
|
130
|
-
**Judgment calls:**
|
|
131
|
-
- Interactive: report — don't guess
|
|
132
|
-
- Unattended: escalate via advisor tool with: error message, surrounding context,
|
|
133
|
-
two most likely fix paths. Resume with advisor's recommendation.
|
|
134
|
-
If advisor unavailable: take the most conservative path, flag in status block.
|
|
135
|
-
|
|
136
|
-
11. **Report:**
|
|
137
|
-
- Interactive:
|
|
138
|
-
```
|
|
139
|
-
## Review Results
|
|
140
|
-
| Package | Tests | Pass/Fail | New Tests | Issues |
|
|
141
|
-
## Fixed
|
|
142
|
-
## Remaining Issues
|
|
143
|
-
## Verdict: CLEAN / HAS ISSUES
|
|
144
|
-
```
|
|
145
|
-
- Unattended: emit status block only:
|
|
146
|
-
```
|
|
147
|
-
REVIEW_STATUS: { verdict: "CLEAN|HAS_ISSUES", packages_checked, tests_passed, tests_failed, new_tests_added, fixes_applied, escalations }
|
|
148
|
-
```
|
|
149
|
-
|
|
150
|
-
## Rules
|
|
151
|
-
- Do NOT run `pnpm build` (crashes system) — vitest only
|
|
152
|
-
- Interactive: fix what you can, flag what needs decision
|
|
153
|
-
- Unattended: fix everything fixable; escalate judgment calls to advisor
|
|
154
|
-
- Each fix is a separate commit (not batched)
|
|
155
|
-
- Always push fixes to origin after committing *(skip if `$RDC_TEST=1` — echo `[RDC_TEST] skipping git push` instead)*
|
|
156
|
-
- Unattended: NEVER pause for input
|
|
157
|
-
|
|
158
|
-
## Capture lessons (exit step)
|
|
159
|
-
|
|
160
|
-
Before the final verdict line, follow `.rdc/guides/lessons-learned-spec.md` § Capture procedure. If this run taught something non-obvious — a first root-cause theory that turned out wrong, the documented/standard path not working, a missing gate or check that cost a round, or a surprising tool/infra behavior — write one `.rdc/lessons/<YYYY-MM-DD>-review-<short-slug>.md` per lesson using the schema in that spec. Set `scope` (`simple` | `architectural`) and `status` (`open`, or `applied` if you shipped the fix in this same run, with the commit linked). Commit the lesson file(s) on `develop` alongside the run's other commits, and note "N lessons captured" in your verdict/summary. A run that taught nothing writes nothing — absence is the default.
|
|
122
|
+
If verify fails → do NOT emit CLEAN. Loop back, fix, re-run verify.
|
|
123
|
+
|
|
124
|
+
10. **Fix issues found:**
|
|
125
|
+
- Failing tests → fix and commit
|
|
126
|
+
- Export conflicts → resolve and commit
|
|
127
|
+
- Missing version bumps → bump and commit
|
|
128
|
+
- All fixes as separate commits with descriptive messages
|
|
129
|
+
|
|
130
|
+
**Judgment calls:**
|
|
131
|
+
- Interactive: report — don't guess
|
|
132
|
+
- Unattended: escalate via advisor tool with: error message, surrounding context,
|
|
133
|
+
two most likely fix paths. Resume with advisor's recommendation.
|
|
134
|
+
If advisor unavailable: take the most conservative path, flag in status block.
|
|
135
|
+
|
|
136
|
+
11. **Report:**
|
|
137
|
+
- Interactive:
|
|
138
|
+
```
|
|
139
|
+
## Review Results
|
|
140
|
+
| Package | Tests | Pass/Fail | New Tests | Issues |
|
|
141
|
+
## Fixed
|
|
142
|
+
## Remaining Issues
|
|
143
|
+
## Verdict: CLEAN / HAS ISSUES
|
|
144
|
+
```
|
|
145
|
+
- Unattended: emit status block only:
|
|
146
|
+
```
|
|
147
|
+
REVIEW_STATUS: { verdict: "CLEAN|HAS_ISSUES", packages_checked, tests_passed, tests_failed, new_tests_added, fixes_applied, escalations }
|
|
148
|
+
```
|
|
149
|
+
|
|
150
|
+
## Rules
|
|
151
|
+
- Do NOT run `pnpm build` (crashes system) — vitest only
|
|
152
|
+
- Interactive: fix what you can, flag what needs decision
|
|
153
|
+
- Unattended: fix everything fixable; escalate judgment calls to advisor
|
|
154
|
+
- Each fix is a separate commit (not batched)
|
|
155
|
+
- Always push fixes to origin after committing *(skip if `$RDC_TEST=1` — echo `[RDC_TEST] skipping git push` instead)*
|
|
156
|
+
- Unattended: NEVER pause for input
|
|
157
|
+
|
|
158
|
+
## Capture lessons (exit step)
|
|
159
|
+
|
|
160
|
+
Before the final verdict line, follow `.rdc/guides/lessons-learned-spec.md` § Capture procedure. If this run taught something non-obvious — a first root-cause theory that turned out wrong, the documented/standard path not working, a missing gate or check that cost a round, or a surprising tool/infra behavior — write one `.rdc/lessons/<YYYY-MM-DD>-review-<short-slug>.md` per lesson using the schema in that spec. Set `scope` (`simple` | `architectural`) and `status` (`open`, or `applied` if you shipped the fix in this same run, with the commit linked). Commit the lesson file(s) on `develop` alongside the run's other commits, and note "N lessons captured" in your verdict/summary. A run that taught nothing writes nothing — absence is the default.
|