@lifeaitools/rdc-skills 0.24.6 → 0.24.7

package/git-sha.json

@@ -1,3 +1,3 @@
 {
-  "sha": "c7ae6c2095cf0f711bf4740bc82adbdb805ab966"
+  "sha": "2fc0a320523abba6b5a122094627eb9c4e2e980d"
 }

package/hooks/task-completed-gate.js

@@ -21,7 +21,11 @@
  *
  * Flag (default OFF), either enables it:
  *   - env  RDC_TRUTHGATE_TASKCOMPLETED in {1,true,on,yes}, OR
- *   - DB   public.truthgate_flags(flag='taskcompleted', enabled=true) (best-effort).
+ *   - DB   public.truthgate_flags(flag='taskcompleted', enabled=true) — but the
+ *          DB check is OPT-IN: it only runs when RDC_TRUTHGATE_TASKCOMPLETED_DB
+ *          is in {1,true,on,yes}. This keeps the default-OFF path ZERO-COST: an
+ *          unset env flag returns false with NO Supabase/clauth round-trip, so a
+ *          dormant gate never makes a network call on every TaskCompleted.
  *
  * Offline test seam: when RDC_TASKCOMPLETED_CLOSURE_SINK points at a JSON file,
  * the hook reads the closure row from that file instead of Supabase. This lets
@@ -74,6 +78,17 @@ function flagEnabledEnv() {
   return v === '1' || v === 'true' || v === 'on' || v === 'yes';
 }
 
+/**
+ * Is the optional DB flag check opted into? Default OFF (returns false).
+ * The DB check is a Supabase/clauth round-trip; gating it behind this explicit
+ * env opt-in keeps the default-OFF path zero-cost (no network on every
+ * TaskCompleted). Only when this is set do we consult truthgate_flags.
+ */
+function flagDbOptIn() {
+  const v = String(process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB || '').trim().toLowerCase();
+  return v === '1' || v === 'true' || v === 'on' || v === 'yes';
+}
+
 async function getServiceKey() {
   if (process.env.SUPABASE_SERVICE_ROLE_KEY) return process.env.SUPABASE_SERVICE_ROLE_KEY;
   if (process.env.SUPABASE_SERVICE_KEY) return process.env.SUPABASE_SERVICE_KEY;
@@ -202,8 +217,14 @@ async function main() {
   let raw;
   try { raw = JSON.parse(await readStdin()); } catch { process.exit(0); }
 
-  // Default-OFF: a no-op until the flag is flipped at deploy.
-  const enabled = flagEnabledEnv() || (await flagEnabledDb().catch(() => false));
+  // Default-OFF: a no-op until the flag is flipped at deploy. The env flag is
+  // checked first and short-circuits — when it is unset, the DB check runs ONLY
+  // if explicitly opted in via RDC_TRUTHGATE_TASKCOMPLETED_DB, so the dormant
+  // path is zero-cost (no Supabase/clauth round-trip on every TaskCompleted).
+  let enabled = flagEnabledEnv();
+  if (!enabled && flagDbOptIn()) {
+    enabled = await flagEnabledDb().catch(() => false);
+  }
   if (!enabled) return pass({ reason: 'flag-off' });
 
   // FAIL-CLOSED from here: any inability to confirm a sound closure is a BLOCK.
@@ -245,6 +266,7 @@ if (require.main === module) {
 } else {
   module.exports = {
     flagEnabledEnv,
+    flagDbOptIn,
     extractWorkItemId,
     closureIsSound,
     WITNESS_ALLOWLIST,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lifeaitools/rdc-skills",
-  "version": "0.24.6",
+  "version": "0.24.7",
   "description": "RDC typed-agent dispatch skill suite for Claude Code - plan, build, review, overnight builds",
   "keywords": [
     "claude-code",

package/tests/harness-gates.test.mjs

@@ -78,12 +78,42 @@ const WI = 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee';
     else process.env.RDC_TRUTHGATE_TASKCOMPLETED = prev;
   }
 
+  // pure: flagDbOptIn default OFF, ON via env
+  {
+    const prev = process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB;
+    delete process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB;
+    assert('TCG DB-opt-in default OFF', tcg.flagDbOptIn() === false);
+    process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB = 'on';
+    assert('TCG DB-opt-in ON via env', tcg.flagDbOptIn() === true);
+    if (prev === undefined) delete process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB;
+    else process.env.RDC_TRUTHGATE_TASKCOMPLETED_DB = prev;
+  }
+
   // process: flag OFF → no-op (exit 0, no block)
   {
     const r = runHook('task-completed-gate.js', { work_item_id: WI }, { RDC_TRUTHGATE_TASKCOMPLETED: '' });
     assert('TCG flag OFF → exit 0 no-op', r.status === 0, `status=${r.status} ${r.stderr}`);
   }
 
+  // process: flag OFF + DB-opt-in unset → ZERO-COST OFF path makes NO DB call.
+  // Point Supabase + the clauth daemon at a non-routable, slow-to-fail address.
+  // If the OFF path consulted the DB, the call would stall near the hook's
+  // Supabase timeout (~3.5s) / clauth timeout (~2s). The run completing far
+  // under that floor proves no round-trip was attempted.
+  {
+    const t0 = Date.now();
+    const r = runHook('task-completed-gate.js', { work_item_id: WI }, {
+      RDC_TRUTHGATE_TASKCOMPLETED: '',
+      RDC_TRUTHGATE_TASKCOMPLETED_DB: '',     // DB check NOT opted into
+      SUPABASE_URL: 'http://10.255.255.1',    // non-routable: any call would hang
+      SUPABASE_SERVICE_ROLE_KEY: 'x',         // a key IS present, so only the opt-in gate keeps us off the network
+    });
+    const elapsed = Date.now() - t0;
+    assert('TCG OFF path → exit 0', r.status === 0, `status=${r.status} ${r.stderr}`);
+    assert('TCG OFF path makes no DB call (returns well under the network-timeout floor)',
+      elapsed < 1500, `elapsed=${elapsed}ms (a DB round-trip would approach the ~3.5s timeout)`);
+  }
+
   // process: flag ON + no closure ref → BLOCK (exit 2)
   {
     const r = runHook('task-completed-gate.js', { task: { note: 'no uuid here' } },