@lifeaitools/rdc-skills 0.24.38 → 0.24.41

package/tests/help-surface.test.mjs

@@ -1,61 +1,61 @@
-#!/usr/bin/env node
-import assert from 'node:assert/strict';
-import { existsSync, readdirSync, readFileSync, statSync } from 'node:fs';
-import { dirname, join, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const root = resolve(__dirname, '..');
-
-const files = {
-  readme: join(root, 'README.md'),
-  skillHelp: join(root, 'skills', 'help', 'SKILL.md'),
-  commandHelp: join(root, 'commands', 'help.md'),
-};
-
-const docs = Object.fromEntries(
-  Object.entries(files).map(([key, file]) => [key, readFileSync(file, 'utf8')]),
-);
-
-for (const [name, text] of Object.entries(docs)) {
-  assert.match(text, /https:\/\/rdc-skills\.regendevcorp\.com\/mcp/, `${name} must expose production MCP endpoint`);
-  assert.match(text, /Accept: application\/json, text\/event-stream/, `${name} must show Streamable HTTP Accept header`);
-  assert.match(text, /data:/, `${name} must explain Streamable HTTP SSE data lines`);
-  assert.match(text, /result\.content\[0\]\.text/, `${name} must explain where tool text lives`);
-  assert.match(text, /sed -n 's\/\^data: \/\/p'/, `${name} must include a plain curl SSE extraction example`);
-  assert.match(text, /rdc_skill_list/, `${name} must mention rdc_skill_list`);
-  assert.match(text, /rdc_skill_search/, `${name} must mention rdc_skill_search`);
-  assert.match(text, /rdc_skill_get/, `${name} must mention rdc_skill_get`);
-  assert.match(text, /output_contract/, `${name} must describe rdc_skill_list metadata fields`);
-  assert.match(text, /codeflow_required/, `${name} must describe CodeFlow metadata`);
-  assert.match(text, /variants/, `${name} must describe supported skill variants`);
-  assert.match(text, /"format":"json"/, `${name} must show structured rdc_skill_get format=json`);
-  assert.match(text, /turn this article into social posts/, `${name} must include a natural-language search example`);
-  assert.match(text, /"name":"rdc:build"/, `${name} must show rdc_skill_get accepts visible slash names`);
-  assert.doesNotMatch(text, /https:\/\/rdc-skills\.dev\.regendevcorp\.com\/mcp/, `${name} must not point callers at dev MCP`);
-}
-
-assert.match(docs.readme, /30 MCP skills organized into 8 manifest categories/, 'README should use manifest category count');
-assert.match(docs.readme, /Nineteen[\s\S]*\/rdc:\*` command shorthands/i, 'README should distinguish slash-command shorthands from full MCP skills');
-assert.match(docs.readme, /Use `rdc_skill_list` for the authoritative live catalog/, 'README should point callers to live MCP catalog');
-assert.doesNotMatch(docs.readme, /All user-invocable skills become available as slash commands/, 'README must not imply all MCP skills are slash commands');
-assert.doesNotMatch(docs.readme, /29 skills organized into 6 categories/, 'README must not carry stale category count');
-assert.match(docs.commandHelp, /menu of all MCP skills/, 'command help should refer to MCP skill catalog');
-assert.match(docs.skillHelp, /Show all MCP skills/, 'skill help should refer to MCP skill catalog');
-assert.match(docs.skillHelp, /manifest-driven/i, 'skill help should be manifest-driven');
-assert.match(docs.commandHelp, /manifest-driven/i, 'command help should be manifest-driven');
-assert.doesNotMatch(docs.commandHelp, /Print the full usage menu below verbatim/, 'command help must not use stale static menu wording');
-assert.doesNotMatch(docs.commandHelp, /get\/<service>/, 'command help must use current clauth /v/<service> wording');
-
-const skillDirs = readdirSync(join(root, 'skills'))
-  .filter((name) => {
-    const dir = join(root, 'skills', name);
-    return statSync(dir).isDirectory() && existsSync(join(dir, 'SKILL.md'));
-  })
-  .sort();
-const readmeSkillDirs = [...docs.readme.matchAll(/^\s{2}([A-Za-z0-9_-]+)\/SKILL\.md/gm)]
-  .map((match) => match[1])
-  .sort();
-assert.deepEqual(readmeSkillDirs, skillDirs, 'README File Structure must list every skill directory exactly once');
-
-console.log('help surface tests — PASS');
+#!/usr/bin/env node
+import assert from 'node:assert/strict';
+import { existsSync, readdirSync, readFileSync, statSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const root = resolve(__dirname, '..');
+
+const files = {
+  readme: join(root, 'README.md'),
+  skillHelp: join(root, 'skills', 'help', 'SKILL.md'),
+  commandHelp: join(root, 'commands', 'help.md'),
+};
+
+const docs = Object.fromEntries(
+  Object.entries(files).map(([key, file]) => [key, readFileSync(file, 'utf8')]),
+);
+
+for (const [name, text] of Object.entries(docs)) {
+  assert.match(text, /https:\/\/rdc-skills\.regendevcorp\.com\/mcp/, `${name} must expose production MCP endpoint`);
+  assert.match(text, /Accept: application\/json, text\/event-stream/, `${name} must show Streamable HTTP Accept header`);
+  assert.match(text, /data:/, `${name} must explain Streamable HTTP SSE data lines`);
+  assert.match(text, /result\.content\[0\]\.text/, `${name} must explain where tool text lives`);
+  assert.match(text, /sed -n 's\/\^data: \/\/p'/, `${name} must include a plain curl SSE extraction example`);
+  assert.match(text, /rdc_skill_list/, `${name} must mention rdc_skill_list`);
+  assert.match(text, /rdc_skill_search/, `${name} must mention rdc_skill_search`);
+  assert.match(text, /rdc_skill_get/, `${name} must mention rdc_skill_get`);
+  assert.match(text, /output_contract/, `${name} must describe rdc_skill_list metadata fields`);
+  assert.match(text, /codeflow_required/, `${name} must describe CodeFlow metadata`);
+  assert.match(text, /variants/, `${name} must describe supported skill variants`);
+  assert.match(text, /"format":"json"/, `${name} must show structured rdc_skill_get format=json`);
+  assert.match(text, /turn this article into social posts/, `${name} must include a natural-language search example`);
+  assert.match(text, /"name":"rdc:build"/, `${name} must show rdc_skill_get accepts visible slash names`);
+  assert.doesNotMatch(text, /https:\/\/rdc-skills\.dev\.regendevcorp\.com\/mcp/, `${name} must not point callers at dev MCP`);
+}
+
+assert.match(docs.readme, /30 MCP skills organized into 8 manifest categories/, 'README should use manifest category count');
+assert.match(docs.readme, /Nineteen[\s\S]*\/rdc:\*` command shorthands/i, 'README should distinguish slash-command shorthands from full MCP skills');
+assert.match(docs.readme, /Use `rdc_skill_list` for the authoritative live catalog/, 'README should point callers to live MCP catalog');
+assert.doesNotMatch(docs.readme, /All user-invocable skills become available as slash commands/, 'README must not imply all MCP skills are slash commands');
+assert.doesNotMatch(docs.readme, /29 skills organized into 6 categories/, 'README must not carry stale category count');
+assert.match(docs.commandHelp, /menu of all MCP skills/, 'command help should refer to MCP skill catalog');
+assert.match(docs.skillHelp, /Show all MCP skills/, 'skill help should refer to MCP skill catalog');
+assert.match(docs.skillHelp, /manifest-driven/i, 'skill help should be manifest-driven');
+assert.match(docs.commandHelp, /manifest-driven/i, 'command help should be manifest-driven');
+assert.doesNotMatch(docs.commandHelp, /Print the full usage menu below verbatim/, 'command help must not use stale static menu wording');
+assert.doesNotMatch(docs.commandHelp, /get\/<service>/, 'command help must use current clauth /v/<service> wording');
+
+const skillDirs = readdirSync(join(root, 'skills'))
+  .filter((name) => {
+    const dir = join(root, 'skills', name);
+    return statSync(dir).isDirectory() && existsSync(join(dir, 'SKILL.md'));
+  })
+  .sort();
+const readmeSkillDirs = [...docs.readme.matchAll(/^\s{2}([A-Za-z0-9_-]+)\/SKILL\.md/gm)]
+  .map((match) => match[1])
+  .sort();
+assert.deepEqual(readmeSkillDirs, skillDirs, 'README File Structure must list every skill directory exactly once');
+
+console.log('help surface tests — PASS');

package/tests/housekeeping-lessons-triage.test.mjs

@@ -0,0 +1,49 @@
+#!/usr/bin/env node
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const root = resolve(dirname(fileURLToPath(import.meta.url)), '..');
+const skill = readFileSync(join(root, 'skills', 'housekeeping', 'SKILL.md'), 'utf8');
+const guide = readFileSync(join(root, 'guides', 'lessons-learned-spec.md'), 'utf8');
+
+function mustAppearInOrder(text, fragments, name) {
+  let previous = -1;
+  for (const fragment of fragments) {
+    const index = text.indexOf(fragment);
+    assert.notEqual(index, -1, `${name} is missing: ${fragment}`);
+    assert.ok(index > previous, `${name} orders ${fragment} before its required predecessor`);
+    previous = index;
+  }
+}
+
+assert.match(skill, /lesson_status: open/, 'housekeeping must read the current lesson status field');
+assert.doesNotMatch(skill, /(?:set|mark) `status: (?:open|triaged|applied|wont-fix)/, 'housekeeping must use lesson_status for triage outcomes');
+assert.match(skill, /do not create new work/i, 'the audit must prevent duplicate work');
+assert.doesNotMatch(skill, /scope: simple.*apply the fix directly/s, 'simple lessons cannot bypass RDC routing');
+mustAppearInOrder(skill, [
+  '### 1. Cluster',
+  '### 2. Resolution audit',
+  '### 3. Architectural report and interview gate',
+  '### 4. Route only still-open, approved work through RDC',
+  '### 5. Complete weekly lessons report',
+], 'housekeeping workflow');
+assert.match(skill, /complete work item/, 'routed work must have a complete work item');
+assert.match(skill, /rdc:fixit/, 'housekeeping must route small work through fixit');
+assert.match(skill, /rdc:fixit` creates and completes the sole work item/, 'fixit must own its single work item');
+assert.match(skill, /rdc:plan` followed by `rdc:build/, 'housekeeping must route larger work through build');
+assert.match(skill, /rdc:review/, 'each lesson action batch must be reviewed');
+assert.match(skill, /dev deployment/, 'deployable work must record dev deployment evidence');
+assert.match(skill, /question-and-answer list/, 'the weekly report must preserve architectural interview answers');
+
+assert.match(guide, /lesson_status: open \| triaged \| applied \| wont-fix/, 'guide schema must match housekeeping');
+mustAppearInOrder(guide, [
+  'Resolution audit before routing',
+  'Architectural report and interview',
+  'RDC routing',
+  'Run `rdc:review`',
+], 'shared lessons guide');
+assert.match(guide, /Do not create an `rdc:fixit`, `rdc:plan`, or `rdc:build` item before this audit/, 'guide must block premature routing');
+
+console.log('housekeeping weekly lessons triage contract - PASS');

package/tests/install-rdc-skills.test.mjs

@@ -1,49 +1,49 @@
-#!/usr/bin/env node
-import assert from 'node:assert/strict';
-import { spawnSync } from 'node:child_process';
-import { readFileSync } from 'node:fs';
-import { dirname, join, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const REPO_ROOT = resolve(__dirname, '..');
-const script = join(REPO_ROOT, 'scripts', 'install-rdc-skills.js');
-
-const syntax = spawnSync(process.execPath, ['--check', script], { encoding: 'utf8' });
-assert.equal(syntax.status, 0, syntax.stderr);
-
-const toml = spawnSync(process.execPath, [script, '--self-test-codex-mcp-toml'], {
-  cwd: REPO_ROOT,
-  encoding: 'utf8',
-});
-assert.equal(toml.status, 0, `${toml.stdout}\n${toml.stderr}`);
-assert.match(toml.stdout, /PASS/);
-
-const source = readFileSync(script, 'utf8');
-const plugin = JSON.parse(readFileSync(join(REPO_ROOT, '.claude-plugin', 'plugin.json'), 'utf8'));
-const skillCount = Array.isArray(plugin.skills_meta)
-  ? plugin.skills_meta.length
-  : Object.keys(plugin.skills_meta || {}).length;
-assert.equal(skillCount, 30, 'test fixture should expose all 30 MCP skills from plugin skills_meta');
-assert.match(
-  source,
-  /Available MCP skills.*\/rdc:\* command shorthands/,
-  'installer should distinguish the full MCP skill catalog from slash-command shorthands',
-);
-assert.match(
-  source,
-  /Object\.keys\(plugin\.skills_meta\)\.length/,
-  'installer should count object-shaped skills_meta manifests',
-);
-assert.match(
-  source,
-  /rdc_skill_list, rdc_skill_search, and rdc_skill_get/,
-  'installer should point raw callers at the MCP discovery tools',
-);
-assert.match(
-  source,
-  /no plugin upload needed for MCP/,
-  'installer should not imply claude.ai MCP usage requires uploading an artifact',
-);
-
-console.log('install-rdc-skills tests — PASS');
+#!/usr/bin/env node
+import assert from 'node:assert/strict';
+import { spawnSync } from 'node:child_process';
+import { readFileSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const REPO_ROOT = resolve(__dirname, '..');
+const script = join(REPO_ROOT, 'scripts', 'install-rdc-skills.js');
+
+const syntax = spawnSync(process.execPath, ['--check', script], { encoding: 'utf8' });
+assert.equal(syntax.status, 0, syntax.stderr);
+
+const toml = spawnSync(process.execPath, [script, '--self-test-codex-mcp-toml'], {
+  cwd: REPO_ROOT,
+  encoding: 'utf8',
+});
+assert.equal(toml.status, 0, `${toml.stdout}\n${toml.stderr}`);
+assert.match(toml.stdout, /PASS/);
+
+const source = readFileSync(script, 'utf8');
+const plugin = JSON.parse(readFileSync(join(REPO_ROOT, '.claude-plugin', 'plugin.json'), 'utf8'));
+const skillCount = Array.isArray(plugin.skills_meta)
+  ? plugin.skills_meta.length
+  : Object.keys(plugin.skills_meta || {}).length;
+assert.equal(skillCount, 30, 'test fixture should expose all 30 MCP skills from plugin skills_meta');
+assert.match(
+  source,
+  /Available MCP skills.*\/rdc:\* command shorthands/,
+  'installer should distinguish the full MCP skill catalog from slash-command shorthands',
+);
+assert.match(
+  source,
+  /Object\.keys\(plugin\.skills_meta\)\.length/,
+  'installer should count object-shaped skills_meta manifests',
+);
+assert.match(
+  source,
+  /rdc_skill_list, rdc_skill_search, and rdc_skill_get/,
+  'installer should point raw callers at the MCP discovery tools',
+);
+assert.match(
+  source,
+  /no plugin upload needed for MCP/,
+  'installer should not imply claude.ai MCP usage requires uploading an artifact',
+);
+
+console.log('install-rdc-skills tests — PASS');

package/tests/lessons-pipeline-contract.test.mjs

@@ -0,0 +1,26 @@
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const root = join(fileURLToPath(new URL('..', import.meta.url)));
+const captureSkills = ['build', 'deploy', 'overnight', 'fixit', 'plan', 'preplan', 'review', 'release', 'collab'];
+
+for (const skill of captureSkills) {
+  const text = readFileSync(join(root, 'skills', skill, 'SKILL.md'), 'utf8');
+  assert.match(text, /lesson_status: open/, `${skill} must capture the canonical status key`);
+  assert.doesNotMatch(text, /and `status` \(`open`/, `${skill} must not emit the legacy status key`);
+}
+
+const guide = readFileSync(join(root, 'guides', 'lessons-learned-spec.md'), 'utf8');
+assert.match(guide, /Legacy status migration/);
+assert.match(guide, /`status` and no `lesson_status`/);
+
+const housekeeping = readFileSync(join(root, 'skills', 'housekeeping', 'SKILL.md'), 'utf8');
+assert.match(housekeeping, /When invoked with `--lessons`, skip every non-lessons maintenance section/);
+assert.match(housekeeping, /including Directory Structure Verification/);
+const legacyNormalization = housekeeping.indexOf('normalize every legacy lesson that has `status` but no `lesson_status`');
+const openFilter = housekeeping.indexOf('Then read all `.rdc/lessons/*.md` with `lesson_status: open`');
+assert.ok(legacyNormalization >= 0 && openFilter > legacyNormalization, 'legacy lessons must be normalized before the open-status filter');
+
+console.log('lessons pipeline contract test passed');

package/tests/manifest-contract-fields.test.mjs

@@ -1,78 +1,78 @@
-#!/usr/bin/env node
-import assert from 'node:assert/strict';
-import { existsSync, readdirSync, readFileSync } from 'node:fs';
-import { dirname, join, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const root = resolve(__dirname, '..');
-const manifest = JSON.parse(readFileSync(join(root, '.claude-plugin', 'plugin.json'), 'utf8'));
-const skillDirs = readdirSync(join(root, 'skills'), { withFileTypes: true })
-  .filter((entry) => entry.isDirectory() && entry.name !== 'tests')
-  .map((entry) => entry.name)
-  .sort();
-const metaNames = Object.keys(manifest.skills_meta).sort();
-const manifestSlashes = new Set(Object.values(manifest.skills_meta).map((meta) => meta.slash));
-
-assert.deepEqual(
-  metaNames,
-  skillDirs,
-  'Every skills/<name>/SKILL.md directory must have a skills_meta entry so MCP/help use explicit caller-facing terms',
-);
-
-function skillPath(name) {
-  const direct = join(root, 'skills', name, 'SKILL.md');
-  if (existsSync(direct)) return direct;
-  const prefixed = join(root, 'skills', `rdc-${name}`, 'SKILL.md');
-  if (existsSync(prefixed)) return prefixed;
-  return direct;
-}
-
-for (const [name, meta] of Object.entries(manifest.skills_meta)) {
-  const file = skillPath(name);
-  assert.equal(existsSync(file), true, `${name} must have a SKILL.md`);
-  const body = readFileSync(file, 'utf8');
-
-  assert.equal(meta.name, name, `${name} manifest name must match its skills_meta key`);
-  assert.doesNotMatch(meta.slash, /^rdc:rdc-/, `${name} slash command must not be a synthesized rdc:rdc-* name`);
-  assert.doesNotMatch(meta.slash, /^rdc:lifeai-/, `${name} slash command must not invent an rdc: prefix for non-rdc skills`);
-
-  const hasOutputContract = body.includes('guides/output-contract.md') || body.includes('OUTPUT CONTRACT');
-  assert.equal(
-    Boolean(meta.output_contract),
-    hasOutputContract,
-    `${name} manifest output_contract must match SKILL.md banner`,
-  );
-
-  if (body.includes('RDC_TEST=1')) {
-    assert.equal(meta.sandbox_aware, true, `${name} mentions RDC_TEST=1 and must be sandbox_aware`);
-  }
-
-  if (meta.sandbox_aware) {
-    assert.match(
-      body,
-      /Sandbox contract|RDC_TEST=1/,
-      `${name} is sandbox_aware and must explain the sandbox contract in SKILL.md`,
-    );
-  }
-}
-
-const testManifests = readdirSync(join(root, 'skills', 'tests'), { withFileTypes: true })
-  .filter((entry) => entry.isFile() && entry.name.endsWith('.test.json'));
-
-for (const entry of testManifests) {
-  const testPath = join(root, 'skills', 'tests', entry.name);
-  const test = JSON.parse(readFileSync(testPath, 'utf8'));
-  assert.equal(
-    manifestSlashes.has(test.skill),
-    true,
-    `${entry.name} skill "${test.skill}" must match a skills_meta[].slash value`,
-  );
-  assert.match(
-    test.fixture?.prompt || '',
-    new RegExp(`(^|\\s)${test.skill.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}(\\s|$)`),
-    `${entry.name} prompt must invoke its manifest skill name`,
-  );
-}
-
-console.log('manifest contract field tests — PASS');
+#!/usr/bin/env node
+import assert from 'node:assert/strict';
+import { existsSync, readdirSync, readFileSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const root = resolve(__dirname, '..');
+const manifest = JSON.parse(readFileSync(join(root, '.claude-plugin', 'plugin.json'), 'utf8'));
+const skillDirs = readdirSync(join(root, 'skills'), { withFileTypes: true })
+  .filter((entry) => entry.isDirectory() && entry.name !== 'tests')
+  .map((entry) => entry.name)
+  .sort();
+const metaNames = Object.keys(manifest.skills_meta).sort();
+const manifestSlashes = new Set(Object.values(manifest.skills_meta).map((meta) => meta.slash));
+
+assert.deepEqual(
+  metaNames,
+  skillDirs,
+  'Every skills/<name>/SKILL.md directory must have a skills_meta entry so MCP/help use explicit caller-facing terms',
+);
+
+function skillPath(name) {
+  const direct = join(root, 'skills', name, 'SKILL.md');
+  if (existsSync(direct)) return direct;
+  const prefixed = join(root, 'skills', `rdc-${name}`, 'SKILL.md');
+  if (existsSync(prefixed)) return prefixed;
+  return direct;
+}
+
+for (const [name, meta] of Object.entries(manifest.skills_meta)) {
+  const file = skillPath(name);
+  assert.equal(existsSync(file), true, `${name} must have a SKILL.md`);
+  const body = readFileSync(file, 'utf8');
+
+  assert.equal(meta.name, name, `${name} manifest name must match its skills_meta key`);
+  assert.doesNotMatch(meta.slash, /^rdc:rdc-/, `${name} slash command must not be a synthesized rdc:rdc-* name`);
+  assert.doesNotMatch(meta.slash, /^rdc:lifeai-/, `${name} slash command must not invent an rdc: prefix for non-rdc skills`);
+
+  const hasOutputContract = body.includes('guides/output-contract.md') || body.includes('OUTPUT CONTRACT');
+  assert.equal(
+    Boolean(meta.output_contract),
+    hasOutputContract,
+    `${name} manifest output_contract must match SKILL.md banner`,
+  );
+
+  if (body.includes('RDC_TEST=1')) {
+    assert.equal(meta.sandbox_aware, true, `${name} mentions RDC_TEST=1 and must be sandbox_aware`);
+  }
+
+  if (meta.sandbox_aware) {
+    assert.match(
+      body,
+      /Sandbox contract|RDC_TEST=1/,
+      `${name} is sandbox_aware and must explain the sandbox contract in SKILL.md`,
+    );
+  }
+}
+
+const testManifests = readdirSync(join(root, 'skills', 'tests'), { withFileTypes: true })
+  .filter((entry) => entry.isFile() && entry.name.endsWith('.test.json'));
+
+for (const entry of testManifests) {
+  const testPath = join(root, 'skills', 'tests', entry.name);
+  const test = JSON.parse(readFileSync(testPath, 'utf8'));
+  assert.equal(
+    manifestSlashes.has(test.skill),
+    true,
+    `${entry.name} skill "${test.skill}" must match a skills_meta[].slash value`,
+  );
+  assert.match(
+    test.fixture?.prompt || '',
+    new RegExp(`(^|\\s)${test.skill.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}(\\s|$)`),
+    `${entry.name} prompt must invoke its manifest skill name`,
+  );
+}
+
+console.log('manifest contract field tests — PASS');