@lidofinance/eslint-config 0.0.0 → 0.0.1

package/lib/build-config.js

@@ -23,7 +23,7 @@ const loosenReactRules = {
     'react/react-in-jsx-scope': 'off',
 }
 
-module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules, reactRules, defaultRules }) {
+module.exports = function buildConfig(env, { nextRules, tsRules, reactRules, defaultRules }) {
     const config = {
         extends: ['eslint:recommended'],
         env: {
@@ -107,7 +107,6 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
 
     if (env.typescript) {
         let tsconfigPath
-        const extraTsRules = {}
 
         try {
             // eslint-disable-next-line @typescript-eslint/unbound-method
@@ -115,6 +114,7 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
             // eslint-disable-next-line @typescript-eslint/unbound-method
             const { config } = ts.readConfigFile(tsconfigPath, ts.sys.readFile)
             if (config) {
+                // this are type-aware checks that require tsconfig presence
                 Object.assign(tsRules, {
                     '@typescript-eslint/await-thenable': 'warn',
                     '@typescript-eslint/no-floating-promises': 'error',
@@ -124,12 +124,12 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
                     '@typescript-eslint/no-unnecessary-type-assertion': 'warn',
                     'require-await': 'off',
                     '@typescript-eslint/require-await': 'error',
-                    '@typescript-eslint/restrict-plus-operands': 'warn',
                     '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
                 })
             }
-            if (config.compilerOptions?.strict) {
-                Object.assign(extraTsRules, {
+            if (config?.compilerOptions?.strict) {
+                Object.assign(tsRules, {
+                    '@typescript-eslint/restrict-plus-operands': 'warn',
                     '@typescript-eslint/no-explicit-any': 'error',
                     '@typescript-eslint/no-unsafe-argument': 'error',
                     '@typescript-eslint/no-unsafe-assignment': 'error',
@@ -166,7 +166,6 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
             rules: {
                 ...config.rules,
                 ...tsRules,
-                ...extraTsRules,
             },
             overrides: [
                 ...config.overrides,
@@ -176,9 +175,6 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
                 {
                     files: ['*.stories.ts', '*.stories.tsx', '*.stories.mts', '*.stories.cts'],
                     rules: {
-                        ...config.rules,
-                        ...tsDisableRules,
-                        ...tsRules,
                         ...loosenRules,
                     },
                 },
@@ -199,16 +195,13 @@ module.exports = function buildConfig(env, { nextRules, tsDisableRules, tsRules,
                     },
                     rules: {
                         ...loosenRules,
-                        ...config.rules,
-                        ...tsDisableRules,
-                        ...tsRules,
                         'jest/no-deprecated-functions': 'off',
                     },
                 },
                 {
                     files: ['*.ts', '*.tsx', '*.mts', '*.cts'],
                     rules: {
-                        ...tsDisableRules,
+                        ...tsRules,
                     },
                 },
             ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lidofinance/eslint-config",
-  "version": "0.0.0",
+  "version": "0.0.1",
   "main": "auto.js",
   "license": "unlicensed (yet)",
   "dependencies": {

package/rulesets/easy.js

@@ -2,8 +2,14 @@
 const defaultRules = {
     'prefer-const': 'warn',
     'no-useless-escape': 'warn',
-    'no-unused-vars': ['error', { ignoreRestSiblings: true }],
+    'no-unused-vars': ['error', {
+        ignoreRestSiblings: true,
+        args: "all",
+        argsIgnorePattern: "^_"
+    }],
+    'no-shadow': 'error',
     'no-empty-function': 'off',
+    'no-void': 'off',
     'promise/no-return-wrap': 'error',
     'promise/param-names': 'warn',
     // analysis/correctness
@@ -17,6 +23,8 @@ const defaultRules = {
     'import/no-named-as-default-member': 'off',
     'import/no-duplicates': 'off',
     'import/no-extraneous-dependencies': 'error',
+    "import/extensions": "off",
+    "import/prefer-default-export": "off",
     'sonarjs/max-switch-cases': 'error',
     'sonarjs/no-all-duplicated-branches': 'error',
     'sonarjs/no-collapsible-if': 'error',
@@ -113,7 +121,7 @@ const nextRules = {
     '@next/next/no-before-interactive-script-outside-document': 'warn',
     '@next/next/no-assign-module-variable': 'error',
 }
-const tsDisableRules = {
+const tsRules = {
     'import/named': 'off', // https://github.com/import-js/eslint-plugin-import/blob/main/config/typescript.js#L29
     'constructor-super': 'off', // ts(2335) & ts(2377)
     'getter-return': 'off', // ts(2378)
@@ -136,8 +144,6 @@ const tsDisableRules = {
     'prefer-rest-params': 'error', // ts provides better types with rest args over arguments
     'prefer-spread': 'error', // ts transpiles spread to apply, so no need for manual apply
     'valid-typeof': 'off', // ts(2367)
-}
-const tsRules = {
     '@typescript-eslint/adjacent-overload-signatures': 'error',
     '@typescript-eslint/ban-ts-comment': 'error',
     '@typescript-eslint/ban-types': 'error',
@@ -161,6 +167,10 @@ const tsRules = {
     '@typescript-eslint/no-unnecessary-type-constraint': 'warn',
     'no-unused-vars': 'off',
     '@typescript-eslint/no-unused-vars': defaultRules['no-unused-vars'],
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': defaultRules['no-shadow'],
+    'default-case': 'off',
+    '@typescript-eslint/switch-exhaustiveness-check': 'error',
     '@typescript-eslint/prefer-as-const': 'error',
     '@typescript-eslint/prefer-namespace-keyword': 'error',
     '@typescript-eslint/triple-slash-reference': 'error',
@@ -195,7 +205,6 @@ const reactRules = {
 
 module.exports = {
     nextRules,
-    tsDisableRules,
     tsRules,
     reactRules,
     defaultRules,

package/rulesets/hard.js

@@ -1,10 +1,9 @@
-const { nextRules, tsDisableRules, tsRules, reactRules, defaultRules } = require('./easy')
+const { nextRules, tsRules, reactRules, defaultRules } = require('./easy')
 
 module.exports = {
     nextRules: {
         ...nextRules,
     },
-    tsDisableRules,
     tsRules,
     reactRules: {
         ...reactRules,