@licklist/design 0.44.486-dev.39 → 0.44.486-dev.4

package/src/recurring-date-picker-input/RecurrenceIntervalAndFrequencyInput.tsx

@@ -1,9 +1,9 @@
-import React, { useEffect, useState } from "react";
+import React, { useEffect } from "react";
 import { DateTime } from "luxon";
 import { Col, Form, Row } from "react-bootstrap";
 import { useTranslation } from "react-i18next";
-import { RegisterOptions, useFormContext } from "react-hook-form";
-import { DATE_FORMAT } from "@licklist/core/dist/Config";
+import { useFormContext } from "react-hook-form";
+import { DATE_FORMAT, TIME_FULL_FORMAT } from "@licklist/core/dist/Config";
 import { RecurringDatePickerInputValues } from "./RecurringDatePickerInput";
 
 interface RecurrenceIntervalAndFrequencyInputProps {
@@ -11,17 +11,8 @@ interface RecurrenceIntervalAndFrequencyInputProps {
   minDate?: string;
   startDateLabel?: string;
   startTimeLabel?: string;
-  isProductSet?: boolean;
   endDateLabel?: string;
   endTimeLabel?: string;
-  startTimeRules?: Pick<
-    RegisterOptions,
-    "max" | "min" | "validate" | "required" | "pattern"
-  >;
-  endTimeRules?: Pick<
-    RegisterOptions,
-    "max" | "min" | "validate" | "required" | "pattern"
-  >;
 }
 
 function RecurrenceIntervalAndFrequencyInput({
@@ -31,18 +22,15 @@ function RecurrenceIntervalAndFrequencyInput({
   startTimeLabel,
   endDateLabel,
   endTimeLabel,
-  startTimeRules,
-  endTimeRules,
-  isProductSet,
 }: RecurrenceIntervalAndFrequencyInputProps) {
   const { t } = useTranslation(["Design", "Notification", "App"]);
 
   const {
     getValues,
-    setValue,
     formState: { errors },
     register,
     trigger,
+    setValue,
   } = useFormContext<RecurringDatePickerInputValues>();
 
   const startDate = getValues("startDate");
@@ -50,14 +38,6 @@ function RecurrenceIntervalAndFrequencyInput({
   const startTime = getValues("startTime");
   const endTime = getValues("endTime");
 
-  const [withOutEndDate, setWithOutEndDate] = useState<boolean>(!endDate);
-  const isProductSetWithoutEndDate = isProductSet && withOutEndDate;
-
-  const handleWithoutEndDate = () => {
-    setValue("endDate", "");
-    setWithOutEndDate((prevWithOutEndDateValue) => !prevWithOutEndDateValue);
-  };
-
   useEffect(() => {
     if (!startDate || !endDate) {
       return;
@@ -67,9 +47,6 @@ function RecurrenceIntervalAndFrequencyInput({
   }, [startDate]);
 
   useEffect(() => {
-    if (!startTime || !endTime) {
-      return;
-    }
     trigger("endTime");
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [startTime]);
@@ -101,7 +78,7 @@ function RecurrenceIntervalAndFrequencyInput({
             <Form.Control
               type="date"
               {...register("endDate", {
-                required: !isProductSetWithoutEndDate,
+                required: true,
                 validate: (date) => {
                   if (!startDate || !date) {
                     return true;
@@ -122,7 +99,7 @@ function RecurrenceIntervalAndFrequencyInput({
               })}
               defaultValue={endDate}
               className={endDate && "date-input-with-value"}
-              disabled={disabled || isProductSetWithoutEndDate}
+              disabled={disabled}
               min={startDate || undefined}
               isInvalid={Boolean(errors.endDate)}
             />
@@ -130,21 +107,6 @@ function RecurrenceIntervalAndFrequencyInput({
               {errors.endDate?.message}
             </Form.Control.Feedback>
           </Form.Group>
-          {isProductSet && (
-            <Form.Group className="custom-checkbox">
-              <Form.Check custom type="checkbox">
-                <Form.Check.Input
-                  type="checkbox"
-                  className="checkbox-input"
-                  checked={withOutEndDate}
-                  onChange={handleWithoutEndDate}
-                />
-                <Form.Check.Label>
-                  {t("Design:infiniteProductSet")}
-                </Form.Check.Label>
-              </Form.Check>
-            </Form.Group>
-          )}
         </Col>
       </Row>
 
@@ -156,15 +118,15 @@ function RecurrenceIntervalAndFrequencyInput({
             </Form.Label>
             <Form.Control
               type="time"
-              {...register("startTime", { required: false, ...startTimeRules })}
+              {...register("startTime", { required: false })}
+              onChange={({ target: { value } }) => {
+                setValue("startTime", `${value}:00`);
+              }}
               placeholder="hh:mm"
               defaultValue={startTime}
               disabled={disabled}
               isInvalid={Boolean(errors.startTime)}
             />
-            <Form.Control.Feedback type="invalid">
-              {errors.startTime?.message}
-            </Form.Control.Feedback>
           </Form.Group>
         </Col>
 
@@ -179,19 +141,28 @@ function RecurrenceIntervalAndFrequencyInput({
                   if (!startTime || !time) {
                     return true;
                   }
-                  const currentStartTime = DateTime.fromISO(startTime);
-                  const currentEndTime = DateTime.fromISO(time);
+                  const currentStartTime = DateTime.fromFormat(
+                    startTime,
+                    TIME_FULL_FORMAT
+                  );
+
+                  const currentEndTime = DateTime.fromFormat(
+                    time,
+                    TIME_FULL_FORMAT
+                  );
 
-                  return currentEndTime?.diff(currentStartTime, ["minutes"])
-                    ?.minutes >= 0
+                  return currentEndTime?.diff(currentStartTime, ["seconds"])
+                    ?.seconds > 0
                     ? true
                     : `${t(`Validation:fieldLaterDate`, {
                         attribute: t("Design:endTimeSmall"),
                         min: t("Design:startTimeSmall"),
                       })}`;
                 },
-                ...endTimeRules,
               })}
+              onChange={({ target: { value } }) => {
+                setValue("endTime", `${value}:59`, { shouldValidate: true });
+              }}
               placeholder="hh:mm"
               defaultValue={endTime}
               disabled={disabled}

package/src/recurring-date-picker-input/RecurringDatePickerInput.tsx

@@ -7,7 +7,6 @@ import { useIntl } from "react-intl";
 import {
   DATE_TIME_FORMAT,
   DATE_TIME_FULL_FORMAT,
-  TIME_FULL_FORMAT,
 } from "@licklist/core/dist/Config/Date";
 import { usePreviousValue } from "@licklist/plugins/dist/hooks/Value/usePreviousValue";
 import { FormProvider, useForm } from "react-hook-form";
@@ -26,7 +25,6 @@ export interface RecurringDatePickerInputProps {
   initialFrequency?: Frequency;
   setInitialStartDateAfterSelect?: boolean;
   minDate?: string;
-  isProductSet?: boolean;
 }
 
 export interface RecurringDatePickerInputValues {
@@ -40,7 +38,6 @@ export interface RecurringDatePickerInputValues {
   byweekday?: Weekday[];
   until?: Date;
   count?: number;
-  withOutEndDate?: boolean;
 }
 
 export function RecurringDatePickerInput({
@@ -52,7 +49,6 @@ export function RecurringDatePickerInput({
   setInitialStartDateAfterSelect = false,
   children,
   minDate,
-  isProductSet,
 }: PropsWithChildren<RecurringDatePickerInputProps>) {
   const { t } = useTranslation(["Design"]);
 
@@ -105,11 +101,6 @@ export function RecurringDatePickerInput({
         })
       : nextState.byweekday;
 
-    const endTimeNextState = nextState?.endTime
-      ? DateTime.fromISO(nextState?.endTime).toFormat(TIME_FULL_FORMAT)
-      : "";
-    const endDateNextState = nextState?.endDate ?? "";
-
     const rrule = RRule.optionsToString({
       // @TODO: investigate if we need these fields
       // dtstart: getDateTimeObject(startDate, startTime).toJSDate(),
@@ -124,8 +115,6 @@ export function RecurringDatePickerInput({
 
     onChange({
       ...nextState,
-      endDate: endDateNextState,
-      endTime: endTimeNextState,
       rrule,
     });
   };
@@ -190,7 +179,6 @@ export function RecurringDatePickerInput({
         <RecurrenceIntervalAndFrequencyInput
           disabled={disabled}
           minDate={minDate}
-          isProductSet={isProductSet}
         />
 
         {children}

package/src/report/form/ReportForm.tsx

@@ -15,7 +15,7 @@ export function ReportForm({
   onSubmit,
   onHide,
   hasPermission,
-}: ReportFormProps) {
+}: ReportFormProps): JSX.Element {
   const { t } = useTranslation(["App"]);
   const fromDateInput = useRef<HTMLInputDateElement | null>(null);
   const toDateInput = useRef<HTMLInputDateElement | null>(null);

package/src/sales/booking/results/components/ResultCard.tsx

@@ -3,7 +3,6 @@ import clsx from "clsx";
 import { useTranslation } from "react-i18next";
 import { DateTime } from "luxon";
 import { Order } from "@licklist/core/dist/DataMapper/Order/OrderDataMapper";
-import { TIME_FORMAT } from "@licklist/core/dist/Config";
 import { formatDateStringForEvent } from "@licklist/plugins/dist/utils/formatDate";
 import Icon from "../../../../static/Icon";
 
@@ -56,10 +55,10 @@ export const ResultCard = ({
             {t("status")}: {t(status)}
           </p>
           <p>
-            {t("date")}: {formatDateStringForEvent(startDate, false)}
+            {t("date")}: {formatDateStringForEvent(startDate)}
           </p>
           <p>
-            {t("time")}: {DateTime.fromISO(startDate).toFormat(TIME_FORMAT)}
+            {t("time")}: {DateTime.fromISO(startDate).toFormat("hh:MM")}
           </p>
         </div>
       </div>

package/src/snippet/snippet-template/preview/Preview.tsx

@@ -7,9 +7,6 @@ import {
   SNIPPET_TYPE_VENUE_MAP,
 } from "@licklist/core/dist/DataMapper/Provider/SnippetDataMapper";
 import { ProductSet } from "@licklist/core/dist/DataMapper/Product/ProductSetDataMapper";
-import { DateTime } from "luxon";
-import { Calendar, defaultStartDay } from "../../../calendar";
-import { getMonthCalendarDates } from "../../../calendar/utils";
 import { IframeEventCard } from "../../../iframe/event/event-card";
 import { SettingButton } from "../settings";
 import {
@@ -27,6 +24,7 @@ import {
 } from "../../../iframe";
 import { NumberInput } from "../../../iframe/order-process/components/CategoryProduct/components/NumberInput";
 import { SnippetTemplateContext } from "../context/snippetTemplate";
+import { EventCalendar } from "../../../iframe/event/event-calendar";
 
 const DEFAULT_IMAGE =
   "https://images.unsplash.com/photo-1638988319382-90e61be77c59?ixlib=rb-1.2.1&auto=format&fit=crop&w=687&q=80";
@@ -54,10 +52,6 @@ export function Preview({
     onSettingClick();
   };
 
-  const [currentDate, setCurrentDate] = useState<DateTime>(defaultStartDay);
-  const [selectedDate, setSelectedDate] = useState<DateTime | null>(null);
-  const calendarDates = getMonthCalendarDates(currentDate);
-
   return (
     <div className="w-100 h-100 snippet-template-preview">
       <Page
@@ -202,13 +196,7 @@ export function Preview({
                         className="mt-3 m-0"
                         containerClassName="mt-5 pt-5"
                       >
-                        <Calendar
-                          currentDate={currentDate}
-                          setCurrentDate={setCurrentDate}
-                          selectedDate={selectedDate}
-                          setSelectedDate={setSelectedDate}
-                          calendarDates={calendarDates}
-                        />
+                        <EventCalendar />
                       </SettingButton>
                     </div>
                     <div className="pt-4">

package/src/static/RestrictedAccess.tsx

@@ -4,7 +4,7 @@ import RouteService from "@licklist/plugins/dist/services/Route/RouteService";
 import { useTranslation } from "react-i18next";
 import Icon from "./Icon";
 
-function RestrictedAccess() {
+function RestrictedAccess(): JSX.Element {
   const { t } = useTranslation("Design");
 
   return (

package/src/static/form-number-input/FormNumberInput.tsx

@@ -15,7 +15,6 @@ interface FormNumberInputProps {
   label: string;
   fieldName: string;
   step?: number;
-  onChange?: (value: number) => void;
   disabled?: boolean;
   rules?: Pick<
     RegisterOptions,
@@ -29,7 +28,6 @@ export const FormNumberInput = ({
   step = 1,
   rules,
   disabled,
-  onChange,
 }: FormNumberInputProps) => {
   const controlId = useId();
   const { t } = useTranslation("Validation");
@@ -78,12 +76,7 @@ export const FormNumberInput = ({
               disabled={disabled}
               isInvalid={HookFormService.isInvalid(fieldName, errors)}
               {...field}
-              onChange={(event) => {
-                if (onChange) {
-                  onChange(Number(event.target.value));
-                }
-                field.onChange(Number(event.target.value));
-              }}
+              onChange={(event) => field.onChange(Number(event.target.value))}
               onFocus={onFocus}
             />
           )}

package/src/styles/form/CustomCheckbox.scss

@@ -1,7 +1,6 @@
 .custom-checkbox {
   margin-top: 1rem;
   display: flex;
-  z-index: 2;
   align-items: center;
 
   .custom-checkbox .custom-control-label::before {
@@ -22,8 +21,4 @@
     font-weight: 400;
     font-size: 0.875rem;
   }
-
-  .checkbox-input {
-    z-index: 2;
-  }
 }

package/src/styles/header/Header.scss

@@ -11,6 +11,10 @@
     }
   }
 
+  svg {
+    max-height: 1rem;
+  }
+
   .navbar-nav {
     line-height: 1;
     margin-top: 4px;

package/src/styles/{activity-card/GridActivitiesCard.scss → iframe-customers-journey/ActivitiesCard.scss}

@@ -11,7 +11,7 @@
   word-wrap: break-word;
   background-color: #fff;
   font-size: 0.8rem;
-  background-color: $snippet-product-set-background-color;
+  color: $snippet-elements-body-color;
 
   div {
     text-align: left;

package/{dist/styles/activity-card/ListActivitiesCard.scss → src/styles/iframe-customers-journey/ActivitiesSelectedCard.scss}

@@ -6,9 +6,8 @@
   align-items: center;
   cursor: pointer;
   height: 5rem;
-  padding: 0.375rem;
   border: 2px solid transparent;
-  border-radius: 0.5rem;
+  border: 2px solid transparent;
   background-color: $snippet-product-set-background-color;
   color: $snippet-product-set-font-color;
   transition: $color-transition;

package/src/styles/{date-time-button → iframe-customers-journey}/DateTimeButton.scss

@@ -86,12 +86,6 @@
     max-width: 5.3rem;
     min-height: 2.75rem;
   }
-
-  &.calendar-view {
-    min-width: auto;
-    max-width: none;
-    min-height: auto;
-  }
 }
 
 .time {
@@ -105,3 +99,15 @@
   font-weight: 300;
   color: $snippet-calendar-button-font-color;
 }
+
+.info {
+  display: flex;
+  justify-content: center;
+  font-weight: 300;
+  flex-direction: row;
+
+  .logo {
+    width: 0.5rem;
+    margin-right: 0.5rem;
+  }
+}

package/src/styles/iframe-customers-journey/_index.scss

@@ -0,0 +1,3 @@
+@import "./ActivitiesSelectedCard.scss";
+@import "./ActivitiesCard.scss";
+@import "./DateTimeButton.scss";

package/src/styles/iframe-events/Card.scss

@@ -142,7 +142,6 @@
     .card-body {
       padding: 0;
       margin: 0 0 auto;
-      margin-top: 1rem;
     }
   }
 

package/src/styles/iframe-page/PageBody.scss

@@ -199,8 +199,7 @@
         color: $snippet-elements-button-color;
         border: none;
         background-color: $snippet-elements-button-background-color;
-        box-shadow: 0 0 0 $input-btn-focus-width
-          $snippet-elements-button-background-color;
+        box-shadow: 0 0 0 $input-btn-focus-width $snippet-elements-button-background-color;
       }
 
       &:disabled {
@@ -235,7 +234,7 @@
     font-weight: 500;
     border-radius: 0.25rem;
     font-size: 0.875rem;
-    min-height: 2.25rem;
+    height: 2.25rem;
 
     &:focus {
       box-shadow: unset;

package/src/styles/notification/Notification.scss

@@ -15,10 +15,6 @@
       display: none !important;
     }
   }
-
-  &.is-invalid {
-    border-color: theme-color("danger");
-  }
 }
 
 .placeholder-row {

package/src/styles/packages.scss

@@ -13,6 +13,7 @@
 @import "./static";
 @import "./table";
 @import "./back-button";
+@import "./iframe-customers-journey";
 @import "./custom-fields";
 @import "./file-upload";
 @import "./iframe-events";
@@ -40,6 +41,3 @@
 @import "./striped-static-table/";
 @import "./image-radio-input/";
 @import "./radio-card/";
-@import "./activity-card/";
-@import "./date-time-button/";
-@import "./availability-indicator/";

package/src/styles/resources-blocking/_index.scss

@@ -7,11 +7,6 @@
     overflow: auto;
   }
 
-  .modal-form-content {
-    max-height: 21rem;
-    overflow-x: hidden;
-  }
-
   .reccurrence-interval-container {
     .form-group {
       margin-bottom: 0.5rem;

package/src/styles/themes/bookedit/_index.scss

@@ -46,7 +46,6 @@
 .header {
   background-color: color("white");
   padding: 0 2.5rem;
-  z-index: 2;
   min-height: 4rem;
   border-bottom: 1px solid #f0f0f0;
 }

package/src/typings.d.ts

@@ -28,14 +28,3 @@ declare module "*.json" {
 
 declare module "react-phone-number-input/input";
 declare module "react-phone-number-input/commonjs/Flag";
-
-// @TODO: this is a hofix for the following issue:
-// licklist_workspace_frontend/packages/design/src/product-set/hooks/useSortableTreeFunctions.ts(17,34):
-// semantic error TS2304: Cannot find name 'structuredClone'.
-interface WindowOrWorkerGlobalScope {
-  structuredClone(value: any, options?: StructuredSerializeOptions): any;
-}
-declare function structuredClone(
-  value: any,
-  options?: StructuredSerializeOptions
-): any;

package/src/zone/form/components/AvailableTimesControl.tsx

@@ -9,6 +9,7 @@ import { Form } from "react-bootstrap";
 import { UseFormSetError, useForm } from "react-hook-form";
 import { useId } from "@react-aria/utils";
 import { WorkHour } from "@licklist/core/dist/DataMapper/Provider/WorkHourDataMapper";
+import { calculateTimeWithOffset } from "@licklist/plugins/dist/utils/time";
 import { getCheckboxesByWorkHours } from "../utils/dates";
 
 export type AvailableTimesControlRef = {
@@ -61,18 +62,20 @@ export const AvailableTimesControl = forwardRef<
   });
 
   const onChange = (option: string) => {
-    const isAlreadyChecked = availableTimes.includes(option);
+    const timeWithOffset = calculateTimeWithOffset(option);
+
+    const isAlreadyChecked = availableTimes.includes(timeWithOffset);
 
     if (isAlreadyChecked) {
       setValue(
         "availableTimes",
-        availableTimes.filter((value) => value !== option)
+        availableTimes.filter((value) => value !== timeWithOffset)
       );
 
       return;
     }
 
-    setValue("availableTimes", [...availableTimes, option]);
+    setValue("availableTimes", [...availableTimes, timeWithOffset]);
   };
 
   useEffect(() => {
@@ -92,7 +95,9 @@ export const AvailableTimesControl = forwardRef<
               <Form.Check.Input
                 type="checkbox"
                 value={option}
-                checked={availableTimes.includes(option)}
+                checked={availableTimes.includes(
+                  calculateTimeWithOffset(option)
+                )}
                 onChange={() => onChange(option)}
                 disabled={isLoading}
               />

package/src/zone/form/components/ZoneControl.tsx

@@ -7,7 +7,6 @@ import { SortControl } from "./SortControl";
 import { ZoneRecurrencesControl } from "./ZoneRecurrencesControl";
 import { DescriptionControl } from "./DescriptionControl";
 import { ZoneImageControl } from "./ZoneImageControl";
-import { GameDurationControl } from "./GameDurationControl";
 
 export type ZoneControlProps = {
   isLoading: boolean;
@@ -28,7 +27,6 @@ export const ZoneControl = ({
           <Col md={6} sm={6}>
             <ZoneTypeControl isLoading={isLoading} />
             <SortControl isLoading={isLoading} />
-            <GameDurationControl isLoading={isLoading} />
           </Col>
           <Col md={6} sm={6}>
             <ZoneImageControl isLoading={isLoading} />

package/src/zone/form/components/ZoneRecurrencesControl.tsx

@@ -12,8 +12,11 @@ import {
 import { DndContext } from "@dnd-kit/core";
 import { WorkHour } from "@licklist/core/dist/DataMapper/Provider/WorkHourDataMapper";
 import { DateTime } from "luxon";
-import { TIME_FORMAT } from "@licklist/core/dist/Config";
-
+import { TIME_FORMAT, TIME_FULL_FORMAT } from "@licklist/core/dist/Config";
+import {
+  calculateTimeWithOffset,
+  DIRECTION_TO_LOCAL,
+} from "@licklist/plugins/dist/utils/time";
 import { CONFIRM_MODAL_ACTIONS } from "../../../modals/confirmation/ConfirmModal";
 import { Icon } from "../../../static";
 import {
@@ -64,6 +67,7 @@ export const ZoneRecurrencesControl = ({
   });
   const clearEditState = () => setEditState({ index: null, values: null });
   const [availableTimes, setAvailableTimes] = useState<string[]>([]);
+
   const popoverRef = useRef<HTMLDivElement>();
   const availableTimesFormRef = useRef<AvailableTimesControlRef>();
 
@@ -93,29 +97,30 @@ export const ZoneRecurrencesControl = ({
     if (!isAvailableTimesFormValid) {
       return;
     }
-    if (next?.startTime && next?.endTime) {
-      const startTime = DateTime.fromISO(next.startTime);
-      const endTime = DateTime.fromISO(next.endTime);
-      const { availableTimes } = availableTimesFormRef.current.getValues();
-      const validAvalilableTimes = availableTimes.every((time) => {
-        const currentAvailableTime = DateTime.fromFormat(time, TIME_FORMAT);
-
-        return (
-          currentAvailableTime.diff(startTime, "minutes").minutes >= 0 &&
-          currentAvailableTime.diff(endTime, "minutes").minutes <= 0
-        );
+    const startTime = DateTime.fromFormat(next.startTime, TIME_FULL_FORMAT);
+    const endTime = DateTime.fromFormat(next.endTime, TIME_FULL_FORMAT);
+    const { availableTimes } = availableTimesFormRef.current.getValues();
+    const validAvalilableTimes = availableTimes.every((time) => {
+      const currentAvailableTime = DateTime.fromFormat(
+        calculateTimeWithOffset(time, DIRECTION_TO_LOCAL),
+        TIME_FORMAT
+      );
+
+      return (
+        currentAvailableTime.diff(startTime, "minutes").minutes >= 0 &&
+        currentAvailableTime.diff(endTime, "minutes").minutes <= 0
+      );
+    });
+    if (!validAvalilableTimes) {
+      availableTimesFormRef.current.setError("availableTimes", {
+        message: t("Validation:fieldTimeBetween", {
+          attribute: t("Design:startTimesSmall"),
+          min: startTime.toFormat(TIME_FORMAT),
+          max: endTime.toFormat(TIME_FORMAT),
+        }),
       });
-      if (!validAvalilableTimes) {
-        availableTimesFormRef.current.setError("availableTimes", {
-          message: t("Validation:fieldTimeBetween", {
-            attribute: t("Design:startTimesSmall"),
-            min: startTime.toFormat(TIME_FORMAT),
-            max: endTime.toFormat(TIME_FORMAT),
-          }),
-        });
-
-        return;
-      }
+
+      return;
     }
     const values = {
       rrule: next.rrule,
@@ -143,9 +148,12 @@ export const ZoneRecurrencesControl = ({
   const handleOnEdit = (next: Partial<ZoneRecurrence>, index) => {
     clearEditState();
 
-    setEditState({ index, values: next });
-    setAvailableTimes(next.availableTimes || []);
-    setIsDatePopoverVisible(() => true);
+    // Hotfix for an issue with Popover close & open actions
+    setTimeout(() => {
+      setEditState({ index, values: next });
+      setAvailableTimes(next.availableTimes || []);
+      setIsDatePopoverVisible(() => true);
+    }, 100);
   };
 
   const handleOnAdd = () => {