@librechat/agents 3.4.6 → 3.5.0

package/src/messages/formatAgentMessages.reducer.test.ts

@@ -1,162 +0,0 @@
-import { convertMessagesToResponsesInput } from '@langchain/openai';
-import { Annotation, END, START, StateGraph } from '@langchain/langgraph';
-import { AIMessage, HumanMessage, ToolMessage } from '@langchain/core/messages';
-import type { BaseMessage } from '@langchain/core/messages';
-import { messagesStateReducer } from './reducer';
-import { formatAgentMessages } from './format';
-import { ContentTypes } from '@/common';
-
-const formatToolTurn = () =>
-  formatAgentMessages([
-    {
-      role: 'assistant',
-      messageId: 'msg_assistant_1',
-      content: [
-        {
-          type: ContentTypes.TEXT,
-          [ContentTypes.TEXT]: 'Running tool',
-          tool_call_ids: ['tool_1'],
-        },
-        {
-          type: ContentTypes.TOOL_CALL,
-          tool_call: {
-            id: 'tool_1',
-            name: 'search',
-            args: '{"query":"hello"}',
-            output: 'world',
-          },
-        },
-      ],
-    },
-  ]).messages;
-
-describe('formatAgentMessages reducer compatibility', () => {
-  it('does not expose derived message ids as OpenAI Responses item ids', () => {
-    const messages = formatAgentMessages([
-      {
-        role: 'assistant',
-        messageId: 'msg_provider_1',
-        content: [
-          {
-            type: ContentTypes.TEXT,
-            [ContentTypes.TEXT]: 'Running tool',
-            tool_call_ids: ['tool_1'],
-          },
-          {
-            type: ContentTypes.TOOL_CALL,
-            tool_call: {
-              id: 'tool_1',
-              name: 'search',
-              args: '{"query":"hello"}',
-              output: 'world',
-            },
-          },
-          {
-            type: ContentTypes.TEXT,
-            [ContentTypes.TEXT]: 'Finished',
-          },
-        ],
-      },
-    ]).messages;
-    const input = convertMessagesToResponsesInput({
-      messages,
-      zdrEnabled: false,
-      model: 'gpt-5.6',
-    });
-
-    expect(
-      input
-        .filter((item) => item.type === 'message')
-        .map((item) => ('id' in item ? item.id : undefined))
-    ).toEqual(['msg_provider_1', undefined]);
-  });
-
-  it('does not let a later source id replace a derived message', () => {
-    const messages = formatAgentMessages([
-      {
-        role: 'assistant',
-        messageId: 'a',
-        content: [
-          {
-            type: ContentTypes.TEXT,
-            [ContentTypes.TEXT]: 'Running tool',
-            tool_call_ids: ['tool_1'],
-          },
-          {
-            type: ContentTypes.TOOL_CALL,
-            tool_call: {
-              id: 'tool_1',
-              name: 'search',
-              args: '{"query":"hello"}',
-              output: 'world',
-            },
-          },
-        ],
-      },
-      {
-        role: 'user',
-        messageId: 'a:derived:1',
-        content: 'Continue',
-      },
-    ]).messages;
-
-    const merged = messagesStateReducer([], messages);
-
-    expect(merged).toHaveLength(3);
-    expect(merged[0]).toBeInstanceOf(AIMessage);
-    expect(merged[1]).toBeInstanceOf(ToolMessage);
-    expect(merged[2]).toBeInstanceOf(HumanMessage);
-  });
-
-  it('lets the reducer identify derived messages while retaining source correlation', () => {
-    const messages = formatToolTurn();
-
-    expect(messages).toHaveLength(2);
-    expect(messages[0]).toBeInstanceOf(AIMessage);
-    expect(messages[1]).toBeInstanceOf(ToolMessage);
-    expect(messages.map((message) => message.id)).toEqual([
-      'msg_assistant_1',
-      undefined,
-    ]);
-    expect(messages.map((message) => message.lc_kwargs.id)).toEqual([
-      'msg_assistant_1',
-      undefined,
-    ]);
-    expect(
-      messages.map((message) => message.additional_kwargs.sourceMessageId)
-    ).toEqual(['msg_assistant_1', 'msg_assistant_1']);
-
-    const merged = messagesStateReducer([], messages);
-    expect(merged).toHaveLength(2);
-    expect(merged[0]).toBeInstanceOf(AIMessage);
-    expect(merged[1]).toBeInstanceOf(ToolMessage);
-    expect(merged[0].id).toBe('msg_assistant_1');
-    expect(merged[1].id).toEqual(expect.any(String));
-    expect(merged[1].id).not.toBe(merged[0].id);
-  });
-
-  it('preserves the tool-call pair through a StateGraph input write', async () => {
-    const State = Annotation.Root({
-      messages: Annotation<BaseMessage[]>({
-        reducer: messagesStateReducer,
-        default: () => [],
-      }),
-    });
-    let observedMessages: BaseMessage[] = [];
-    const graph = new StateGraph(State)
-      .addNode('capture', (state) => {
-        observedMessages = state.messages;
-        return {};
-      })
-      .addEdge(START, 'capture')
-      .addEdge('capture', END)
-      .compile();
-
-    await graph.invoke({ messages: formatToolTurn() });
-
-    expect(observedMessages).toHaveLength(2);
-    expect(observedMessages[0]).toBeInstanceOf(AIMessage);
-    expect((observedMessages[0] as AIMessage).tool_calls).toHaveLength(1);
-    expect(observedMessages[1]).toBeInstanceOf(ToolMessage);
-  });
-});

package/src/messages/formatAgentMessages.skills.test.ts

@@ -1,513 +0,0 @@
-import { HumanMessage } from '@langchain/core/messages';
-import type { TPayload } from '@/types';
-import { ContentTypes, Constants } from '@/common';
-import { formatAgentMessages } from './format';
-
-/** Helper to build a skill tool_call content part */
-function skillToolCall(
-  id: string,
-  skillName: string,
-  output = 'Skill loaded.'
-): Record<string, unknown> {
-  return {
-    type: ContentTypes.TOOL_CALL,
-    tool_call: {
-      id,
-      name: Constants.SKILL_TOOL,
-      args: JSON.stringify({ skillName }),
-      output,
-    },
-  };
-}
-
-describe('formatAgentMessages skill body reconstruction', () => {
-  const skillBodies = new Map([
-    ['pdf-analyzer', '# PDF Analyzer\nAnalyze PDF files step by step.'],
-    ['code-review', '# Code Review\nReview the code for issues.'],
-  ]);
-
-  describe('with discoveredTools (tools filtering active)', () => {
-    const tools = new Set([Constants.SKILL_TOOL, 'web_search']);
-
-    it('reconstructs HumanMessage after skill ToolMessage', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Analyze this PDF' },
-        {
-          role: 'assistant',
-          content: [
-            {
-              type: ContentTypes.TEXT,
-              [ContentTypes.TEXT]: 'I\'ll invoke the skill.',
-              tool_call_ids: ['call_1'],
-            },
-            skillToolCall('call_1', 'pdf-analyzer'),
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      // user, AI, ToolMessage, injected HumanMessage
-      expect(messages.length).toBeGreaterThanOrEqual(4);
-      const last = messages[messages.length - 1];
-      expect(last).toBeInstanceOf(HumanMessage);
-      expect(last.content).toBe(
-        '# PDF Analyzer\nAnalyze PDF files step by step.'
-      );
-      expect((last as HumanMessage).additional_kwargs.source).toBe('skill');
-      expect((last as HumanMessage).additional_kwargs.skillName).toBe(
-        'pdf-analyzer'
-      );
-      expect((last as HumanMessage).additional_kwargs.isMeta).toBe(true);
-    });
-
-    it('does NOT inject body when skill tool is not in discoveredTools', () => {
-      const restrictedTools = new Set(['web_search']); // skill NOT allowed
-      const payload: TPayload = [
-        { role: 'user', content: 'Analyze this' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'pdf-analyzer')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        restrictedTools,
-        skillBodies
-      );
-
-      const humanMessages = messages.filter((m) => m instanceof HumanMessage);
-      // Only the user message, no injected skill body
-      expect(humanMessages).toHaveLength(1);
-    });
-
-    it('does not inject when skill name is not in skills Map', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Hello' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'unknown-skill')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const humanMessages = messages.filter((m) => m instanceof HumanMessage);
-      expect(humanMessages).toHaveLength(1); // only the user message
-    });
-  });
-
-  describe('without discoveredTools (no tools filtering)', () => {
-    it('reconstructs HumanMessage when skills Map provided', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Review my code' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'code-review')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        undefined,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(1);
-      expect(injected[0].content).toBe(
-        '# Code Review\nReview the code for issues.'
-      );
-    });
-
-    it('no injection when skills Map is undefined', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Hello' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'pdf-analyzer')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        undefined,
-        undefined
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(0);
-    });
-
-    it('no injection when skills Map is empty', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Hello' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'pdf-analyzer')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        undefined,
-        new Map()
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(0);
-    });
-  });
-
-  describe('extractSkillName edge cases', () => {
-    const tools = new Set([Constants.SKILL_TOOL]);
-
-    it('handles object args (not stringified)', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            {
-              type: ContentTypes.TOOL_CALL,
-              tool_call: {
-                id: 'call_1',
-                name: Constants.SKILL_TOOL,
-                args: { skillName: 'pdf-analyzer' }, // object, not string
-                output: 'Loaded.',
-              },
-            },
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(1);
-    });
-
-    it('gracefully skips malformed JSON args', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            {
-              type: ContentTypes.TOOL_CALL,
-              tool_call: {
-                id: 'call_1',
-                name: Constants.SKILL_TOOL,
-                args: '{bad json',
-                output: 'Loaded.',
-              },
-            },
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(0); // gracefully skipped
-    });
-
-    it('skips empty skillName', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            {
-              type: ContentTypes.TOOL_CALL,
-              tool_call: {
-                id: 'call_1',
-                name: Constants.SKILL_TOOL,
-                args: JSON.stringify({ skillName: '' }),
-                output: 'Loaded.',
-              },
-            },
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(0);
-    });
-  });
-
-  describe('deduplication', () => {
-    const tools = new Set([Constants.SKILL_TOOL]);
-
-    it('injects body only once when same skill invoked twice in one message', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            skillToolCall('call_1', 'pdf-analyzer'),
-            skillToolCall('call_2', 'pdf-analyzer'),
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(1);
-    });
-
-    it('injects body for each distinct skill invoked', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            skillToolCall('call_1', 'pdf-analyzer'),
-            skillToolCall('call_2', 'code-review'),
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies
-      );
-
-      const injected = messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-      expect(injected).toHaveLength(2);
-      const names = injected.map(
-        (m) => (m as HumanMessage).additional_kwargs.skillName
-      );
-      expect(names).toContain('pdf-analyzer');
-      expect(names).toContain('code-review');
-    });
-  });
-
-  describe('indexTokenCountMap distribution', () => {
-    const tools = new Set([Constants.SKILL_TOOL]);
-
-    it('excludes injected HumanMessages from assistant token distribution', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Analyze this' },
-        {
-          role: 'assistant',
-          content: [
-            {
-              type: ContentTypes.TEXT,
-              [ContentTypes.TEXT]: 'Invoking skill.',
-              tool_call_ids: ['call_1'],
-            },
-            skillToolCall('call_1', 'pdf-analyzer'),
-          ],
-        },
-      ];
-
-      const inputTokenMap: Record<number, number | undefined> = {
-        0: 100, // user message
-        1: 500, // assistant message
-      };
-
-      const { messages, indexTokenCountMap } = formatAgentMessages(
-        payload,
-        inputTokenMap,
-        tools,
-        skillBodies
-      );
-
-      // There should be messages: user, AI, ToolMessage, injected HumanMessage
-      expect(messages.length).toBeGreaterThanOrEqual(4);
-      const lastMsg = messages[messages.length - 1];
-      expect(lastMsg).toBeInstanceOf(HumanMessage);
-      expect((lastMsg as HumanMessage).additional_kwargs.source).toBe('skill');
-
-      // Token map must be defined when input was provided
-      expect(indexTokenCountMap).toBeDefined();
-
-      // The injected HumanMessage's index should NOT be in the token map
-      const injectedIndex = messages.length - 1;
-      expect(indexTokenCountMap![injectedIndex]).toBeUndefined();
-
-      // The assistant's 500 tokens should be distributed only across
-      // the AI + ToolMessage, NOT the injected HumanMessage
-      let assistantTotal = 0;
-      for (const [idx, count] of Object.entries(indexTokenCountMap!)) {
-        if (Number(idx) > 0 && Number(idx) < injectedIndex) {
-          assistantTotal += count ?? 0;
-        }
-      }
-      expect(assistantTotal).toBe(500);
-    });
-  });
-
-  describe('skipSkillBodyNames (fresh-prime dedupe)', () => {
-    const tools = new Set([Constants.SKILL_TOOL]);
-
-    const injectedSkillBodies = (
-      messages: ReturnType<typeof formatAgentMessages>['messages']
-    ) =>
-      messages.filter(
-        (m) =>
-          m instanceof HumanMessage &&
-          (m as HumanMessage).additional_kwargs.source === 'skill'
-      );
-
-    it('does NOT reconstruct body when skill name is in skipSkillBodyNames', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Review my code' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'code-review')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies,
-        { skipSkillBodyNames: new Set(['code-review']) }
-      );
-
-      expect(injectedSkillBodies(messages)).toHaveLength(0);
-    });
-
-    it('reconstructs only names NOT in skipSkillBodyNames', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Go' },
-        {
-          role: 'assistant',
-          content: [
-            skillToolCall('call_1', 'pdf-analyzer'),
-            skillToolCall('call_2', 'code-review'),
-          ],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies,
-        { skipSkillBodyNames: new Set(['code-review']) }
-      );
-
-      const injected = injectedSkillBodies(messages);
-      expect(injected).toHaveLength(1);
-      expect((injected[0] as HumanMessage).additional_kwargs.skillName).toBe(
-        'pdf-analyzer'
-      );
-    });
-
-    it('reconstructs normally when skipSkillBodyNames is empty', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Review my code' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'code-review')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        tools,
-        skillBodies,
-        { skipSkillBodyNames: new Set() }
-      );
-
-      expect(injectedSkillBodies(messages)).toHaveLength(1);
-    });
-
-    it('skips in the non-tools-filtering path too', () => {
-      const payload: TPayload = [
-        { role: 'user', content: 'Review my code' },
-        {
-          role: 'assistant',
-          content: [skillToolCall('call_1', 'code-review')],
-        },
-      ];
-
-      const { messages } = formatAgentMessages(
-        payload,
-        undefined,
-        undefined,
-        skillBodies,
-        { skipSkillBodyNames: new Set(['code-review']) }
-      );
-
-      expect(injectedSkillBodies(messages)).toHaveLength(0);
-    });
-  });
-});