@librechat/agents 3.1.89 → 3.1.91

package/src/tools/__tests__/subagentHooks.test.ts

@@ -4,6 +4,9 @@ import type { ToolCall } from '@langchain/core/messages/tool';
 import type * as t from '@/types';
 import type {
   HookCallback,
+  PermissionDeniedHookOutput,
+  PostToolUseHookOutput,
+  PreToolUseHookOutput,
   SubagentStartHookInput,
   SubagentStartHookOutput,
   SubagentStopHookInput,
@@ -11,6 +14,7 @@ import type {
 } from '@/hooks/types';
 import { HookRegistry } from '@/hooks/HookRegistry';
 import { Run } from '@/run';
+import { FakeChatModel } from '@/llm/fake';
 import {
   Constants,
   GraphEvents,
@@ -22,6 +26,18 @@ import * as providers from '@/llm/providers';
 
 const CHILD_RESPONSE = 'Hook test child response.';
 
+const calculatorDef: t.LCTool = {
+  name: 'calculator',
+  description: 'Evaluate a math expression.',
+  parameters: {
+    type: 'object',
+    properties: {
+      expression: { type: 'string' },
+    },
+    required: ['expression'],
+  },
+};
+
 const callerConfig = {
   configurable: { thread_id: 'hook-test-thread' },
   streamMode: 'values' as const,
@@ -66,6 +82,40 @@ function createParentAgent(): t.AgentInputs {
   };
 }
 
+function createParentAgentWithChildTool(): t.AgentInputs {
+  return {
+    agentId: 'hook-parent',
+    provider: Providers.OPENAI,
+    clientOptions: { modelName: 'gpt-4o-mini', apiKey: 'test-key' },
+    instructions: 'Delegate research tasks to subagents.',
+    maxContextTokens: 8000,
+    subagentConfigs: [
+      {
+        type: 'researcher',
+        name: 'Researcher',
+        description: 'Researches topics',
+        agentInputs: {
+          agentId: 'researcher-child',
+          provider: Providers.OPENAI,
+          clientOptions: { modelName: 'gpt-4o-mini', apiKey: 'test-key' },
+          instructions: 'Use calculator for arithmetic, then answer concisely.',
+          maxContextTokens: 8000,
+          toolDefinitions: [calculatorDef],
+        },
+      },
+    ],
+  };
+}
+
+function createCalculatorToolCall(): ToolCall {
+  return {
+    name: 'calculator',
+    args: { expression: '21 * 2' },
+    id: 'call_child_calculator',
+    type: 'tool_call',
+  };
+}
+
 async function createSubagentRun(
   hooks: HookRegistry,
   runId = `subagent-hook-${Date.now()}`
@@ -212,4 +262,191 @@ describe('Subagent hook integration (end-to-end via Run)', () => {
       'Blocked: policy violation'
     );
   });
+
+  it('PreToolUse and PostToolUse fire for event-driven tools inside subagents', async () => {
+    getChatModelClassSpy.mockImplementation(((provider: Providers) => {
+      if (provider === Providers.OPENAI) {
+        return class extends FakeChatModel {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          constructor(_options: any) {
+            super({
+              responses: ['Using calculator.', CHILD_RESPONSE],
+              sleep: 1,
+              toolCalls: [createCalculatorToolCall()],
+            });
+          }
+          bindTools(
+            tools: unknown
+          ): ReturnType<FakeChatModel['withConfig']> {
+            const config = {
+              tools,
+            } as Parameters<FakeChatModel['withConfig']>[0];
+            return this.withConfig(config);
+          }
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        } as any;
+      }
+      return originalGetChatModelClass(provider);
+    }) as typeof providers.getChatModelClass);
+
+    const registry = new HookRegistry();
+    const preToolEvents: string[] = [];
+    const postToolEvents: string[] = [];
+
+    const preHook: HookCallback<'PreToolUse'> = async (
+      input
+    ): Promise<PreToolUseHookOutput> => {
+      preToolEvents.push(`${input.agentId ?? '-'}:${input.toolName}`);
+      return { decision: 'allow' };
+    };
+    registry.register('PreToolUse', { hooks: [preHook] });
+
+    const postHook: HookCallback<'PostToolUse'> = async (
+      input
+    ): Promise<PostToolUseHookOutput> => {
+      postToolEvents.push(`${input.agentId ?? '-'}:${input.toolName}`);
+      return {};
+    };
+    registry.register('PostToolUse', { hooks: [postHook] });
+
+    const customHandlers: Record<string, t.EventHandler> = {
+      [GraphEvents.TOOL_END]: new ToolEndHandler(),
+      [GraphEvents.CHAT_MODEL_END]: new ModelEndHandler(),
+      [GraphEvents.ON_TOOL_EXECUTE]: {
+        handle: (_event, rawData): void => {
+          const request = rawData as t.ToolExecuteBatchRequest;
+          const results: t.ToolExecuteResult[] = request.toolCalls.map(
+            (call) => ({
+              toolCallId: call.id,
+              status: 'success',
+              content: '42',
+            })
+          );
+          request.resolve(results);
+        },
+      },
+    };
+
+    const run = await Run.create<t.IState>({
+      runId: `subagent-tool-hook-${Date.now()}`,
+      graphConfig: {
+        type: 'standard',
+        agents: [createParentAgentWithChildTool()],
+      },
+      returnContent: true,
+      skipCleanup: true,
+      customHandlers,
+      hooks: registry,
+    });
+
+    const tc = makeSubagentToolCall();
+    run.Graph!.overrideTestModel(['Delegating...', 'Final answer.'], 5, [tc]);
+
+    await run.processStream(
+      { messages: [new HumanMessage('calculate something')] },
+      callerConfig
+    );
+
+    expect(preToolEvents).toContain('-:subagent');
+    expect(preToolEvents).toContain('researcher-child:calculator');
+    expect(postToolEvents).toContain('-:subagent');
+    expect(postToolEvents).toContain('researcher-child:calculator');
+  });
+
+  it('child subagent tool ask hooks fail closed instead of starting unsupported nested HITL', async () => {
+    getChatModelClassSpy.mockImplementation(((provider: Providers) => {
+      if (provider === Providers.OPENAI) {
+        return class extends FakeChatModel {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          constructor(_options: any) {
+            super({
+              responses: ['Using calculator.', CHILD_RESPONSE],
+              sleep: 1,
+              toolCalls: [createCalculatorToolCall()],
+            });
+          }
+          bindTools(
+            tools: unknown
+          ): ReturnType<FakeChatModel['withConfig']> {
+            const config = {
+              tools,
+            } as Parameters<FakeChatModel['withConfig']>[0];
+            return this.withConfig(config);
+          }
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        } as any;
+      }
+      return originalGetChatModelClass(provider);
+    }) as typeof providers.getChatModelClass);
+
+    const registry = new HookRegistry();
+    const deniedTools: string[] = [];
+    const executedTools: string[] = [];
+
+    const preHook: HookCallback<'PreToolUse'> = async (
+      input
+    ): Promise<PreToolUseHookOutput> => {
+      if (input.toolName === 'calculator') {
+        return { decision: 'ask', reason: 'review calculator' };
+      }
+      return { decision: 'allow' };
+    };
+    registry.register('PreToolUse', { hooks: [preHook] });
+
+    const deniedHook: HookCallback<'PermissionDenied'> = async (
+      input
+    ): Promise<PermissionDeniedHookOutput> => {
+      deniedTools.push(
+        `${input.agentId ?? '-'}:${input.toolName}:${input.reason}`
+      );
+      return {};
+    };
+    registry.register('PermissionDenied', { hooks: [deniedHook] });
+
+    const customHandlers: Record<string, t.EventHandler> = {
+      [GraphEvents.TOOL_END]: new ToolEndHandler(),
+      [GraphEvents.CHAT_MODEL_END]: new ModelEndHandler(),
+      [GraphEvents.ON_TOOL_EXECUTE]: {
+        handle: (_event, rawData): void => {
+          const request = rawData as t.ToolExecuteBatchRequest;
+          executedTools.push(...request.toolCalls.map((call) => call.name));
+          const results: t.ToolExecuteResult[] = request.toolCalls.map(
+            (call) => ({
+              toolCallId: call.id,
+              status: 'success',
+              content: '42',
+            })
+          );
+          request.resolve(results);
+        },
+      },
+    };
+
+    const run = await Run.create<t.IState>({
+      runId: `subagent-tool-ask-${Date.now()}`,
+      graphConfig: {
+        type: 'standard',
+        agents: [createParentAgentWithChildTool()],
+      },
+      returnContent: true,
+      skipCleanup: true,
+      customHandlers,
+      hooks: registry,
+      humanInTheLoop: { enabled: true },
+    });
+
+    const tc = makeSubagentToolCall();
+    run.Graph!.overrideTestModel(['Delegating...', 'Final answer.'], 5, [tc]);
+
+    await run.processStream(
+      { messages: [new HumanMessage('calculate something')] },
+      callerConfig
+    );
+
+    expect(run.getInterrupt()).toBeUndefined();
+    expect(deniedTools).toContain(
+      'researcher-child:calculator:review calculator'
+    );
+    expect(executedTools).not.toContain('calculator');
+  });
 });