@librechat/agents 3.1.78 → 3.1.80-dev.0

package/dist/esm/tools/ToolNode.mjs

@@ -121,39 +121,69 @@ function normalizeApprovalDecisions(callIds, resumeValue) {
  *  - `artifact.session_id` (the `sessionId` arg here) is the EXEC session
  *    — the sandbox VM that ran the code. It's transient and torn down
  *    post-execution; subsequent calls cannot reuse it as a sandbox.
- *  - `file.session_id` on each `artifact.files[i]` is the STORAGE
+ *  - `file.storage_session_id` on each `artifact.files[i]` is the STORAGE
  *    session — the file-server bucket prefix where the artifact actually
  *    lives and is served from.
  *
- * Per-file `session_id` is preserved (not overwritten with the exec id)
- * because `_injected_files` are looked up against the file-server's
- * storage path on subsequent tool calls. Stomping the storage id with
- * the exec id silently 404s every follow-up tool call within the same
- * run — `cat /mnt/data/foo.txt` reports "No such file or directory"
- * because the worker can't mount a file at a path the storage doesn't
- * know about. Fall back to `sessionId` only when the per-file id is
- * absent (older worker payloads).
+ * Per-file `storage_session_id` is preserved (not overwritten with the
+ * exec id) because `_injected_files` are looked up against the
+ * file-server's storage path on subsequent tool calls. Stomping the
+ * storage id with the exec id silently 404s every follow-up tool call
+ * within the same run — `cat /mnt/data/foo.txt` reports "No such file
+ * or directory" because the worker can't mount a file at a path the
+ * storage doesn't know about. Fall back to the exec id only when the
+ * per-file id is absent (e.g. inline `content` files have no persistent
+ * storage location).
  */
-function updateCodeSession(sessions, sessionId, files) {
+/**
+ * Builds a `CodeEnvFile` ref from an arbitrary `FileRef`-like input,
+ * narrowing onto the discriminated union: `kind: 'skill'` requires
+ * `version`, other kinds forbid it.
+ *
+ * Defaults `kind` to `'user'` when unset — most ad-hoc files are
+ * user-private; shared resources (skills/agents) populate their kind
+ * upstream. A skill ref missing `version` falls back to `'user'` so
+ * the upstream contract bug surfaces as a degraded sessionKey rather
+ * than a runtime crash; primeSkillFiles is the only writer, and it
+ * always sets `version` — see LC packages/api/src/agents/skillFiles.ts.
+ */
+function toInjectedFileRef(file, execSessionId) {
+    const base = {
+        id: file.id,
+        name: file.name,
+        /* Inline `content` files have no persistent storage location;
+         * fall back to the execution session id for those entries. */
+        storage_session_id: file.storage_session_id ?? execSessionId,
+    };
+    const kind = file.kind ?? 'user';
+    if (kind === 'skill' && file.version != null) {
+        return { ...base, kind: 'skill', version: file.version };
+    }
+    if (kind === 'agent') {
+        return { ...base, kind: 'agent' };
+    }
+    return { ...base, kind: 'user' };
+}
+function updateCodeSession(sessions, execSessionId, files) {
     const newFiles = files ?? [];
     const existingSession = sessions.get(Constants.EXECUTE_CODE);
     const existingFiles = existingSession?.files ?? [];
     if (newFiles.length > 0) {
         const filesWithSession = newFiles.map((file) => ({
             ...file,
-            session_id: file.session_id ?? sessionId,
+            storage_session_id: file.storage_session_id ?? execSessionId,
         }));
         const newFileNames = new Set(filesWithSession.map((f) => f.name));
         const filteredExisting = existingFiles.filter((f) => !newFileNames.has(f.name));
         sessions.set(Constants.EXECUTE_CODE, {
-            session_id: sessionId,
+            session_id: execSessionId,
             files: [...filteredExisting, ...filesWithSession],
             lastUpdated: Date.now(),
         });
     }
     else {
         sessions.set(Constants.EXECUTE_CODE, {
-            session_id: sessionId,
+            session_id: execSessionId,
             files: existingFiles,
             lastUpdated: Date.now(),
         });
@@ -240,7 +270,10 @@ class ToolNode extends RunnableCallable {
         this.loadRuntimeTools = loadRuntimeTools;
         this.errorHandler = errorHandler;
         this.toolUsageCount = new Map();
-        this.toolRegistry = resolveLocalToolRegistry({ toolRegistry, toolExecution });
+        this.toolRegistry = resolveLocalToolRegistry({
+            toolRegistry,
+            toolExecution,
+        });
         this.sessions = sessions;
         this.eventDrivenMode = eventDrivenMode ?? false;
         this.agentId = agentId;
@@ -507,19 +540,14 @@ class ToolNode extends RunnableCallable {
              */
             if (CODE_EXECUTION_TOOLS.has(call.name)) {
                 const codeSession = this.sessions?.get(Constants.EXECUTE_CODE);
-                if (codeSession?.session_id != null && codeSession.session_id !== '') {
+                const execSessionId = codeSession?.session_id;
+                if (execSessionId != null && execSessionId !== '') {
                     invokeParams = {
                         ...invokeParams,
-                        session_id: codeSession.session_id,
+                        session_id: execSessionId,
                     };
-                    if (codeSession.files != null && codeSession.files.length > 0) {
-                        const fileRefs = codeSession.files.map((file) => ({
-                            session_id: file.session_id ?? codeSession.session_id,
-                            id: file.id,
-                            name: file.name,
-                            ...(file.entity_id != null ? { entity_id: file.entity_id } : {}),
-                        }));
-                        invokeParams._injected_files = fileRefs;
+                    if (codeSession?.files != null && codeSession.files.length > 0) {
+                        invokeParams._injected_files = codeSession.files.map((file) => toInjectedFileRef(file, execSessionId));
                     }
                 }
             }
@@ -735,8 +763,7 @@ class ToolNode extends RunnableCallable {
         // survives `run()`'s clear, so a resume sees the original
         // assignment.)
         const cachedTurn = call.id != null && call.id !== ''
-            ? this.directPathTurns.get(call.id) ??
-                this.toolCallTurns.get(call.id)
+            ? (this.directPathTurns.get(call.id) ?? this.toolCallTurns.get(call.id))
             : undefined;
         if (cachedTurn != null) {
             usageCount = cachedTurn;
@@ -872,9 +899,7 @@ class ToolNode extends RunnableCallable {
                         return this.blockDirectCall({
                             call,
                             resolvedArgs,
-                            reason: decision.reason ??
-                                preResult.reason ??
-                                'Rejected by user',
+                            reason: decision.reason ?? preResult.reason ?? 'Rejected by user',
                             hookRegistry,
                             runId,
                             threadId,
@@ -1133,16 +1158,12 @@ class ToolNode extends RunnableCallable {
         if (!codeSession) {
             return undefined;
         }
+        const execSessionId = codeSession.session_id;
         const context = {
-            session_id: codeSession.session_id,
+            session_id: execSessionId,
         };
         if (codeSession.files && codeSession.files.length > 0) {
-            context.files = codeSession.files.map((file) => ({
-                session_id: file.session_id ?? codeSession.session_id,
-                id: file.id,
-                name: file.name,
-                ...(file.entity_id != null ? { entity_id: file.entity_id } : {}),
-            }));
+            context.files = codeSession.files.map((file) => toInjectedFileRef(file, execSessionId));
         }
         return context;
     }
@@ -1167,10 +1188,11 @@ class ToolNode extends RunnableCallable {
                 continue;
             }
             const artifact = result.artifact;
-            if (artifact?.session_id == null || artifact.session_id === '') {
+            const execSessionId = artifact?.session_id;
+            if (execSessionId == null || execSessionId === '') {
                 continue;
             }
-            updateCodeSession(this.sessions, artifact.session_id, artifact.files);
+            updateCodeSession(this.sessions, execSessionId, artifact?.files);
         }
     }
     /**
@@ -1203,8 +1225,9 @@ class ToolNode extends RunnableCallable {
             }
             if (this.sessions && CODE_EXECUTION_TOOLS.has(call.name)) {
                 const artifact = toolMessage.artifact;
-                if (artifact?.session_id != null && artifact.session_id !== '') {
-                    updateCodeSession(this.sessions, artifact.session_id, artifact.files);
+                const execSessionId = artifact?.session_id;
+                if (execSessionId != null && execSessionId !== '') {
+                    updateCodeSession(this.sessions, execSessionId, artifact?.files);
                 }
             }
             // Dispatch ON_RUN_STEP_COMPLETED via custom event (same path as dispatchToolEvents)