@libp2p/yamux 7.0.4 → 8.0.0-55b7e5fea

package/src/muxer.ts

@@ -449,7 +449,8 @@ export class YamuxMuxer extends AbstractStreamMuxer<YamuxStream> {
         flag: Flag.RST,
         streamID: id,
         length: 0
-      }); return
+      })
+      return
     }
 
     // allocate a new stream
@@ -465,7 +466,7 @@ export class YamuxMuxer extends AbstractStreamMuxer<YamuxStream> {
     let encoded: Uint8Array | Uint8ArrayList
 
     if (header.type === FrameType.Data) {
-      if (data === undefined) {
+      if (data == null) {
         throw new InvalidFrameError('Invalid frame')
       }
 

package/src/stream.ts

@@ -1,7 +1,6 @@
 import { AbstractStream } from '@libp2p/utils'
 import { Uint8ArrayList } from 'uint8arraylist'
-import { defaultConfig } from './config.js'
-import { INITIAL_STREAM_WINDOW } from './constants.js'
+import { INITIAL_STREAM_WINDOW, MAX_STREAM_WINDOW } from './constants.js'
 import { isDataFrame } from './decode.ts'
 import { InvalidFrameError, ReceiveWindowExceededError } from './errors.js'
 import { Flag, FrameType, HEADER_LENGTH } from './frame.js'
@@ -53,17 +52,19 @@ export class YamuxStream extends AbstractStream {
   private readonly sendFrame: (header: FrameHeader, body?: Uint8ArrayList) => boolean
 
   constructor (init: YamuxStreamInit) {
+    const initialWindowSize = init.initialStreamWindowSize ?? INITIAL_STREAM_WINDOW
+
     super({
       ...init,
-      maxMessageSize: (init.maxMessageSize ?? defaultConfig.maxMessageSize) - HEADER_LENGTH
+      maxMessageSize: initialWindowSize - HEADER_LENGTH
     })
 
     this.streamId = init.streamId
     this.state = init.state
-    this.sendWindowCapacity = INITIAL_STREAM_WINDOW
-    this.recvWindow = init.initialStreamWindowSize ?? defaultConfig.initialStreamWindowSize
+    this.sendWindowCapacity = initialWindowSize
+    this.recvWindow = initialWindowSize
     this.recvWindowCapacity = this.recvWindow
-    this.maxStreamWindowSize = init.maxStreamWindowSize ?? defaultConfig.maxStreamWindowSize
+    this.maxStreamWindowSize = init.maxStreamWindowSize ?? MAX_STREAM_WINDOW
     this.epochStart = Date.now()
     this.getRTT = init.getRTT
     this.sendFrame = init.sendFrame
@@ -82,34 +83,37 @@ export class YamuxStream extends AbstractStream {
     let sentBytes = 0
     let canSendMore = true
 
+    this.log?.trace('send window capacity is %d bytes', this.sendWindowCapacity)
+
     // send in chunks, waiting for window updates
-    while (buf.byteLength !== 0) {
+    while (buf.byteLength > 0) {
       // we exhausted the send window, sending will resume later
       if (this.sendWindowCapacity === 0) {
         canSendMore = false
-        this.log?.trace('sent %d/%d bytes, wait for send window update, status %s', sentBytes, totalBytes, this.status)
+        this.log?.trace('sent %d/%d bytes, exhausted send window, waiting for window update', sentBytes, totalBytes)
         break
       }
 
       // send as much as we can
-      const toSend = Math.min(this.sendWindowCapacity, buf.length)
+      const toSend = Math.min(this.sendWindowCapacity, buf.byteLength)
       const flags = this.getSendFlags()
 
+      const data = buf.sublist(0, toSend)
+      buf.consume(toSend)
+
       const muxerSendMore = this.sendFrame({
         type: FrameType.Data,
         flag: flags,
         streamID: this.streamId,
         length: toSend
-      }, buf.sublist(0, toSend))
+      }, data)
 
       this.sendWindowCapacity -= toSend
-
       sentBytes += toSend
-      buf.consume(toSend)
 
       if (!muxerSendMore) {
         canSendMore = muxerSendMore
-        this.log('sent %d/%d bytes, wait for muxer to have more send capacity', sentBytes, totalBytes)
+        this.log.trace('sent %d/%d bytes, wait for muxer to have more send capacity', sentBytes, totalBytes)
         break
       }
     }
@@ -177,12 +181,23 @@ export class YamuxStream extends AbstractStream {
     this.processFlags(frame.header.flag)
 
     // increase send window
-    const available = this.sendWindowCapacity
     this.sendWindowCapacity += frame.header.length
 
-    // if the update increments a 0 availability, notify the stream that sending can resume
-    if (available === 0 && frame.header.length > 0) {
-      this.log?.trace('window update of %d bytes allows more data to be sent', frame.header.length)
+    // change the chunk size the superclass uses
+    this.maxMessageSize = this.sendWindowCapacity - HEADER_LENGTH
+
+    if (this.maxMessageSize < 0) {
+      this.maxMessageSize = 0
+    }
+
+    if (this.maxMessageSize === 0) {
+      return
+    }
+
+    // if writing is paused and the update increases our send window, notify
+    // writers that writing can resume
+    if (this.writeBuffer.byteLength > 0) {
+      this.log?.trace('window update of %d bytes allows more data to be sent, have %d bytes queued, sending data %s', frame.header.length, this.writeBuffer.byteLength, this.sendingData)
       this.safeDispatchEvent('drain')
     }
   }
@@ -252,6 +267,15 @@ export class YamuxStream extends AbstractStream {
    * place.
    */
   sendWindowUpdate (): void {
+    if (this.state === StreamState.Paused) {
+      // we don't want any more data from the remote right now - update the
+      // epoch start as otherwise when we unpause we'd be looking at the epoch
+      // start from before we were paused
+      this.epochStart = Date.now()
+
+      return
+    }
+
     // determine the flags if any
     const flags = this.getSendFlags()
 
@@ -260,7 +284,8 @@ export class YamuxStream extends AbstractStream {
     // then we (up to) double the recvWindow
     const now = Date.now()
     const rtt = this.getRTT()
-    if (flags === 0 && rtt > -1 && now - this.epochStart < rtt * 4) {
+
+    if (flags === 0 && rtt > -1 && (now - this.epochStart) <= (rtt * 4)) {
       // we've already validated that maxStreamWindowSize can't be more than MAX_UINT32
       this.recvWindow = Math.min(this.recvWindow * 2, this.maxStreamWindowSize)
     }
@@ -270,11 +295,6 @@ export class YamuxStream extends AbstractStream {
       return
     }
 
-    if (this.state === StreamState.Paused) {
-      // we don't want any more data from the remote right now
-      return
-    }
-
     // update the receive window
     const delta = this.recvWindow - this.recvWindowCapacity
     this.recvWindowCapacity = this.recvWindow