@libar-dev/architect 1.0.0-pre.3

package/dist/validation/anti-patterns.d.ts

@@ -0,0 +1,134 @@
+/**
+ * @architect
+ * @architect-validation
+ * @architect-pattern AntiPatternDetector
+ * @architect-status completed
+ * @architect-arch-role service
+ * @architect-arch-context validation
+ * @architect-arch-layer application
+ * @architect-uses DoDValidationTypes, GherkinTypes
+ * @architect-extract-shapes AntiPatternDetectionOptions, detectAntiPatterns, detectProcessInCode, detectMagicComments, detectScenarioBloat, detectMegaFeature, formatAntiPatternReport, toValidationIssues
+ *
+ * ## AntiPatternDetector - Documentation Anti-Pattern Detection
+ *
+ * Detects violations of the dual-source documentation architecture and
+ * process hygiene issues that lead to documentation drift.
+ *
+ * ### Anti-Patterns Detected
+ *
+ * | ID | Severity | Description |
+ * |----|----------|-------------|
+ * | tag-duplication | error | Dependencies in features (should be code-only) |
+ * | process-in-code | error | Process metadata in code (should be features-only) |
+ * | magic-comments | warning | Generator hints in features |
+ * | scenario-bloat | warning | Too many scenarios per feature |
+ * | mega-feature | warning | Feature file too large |
+ *
+ * ### When to Use
+ *
+ * - Pre-commit validation to catch architecture violations early
+ * - CI pipeline to enforce documentation standards
+ * - Code review checklists for documentation quality
+ */
+import type { ScannedGherkinFile } from '../validation-schemas/feature.js';
+import type { TagRegistry } from '../validation-schemas/tag-registry.js';
+import type { ScannedFile } from '../scanner/index.js';
+import type { AntiPatternViolation, AntiPatternThresholds, WithTagRegistry } from './types.js';
+export type { AntiPatternViolation, AntiPatternThresholds } from './types.js';
+/**
+ * Configuration options for anti-pattern detection
+ */
+export interface AntiPatternDetectionOptions extends WithTagRegistry {
+    /** Thresholds for warning triggers */
+    readonly thresholds?: Partial<AntiPatternThresholds>;
+}
+/**
+ * Detect process metadata in code anti-pattern
+ *
+ * Finds process tracking annotations (e.g., @architect-quarter, @architect-team, etc.)
+ * in TypeScript files. Process metadata belongs in feature files.
+ *
+ * @param scannedFiles - Array of scanned TypeScript files
+ * @param registry - Optional tag registry for prefix-aware detection (defaults to @architect-)
+ * @returns Array of anti-pattern violations
+ */
+export declare function detectProcessInCode(scannedFiles: readonly ScannedFile[], registry?: TagRegistry): AntiPatternViolation[];
+/**
+ * Detect magic comments anti-pattern
+ *
+ * Finds generator hints like "# GENERATOR:", "# PARSER:" in feature files.
+ * These create tight coupling between features and generators.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum magic comments before warning (default: 5)
+ * @returns Array of anti-pattern violations
+ */
+export declare function detectMagicComments(features: readonly ScannedGherkinFile[], threshold?: number): AntiPatternViolation[];
+/**
+ * Detect scenario bloat anti-pattern
+ *
+ * Finds feature files with too many scenarios, which indicates poor
+ * organization and slows test suites.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum scenarios before warning (default: 20)
+ * @returns Array of anti-pattern violations
+ */
+export declare function detectScenarioBloat(features: readonly ScannedGherkinFile[], threshold?: number): AntiPatternViolation[];
+/**
+ * Detect mega-feature anti-pattern
+ *
+ * Finds feature files that are too large, which makes them hard to
+ * maintain and review.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum lines before warning (default: 500)
+ * @returns Array of anti-pattern violations
+ */
+export declare function detectMegaFeature(features: readonly ScannedGherkinFile[], threshold?: number): AntiPatternViolation[];
+/**
+ * Detect all anti-patterns
+ *
+ * Runs all anti-pattern detectors and returns combined violations.
+ *
+ * @param scannedFiles - Array of scanned TypeScript files
+ * @param features - Array of scanned feature files
+ * @param options - Optional configuration (registry for prefix, thresholds)
+ * @returns Array of all detected anti-pattern violations
+ *
+ * @example
+ * ```typescript
+ * // With default prefix (@architect-)
+ * const violations = detectAntiPatterns(tsFiles, featureFiles);
+ *
+ * // With custom prefix
+ * const registry = createDefaultTagRegistry();
+ * registry.tagPrefix = "@architect-";
+ * const customViolations = detectAntiPatterns(tsFiles, featureFiles, { registry });
+ *
+ * for (const v of violations) {
+ *   console.log(`[${v.severity.toUpperCase()}] ${v.id}: ${v.message}`);
+ * }
+ * ```
+ */
+export declare function detectAntiPatterns(scannedFiles: readonly ScannedFile[], features: readonly ScannedGherkinFile[], options?: AntiPatternDetectionOptions): AntiPatternViolation[];
+/**
+ * Format anti-pattern violations for console output
+ *
+ * @param violations - Array of violations to format
+ * @returns Multi-line string for pretty printing
+ */
+export declare function formatAntiPatternReport(violations: AntiPatternViolation[]): string;
+/**
+ * Convert anti-pattern violations to ValidationIssue format
+ *
+ * For integration with the existing validate-patterns CLI.
+ */
+export declare function toValidationIssues(violations: readonly AntiPatternViolation[]): Array<{
+    severity: 'error' | 'warning' | 'info';
+    message: string;
+    source: 'typescript' | 'gherkin' | 'cross-source';
+    pattern?: string;
+    file?: string;
+}>;
+//# sourceMappingURL=anti-patterns.d.ts.map

package/dist/validation/anti-patterns.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"anti-patterns.d.ts","sourceRoot":"","sources":["../../src/validation/anti-patterns.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AAGH,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,kCAAkC,CAAC;AAC3E,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,uCAAuC,CAAC;AACzE,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AACvD,OAAO,KAAK,EAAE,oBAAoB,EAAE,qBAAqB,EAAE,eAAe,EAAE,MAAM,YAAY,CAAC;AAK/F,YAAY,EAAE,oBAAoB,EAAE,qBAAqB,EAAE,MAAM,YAAY,CAAC;AAoC9E;;GAEG;AACH,MAAM,WAAW,2BAA4B,SAAQ,eAAe;IAClE,sCAAsC;IACtC,QAAQ,CAAC,UAAU,CAAC,EAAE,OAAO,CAAC,qBAAqB,CAAC,CAAC;CACtD;AAED;;;;;;;;;GASG;AACH,wBAAgB,mBAAmB,CACjC,YAAY,EAAE,SAAS,WAAW,EAAE,EACpC,QAAQ,CAAC,EAAE,WAAW,GACrB,oBAAoB,EAAE,CA6BxB;AAED;;;;;;;;;GASG;AACH,wBAAgB,mBAAmB,CACjC,QAAQ,EAAE,SAAS,kBAAkB,EAAE,EACvC,SAAS,GAAE,MAAiD,GAC3D,oBAAoB,EAAE,CAoCxB;AAED;;;;;;;;;GASG;AACH,wBAAgB,mBAAmB,CACjC,QAAQ,EAAE,SAAS,kBAAkB,EAAE,EACvC,SAAS,GAAE,MAAkD,GAC5D,oBAAoB,EAAE,CAiBxB;AAED;;;;;;;;;GASG;AACH,wBAAgB,iBAAiB,CAC/B,QAAQ,EAAE,SAAS,kBAAkB,EAAE,EACvC,SAAS,GAAE,MAAoD,GAC9D,oBAAoB,EAAE,CAuBxB;AAED;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,wBAAgB,kBAAkB,CAChC,YAAY,EAAE,SAAS,WAAW,EAAE,EACpC,QAAQ,EAAE,SAAS,kBAAkB,EAAE,EACvC,OAAO,GAAE,2BAAgC,GACxC,oBAAoB,EAAE,CAexB;AAED;;;;;GAKG;AACH,wBAAgB,uBAAuB,CAAC,UAAU,EAAE,oBAAoB,EAAE,GAAG,MAAM,CA8ClF;AAED;;;;GAIG;AACH,wBAAgB,kBAAkB,CAAC,UAAU,EAAE,SAAS,oBAAoB,EAAE,GAAG,KAAK,CAAC;IACrF,QAAQ,EAAE,OAAO,GAAG,SAAS,GAAG,MAAM,CAAC;IACvC,OAAO,EAAE,MAAM,CAAC;IAChB,MAAM,EAAE,YAAY,GAAG,SAAS,GAAG,cAAc,CAAC;IAClD,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,CAAC,CAOD"}

package/dist/validation/anti-patterns.js

@@ -0,0 +1,307 @@
+/**
+ * @architect
+ * @architect-validation
+ * @architect-pattern AntiPatternDetector
+ * @architect-status completed
+ * @architect-arch-role service
+ * @architect-arch-context validation
+ * @architect-arch-layer application
+ * @architect-uses DoDValidationTypes, GherkinTypes
+ * @architect-extract-shapes AntiPatternDetectionOptions, detectAntiPatterns, detectProcessInCode, detectMagicComments, detectScenarioBloat, detectMegaFeature, formatAntiPatternReport, toValidationIssues
+ *
+ * ## AntiPatternDetector - Documentation Anti-Pattern Detection
+ *
+ * Detects violations of the dual-source documentation architecture and
+ * process hygiene issues that lead to documentation drift.
+ *
+ * ### Anti-Patterns Detected
+ *
+ * | ID | Severity | Description |
+ * |----|----------|-------------|
+ * | tag-duplication | error | Dependencies in features (should be code-only) |
+ * | process-in-code | error | Process metadata in code (should be features-only) |
+ * | magic-comments | warning | Generator hints in features |
+ * | scenario-bloat | warning | Too many scenarios per feature |
+ * | mega-feature | warning | Feature file too large |
+ *
+ * ### When to Use
+ *
+ * - Pre-commit validation to catch architecture violations early
+ * - CI pipeline to enforce documentation standards
+ * - Code review checklists for documentation quality
+ */
+import { readFileSync } from 'fs';
+import { DEFAULT_THRESHOLDS } from './types.js';
+import { DEFAULT_TAG_PREFIX } from '../config/defaults.js';
+/**
+ * Tag suffixes that should only appear in feature files, not TypeScript code.
+ * These are process metadata tags that track delivery workflow state.
+ */
+const FEATURE_ONLY_TAG_SUFFIXES = [
+    'quarter',
+    'team',
+    'effort',
+    'workflow',
+    'completed',
+    'effort-actual',
+];
+/**
+ * Builds feature-only annotation list from the tag prefix.
+ * These tags should appear in feature files, not TypeScript code.
+ *
+ * @param tagPrefix - The tag prefix (e.g., "@architect-" or "@acme-")
+ * @returns Array of full annotation strings (e.g., ["@architect-quarter", "@architect-team", ...])
+ */
+function buildFeatureOnlyAnnotations(tagPrefix) {
+    return FEATURE_ONLY_TAG_SUFFIXES.map((suffix) => `${tagPrefix}${suffix}`);
+}
+/**
+ * Magic comment patterns that indicate generator coupling
+ */
+const MAGIC_COMMENT_PATTERNS = [
+    /^#\s*GENERATOR:/i,
+    /^#\s*PARSER:/i,
+    /^#\s*AUTO-GEN:/i,
+    /^#\s*DO NOT EDIT/i,
+];
+/**
+ * Detect process metadata in code anti-pattern
+ *
+ * Finds process tracking annotations (e.g., @architect-quarter, @architect-team, etc.)
+ * in TypeScript files. Process metadata belongs in feature files.
+ *
+ * @param scannedFiles - Array of scanned TypeScript files
+ * @param registry - Optional tag registry for prefix-aware detection (defaults to @architect-)
+ * @returns Array of anti-pattern violations
+ */
+export function detectProcessInCode(scannedFiles, registry) {
+    const violations = [];
+    const tagPrefix = registry?.tagPrefix ?? DEFAULT_TAG_PREFIX;
+    const featureOnlyAnnotations = buildFeatureOnlyAnnotations(tagPrefix);
+    for (const file of scannedFiles) {
+        for (const { directive } of file.directives) {
+            // Check tags array for process annotations that shouldn't be in code
+            for (const tag of directive.tags) {
+                const normalizedTag = tag.toLowerCase();
+                for (const annotation of featureOnlyAnnotations) {
+                    if (normalizedTag === annotation.toLowerCase()) {
+                        // Extract the suffix part after the prefix
+                        const suffix = annotation.slice(tagPrefix.length);
+                        violations.push({
+                            id: 'process-in-code',
+                            message: `Annotation "${tag}" found in TypeScript code. Process metadata belongs in feature files.`,
+                            file: file.filePath,
+                            line: directive.position.startLine,
+                            severity: 'error',
+                            fix: `Move to corresponding .feature file using @architect-${suffix} tag.`,
+                        });
+                    }
+                }
+            }
+        }
+    }
+    return violations;
+}
+/**
+ * Detect magic comments anti-pattern
+ *
+ * Finds generator hints like "# GENERATOR:", "# PARSER:" in feature files.
+ * These create tight coupling between features and generators.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum magic comments before warning (default: 5)
+ * @returns Array of anti-pattern violations
+ */
+export function detectMagicComments(features, threshold = DEFAULT_THRESHOLDS.magicCommentThreshold) {
+    const violations = [];
+    for (const feature of features) {
+        try {
+            const content = readFileSync(feature.filePath, 'utf-8');
+            const lines = content.split('\n');
+            const magicComments = [];
+            for (let i = 0; i < lines.length; i++) {
+                const rawLine = lines[i];
+                if (!rawLine)
+                    continue;
+                const line = rawLine.trim();
+                for (const pattern of MAGIC_COMMENT_PATTERNS) {
+                    if (pattern.test(line)) {
+                        magicComments.push({ line: i + 1, text: line });
+                        break;
+                    }
+                }
+            }
+            if (magicComments.length > threshold) {
+                violations.push({
+                    id: 'magic-comments',
+                    message: `Feature file has ${magicComments.length} magic comments (threshold: ${threshold}). This creates tight coupling with generators.`,
+                    file: feature.filePath,
+                    severity: 'warning',
+                    fix: `Reduce generator hints. Use standard Gherkin tags and structured data instead.`,
+                });
+            }
+        }
+        catch {
+            // Ignore read errors - file may have been deleted
+        }
+    }
+    return violations;
+}
+/**
+ * Detect scenario bloat anti-pattern
+ *
+ * Finds feature files with too many scenarios, which indicates poor
+ * organization and slows test suites.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum scenarios before warning (default: 20)
+ * @returns Array of anti-pattern violations
+ */
+export function detectScenarioBloat(features, threshold = DEFAULT_THRESHOLDS.scenarioBloatThreshold) {
+    const violations = [];
+    for (const feature of features) {
+        const scenarioCount = feature.scenarios.length;
+        if (scenarioCount > threshold) {
+            violations.push({
+                id: 'scenario-bloat',
+                message: `Feature file has ${scenarioCount} scenarios (threshold: ${threshold}). Consider splitting by component or domain.`,
+                file: feature.filePath,
+                severity: 'warning',
+                fix: `Split into multiple .feature files organized by component, use case, or business capability.`,
+            });
+        }
+    }
+    return violations;
+}
+/**
+ * Detect mega-feature anti-pattern
+ *
+ * Finds feature files that are too large, which makes them hard to
+ * maintain and review.
+ *
+ * @param features - Array of scanned feature files
+ * @param threshold - Maximum lines before warning (default: 500)
+ * @returns Array of anti-pattern violations
+ */
+export function detectMegaFeature(features, threshold = DEFAULT_THRESHOLDS.megaFeatureLineThreshold) {
+    const violations = [];
+    for (const feature of features) {
+        try {
+            const content = readFileSync(feature.filePath, 'utf-8');
+            const lineCount = content.split('\n').length;
+            if (lineCount > threshold) {
+                violations.push({
+                    id: 'mega-feature',
+                    message: `Feature file has ${lineCount} lines (threshold: ${threshold}). Large files are hard to review and maintain.`,
+                    file: feature.filePath,
+                    severity: 'warning',
+                    fix: `Split into multiple smaller .feature files organized by component or business domain.`,
+                });
+            }
+        }
+        catch {
+            // Ignore read errors - file may have been deleted
+        }
+    }
+    return violations;
+}
+/**
+ * Detect all anti-patterns
+ *
+ * Runs all anti-pattern detectors and returns combined violations.
+ *
+ * @param scannedFiles - Array of scanned TypeScript files
+ * @param features - Array of scanned feature files
+ * @param options - Optional configuration (registry for prefix, thresholds)
+ * @returns Array of all detected anti-pattern violations
+ *
+ * @example
+ * ```typescript
+ * // With default prefix (@architect-)
+ * const violations = detectAntiPatterns(tsFiles, featureFiles);
+ *
+ * // With custom prefix
+ * const registry = createDefaultTagRegistry();
+ * registry.tagPrefix = "@architect-";
+ * const customViolations = detectAntiPatterns(tsFiles, featureFiles, { registry });
+ *
+ * for (const v of violations) {
+ *   console.log(`[${v.severity.toUpperCase()}] ${v.id}: ${v.message}`);
+ * }
+ * ```
+ */
+export function detectAntiPatterns(scannedFiles, features, options = {}) {
+    const { registry, thresholds = {} } = options;
+    const mergedThresholds = {
+        ...DEFAULT_THRESHOLDS,
+        ...thresholds,
+    };
+    return [
+        // Error-level (architectural violations)
+        ...detectProcessInCode(scannedFiles, registry),
+        // Warning-level (hygiene issues)
+        ...detectMagicComments(features, mergedThresholds.magicCommentThreshold),
+        ...detectScenarioBloat(features, mergedThresholds.scenarioBloatThreshold),
+        ...detectMegaFeature(features, mergedThresholds.megaFeatureLineThreshold),
+    ];
+}
+/**
+ * Format anti-pattern violations for console output
+ *
+ * @param violations - Array of violations to format
+ * @returns Multi-line string for pretty printing
+ */
+export function formatAntiPatternReport(violations) {
+    const lines = [];
+    lines.push('');
+    lines.push('Anti-Pattern Detection Report');
+    lines.push('=============================');
+    lines.push('');
+    if (violations.length === 0) {
+        lines.push('No anti-patterns detected.');
+        return lines.join('\n');
+    }
+    const errors = violations.filter((v) => v.severity === 'error');
+    const warnings = violations.filter((v) => v.severity === 'warning');
+    lines.push(`Total: ${violations.length} (${errors.length} errors, ${warnings.length} warnings)`);
+    lines.push('');
+    if (errors.length > 0) {
+        lines.push('Errors (architectural violations):');
+        for (const v of errors) {
+            lines.push(`  [ERROR] ${v.id}`);
+            lines.push(`          ${v.message}`);
+            lines.push(`          at ${v.file}${v.line !== undefined ? `:${v.line}` : ''}`);
+            if (v.fix) {
+                lines.push(`          Fix: ${v.fix}`);
+            }
+            lines.push('');
+        }
+    }
+    if (warnings.length > 0) {
+        lines.push('Warnings (hygiene issues):');
+        for (const v of warnings) {
+            lines.push(`  [WARN]  ${v.id}`);
+            lines.push(`          ${v.message}`);
+            lines.push(`          at ${v.file}${v.line !== undefined ? `:${v.line}` : ''}`);
+            if (v.fix) {
+                lines.push(`          Fix: ${v.fix}`);
+            }
+            lines.push('');
+        }
+    }
+    return lines.join('\n');
+}
+/**
+ * Convert anti-pattern violations to ValidationIssue format
+ *
+ * For integration with the existing validate-patterns CLI.
+ */
+export function toValidationIssues(violations) {
+    return violations.map((v) => ({
+        severity: v.severity,
+        message: `[${v.id}] ${v.message}`,
+        source: v.id === 'process-in-code' ? 'typescript' : 'gherkin',
+        file: v.file,
+    }));
+}
+//# sourceMappingURL=anti-patterns.js.map

package/dist/validation/anti-patterns.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"anti-patterns.js","sourceRoot":"","sources":["../../src/validation/anti-patterns.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AAEH,OAAO,EAAE,YAAY,EAAE,MAAM,IAAI,CAAC;AAKlC,OAAO,EAAE,kBAAkB,EAAE,MAAM,YAAY,CAAC;AAChD,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAK3D;;;GAGG;AACH,MAAM,yBAAyB,GAAG;IAChC,SAAS;IACT,MAAM;IACN,QAAQ;IACR,UAAU;IACV,WAAW;IACX,eAAe;CACP,CAAC;AAEX;;;;;;GAMG;AACH,SAAS,2BAA2B,CAAC,SAAiB;IACpD,OAAO,yBAAyB,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,GAAG,SAAS,GAAG,MAAM,EAAE,CAAC,CAAC;AAC5E,CAAC;AAED;;GAEG;AACH,MAAM,sBAAsB,GAAG;IAC7B,kBAAkB;IAClB,eAAe;IACf,iBAAiB;IACjB,mBAAmB;CACX,CAAC;AAUX;;;;;;;;;GASG;AACH,MAAM,UAAU,mBAAmB,CACjC,YAAoC,EACpC,QAAsB;IAEtB,MAAM,UAAU,GAA2B,EAAE,CAAC;IAC9C,MAAM,SAAS,GAAG,QAAQ,EAAE,SAAS,IAAI,kBAAkB,CAAC;IAC5D,MAAM,sBAAsB,GAAG,2BAA2B,CAAC,SAAS,CAAC,CAAC;IAEtE,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;QAChC,KAAK,MAAM,EAAE,SAAS,EAAE,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;YAC5C,qEAAqE;YACrE,KAAK,MAAM,GAAG,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC;gBACjC,MAAM,aAAa,GAAI,GAAc,CAAC,WAAW,EAAE,CAAC;gBACpD,KAAK,MAAM,UAAU,IAAI,sBAAsB,EAAE,CAAC;oBAChD,IAAI,aAAa,KAAK,UAAU,CAAC,WAAW,EAAE,EAAE,CAAC;wBAC/C,2CAA2C;wBAC3C,MAAM,MAAM,GAAG,UAAU,CAAC,KAAK,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;wBAClD,UAAU,CAAC,IAAI,CAAC;4BACd,EAAE,EAAE,iBAAiB;4BACrB,OAAO,EAAE,eAAe,GAAG,wEAAwE;4BACnG,IAAI,EAAE,IAAI,CAAC,QAAQ;4BACnB,IAAI,EAAE,SAAS,CAAC,QAAQ,CAAC,SAAS;4BAClC,QAAQ,EAAE,OAAO;4BACjB,GAAG,EAAE,wDAAwD,MAAM,OAAO;yBAC3E,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,mBAAmB,CACjC,QAAuC,EACvC,YAAoB,kBAAkB,CAAC,qBAAqB;IAE5D,MAAM,UAAU,GAA2B,EAAE,CAAC;IAE9C,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,IAAI,CAAC;YACH,MAAM,OAAO,GAAG,YAAY,CAAC,OAAO,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;YACxD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,aAAa,GAA0C,EAAE,CAAC;YAEhE,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACtC,MAAM,OAAO,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;gBACzB,IAAI,CAAC,OAAO;oBAAE,SAAS;gBACvB,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,EAAE,CAAC;gBAC5B,KAAK,MAAM,OAAO,IAAI,sBAAsB,EAAE,CAAC;oBAC7C,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;wBACvB,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;wBAChD,MAAM;oBACR,CAAC;gBACH,CAAC;YACH,CAAC;YAED,IAAI,aAAa,CAAC,MAAM,GAAG,SAAS,EAAE,CAAC;gBACrC,UAAU,CAAC,IAAI,CAAC;oBACd,EAAE,EAAE,gBAAgB;oBACpB,OAAO,EAAE,oBAAoB,aAAa,CAAC,MAAM,+BAA+B,SAAS,iDAAiD;oBAC1I,IAAI,EAAE,OAAO,CAAC,QAAQ;oBACtB,QAAQ,EAAE,SAAS;oBACnB,GAAG,EAAE,gFAAgF;iBACtF,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,kDAAkD;QACpD,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,mBAAmB,CACjC,QAAuC,EACvC,YAAoB,kBAAkB,CAAC,sBAAsB;IAE7D,MAAM,UAAU,GAA2B,EAAE,CAAC;IAE9C,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,MAAM,aAAa,GAAG,OAAO,CAAC,SAAS,CAAC,MAAM,CAAC;QAC/C,IAAI,aAAa,GAAG,SAAS,EAAE,CAAC;YAC9B,UAAU,CAAC,IAAI,CAAC;gBACd,EAAE,EAAE,gBAAgB;gBACpB,OAAO,EAAE,oBAAoB,aAAa,0BAA0B,SAAS,+CAA+C;gBAC5H,IAAI,EAAE,OAAO,CAAC,QAAQ;gBACtB,QAAQ,EAAE,SAAS;gBACnB,GAAG,EAAE,8FAA8F;aACpG,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,iBAAiB,CAC/B,QAAuC,EACvC,YAAoB,kBAAkB,CAAC,wBAAwB;IAE/D,MAAM,UAAU,GAA2B,EAAE,CAAC;IAE9C,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,IAAI,CAAC;YACH,MAAM,OAAO,GAAG,YAAY,CAAC,OAAO,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;YACxD,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;YAE7C,IAAI,SAAS,GAAG,SAAS,EAAE,CAAC;gBAC1B,UAAU,CAAC,IAAI,CAAC;oBACd,EAAE,EAAE,cAAc;oBAClB,OAAO,EAAE,oBAAoB,SAAS,sBAAsB,SAAS,iDAAiD;oBACtH,IAAI,EAAE,OAAO,CAAC,QAAQ;oBACtB,QAAQ,EAAE,SAAS;oBACnB,GAAG,EAAE,uFAAuF;iBAC7F,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,kDAAkD;QACpD,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AACH,MAAM,UAAU,kBAAkB,CAChC,YAAoC,EACpC,QAAuC,EACvC,UAAuC,EAAE;IAEzC,MAAM,EAAE,QAAQ,EAAE,UAAU,GAAG,EAAE,EAAE,GAAG,OAAO,CAAC;IAC9C,MAAM,gBAAgB,GAA0B;QAC9C,GAAG,kBAAkB;QACrB,GAAG,UAAU;KACd,CAAC;IAEF,OAAO;QACL,yCAAyC;QACzC,GAAG,mBAAmB,CAAC,YAAY,EAAE,QAAQ,CAAC;QAC9C,iCAAiC;QACjC,GAAG,mBAAmB,CAAC,QAAQ,EAAE,gBAAgB,CAAC,qBAAqB,CAAC;QACxE,GAAG,mBAAmB,CAAC,QAAQ,EAAE,gBAAgB,CAAC,sBAAsB,CAAC;QACzE,GAAG,iBAAiB,CAAC,QAAQ,EAAE,gBAAgB,CAAC,wBAAwB,CAAC;KAC1E,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,uBAAuB,CAAC,UAAkC;IACxE,MAAM,KAAK,GAAa,EAAE,CAAC;IAE3B,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACf,KAAK,CAAC,IAAI,CAAC,+BAA+B,CAAC,CAAC;IAC5C,KAAK,CAAC,IAAI,CAAC,+BAA+B,CAAC,CAAC;IAC5C,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC5B,KAAK,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAC;QACzC,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1B,CAAC;IAED,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;IAChE,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IAEpE,KAAK,CAAC,IAAI,CAAC,UAAU,UAAU,CAAC,MAAM,KAAK,MAAM,CAAC,MAAM,YAAY,QAAQ,CAAC,MAAM,YAAY,CAAC,CAAC;IACjG,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAEf,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACtB,KAAK,CAAC,IAAI,CAAC,oCAAoC,CAAC,CAAC;QACjD,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;YACvB,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAChC,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;YACrC,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC,IAAI,GAAG,CAAC,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAChF,IAAI,CAAC,CAAC,GAAG,EAAE,CAAC;gBACV,KAAK,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC,GAAG,EAAE,CAAC,CAAC;YACxC,CAAC;YACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACjB,CAAC;IACH,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,KAAK,CAAC,IAAI,CAAC,4BAA4B,CAAC,CAAC;QACzC,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;YACzB,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAChC,KAAK,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;YACrC,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC,IAAI,GAAG,CAAC,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAChF,IAAI,CAAC,CAAC,GAAG,EAAE,CAAC;gBACV,KAAK,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC,GAAG,EAAE,CAAC,CAAC;YACxC,CAAC;YACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACjB,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,kBAAkB,CAAC,UAA2C;IAO5E,OAAO,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;QAC5B,QAAQ,EAAE,CAAC,CAAC,QAAQ;QACpB,OAAO,EAAE,IAAI,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC,OAAO,EAAE;QACjC,MAAM,EAAE,CAAC,CAAC,EAAE,KAAK,iBAAiB,CAAC,CAAC,CAAE,YAAsB,CAAC,CAAC,CAAE,SAAmB;QACnF,IAAI,EAAE,CAAC,CAAC,IAAI;KACb,CAAC,CAAC,CAAC;AACN,CAAC"}

package/dist/validation/dod-validator.d.ts

@@ -0,0 +1,94 @@
+/**
+ * @architect
+ * @architect-validation
+ * @architect-pattern DoDValidator
+ * @architect-status completed
+ * @architect-arch-role service
+ * @architect-arch-context validation
+ * @architect-arch-layer application
+ * @architect-uses DoDValidationTypes, GherkinTypes, DualSourceExtractor
+ * @architect-extract-shapes isDeliverableComplete, hasAcceptanceCriteria, extractAcceptanceCriteriaScenarios, validateDoDForPhase, validateDoD, formatDoDSummary
+ *
+ * ## DoDValidator - Definition of Done Validation
+ *
+ * Validates that completed phases meet Definition of Done criteria:
+ * 1. All deliverables must be in a terminal state (complete, n/a, or superseded)
+ * 2. At least one @acceptance-criteria scenario must exist
+ *
+ * ### When to Use
+ *
+ * - Pre-release validation to ensure phases are truly complete
+ * - CI pipeline checks to prevent premature "done" declarations
+ * - Manual DoD checks during code review
+ */
+import type { Deliverable, ScannedGherkinFile } from '../validation-schemas/index.js';
+import type { DoDValidationResult, DoDValidationSummary } from './types.js';
+/**
+ * Check if a deliverable has "complete" status.
+ *
+ * This checks for the literal 'complete' status value only.
+ * For DoD validation (which also accepts 'n/a' and 'superseded'),
+ * see isDeliverableStatusTerminal().
+ *
+ * @param deliverable - The deliverable to check
+ * @returns True if the deliverable status is 'complete'
+ */
+export declare function isDeliverableComplete(deliverable: Deliverable): boolean;
+/**
+ * Check if a feature has @acceptance-criteria scenarios
+ *
+ * Scans scenarios for the @acceptance-criteria tag, which indicates
+ * BDD-driven acceptance tests.
+ *
+ * @param feature - The scanned feature file to check
+ * @returns True if at least one @acceptance-criteria scenario exists
+ */
+export declare function hasAcceptanceCriteria(feature: ScannedGherkinFile): boolean;
+/**
+ * Extract acceptance criteria scenario names from a feature
+ *
+ * @param feature - The scanned feature file
+ * @returns Array of scenario names with @acceptance-criteria tag
+ */
+export declare function extractAcceptanceCriteriaScenarios(feature: ScannedGherkinFile): readonly string[];
+/**
+ * Validate DoD for a single phase/pattern
+ *
+ * Checks:
+ * 1. All deliverables must be in a terminal state (complete, n/a, superseded)
+ * 2. At least one @acceptance-criteria scenario exists
+ *
+ * @param patternName - Name of the pattern being validated
+ * @param phase - Phase number being validated
+ * @param feature - The scanned feature file with deliverables and scenarios
+ * @returns DoD validation result
+ */
+export declare function validateDoDForPhase(patternName: string, phase: number, feature: ScannedGherkinFile): DoDValidationResult;
+/**
+ * Validate DoD across multiple phases
+ *
+ * Filters to completed phases and validates each against DoD criteria.
+ * Optionally filter to specific phases using phaseFilter.
+ *
+ * @param features - Array of scanned feature files
+ * @param phaseFilter - Optional array of phase numbers to validate (validates all if empty)
+ * @returns Aggregate DoD validation summary
+ *
+ * @example
+ * ```typescript
+ * // Validate all completed phases
+ * const summary = validateDoD(features);
+ *
+ * // Validate specific phase
+ * const summary = validateDoD(features, [14]);
+ * ```
+ */
+export declare function validateDoD(features: readonly ScannedGherkinFile[], phaseFilter?: readonly number[]): DoDValidationSummary;
+/**
+ * Format DoD validation summary for console output
+ *
+ * @param summary - DoD validation summary to format
+ * @returns Multi-line string for pretty printing
+ */
+export declare function formatDoDSummary(summary: DoDValidationSummary): string;
+//# sourceMappingURL=dod-validator.d.ts.map

package/dist/validation/dod-validator.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"dod-validator.d.ts","sourceRoot":"","sources":["../../src/validation/dod-validator.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;GAsBG;AAEH,OAAO,KAAK,EAAE,WAAW,EAAE,kBAAkB,EAAE,MAAM,gCAAgC,CAAC;AAEtF,OAAO,KAAK,EAAE,mBAAmB,EAAE,oBAAoB,EAAE,MAAM,YAAY,CAAC;AAO5E;;;;;;;;;GASG;AACH,wBAAgB,qBAAqB,CAAC,WAAW,EAAE,WAAW,GAAG,OAAO,CAEvE;AAED;;;;;;;;GAQG;AACH,wBAAgB,qBAAqB,CAAC,OAAO,EAAE,kBAAkB,GAAG,OAAO,CAI1E;AAED;;;;;GAKG;AACH,wBAAgB,kCAAkC,CAAC,OAAO,EAAE,kBAAkB,GAAG,SAAS,MAAM,EAAE,CAIjG;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,mBAAmB,CACjC,WAAW,EAAE,MAAM,EACnB,KAAK,EAAE,MAAM,EACb,OAAO,EAAE,kBAAkB,GAC1B,mBAAmB,CAwCrB;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAgB,WAAW,CACzB,QAAQ,EAAE,SAAS,kBAAkB,EAAE,EACvC,WAAW,GAAE,SAAS,MAAM,EAAO,GAClC,oBAAoB,CA8BtB;AAED;;;;;GAKG;AACH,wBAAgB,gBAAgB,CAAC,OAAO,EAAE,oBAAoB,GAAG,MAAM,CA8CtE"}