@lhremote/core 0.8.0 → 0.9.0

package/dist/operations/get-post.test.js

@@ -7,375 +7,51 @@ vi.mock("../cdp/discovery.js", () => ({
 vi.mock("../cdp/client.js", () => ({
     CDPClient: vi.fn(),
 }));
-vi.mock("../voyager/interceptor.js", () => ({
-    VoyagerInterceptor: vi.fn(),
+vi.mock("../utils/delay.js", () => ({
+    gaussianDelay: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("./navigate-away.js", () => ({
+    navigateAwayIf: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("./get-feed.js", () => ({
+    delay: vi.fn().mockResolvedValue(undefined),
+    parseTimestamp: vi.fn((raw) => {
+        if (!raw)
+            return null;
+        const asDate = Date.parse(raw);
+        if (!isNaN(asDate))
+            return asDate;
+        return null;
+    }),
 }));
 import { discoverTargets } from "../cdp/discovery.js";
 import { CDPClient } from "../cdp/client.js";
-import { VoyagerInterceptor } from "../voyager/interceptor.js";
-import { getPost, parseCommentsResponse, parseFeedUpdateResponse, resolveTextValue, } from "./get-post.js";
-describe("resolveTextValue", () => {
-    it("returns empty string for undefined", () => {
-        expect(resolveTextValue(undefined)).toBe("");
-    });
-    it("returns empty string for null", () => {
-        expect(resolveTextValue(null)).toBe("");
-    });
-    it("returns string value as-is", () => {
-        expect(resolveTextValue("hello")).toBe("hello");
-    });
-    it("extracts text from object with text field", () => {
-        expect(resolveTextValue({ text: "hello" })).toBe("hello");
-    });
-    it("returns empty string for object without text field", () => {
-        expect(resolveTextValue({})).toBe("");
-    });
-});
-describe("parseFeedUpdateResponse", () => {
-    const postUrn = "urn:li:activity:1234567890";
-    it("parses flat response with inline actor", () => {
-        const raw = {
-            actor: {
-                name: { text: "John Doe" },
-                description: { text: "Software Engineer" },
-                navigationUrl: "https://www.linkedin.com/in/johndoe",
-            },
-            commentary: { text: { text: "Hello world!" } },
-            publishedAt: 1700000000000,
-            socialDetail: {
-                totalSocialActivityCounts: {
-                    numLikes: 42,
-                    numComments: 5,
-                    numShares: 3,
-                },
-            },
-        };
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result).toEqual({
-            postUrn,
-            authorName: "John Doe",
-            authorHeadline: "Software Engineer",
-            authorPublicId: "johndoe",
-            text: "Hello world!",
-            publishedAt: 1700000000000,
-            reactionCount: 42,
-            commentCount: 5,
-            shareCount: 3,
-        });
-    });
-    it("parses nested data response", () => {
-        const raw = {
-            data: {
-                actor: {
-                    name: { text: "Jane Smith" },
-                    description: { text: "Product Manager" },
-                    publicIdentifier: "janesmith",
-                },
-                commentary: { text: { text: "Great post!" } },
-                publishedAt: 1700001000000,
-                socialDetail: {
-                    totalSocialActivityCounts: {
-                        numLikes: 10,
-                        numComments: 2,
-                        numShares: 1,
-                    },
-                },
-            },
-        };
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result.authorName).toBe("Jane Smith");
-        expect(result.authorPublicId).toBe("janesmith");
-        expect(result.text).toBe("Great post!");
-        expect(result.publishedAt).toBe(1700001000000);
-    });
-    it("parses data.elements array response", () => {
-        const raw = {
-            data: {
-                elements: [
-                    {
-                        actor: {
-                            name: { text: "Bob Johnson" },
-                            description: { text: "Developer" },
-                        },
-                        commentary: { text: { text: "First element" } },
-                        publishedAt: 1700002000000,
-                        socialDetail: {
-                            totalSocialActivityCounts: {
-                                numLikes: 5,
-                                numComments: 1,
-                                numShares: 0,
-                            },
-                        },
-                    },
-                ],
-            },
-        };
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result.authorName).toBe("Bob Johnson");
-        expect(result.text).toBe("First element");
-    });
-    it("resolves actor from URN reference via included", () => {
-        const actorUrn = "urn:li:member:999";
-        const raw = {
-            data: {
-                actor: actorUrn,
-                commentary: { text: { text: "Referenced actor" } },
-            },
-        };
-        const included = [
-            {
-                entityUrn: actorUrn,
-                firstName: "Alice",
-                lastName: "Williams",
-                publicIdentifier: "alicew",
-                headline: { text: "Engineer" },
-            },
-        ];
-        const result = parseFeedUpdateResponse(raw, postUrn, included);
-        expect(result.authorName).toBe("Alice Williams");
-        expect(result.authorPublicId).toBe("alicew");
-        expect(result.authorHeadline).toBe("Engineer");
-    });
-    it("resolves actor from *actor URN reference", () => {
-        const actorUrn = "urn:li:member:888";
-        const raw = {
-            data: {
-                "*actor": actorUrn,
-                commentary: { text: { text: "Star actor ref" } },
-            },
-        };
-        const included = [
-            {
-                entityUrn: actorUrn,
-                name: { text: "Star Actor" },
-                description: { text: "CTO" },
-                navigationUrl: "https://www.linkedin.com/in/staractor",
-            },
-        ];
-        const result = parseFeedUpdateResponse(raw, postUrn, included);
-        expect(result.authorName).toBe("Star Actor");
-        expect(result.authorPublicId).toBe("staractor");
-    });
-    it("handles missing optional fields gracefully", () => {
-        const raw = {};
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result.postUrn).toBe(postUrn);
-        expect(result.authorName).toBe("");
-        expect(result.authorHeadline).toBeNull();
-        expect(result.authorPublicId).toBeNull();
-        expect(result.text).toBe("");
-        expect(result.publishedAt).toBeNull();
-        expect(result.reactionCount).toBe(0);
-        expect(result.commentCount).toBe(0);
-        expect(result.shareCount).toBe(0);
-    });
-    it("handles string commentary text", () => {
-        const raw = {
-            commentary: { text: "Plain string text" },
-        };
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result.text).toBe("Plain string text");
-    });
-    it("resolves actor with firstName/lastName pattern", () => {
-        const raw = {
-            actor: {
-                firstName: "First",
-                lastName: "Last",
-                headline: { text: "Title" },
-                publicIdentifier: "firstlast",
-            },
-        };
-        const result = parseFeedUpdateResponse(raw, postUrn, []);
-        expect(result.authorName).toBe("First Last");
-        expect(result.authorPublicId).toBe("firstlast");
-        expect(result.authorHeadline).toBe("Title");
-    });
-});
-describe("parseCommentsResponse", () => {
-    it("parses comments with inline commenter", () => {
-        const raw = {
-            elements: [
-                {
-                    urn: "urn:li:comment:100",
-                    commenter: {
-                        firstName: "Alice",
-                        lastName: "Smith",
-                        publicIdentifier: "alices",
-                        headline: { text: "Engineer" },
-                    },
-                    commentV2: { text: { text: "Nice post!" } },
-                    createdTime: 1700010000000,
-                    socialDetail: {
-                        totalSocialActivityCounts: { numLikes: 3 },
-                    },
-                },
-            ],
-            paging: { start: 0, count: 10, total: 1 },
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments).toHaveLength(1);
-        expect(result.comments[0]).toEqual({
-            commentUrn: "urn:li:comment:100",
-            authorName: "Alice Smith",
-            authorHeadline: "Engineer",
-            authorPublicId: "alices",
-            text: "Nice post!",
-            createdAt: 1700010000000,
-            reactionCount: 3,
-        });
-        expect(result.paging).toEqual({ start: 0, count: 10, total: 1 });
-    });
-    it("parses nested data.elements response", () => {
-        const raw = {
-            data: {
-                elements: [
-                    {
-                        entityUrn: "urn:li:comment:200",
-                        commenter: {
-                            firstName: "Bob",
-                            lastName: "Jones",
-                        },
-                        commentary: { text: { text: "Commentary format" } },
-                        createdTime: 1700020000000,
-                    },
-                ],
-                paging: { start: 0, count: 5, total: 1 },
-            },
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments).toHaveLength(1);
-        expect(result.comments[0]?.text).toBe("Commentary format");
-        expect(result.comments[0]?.commentUrn).toBe("urn:li:comment:200");
-        expect(result.paging).toEqual({ start: 0, count: 5, total: 1 });
-    });
-    it("resolves commenter from included via URN reference", () => {
-        const commenterUrn = "urn:li:member:555";
-        const raw = {
-            elements: [
-                {
-                    urn: "urn:li:comment:300",
-                    commenterUrn,
-                    commentV2: { text: { text: "Looked up commenter" } },
-                    createdTime: 1700030000000,
-                },
-            ],
-            included: [
-                {
-                    entityUrn: commenterUrn,
-                    firstName: "Charlie",
-                    lastName: "Brown",
-                    publicIdentifier: "charlieb",
-                    occupation: "Writer",
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.authorName).toBe("Charlie Brown");
-        expect(result.comments[0]?.authorPublicId).toBe("charlieb");
-        expect(result.comments[0]?.authorHeadline).toBe("Writer");
-    });
-    it("resolves commenter from *commenter URN reference", () => {
-        const commenterUrn = "urn:li:member:666";
-        const raw = {
-            elements: [
-                {
-                    urn: "urn:li:comment:400",
-                    "*commenter": commenterUrn,
-                    commentV2: { text: { text: "Star commenter ref" } },
-                },
-            ],
-            included: [
-                {
-                    entityUrn: commenterUrn,
-                    firstName: "Dana",
-                    lastName: "White",
-                    headline: { text: "Manager" },
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.authorName).toBe("Dana White");
-        expect(result.comments[0]?.authorHeadline).toBe("Manager");
-    });
-    it("handles plain string comment text", () => {
-        const raw = {
-            elements: [
-                {
-                    comment: "Simple string comment",
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.text).toBe("Simple string comment");
-    });
-    it("handles comment with text object", () => {
-        const raw = {
-            elements: [
-                {
-                    comment: { text: "Object text comment" },
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.text).toBe("Object text comment");
-    });
-    it("handles comment with values array", () => {
-        const raw = {
-            elements: [
-                {
-                    comment: { values: [{ value: "Part 1" }, { value: " Part 2" }] },
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.text).toBe("Part 1 Part 2");
-    });
-    it("handles created.time timestamp variant", () => {
-        const raw = {
-            elements: [
-                {
-                    created: { time: 1700040000000 },
-                    commentV2: { text: "Nested time" },
-                },
-            ],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments[0]?.createdAt).toBe(1700040000000);
-    });
-    it("handles empty response gracefully", () => {
-        const result = parseCommentsResponse({});
-        expect(result.comments).toEqual([]);
-        expect(result.paging).toEqual({ start: 0, count: 0, total: 0 });
-    });
-    it("handles missing optional fields", () => {
-        const raw = {
-            elements: [{}],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.comments).toHaveLength(1);
-        expect(result.comments[0]).toEqual({
-            commentUrn: null,
-            authorName: "",
-            authorHeadline: null,
-            authorPublicId: null,
-            text: "",
-            createdAt: null,
-            reactionCount: 0,
-        });
-    });
-    it("defaults paging from comment count when absent", () => {
-        const raw = {
-            elements: [{}, {}, {}],
-        };
-        const result = parseCommentsResponse(raw);
-        expect(result.paging).toEqual({ start: 0, count: 3, total: 3 });
-    });
-});
+import { getPost } from "./get-post.js";
 describe("getPost", () => {
     const CDP_PORT = 9222;
     const POST_URL = "https://www.linkedin.com/feed/update/urn:li:activity:1234567890/";
+    const DEFAULT_POST_DETAIL = {
+        authorName: "John Doe",
+        authorHeadline: "Software Engineer",
+        authorProfileUrl: "https://www.linkedin.com/in/johndoe",
+        text: "Hello world! This is a long post text.",
+        reactionCount: 42,
+        commentCount: 5,
+        shareCount: 3,
+        timestamp: "2024-11-15T10:00:00.000Z",
+    };
+    const DEFAULT_COMMENTS = [
+        {
+            authorName: "Alice Smith",
+            authorHeadline: "Product Manager",
+            authorPublicId: "alices",
+            text: "Great post!",
+            createdAt: "2024-11-15T11:00:00.000Z",
+            reactionCount: 2,
+        },
+    ];
     function setupMocks(opts) {
-        const { postStatus = 200, postBody = {}, commentsStatus = 200, commentsBody = { elements: [] }, } = opts ?? {};
+        const { postDetail = DEFAULT_POST_DETAIL, comments = DEFAULT_COMMENTS, readySequence = [true], articleCount = 1, loadMoreClicked = [false], } = opts ?? {};
         vi.mocked(discoverTargets).mockResolvedValue([
             {
                 id: "target-1",
@@ -387,24 +63,37 @@ describe("getPost", () => {
             },
         ]);
         const disconnect = vi.fn();
+        const navigate = vi.fn().mockResolvedValue(undefined);
+        // Build evaluate mock call sequence:
+        // 1. readiness checks (boolean)
+        // 2. post detail (object)
+        // 3. article count for load-more loop (number)
+        // 4. load more click result (boolean) — repeats until false
+        // 5. final comments scrape (array)
+        const evaluateMock = vi.fn();
+        for (const ready of readySequence) {
+            evaluateMock.mockResolvedValueOnce(ready);
+        }
+        evaluateMock.mockResolvedValueOnce(postDetail);
+        evaluateMock.mockResolvedValueOnce(articleCount);
+        for (const clicked of loadMoreClicked) {
+            evaluateMock.mockResolvedValueOnce(clicked);
+            if (clicked) {
+                // After a successful click, the loop checks article count again
+                evaluateMock.mockResolvedValueOnce(articleCount);
+            }
+        }
+        evaluateMock.mockResolvedValueOnce(comments);
         vi.mocked(CDPClient).mockImplementation(function () {
             return {
                 connect: vi.fn().mockResolvedValue(undefined),
                 disconnect,
+                navigate,
+                evaluate: evaluateMock,
+                send: vi.fn().mockResolvedValue(undefined),
             };
         });
-        const fetchMock = vi
-            .fn()
-            .mockResolvedValueOnce({ url: "", status: postStatus, body: postBody })
-            .mockResolvedValueOnce({
-            url: "",
-            status: commentsStatus,
-            body: commentsBody,
-        });
-        vi.mocked(VoyagerInterceptor).mockImplementation(function () {
-            return { fetch: fetchMock };
-        });
-        return { fetchMock, disconnect };
+        return { evaluateMock, disconnect, navigate };
     }
     beforeEach(() => {
         vi.clearAllMocks();
@@ -419,21 +108,155 @@ describe("getPost", () => {
         vi.mocked(discoverTargets).mockResolvedValue([]);
         await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("No LinkedIn page found in LinkedHelper");
     });
-    it("throws on non-200 response for post detail", async () => {
-        setupMocks({ postStatus: 403 });
-        await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("Voyager API returned HTTP 403 for post detail");
+    it("navigates to post detail URL and extracts post data from DOM", async () => {
+        const { navigate } = setupMocks();
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(navigate).toHaveBeenCalledWith("https://www.linkedin.com/feed/update/urn:li:activity:1234567890/");
+        expect(result.post.postUrn).toBe("urn:li:activity:1234567890");
+        expect(result.post.authorName).toBe("John Doe");
+        expect(result.post.authorHeadline).toBe("Software Engineer");
+        expect(result.post.authorPublicId).toBe("johndoe");
+        expect(result.post.text).toBe("Hello world! This is a long post text.");
+        expect(result.post.reactionCount).toBe(42);
+        expect(result.post.commentCount).toBe(5);
+        expect(result.post.shareCount).toBe(3);
+    });
+    it("extracts comments from DOM", async () => {
+        setupMocks();
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.comments).toHaveLength(1);
+        expect(result.comments[0]).toMatchObject({
+            commentUrn: null,
+            authorName: "Alice Smith",
+            authorHeadline: "Product Manager",
+            authorPublicId: "alices",
+            text: "Great post!",
+            reactionCount: 2,
+        });
     });
-    it("throws on non-object response body for post detail", async () => {
-        setupMocks({ postBody: null });
-        await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("Voyager API returned an unexpected response format for post detail");
+    it("returns paging metadata from visible comments", async () => {
+        setupMocks({
+            comments: [
+                { authorName: "A", text: "c1", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+                { authorName: "B", text: "c2", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+            ],
+        });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.commentsPaging).toEqual({
+            start: 0,
+            count: 2,
+            total: 2,
+        });
     });
-    it("throws on non-200 response for post comments", async () => {
-        setupMocks({ commentsStatus: 500 });
-        await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("Voyager API returned HTTP 500 for post comments");
+    it("handles empty comments gracefully", async () => {
+        setupMocks({ comments: [] });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.comments).toEqual([]);
+        expect(result.commentsPaging).toEqual({ start: 0, count: 0, total: 0 });
     });
-    it("throws on non-object response body for post comments", async () => {
-        setupMocks({ commentsBody: null });
-        await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("Voyager API returned an unexpected response format for post comments");
+    it("handles null evaluate result for comments", async () => {
+        setupMocks({ comments: null });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.comments).toEqual([]);
+    });
+    it("throws when post detail extraction fails", async () => {
+        setupMocks({ postDetail: null });
+        await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow("Failed to extract post detail from the DOM");
+    });
+    it("handles missing optional fields in post detail", async () => {
+        setupMocks({
+            postDetail: {
+                authorName: null,
+                authorHeadline: null,
+                authorProfileUrl: null,
+                text: null,
+                reactionCount: 0,
+                commentCount: 0,
+                shareCount: 0,
+                timestamp: null,
+            },
+            comments: [],
+        });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.post.postUrn).toBe("urn:li:activity:1234567890");
+        expect(result.post.authorName).toBe("");
+        expect(result.post.authorHeadline).toBeNull();
+        expect(result.post.authorPublicId).toBeNull();
+        expect(result.post.text).toBe("");
+        expect(result.post.publishedAt).toBeNull();
+        expect(result.post.reactionCount).toBe(0);
+        expect(result.post.commentCount).toBe(0);
+        expect(result.post.shareCount).toBe(0);
+    });
+    it("waits for post to load with polling", async () => {
+        const { evaluateMock } = setupMocks({
+            readySequence: [false, false, true],
+        });
+        await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        // 3 readiness + 1 post detail + 1 article count + 1 load-more (false) + 1 comments = 7
+        expect(evaluateMock).toHaveBeenCalledTimes(7);
+    });
+    it("extracts authorPublicId from profile URL", async () => {
+        setupMocks({
+            postDetail: {
+                ...DEFAULT_POST_DETAIL,
+                authorProfileUrl: "https://www.linkedin.com/in/jane-doe-123",
+            },
+            comments: [],
+        });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.post.authorPublicId).toBe("jane-doe-123");
+    });
+    it("returns null authorPublicId for company URLs", async () => {
+        setupMocks({
+            postDetail: {
+                ...DEFAULT_POST_DETAIL,
+                authorProfileUrl: "https://www.linkedin.com/company/acme-corp",
+            },
+            comments: [],
+        });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.post.authorPublicId).toBeNull();
+    });
+    it("clicks load-more to expand comments", async () => {
+        setupMocks({
+            articleCount: 2,
+            loadMoreClicked: [true, true, false],
+            comments: [
+                { authorName: "A", text: "c1", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+                { authorName: "B", text: "c2", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+                { authorName: "C", text: "c3", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+            ],
+        });
+        const result = await getPost({ postUrl: POST_URL, cdpPort: CDP_PORT });
+        expect(result.comments).toHaveLength(3);
+    });
+    it("skips comment loading when commentCount is 0", async () => {
+        const { evaluateMock } = setupMocks({ comments: [] });
+        const result = await getPost({
+            postUrl: POST_URL,
+            cdpPort: CDP_PORT,
+            commentCount: 0,
+        });
+        expect(result.comments).toEqual([]);
+        // readiness + post detail + comments scrape (no load-more loop)
+        // With commentCount=0: 1 ready + 1 post + 1 comments = 3
+        expect(evaluateMock).toHaveBeenCalledTimes(3);
+    });
+    it("limits comments to commentCount", async () => {
+        setupMocks({
+            comments: [
+                { authorName: "A", text: "c1", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+                { authorName: "B", text: "c2", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+                { authorName: "C", text: "c3", authorPublicId: null, authorHeadline: null, createdAt: null, reactionCount: 0 },
+            ],
+        });
+        const result = await getPost({
+            postUrl: POST_URL,
+            cdpPort: CDP_PORT,
+            commentCount: 2,
+        });
+        expect(result.comments).toHaveLength(2);
     });
     it("disconnects CDP client after successful operation", async () => {
         const { disconnect } = setupMocks();
@@ -441,7 +264,7 @@ describe("getPost", () => {
         expect(disconnect).toHaveBeenCalled();
     });
     it("disconnects CDP client even on error", async () => {
-        const { disconnect } = setupMocks({ postStatus: 500 });
+        const { disconnect } = setupMocks({ postDetail: null });
         await expect(getPost({ postUrl: POST_URL, cdpPort: CDP_PORT })).rejects.toThrow();
         expect(disconnect).toHaveBeenCalled();
     });