@lhncbc/ucum-lhc 4.2.0 → 5.0.0

package/browser-dist/ucum-lhc.js

@@ -1617,24 +1617,17 @@ var UcumLhcUtils = /*#__PURE__*/function () {
       if (valConv === undefined) valConv = 'validate';
       var resp = this.getSpecifiedUnit(uStr, valConv, suggest);
       var theUnit = resp['unit'];
-      var retObj = {};
-
-      if (!theUnit) {
-        retObj = {
-          'status': !resp['origString'] || resp['origString'] === null ? 'error' : 'invalid',
-          'ucumCode': null
-        };
-      } else {
-        retObj = {
-          'status': resp['origString'] === uStr ? 'valid' : 'invalid',
-          'ucumCode': resp['origString'],
-          'unit': {
-            'code': theUnit.csCode_,
-            'name': theUnit.name_,
-            'guidance': theUnit.guidance_
-          }
-        };
-      }
+      var retObj = !theUnit ? {
+        'ucumCode': null
+      } : {
+        'ucumCode': resp['origString'],
+        'unit': {
+          'code': theUnit.csCode_,
+          'name': theUnit.name_,
+          'guidance': theUnit.guidance_
+        }
+      };
+      retObj.status = resp.status;
 
       if (resp['suggestions']) {
         retObj['suggestions'] = resp['suggestions'];
@@ -1723,10 +1716,7 @@ var UcumLhcUtils = /*#__PURE__*/function () {
         returnObj['msg'].push('No "from" unit expression specified.');
       }
 
-      if (fromVal === null || isNaN(fromVal) || typeof fromVal !== 'number' && !intUtils_.isNumericString(fromVal)) {
-        returnObj['status'] = 'error';
-        returnObj['msg'].push('No "from" value, or an invalid "from" value, ' + 'was specified.');
-      }
+      this._checkFromVal(fromVal, returnObj);
 
       if (toUnitCode) {
         toUnitCode = toUnitCode.trim();
@@ -1823,11 +1813,17 @@ var UcumLhcUtils = /*#__PURE__*/function () {
      * @param fromUnit the unit string to be converted to base units information
      * @param fromVal the number of "from" units to be converted
      * @returns an object with the properties:
+     *  'status' indicates whether the result succeeded.  The value will be one of:
+     *    'succeeded':  the conversion was successfully calculated (which can be
+     *      true even if it was already in base units);
+     *    'invalid':  fromUnit is not a valid UCUM code;
+     *    'failed':  the conversion could not be made (e.g., if it is an "arbitrary" unit);
+     *    'error':  if an error occurred (an input or programming error)
      *  'msg': an array of one or more messages, if the string is invalid or
      *        an error occurred, indicating the problem, or a suggestion of a
      *        substitution such as the substitution of 'G' for 'Gauss', or
-     *        an empty array if no messages were generated.  If this is not empty,
-     *        no other information will be returned.
+     *        an empty array if no messages were generated.  There can also be a
+     *        message that is just informational or warning.
      *  'magnitude': the new value when fromVal units of fromUnits is expressed in the base units.
      *  'fromUnitIsSpecial': whether the input unit fromUnit is a "special unit"
      *         as defined in UCUM.  This means there is some function applied to convert
@@ -1840,58 +1836,91 @@ var UcumLhcUtils = /*#__PURE__*/function () {
   }, {
     key: "convertToBaseUnits",
     value: function convertToBaseUnits(fromUnit, fromVal) {
-      var inputUnitLookup = this.getSpecifiedUnit(fromUnit, 'validate');
       var retObj = {};
-      var unit = inputUnitLookup.unit;
-      retObj.msg = inputUnitLookup.retMsg || [];
 
-      if (!unit) {
-        var _inputUnitLookup$retM;
+      this._checkFromVal(fromVal, retObj);
+
+      if (!retObj.status) {
+        // could be set to 'error' by _checkFromVal
+        var inputUnitLookup = this.getSpecifiedUnit(fromUnit, 'validate');
+        retObj = {
+          status: inputUnitLookup.status == 'valid' ? 'succeeded' : inputUnitLookup.status
+        };
+        var unit = inputUnitLookup.unit;
+        retObj.msg = inputUnitLookup.retMsg || [];
+
+        if (!unit) {
+          var _inputUnitLookup$retM;
 
-        if (((_inputUnitLookup$retM = inputUnitLookup.retMsg) === null || _inputUnitLookup$retM === void 0 ? void 0 : _inputUnitLookup$retM.length) == 0) retObj.msg.push('Could not find unit information for ' + fromUnit);
-      } else if (unit.isArbitrary_) {
-        retObj.msg.push('Arbitrary units cannot be converted to base units or other units.');
-      } else if (retObj.msg.length == 0) {
-        var _unit$dim_, _retUnitLookup$retMsg;
+          if (((_inputUnitLookup$retM = inputUnitLookup.retMsg) === null || _inputUnitLookup$retM === void 0 ? void 0 : _inputUnitLookup$retM.length) == 0) retObj.msg.push('Could not find unit information for ' + fromUnit);
+        } else if (unit.isArbitrary_) {
+          retObj.msg.push('Arbitrary units cannot be converted to base units or other units.');
+          retObj.status = 'failed';
+        } else if (retObj.status == 'succeeded') {
+          var _unit$dim_;
 
-        var unitToExp = {};
-        var dimVec = (_unit$dim_ = unit.dim_) === null || _unit$dim_ === void 0 ? void 0 : _unit$dim_.dimVec_;
-        var baseUnitString = '1';
+          var unitToExp = {};
+          var dimVec = (_unit$dim_ = unit.dim_) === null || _unit$dim_ === void 0 ? void 0 : _unit$dim_.dimVec_;
+          var baseUnitString = '1';
 
-        if (dimVec) {
-          var dimVecIndexToBaseUnit = UnitTables.getInstance().dimVecIndexToBaseUnit_;
+          if (dimVec) {
+            var dimVecIndexToBaseUnit = UnitTables.getInstance().dimVecIndexToBaseUnit_;
 
-          for (var i = 0, len = dimVec.length; i < len; ++i) {
-            var exp = dimVec[i];
+            for (var i = 0, len = dimVec.length; i < len; ++i) {
+              var exp = dimVec[i];
 
-            if (exp) {
-              unitToExp[dimVecIndexToBaseUnit[i]] = exp;
-              baseUnitString += '.' + dimVecIndexToBaseUnit[i] + exp;
+              if (exp) {
+                unitToExp[dimVecIndexToBaseUnit[i]] = exp;
+                baseUnitString += '.' + dimVecIndexToBaseUnit[i] + exp;
+              }
             }
-          }
-        } // The unit might have a conversion function, which has to be applied; we
-        // cannot just assume unit_.magnitude_ is the magnitude in base units.
+          } // The unit might have a conversion function, which has to be applied; we
+          // cannot just assume unit_.magnitude_ is the magnitude in base units.
 
 
-        var retUnitLookup = this.getSpecifiedUnit(baseUnitString, 'validate'); // There should not be any error in retUnitLookup, unless there is a bug.
+          var retUnitLookup = this.getSpecifiedUnit(baseUnitString, 'validate'); // There should not be any error in retUnitLookup, unless there is a bug.
 
-        var retUnit = retUnitLookup.unit;
-        if (!retUnit && ((_retUnitLookup$retMsg = retUnitLookup.retMsg) === null || _retUnitLookup$retMsg === void 0 ? void 0 : _retUnitLookup$retMsg.length) == 0) retObj.msg.push('Unable construct base unit string; tried ' + baseUnitString);else {
-          try {
-            retObj.magnitude = retUnit.convertFrom(fromVal, unit);
-          } catch (e) {
-            retObj.msg.push(e.toString());
-          }
+          var retUnit = retUnitLookup.unit;
 
-          if (retObj.msg.length == 0) {
-            retObj.unitToExp = unitToExp;
-            retObj.fromUnitIsSpecial = unit.isSpecial_;
+          if (retUnitLookup.status !== 'valid') {
+            retObj.msg.push('Unable construct base unit string; tried ' + baseUnitString);
+            retObj.status = 'error';
+          } else {
+            try {
+              retObj.magnitude = retUnit.convertFrom(fromVal, unit);
+            } catch (e) {
+              retObj.msg.push(e.toString());
+              retObj.status = 'error';
+            }
+
+            if (retObj.status == 'succeeded') {
+              retObj.unitToExp = unitToExp;
+              retObj.fromUnitIsSpecial = unit.isSpecial_;
+            }
           }
         }
       }
 
       return retObj;
     }
+    /**
+     *  Checks the given value as to whether it is suitable as a "from" value in a
+     *  unit conversion.  If it is not, the responseObj will have its status set
+     *  to 'error' and a message added.
+     * @param fromVal The value to check
+     * @param responseObj the object that will be updated if the value is not
+     *  usable.
+     */
+
+  }, {
+    key: "_checkFromVal",
+    value: function _checkFromVal(fromVal, responseObj) {
+      if (fromVal === null || isNaN(fromVal) || typeof fromVal !== 'number' && !intUtils_.isNumericString(fromVal)) {
+        responseObj.status = 'error';
+        if (!responseObj.msg) responseObj.msg = [];
+        responseObj.msg.push('No "from" value, or an invalid "from" value, ' + 'was specified.');
+      }
+    }
     /**
      * This method accepts a term and looks for units that include it as
      * a synonym - or that include the term in its name.
@@ -1937,13 +1966,18 @@ var UcumLhcUtils = /*#__PURE__*/function () {
      *  true indicates suggestions are wanted; false indicates they are not,
      *  and is the default if the parameter is not specified;
      * @returns a hash containing:
+     *   'status' will be 'valid' (uName is a valid UCUM code), 'invalid'
+     *     (the uStr is not a valid UCUM code, and substitutions or
+     *     suggestions may or may not be returned, depending on what was
+     *     requested and found); or 'error' (an input or programming error
+     *     occurred);
      *   'unit' the unit object (or null if there were problems creating the
      *     unit);
      *   'origString' the possibly updated unit string passed in;
      *   'retMsg' an array of user messages (informational, error or warning) if
      *     any were generated (IF any were generated, otherwise will be an
      *     empty array); and
-     *  'suggestions' is an array of 1 or more hash objects.  Each hash
+     *   'suggestions' is an array of 1 or more hash objects.  Each hash
      *     contains three elements:
      *       'msg' which is a message indicating what unit expression the
      *          suggestions are for;
@@ -1990,7 +2024,17 @@ var UcumLhcUtils = /*#__PURE__*/function () {
         } // end if the unit was not found as a unit name
 
       } // end if a unit expression was specified
+      // Set the status field
+
 
+      if (!retObj.unit) {
+        // No unit was found; check whether origString has a value
+        retObj.status = !retObj.origString ? 'error' : 'invalid';
+      } else {
+        // Check whether substitutions were made to the unit string in order to
+        // find the unit
+        retObj.status = retObj.origString === uName ? 'valid' : 'invalid';
+      }
 
       return retObj;
     } // end getSpecifiedUnit
@@ -4459,24 +4503,30 @@ var UnitString = /*#__PURE__*/function () {
       if (!befAnnoText && !aftAnnoText) {
         var tryBrackets = '[' + annoText.substring(1, annoText.length - 1) + ']';
 
-        var mkUnitRet = this._makeUnit(tryBrackets, origString); // If we got back a unit, assign it to the returned unit, and add
-        // a message to advise the user that brackets should enclose the code
+        var mkUnitRet = this._makeUnit(tryBrackets, origString); // Nearly anything inside braces is valid, so we don't want to change the
+        // unit, but we can put the found unit in the message as a sort of
+        // warning.
 
 
         if (mkUnitRet[0]) {
-          retUnit = mkUnitRet[0];
-          origString = origString.replace(annoText, tryBrackets);
-          this.retMsg_.push("".concat(annoText, " is not a valid unit expression, but ") + "".concat(tryBrackets, " is.\n") + this.vcMsgStart_ + "".concat(tryBrackets, " (").concat(retUnit.name_, ")").concat(this.vcMsgEnd_));
-        } // Otherwise assume that this should be interpreted as a 1
-        else {
-            // remove error message generated for trybrackets
-            if (this.retMsg_.length > msgLen) {
-              this.retMsg_.pop();
-            }
-
-            uCode = 1;
-            retUnit = 1;
+          retUnit = uCode;
+          this.retMsg_.push("".concat(annoText, " is a valid unit expression, but ") + "did you mean ".concat(tryBrackets, " (").concat(mkUnitRet[0].name_, ")?"));
+        } else {
+          // remove error message generated for trybrackets
+          if (this.retMsg_.length > msgLen) {
+            this.retMsg_.pop();
           }
+        } // This is the case where the string is only this annotation.
+        // Create and return a unit object, as we do for numeric units in
+        // parseString.
+
+
+        retUnit = new Unit({
+          'csCode_': annoText,
+          'ciCode_': annoText,
+          'magnitude_': 1,
+          'name_': annoText
+        });
       } // end if it's only an annotation
       else {
           // if there's text before and no text after, assume the text before

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lhncbc/ucum-lhc",
-  "version": "4.2.0",
+  "version": "5.0.0",
   "description": "Implements Unified Code for Units of Measure (UCUM) functions in a javascript library",
   "main": "source-cjs/ucumPkg.js",
   "homepage": "https://lhncbc.github.io/ucum-lhc/",

package/source/ucumLhcUtils.js

@@ -130,19 +130,12 @@ export class UcumLhcUtils {
 
     let resp = this.getSpecifiedUnit(uStr, valConv, suggest);
     let theUnit = resp['unit'];
-    let retObj = {};
-    if (!theUnit) {
-      retObj = {'status': (!resp['origString'] || resp['origString'] === null) ?
-                           'error' : 'invalid',
-                'ucumCode': null};
-    }
-    else {
-      retObj = {'status': resp['origString'] === uStr ? 'valid': 'invalid',
-                'ucumCode': resp['origString'],
-                'unit': {'code': theUnit.csCode_,
-                         'name': theUnit.name_,
-                         'guidance': theUnit.guidance_ }};
-    }
+    let retObj = !theUnit ? {'ucumCode': null} :
+      {'ucumCode': resp['origString'],
+       'unit': {'code': theUnit.csCode_,
+                'name': theUnit.name_,
+                'guidance': theUnit.guidance_ }};
+    retObj.status = resp.status;
     if (resp['suggestions']) {
       retObj['suggestions'] = resp['suggestions'];
     }
@@ -228,12 +221,7 @@ export class UcumLhcUtils {
       returnObj['status'] = 'error';
       returnObj['msg'].push('No "from" unit expression specified.');
     }
-    if (fromVal === null || isNaN(fromVal) || (typeof fromVal !== 'number' &&
-        !intUtils_.isNumericString(fromVal))) {
-      returnObj['status'] = 'error';
-      returnObj['msg'].push('No "from" value, or an invalid "from" value, ' +
-                         'was specified.');
-    }
+    this._checkFromVal(fromVal, returnObj);
     if (toUnitCode) {
       toUnitCode = toUnitCode.trim();
     }
@@ -343,11 +331,17 @@ export class UcumLhcUtils {
    * @param fromUnit the unit string to be converted to base units information
    * @param fromVal the number of "from" units to be converted
    * @returns an object with the properties:
+   *  'status' indicates whether the result succeeded.  The value will be one of:
+   *    'succeeded':  the conversion was successfully calculated (which can be
+   *      true even if it was already in base units);
+   *    'invalid':  fromUnit is not a valid UCUM code;
+   *    'failed':  the conversion could not be made (e.g., if it is an "arbitrary" unit);
+   *    'error':  if an error occurred (an input or programming error)
    *  'msg': an array of one or more messages, if the string is invalid or
    *        an error occurred, indicating the problem, or a suggestion of a
    *        substitution such as the substitution of 'G' for 'Gauss', or
-   *        an empty array if no messages were generated.  If this is not empty,
-   *        no other information will be returned.
+   *        an empty array if no messages were generated.  There can also be a
+   *        message that is just informational or warning.
    *  'magnitude': the new value when fromVal units of fromUnits is expressed in the base units.
    *  'fromUnitIsSpecial': whether the input unit fromUnit is a "special unit"
    *         as defined in UCUM.  This means there is some function applied to convert
@@ -357,49 +351,57 @@ export class UcumLhcUtils {
    *  'unitToExp': a map of base units in uStr to their exponent
    */
   convertToBaseUnits(fromUnit, fromVal) {
-    let inputUnitLookup = this.getSpecifiedUnit(fromUnit, 'validate');
     let retObj = {};
-    let unit = inputUnitLookup.unit;
-    retObj.msg = inputUnitLookup.retMsg || [];
-    if (!unit) {
-      if (inputUnitLookup.retMsg?.length == 0)
-        retObj.msg.push('Could not find unit information for '+fromUnit);
-    }
-    else if (unit.isArbitrary_) {
-      retObj.msg.push('Arbitrary units cannot be converted to base units or other units.');
-    }
-    else if (retObj.msg.length == 0) {
-      let unitToExp = {};
-      let dimVec = unit.dim_?.dimVec_
-      let baseUnitString = '1';
-      if (dimVec) {
-        let dimVecIndexToBaseUnit = UnitTables.getInstance().dimVecIndexToBaseUnit_;
-        for (let i=0, len=dimVec.length; i<len; ++i) {
-          let exp = dimVec[i];
-          if (exp) {
-            unitToExp[dimVecIndexToBaseUnit[i]] = exp;
-            baseUnitString += '.' + dimVecIndexToBaseUnit[i] + exp;
+    this._checkFromVal(fromVal, retObj);
+    if (!retObj.status) { // could be set to 'error' by _checkFromVal
+      let inputUnitLookup = this.getSpecifiedUnit(fromUnit, 'validate');
+      retObj = {status: inputUnitLookup.status == 'valid' ? 'succeeded' : inputUnitLookup.status};
+      let unit = inputUnitLookup.unit;
+      retObj.msg = inputUnitLookup.retMsg || [];
+      if (!unit) {
+        if (inputUnitLookup.retMsg?.length == 0)
+          retObj.msg.push('Could not find unit information for '+fromUnit);
+      }
+      else if (unit.isArbitrary_) {
+        retObj.msg.push('Arbitrary units cannot be converted to base units or other units.');
+        retObj.status = 'failed';
+      }
+      else if (retObj.status == 'succeeded') {
+        let unitToExp = {};
+        let dimVec = unit.dim_?.dimVec_
+        let baseUnitString = '1';
+        if (dimVec) {
+          let dimVecIndexToBaseUnit = UnitTables.getInstance().dimVecIndexToBaseUnit_;
+          for (let i=0, len=dimVec.length; i<len; ++i) {
+            let exp = dimVec[i];
+            if (exp) {
+              unitToExp[dimVecIndexToBaseUnit[i]] = exp;
+              baseUnitString += '.' + dimVecIndexToBaseUnit[i] + exp;
+            }
           }
         }
-      }
 
-      // The unit might have a conversion function, which has to be applied; we
-      // cannot just assume unit_.magnitude_ is the magnitude in base units.
-      let retUnitLookup = this.getSpecifiedUnit(baseUnitString, 'validate');
-      // There should not be any error in retUnitLookup, unless there is a bug.
-      let retUnit = retUnitLookup.unit;
-      if (!retUnit && retUnitLookup.retMsg?.length == 0)
-        retObj.msg.push('Unable construct base unit string; tried '+baseUnitString);
-      else {
-        try {
-          retObj.magnitude = retUnit.convertFrom(fromVal, unit);
-        }
-        catch (e) {
-          retObj.msg.push(e.toString());
+        // The unit might have a conversion function, which has to be applied; we
+        // cannot just assume unit_.magnitude_ is the magnitude in base units.
+        let retUnitLookup = this.getSpecifiedUnit(baseUnitString, 'validate');
+        // There should not be any error in retUnitLookup, unless there is a bug.
+        let retUnit = retUnitLookup.unit;
+        if (retUnitLookup.status !== 'valid') {
+          retObj.msg.push('Unable construct base unit string; tried '+baseUnitString);
+          retObj.status = 'error';
         }
-        if (retObj.msg.length == 0) {
-          retObj.unitToExp = unitToExp;
-          retObj.fromUnitIsSpecial = unit.isSpecial_;
+        else {
+          try {
+            retObj.magnitude = retUnit.convertFrom(fromVal, unit);
+          }
+          catch (e) {
+            retObj.msg.push(e.toString());
+            retObj.status = 'error';
+          }
+          if (retObj.status == 'succeeded') {
+            retObj.unitToExp = unitToExp;
+            retObj.fromUnitIsSpecial = unit.isSpecial_;
+          }
         }
       }
     }
@@ -407,6 +409,26 @@ export class UcumLhcUtils {
   }
 
 
+  /**
+   *  Checks the given value as to whether it is suitable as a "from" value in a
+   *  unit conversion.  If it is not, the responseObj will have its status set
+   *  to 'error' and a message added.
+   * @param fromVal The value to check
+   * @param responseObj the object that will be updated if the value is not
+   *  usable.
+   */
+  _checkFromVal(fromVal, responseObj) {
+    if (fromVal === null || isNaN(fromVal) || (typeof fromVal !== 'number' &&
+        !intUtils_.isNumericString(fromVal))) {
+      responseObj.status = 'error';
+      if (!responseObj.msg)
+        responseObj.msg = [];
+      responseObj.msg.push('No "from" value, or an invalid "from" value, ' +
+                         'was specified.');
+    }
+  }
+
+
   /**
    * This method accepts a term and looks for units that include it as
    * a synonym - or that include the term in its name.
@@ -450,13 +472,18 @@ export class UcumLhcUtils {
    *  true indicates suggestions are wanted; false indicates they are not,
    *  and is the default if the parameter is not specified;
    * @returns a hash containing:
+   *   'status' will be 'valid' (uName is a valid UCUM code), 'invalid'
+   *     (the uStr is not a valid UCUM code, and substitutions or
+   *     suggestions may or may not be returned, depending on what was
+   *     requested and found); or 'error' (an input or programming error
+   *     occurred);
    *   'unit' the unit object (or null if there were problems creating the
    *     unit);
    *   'origString' the possibly updated unit string passed in;
    *   'retMsg' an array of user messages (informational, error or warning) if
    *     any were generated (IF any were generated, otherwise will be an
    *     empty array); and
-   *  'suggestions' is an array of 1 or more hash objects.  Each hash
+   *   'suggestions' is an array of 1 or more hash objects.  Each hash
    *     contains three elements:
    *       'msg' which is a message indicating what unit expression the
    *          suggestions are for;
@@ -511,6 +538,17 @@ export class UcumLhcUtils {
       } // end if the unit was not found as a unit name
     } // end if a unit expression was specified
 
+    // Set the status field
+    if (!retObj.unit) {
+      // No unit was found; check whether origString has a value
+      retObj.status = !retObj.origString ? 'error' : 'invalid';
+    }
+    else {
+      // Check whether substitutions were made to the unit string in order to
+      // find the unit
+      retObj.status = retObj.origString === uName ? 'valid': 'invalid';
+    }
+
     return retObj;
 
   } // end getSpecifiedUnit
@@ -582,7 +620,3 @@ export class UcumLhcUtils {
 UcumLhcUtils.getInstance = function(){
   return new UcumLhcUtils();
 } ;
-
-
-
-

package/source/unitString.js

@@ -1330,24 +1330,31 @@ export class UnitString {
       let tryBrackets = '[' + annoText.substring(1, annoText.length - 1) + ']';
       let mkUnitRet = this._makeUnit(tryBrackets, origString);
 
-      // If we got back a unit, assign it to the returned unit, and add
-      // a message to advise the user that brackets should enclose the code
+      // Nearly anything inside braces is valid, so we don't want to change the
+      // unit, but we can put the found unit in the message as a sort of
+      // warning.
       if (mkUnitRet[0]) {
-        retUnit = mkUnitRet[0];
-        origString = origString.replace(annoText, tryBrackets);
-        this.retMsg_.push(`${annoText} is not a valid unit expression, but ` +
-          `${tryBrackets} is.\n` + this.vcMsgStart_ +
-          `${tryBrackets} (${retUnit.name_})${this.vcMsgEnd_}`);
+        retUnit = uCode;
+        this.retMsg_.push(`${annoText} is a valid unit expression, but ` +
+          `did you mean ${tryBrackets} (${mkUnitRet[0].name_})?`);
       }
-      // Otherwise assume that this should be interpreted as a 1
       else {
         // remove error message generated for trybrackets
         if (this.retMsg_.length > msgLen) {
           this.retMsg_.pop();
         }
-        uCode = 1;
-        retUnit = 1;
       }
+
+      // This is the case where the string is only this annotation.
+      // Create and return a unit object, as we do for numeric units in
+      // parseString.
+      retUnit = new Unit({
+        'csCode_': annoText,
+        'ciCode_': annoText,
+        'magnitude_': 1,
+        'name_': annoText
+      });
+
     } // end if it's only an annotation
 
     else {