@lexriver/dome 1.4.1 → 1.5.1

package/out/DomeRouter.d.ts

@@ -1,6 +1,6 @@
 export declare type RouteAction = (params: {
     [key: string]: string;
-}, url: string) => void | Promise<void>;
+}, url: string, scrollToPreviousPositionFunctionAsync: () => Promise<void>) => void | Promise<void>;
 interface HistoryUrl {
     url: string;
     scroll: number;

package/out/DomeRouter.js

@@ -7,26 +7,36 @@ export var DomeRouter;
     const allRoutes = [];
     let onNotFoundAction = undefined;
     window.addEventListener('popstate', async (e) => {
+        // on go back
         //console.log(filename, 'window.popstate event', e, 'historyUrl=', historyUrls)
-        await executeAsync();
-        await DomeManipulator.scrollToAsync({
-            pxFromTop: getScrollPositionForUrl(window.location.pathname)
-        });
+        const url = window.location.pathname;
+        await executeAsync(url, getScrollPositionForUrl(url));
+        // await DomeManipulator.scrollToAsync({
+        //     pxFromTop: getScrollPositionForUrl(window.location.pathname)
+        // })
     });
     function getScrollPositionForUrl(url) {
         // well, let's find the last url? or which index? 
-        let result = 0;
-        for (let item of historyUrls) {
+        //let result = 0
+        for (let i = historyUrls.length - 1; i >= 0; i--) {
+            const item = historyUrls[i];
             if (item.url === url) {
-                result = item.scroll;
+                //result = item.scroll
+                return item.scroll;
             }
         }
-        return result;
+        return 0;
+        // for(let item of historyUrls){
+        //     if(item.url === url){
+        //         result = item.scroll        
+        //     }
+        // }
+        // return result
     }
     function navigate(url) {
         window.history.pushState(null, '', url);
         addUrlToHistory(url);
-        executeAsync();
+        executeAsync(url, 0);
         DomeManipulator.scrollToTop();
     }
     DomeRouter.navigate = navigate;
@@ -72,15 +82,16 @@ export var DomeRouter;
     }
     DomeRouter.getPreviousPageUrl = getPreviousPageUrl;
     function reloadCurrentPage(addToHistory = false) {
+        const url = window.location.pathname;
         if (addToHistory)
-            addUrlToHistory(window.location.pathname);
-        executeAsync();
+            addUrlToHistory(url);
+        executeAsync(url, getScrollPositionForUrl(url)); // TODO: check
     }
     DomeRouter.reloadCurrentPage = reloadCurrentPage;
     function resolveUrl(url = window.location.pathname, addToHistory = true) {
         if (addToHistory)
             addUrlToHistory(window.location.pathname);
-        executeAsync(url);
+        executeAsync(url, getScrollPositionForUrl(url)); // TODO: check
     }
     DomeRouter.resolveUrl = resolveUrl;
     function onRoute(route, exactMatch, action) {
@@ -177,7 +188,7 @@ export var DomeRouter;
             return [name.substring(1), value];
         }
     }
-    async function executeAsync(url = window.location.pathname) {
+    async function executeAsync(url = window.location.pathname, scrollToPosition) {
         //const url = window.location.pathname
         const urlSlices = getRouteSlices(url);
         // urlSlices = show, category, 345
@@ -216,7 +227,11 @@ export var DomeRouter;
             if (matched) {
                 countOfFoundRoutes++;
                 //console.log('DomeRouter', 'executeAsync', url, route, extractedParameters)
-                await route.action(extractedParameters, url);
+                await route.action(extractedParameters, url, async () => {
+                    await DomeManipulator.scrollToAsync({
+                        pxFromTop: scrollToPosition
+                    });
+                });
             }
         }
         if (countOfFoundRoutes == 0 && onNotFoundAction) {

package/package.json

@@ -2,7 +2,7 @@
     "type": "module",
     "sideEffects": false,
     "name": "@lexriver/dome",
-    "version": "1.4.1",
+    "version": "1.5.1",
     "description": "",
     "main": "out/index.js",
     "types": "out/index.d.ts",
@@ -30,8 +30,7 @@
         "@lexriver/async": "^1.0.0",
         "@lexriver/data-types": "^2.0.0",
         "@lexriver/observable": "^1.0.0",
-        "lodash.clonedeep": "^4.5.0",
         "svg-tag-names": "^2.0.0",
         "ts-debounce": "^2.0.1"
     }
-}
+}

package/src/DomeRouter.ts

@@ -2,7 +2,11 @@ import { DomeManipulator } from "./DomeManipulator"
 
 const filename = '[DomeRouter]'
 
-export type RouteAction = (params:{[key:string]:string}, url:string) => void|Promise<void>
+export type RouteAction = (
+    params:{[key:string]:string}, 
+    url:string,
+    scrollToPreviousPositionFunctionAsync:()=>Promise<void>
+    ) => void|Promise<void>
 
 interface Route{
     routeSlices:string[]
@@ -22,28 +26,39 @@ export module DomeRouter {
     let onNotFoundAction:(()=>void)|undefined = undefined
 
     window.addEventListener('popstate', async (e) => {
+        // on go back
         //console.log(filename, 'window.popstate event', e, 'historyUrl=', historyUrls)
-        await executeAsync()
-        await DomeManipulator.scrollToAsync({
-            pxFromTop: getScrollPositionForUrl(window.location.pathname)
-        })
+        const url = window.location.pathname
+        await executeAsync(url, getScrollPositionForUrl(url) )
+        // await DomeManipulator.scrollToAsync({
+        //     pxFromTop: getScrollPositionForUrl(window.location.pathname)
+        // })
     })
 
     function getScrollPositionForUrl(url:string){
         // well, let's find the last url? or which index? 
-        let result = 0
-        for(let item of historyUrls){
+        //let result = 0
+        for(let i=historyUrls.length-1;i>=0;i--){
+            const item = historyUrls[i]
             if(item.url === url){
-                result = item.scroll        
+                //result = item.scroll
+                return item.scroll
+
             }
         }
-        return result
+        return 0
+        // for(let item of historyUrls){
+        //     if(item.url === url){
+        //         result = item.scroll        
+        //     }
+        // }
+        // return result
     }
 
     export function navigate(url:string){
         window.history.pushState(null, '', url)
         addUrlToHistory(url)
-        executeAsync()
+        executeAsync(url, 0)
         DomeManipulator.scrollToTop()
     }
 
@@ -91,13 +106,14 @@ export module DomeRouter {
     }
 
     export function reloadCurrentPage(addToHistory:boolean = false){
-        if(addToHistory) addUrlToHistory(window.location.pathname)
-        executeAsync()
+        const url = window.location.pathname
+        if(addToHistory) addUrlToHistory(url)
+        executeAsync(url, getScrollPositionForUrl(url)) // TODO: check
     }
 
     export function resolveUrl(url:string = window.location.pathname, addToHistory:boolean = true){
         if(addToHistory) addUrlToHistory(window.location.pathname)
-        executeAsync(url)
+        executeAsync(url, getScrollPositionForUrl(url)) // TODO: check
     }
 
     export function onRoute(route:string, exactMatch:boolean, action:RouteAction){
@@ -198,7 +214,7 @@ export module DomeRouter {
 
     }
 
-    async function executeAsync(url:string = window.location.pathname){
+    async function executeAsync(url:string = window.location.pathname, scrollToPosition:number){
         //const url = window.location.pathname
         const urlSlices = getRouteSlices(url)
         // urlSlices = show, category, 345
@@ -238,7 +254,11 @@ export module DomeRouter {
             if(matched){
                 countOfFoundRoutes++
                 //console.log('DomeRouter', 'executeAsync', url, route, extractedParameters)
-                await route.action(extractedParameters, url)
+                await route.action(extractedParameters, url, async () => {
+                    await DomeManipulator.scrollToAsync({
+                        pxFromTop: scrollToPosition
+                    })
+                })
             }
         }
         if(countOfFoundRoutes==0 && onNotFoundAction){