@levistudio/redline 0.2.0 → 0.4.0

package/src/server.ts

@@ -50,7 +50,7 @@ function getClientBundle(): Promise<string> {
 
 export function createServer(
   filePath: string,
-  opts: { context?: string; csrfToken?: string; noAgent?: boolean } = {}
+  opts: { context?: string; csrfToken?: string; noAgent?: boolean; agentName?: string } = {}
 ) {
   const app = new Hono();
   const fileName = path.basename(filePath);
@@ -129,12 +129,23 @@ export function createServer(
 
   // Abandonment detection: if no browser is connected for ABANDON_GRACE_MS after
   // the first one ever connected, fire onAbandonCallback so the CLI can exit.
-  // Default 10min — DevTools-offline debugging, brief network blips, and tab
-  // sleeps all reconnect well within that. The previous 2min default tripped on
-  // routine offline-mode testing. Override with REDLINE_ABANDON_MS for tests.
+  // Default 10min — this is now only the *backstop* for the no-beacon case
+  // (browser crash, kill -9, OS-killed tab). A cleanly closed tab fires an
+  // explicit /api/tab-closed beacon and takes the much shorter TAB_CLOSE_GRACE_MS
+  // path instead. The long backstop must stay generous: a bare SSE drop (laptop
+  // sleep, network blip, DevTools offline) is NOT a closed tab, and exiting on
+  // it kills a session the user means to continue. Override with
+  // REDLINE_ABANDON_MS for tests.
   const ABANDON_GRACE_MS = process.env.REDLINE_ABANDON_MS
     ? parseInt(process.env.REDLINE_ABANDON_MS, 10)
     : 10 * 60 * 1000;
+  // Grace applied after an explicit tab-close beacon. A reload also fires the
+  // beacon, so we can't exit immediately — but a reload reconnects its SSE
+  // within ~1s, while a real close never does. A few seconds covers the
+  // reconnect. Override with REDLINE_TABCLOSE_MS for tests.
+  const TAB_CLOSE_GRACE_MS = process.env.REDLINE_TABCLOSE_MS
+    ? parseInt(process.env.REDLINE_TABCLOSE_MS, 10)
+    : 8000;
   let hadBrowser = false;
   let abandonTimer: ReturnType<typeof setTimeout> | null = null;
   let onAbandonCallback: (() => void) | undefined;
@@ -194,15 +205,24 @@ export function createServer(
     }, REVISION_TIMEOUT_MS);
   }
 
+  function armAbandonTimer(graceMs: number) {
+    if (abandonTimer) clearTimeout(abandonTimer);
+    abandonTimer = setTimeout(() => {
+      abandonTimer = null;
+      // Re-check at fire time: a tab may have (re)connected during the grace
+      // — a reload, or a second tab — in which case nothing is abandoned.
+      if (browserClients.size > 0) return;
+      console.log(`\n[redline] No browser connected for ${graceMs / 1000}s — assuming abandoned.`);
+      onAbandonCallback?.();
+    }, graceMs);
+  }
+
   function checkBrowserPresence() {
     if (browserClients.size > 0) {
       hadBrowser = true;
       if (abandonTimer) { clearTimeout(abandonTimer); abandonTimer = null; }
     } else if (hadBrowser && !abandonTimer) {
-      abandonTimer = setTimeout(() => {
-        console.log(`\n[redline] No browser connected for ${ABANDON_GRACE_MS / 1000}s — assuming abandoned.`);
-        onAbandonCallback?.();
-      }, ABANDON_GRACE_MS);
+      armAbandonTimer(ABANDON_GRACE_MS);
     }
   }
 
@@ -255,7 +275,7 @@ export function createServer(
     const agentRepliedAt = latestRound?.agent_replied_at ?? null;
     const roundNumber = latestRound?.round ?? 1;
     const totalRounds = sidecar.rounds.length;
-    return c.html(pageTemplate(fileName, html, serializeCommentsForClient(comments), roundResolved, agentRepliedAt, roundNumber, totalRounds, sidecar.context, false, csrfToken, opts.noAgent ?? false));
+    return c.html(pageTemplate(fileName, html, serializeCommentsForClient(comments), roundResolved, agentRepliedAt, roundNumber, totalRounds, sidecar.context, false, csrfToken, opts.noAgent ?? false, opts.agentName));
   });
 
   // Add a comment to the active round
@@ -410,7 +430,7 @@ export function createServer(
   });
 
   // CLI signals the agent subprocess is gone for good (restart cap exhausted,
-  // missing claude CLI, etc). Surfaces a small persistent indicator in the
+  // missing provider CLI, etc). Surfaces a small persistent indicator in the
   // header so the user knows replies aren't coming and can restart redline.
   // No paired "agent-available" event — recovery requires a restart, so the
   // indicator stays until the page reloads.
@@ -424,6 +444,17 @@ export function createServer(
     return c.json({ ok: true });
   });
 
+  // A browser tab fired pagehide — it is closing, reloading, or navigating away.
+  // This is a hint, not proof of abandonment (a reload fires it too), so we
+  // shorten the abandon grace rather than exiting outright. On a real close the
+  // SSE never reconnects and the short timer fires; on a reload the new page
+  // reconnects within ~1s and checkBrowserPresence clears the timer. Crashes
+  // and kill -9 send no beacon and fall back to the long ABANDON_GRACE_MS.
+  app.post("/api/tab-closed", (c) => {
+    if (hadBrowser) armAbandonTimer(TAB_CLOSE_GRACE_MS);
+    return c.json({ ok: true });
+  });
+
   // Agent signals it is composing a reply (shows typing indicator in thread)
   app.post("/api/comment/:id/thinking", async (c) => {
     const id = c.req.param("id");
@@ -440,6 +471,7 @@ export function createServer(
       name?: string;
       requires_revision?: boolean;
       revision_reason?: string;
+      escalate?: boolean;
     }>();
     if (!body.message?.trim()) return c.json({ ok: false, error: "message is required" }, 400);
     const role = (body.role === "human" ? "human" : "agent") as "human" | "agent";
@@ -453,9 +485,12 @@ export function createServer(
       const entry: import("./sidecar").ThreadEntry = { role, message: body.message.trim(), at: new Date().toISOString() };
       if (name) entry.name = name;
       // Verdict only meaningful on agent replies; ignore on human entries.
-      if (role === "agent" && typeof body.requires_revision === "boolean") {
-        entry.requires_revision = body.requires_revision;
-        if (body.revision_reason?.trim()) entry.revision_reason = body.revision_reason.trim();
+      if (role === "agent") {
+        if (typeof body.requires_revision === "boolean") {
+          entry.requires_revision = body.requires_revision;
+          if (body.revision_reason?.trim()) entry.revision_reason = body.revision_reason.trim();
+        }
+        if (body.escalate === true) entry.escalate = true;
       }
       comment.thread.push(entry);
       return { skip: false as const, roundNumber: round.round, comment };
@@ -553,7 +588,8 @@ export function createServer(
       sidecar.context,
       true,   // readOnly
       csrfToken,
-      opts.noAgent ?? false
+      opts.noAgent ?? false,
+      opts.agentName
     ));
   });
 
@@ -646,5 +682,3 @@ export function createServer(
     onRevisionRecovered(cb: () => void) { onRevisionRecoveredCallback = cb; },
   };
 }
-
-

package/src/sidecar.ts

@@ -13,6 +13,11 @@ export interface ThreadEntry {
   // action defaults to "Revise" or "Accept as-is". Only set on agent entries.
   requires_revision?: boolean;
   revision_reason?: string;
+  // Set true on an agent reply when the comment can't be acted on from inside
+  // this review — it needs the agent that *launched* redline (project context,
+  // tools, or authority the inline agent lacks). Surfaced in the closeout
+  // summary so the launching agent picks it up. Only set on agent entries.
+  escalate?: boolean;
 }
 
 // Latest agent verdict on a comment thread: