@letsscrapedata/controller 0.0.24 → 0.0.26

package/dist/index.cjs

@@ -1299,6 +1299,7 @@ var PlaywrightBrowserContext = class extends import_node_events2.default {
         return null;
       }
       const page = await this.#browserContext.newPage();
+      await (0, import_utils3.sleep)(2e3);
       const pageInfo = page.pageInfo;
       if (!pageInfo) {
         throw new Error(`Logic error in getPage`);
@@ -1481,7 +1482,7 @@ var PlaywrightBrowser = class extends import_node_events3.default {
       return null;
     }
     const browserContextOptions = {};
-    if (this.#options.args?.includes("--start-maximized")) {
+    if (this.#options.maxWindowSize) {
       browserContextOptions.viewport = null;
     }
     const proxy = options?.proxy ? Object.assign({}, options.proxy) : this.#proxy;
@@ -2779,6 +2780,7 @@ var PuppeteerBrowserContext = class extends import_node_events5.default {
         return null;
       }
       const page = await this.#browserContext.newPage();
+      await (0, import_utils7.sleep)(2e3);
       const pageInfo = page.pageInfo;
       if (!pageInfo) {
         throw new Error(`Logic error in getPage`);
@@ -17234,6 +17236,7 @@ var LsdBrowserController = class _LsdBrowserController {
       timeout = 3e4,
       args = [],
       executablePath = "",
+      maxWindowSize = false,
       headless = true,
       minBrowserContexts = 1,
       // incognito
@@ -17242,7 +17245,7 @@ var LsdBrowserController = class _LsdBrowserController {
       userAgent = ""
     } = options ? options : {};
     const incognito = typeof options?.incognito === "boolean" ? options.incognito : browserControllerType === "puppeteer" ? false : true;
-    const actOptions = { closeFreePagesIntervalSeconds, maxBrowserContextsPerBrowser, maxPagesPerBrowserContext, maxPageFreeSeconds, maxViewportOfNewPage, proxy, timeout, args, executablePath, headless, minBrowserContexts, incognito, proxyPerBrowserContext, userDataDir, userAgent };
+    const actOptions = { closeFreePagesIntervalSeconds, maxBrowserContextsPerBrowser, maxPagesPerBrowserContext, maxPageFreeSeconds, maxViewportOfNewPage, proxy, timeout, args, executablePath, maxWindowSize, headless, minBrowserContexts, incognito, proxyPerBrowserContext, userDataDir, userAgent };
     let idx = args.findIndex((arg) => arg.toLowerCase().startsWith("--incoginto"));
     if (idx >= 0) {
       (0, import_utils15.logwarn)(`Please use options.incognito instead when launching new browser.`);
@@ -17258,12 +17261,20 @@ var LsdBrowserController = class _LsdBrowserController {
       (0, import_utils15.logwarn)(`Please use options.userDataDir instead when launching new browser.`);
       args.splice(idx, 1);
     }
+    idx = args.findIndex((arg) => arg.toLowerCase().startsWith("--start-maximized"));
+    if (idx >= 0) {
+      (0, import_utils15.logwarn)(`Please use options.maxWindowSize instead when launching new browser.`);
+      args.splice(idx, 1);
+    }
     let lsdBrowser;
     if (browserControllerType === "playwright") {
       const launchOptions = { headless, timeout };
       if (executablePath) {
         launchOptions.executablePath = executablePath;
       }
+      if (maxWindowSize) {
+        args.push("--start-maximized");
+      }
       if (proxy?.server && proxy.server !== "default") {
         launchOptions.proxy = proxy;
       } else if (proxyPerBrowserContext && browserType === "chromium" && this.#osPlatform.startsWith("win")) {
@@ -17288,12 +17299,13 @@ var LsdBrowserController = class _LsdBrowserController {
     } else if (browserControllerType === "puppeteer") {
       const product = this.#puppeteerProduct(browserType);
       const launchOptions = { headless, timeout, product };
-      if (actOptions.args?.includes("--start-maximized")) {
-        launchOptions.defaultViewport = null;
-      }
       if (executablePath) {
         launchOptions.executablePath = executablePath;
       }
+      if (maxWindowSize) {
+        args.push("--start-maximized");
+        launchOptions.defaultViewport = null;
+      }
       if (browserType === "chromium") {
         if (incognito) {
           args.push("--incognito");

package/dist/index.d.cts

@@ -80,6 +80,10 @@ interface BrowserOptions {
 interface LsdLaunchOptions extends BrowserOptions {
     args?: string[];
     executablePath?: string;
+    /**
+     * @default false
+     */
+    maxWindowSize?: boolean;
     /**
      * @default true
      */

package/dist/index.d.ts

@@ -80,6 +80,10 @@ interface BrowserOptions {
 interface LsdLaunchOptions extends BrowserOptions {
     args?: string[];
     executablePath?: string;
+    /**
+     * @default false
+     */
+    maxWindowSize?: boolean;
     /**
      * @default true
      */

package/dist/index.js

@@ -1279,6 +1279,7 @@ var PlaywrightBrowserContext = class extends EventEmitter2 {
         return null;
       }
       const page = await this.#browserContext.newPage();
+      await sleep(2e3);
       const pageInfo = page.pageInfo;
       if (!pageInfo) {
         throw new Error(`Logic error in getPage`);
@@ -1461,7 +1462,7 @@ var PlaywrightBrowser = class extends EventEmitter3 {
       return null;
     }
     const browserContextOptions = {};
-    if (this.#options.args?.includes("--start-maximized")) {
+    if (this.#options.maxWindowSize) {
       browserContextOptions.viewport = null;
     }
     const proxy = options?.proxy ? Object.assign({}, options.proxy) : this.#proxy;
@@ -2759,6 +2760,7 @@ var PuppeteerBrowserContext = class extends EventEmitter5 {
         return null;
       }
       const page = await this.#browserContext.newPage();
+      await sleep2(2e3);
       const pageInfo = page.pageInfo;
       if (!pageInfo) {
         throw new Error(`Logic error in getPage`);
@@ -17214,6 +17216,7 @@ var LsdBrowserController = class _LsdBrowserController {
       timeout = 3e4,
       args = [],
       executablePath = "",
+      maxWindowSize = false,
       headless = true,
       minBrowserContexts = 1,
       // incognito
@@ -17222,7 +17225,7 @@ var LsdBrowserController = class _LsdBrowserController {
       userAgent = ""
     } = options ? options : {};
     const incognito = typeof options?.incognito === "boolean" ? options.incognito : browserControllerType === "puppeteer" ? false : true;
-    const actOptions = { closeFreePagesIntervalSeconds, maxBrowserContextsPerBrowser, maxPagesPerBrowserContext, maxPageFreeSeconds, maxViewportOfNewPage, proxy, timeout, args, executablePath, headless, minBrowserContexts, incognito, proxyPerBrowserContext, userDataDir, userAgent };
+    const actOptions = { closeFreePagesIntervalSeconds, maxBrowserContextsPerBrowser, maxPagesPerBrowserContext, maxPageFreeSeconds, maxViewportOfNewPage, proxy, timeout, args, executablePath, maxWindowSize, headless, minBrowserContexts, incognito, proxyPerBrowserContext, userDataDir, userAgent };
     let idx = args.findIndex((arg) => arg.toLowerCase().startsWith("--incoginto"));
     if (idx >= 0) {
       logwarn6(`Please use options.incognito instead when launching new browser.`);
@@ -17238,12 +17241,20 @@ var LsdBrowserController = class _LsdBrowserController {
       logwarn6(`Please use options.userDataDir instead when launching new browser.`);
       args.splice(idx, 1);
     }
+    idx = args.findIndex((arg) => arg.toLowerCase().startsWith("--start-maximized"));
+    if (idx >= 0) {
+      logwarn6(`Please use options.maxWindowSize instead when launching new browser.`);
+      args.splice(idx, 1);
+    }
     let lsdBrowser;
     if (browserControllerType === "playwright") {
       const launchOptions = { headless, timeout };
       if (executablePath) {
         launchOptions.executablePath = executablePath;
       }
+      if (maxWindowSize) {
+        args.push("--start-maximized");
+      }
       if (proxy?.server && proxy.server !== "default") {
         launchOptions.proxy = proxy;
       } else if (proxyPerBrowserContext && browserType === "chromium" && this.#osPlatform.startsWith("win")) {
@@ -17268,12 +17279,13 @@ var LsdBrowserController = class _LsdBrowserController {
     } else if (browserControllerType === "puppeteer") {
       const product = this.#puppeteerProduct(browserType);
       const launchOptions = { headless, timeout, product };
-      if (actOptions.args?.includes("--start-maximized")) {
-        launchOptions.defaultViewport = null;
-      }
       if (executablePath) {
         launchOptions.executablePath = executablePath;
       }
+      if (maxWindowSize) {
+        args.push("--start-maximized");
+        launchOptions.defaultViewport = null;
+      }
       if (browserType === "chromium") {
         if (incognito) {
           args.push("--incognito");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@letsscrapedata/controller",
-  "version": "0.0.24",
+  "version": "0.0.26",
   "description": "Unified browser / HTML controller interfaces that support playwright, puppeteer and cheerio",
   "type": "module",
   "main": "./dist/index.mjs",