@letsscrapedata/controller 0.0.2 → 0.0.4

package/dist/index.cjs

@@ -497,17 +497,19 @@ var PlaywrightPage = class extends import_node_events.default {
     });
     page.on("popup", (p) => {
       if (p) {
+        let evtData = null;
         const pageInfo = p.pageInfo;
         let popupPageId = "page";
         if (pageInfo) {
           const { browserIdx, browserContextIdx, pageIdx } = pageInfo;
           popupPageId = `page-${browserIdx}-${browserContextIdx}-${pageIdx}`;
           pageInfo.openType = "popup";
+          evtData = this.browserContext().page(pageIdx);
         } else {
           (0, import_utils2.logerr)(`##browser  ${pageId} has popup without page.pageInfo`);
         }
         (0, import_utils2.loginfo)(`##browser  ${pageId} has popup ${popupPageId}`);
-        this.emit("pagePopup", pageInfo);
+        this.emit("pagePopup", evtData);
       } else {
         (0, import_utils2.logerr)(`##browser  ${pageId} has popup page with null page`);
       }
@@ -667,12 +669,19 @@ var PlaywrightPage = class extends import_node_events.default {
     await this.clearResponseInterceptions();
     return true;
   }
+  #getWaitUntil(origWaitUntil) {
+    if (origWaitUntil === "networkidle0" || origWaitUntil === "networkidle2") {
+      return "networkidle";
+    } else {
+      return origWaitUntil;
+    }
+  }
   async goto(url, options) {
     if (!this.#page) {
       throw new Error("No valid page");
     }
     if (options) {
-      const { referer, timeout, waitUntil } = options;
+      const { referer, timeout, waitUntil = "load" } = options;
       const newOptions = {};
       if (referer) {
         newOptions.referer = referer;
@@ -680,9 +689,7 @@ var PlaywrightPage = class extends import_node_events.default {
       if (timeout) {
         newOptions.timeout = timeout;
       }
-      if (waitUntil && waitUntil !== "commit") {
-        newOptions.waitUntil = waitUntil === "networkidle" ? "networkidle0" : waitUntil;
-      }
+      newOptions.waitUntil = this.#getWaitUntil(waitUntil);
       await this.#page.goto(url, newOptions);
     } else {
       await this.#page.goto(url);
@@ -1015,6 +1022,30 @@ var PlaywrightPage = class extends import_node_events.default {
     this.#status = "busy";
     return true;
   }
+  async waitForElement(selector, options = {}) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const locator = this.#page.locator(selector);
+    const { timeout = 3e4, state = "visible" } = options;
+    await locator.waitFor({ state, timeout });
+    return true;
+  }
+  async waitForNavigation(options) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { url = "", timeout = 3e4, waitUntil = "load" } = options;
+    const newWaitUntil = this.#getWaitUntil(waitUntil);
+    if (url) {
+      await this.#page.waitForURL(url, { timeout, waitUntil: newWaitUntil });
+    } else if (newWaitUntil === "commit") {
+      throw new Error("commit is not supported in PlaywrightPage.waitForNavigation");
+    } else {
+      await this.#page.waitForLoadState(newWaitUntil, { timeout });
+    }
+    return true;
+  }
   async windowMember(keys) {
     if (!this.#page) {
       throw new Error("No valid page");
@@ -1237,6 +1268,10 @@ var PlaywrightBrowserContext = class extends import_node_events2.default {
   isIncognito() {
     return this.#incognito;
   }
+  page(pageIdx) {
+    const lsdPage = this.#lsdPages.find((p) => p.pageInfo().pageIdx === pageIdx);
+    return lsdPage ? lsdPage : null;
+  }
   pages() {
     return this.#lsdPages;
   }
@@ -1873,17 +1908,19 @@ var PuppeteerPage = class extends import_node_events4.default {
     });
     page.on("popup", (p) => {
       if (p) {
+        let evtData = null;
         const pageInfo = p.pageInfo;
         let popupPageId = "page";
         if (pageInfo) {
           const { browserIdx, browserContextIdx, pageIdx } = pageInfo;
           popupPageId = `page-${browserIdx}-${browserContextIdx}-${pageIdx}`;
           pageInfo.openType = "popup";
+          evtData = this.browserContext().page(pageIdx);
         } else {
           (0, import_utils6.logerr)(`##browser  ${pageId} has popup without page.pageInfo`);
         }
         (0, import_utils6.loginfo)(`##browser  ${pageId} has popup ${popupPageId}`);
-        this.emit("pagePopup", pageInfo);
+        this.emit("pagePopup", evtData);
       } else {
         (0, import_utils6.logerr)(`##browser  ${pageId} has popup page with null page`);
       }
@@ -2042,12 +2079,21 @@ var PuppeteerPage = class extends import_node_events4.default {
     await this.clearResponseInterceptions();
     return true;
   }
+  #getWaitUntil(origWaitUntil) {
+    if (origWaitUntil === "networkidle") {
+      return "networkidle0";
+    } else if (origWaitUntil === "commit") {
+      throw new Error("commit is not supported in PuppeteerPage");
+    } else {
+      return origWaitUntil;
+    }
+  }
   async goto(url, options) {
     if (!this.#page) {
       throw new Error("No valid page");
     }
     if (options) {
-      const { referer, timeout, waitUntil } = options;
+      const { referer, timeout, waitUntil = "load" } = options;
       const newOptions = {};
       if (referer) {
         newOptions.referer = referer;
@@ -2056,7 +2102,7 @@ var PuppeteerPage = class extends import_node_events4.default {
         newOptions.timeout = timeout;
       }
       if (waitUntil && waitUntil !== "commit") {
-        newOptions.waitUntil = waitUntil === "networkidle" ? "networkidle0" : waitUntil;
+        newOptions.waitUntil = this.#getWaitUntil(waitUntil);
       }
       await this.#page.goto(url, newOptions);
     } else {
@@ -2370,6 +2416,33 @@ var PuppeteerPage = class extends import_node_events4.default {
     this.#status = "busy";
     return true;
   }
+  async waitForElement(selector, options = {}) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { timeout = 3e4, state = "visible" } = options;
+    if (state === "visible") {
+      await this.#page.waitForSelector(selector, { timeout, visible: true });
+    } else if (state === "hidden") {
+      await this.#page.waitForSelector(selector, { timeout, hidden: true });
+    } else {
+      throw new Error(`${state} is not supported in PuppeteerPage.waitForElement`);
+    }
+    return true;
+  }
+  async waitForNavigation(options) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { url = "", timeout = 3e4, waitUntil = "load" } = options;
+    const newWaitUntil = this.#getWaitUntil(waitUntil);
+    if (url) {
+      throw new Error("url is not supported in PuppeteerPage.waitForNavigation");
+    } else {
+      await this.#page.waitForNavigation({ timeout, waitUntil: newWaitUntil });
+    }
+    return true;
+  }
   async windowMember(keys) {
     if (!this.#page) {
       throw new Error("No valid page");
@@ -2610,6 +2683,10 @@ var PuppeteerBrowserContext = class extends import_node_events5.default {
   isIncognito() {
     return this.#incognito;
   }
+  page(pageIdx) {
+    const lsdPage = this.#lsdPages.find((p) => p.pageInfo().pageIdx === pageIdx);
+    return lsdPage ? lsdPage : null;
+  }
   pages() {
     return this.#lsdPages;
   }
@@ -16946,6 +17023,12 @@ var CheerioPage = class extends import_node_events7.default {
   use() {
     throw new Error("Not supported in CheerioPage.");
   }
+  waitForElement() {
+    throw new Error("Not supported in CheerioPage.");
+  }
+  waitForNavigation() {
+    throw new Error("Not supported in CheerioPage.");
+  }
   async windowMember() {
     throw new Error("Not supported in CheerioPage.");
   }

package/dist/index.d.cts

@@ -243,14 +243,15 @@ interface SelectOptions {
      */
     labels?: string[];
 }
+/**
+ * * playwright: "load" | "domcontentloaded" | "networkidle" | "commit", "networkidle0" | "networkidle2" => "networkidle";
+ * * puppeteer: "load" | "domcontentloaded" | "networkidle0" | "networkidle2", "networkidle" => "networkidle0", "commit" ignored;
+ */
+type NavigationWaitUntil = "load" | "domcontentloaded" | "networkidle" | "commit" | "networkidle0" | "networkidle2";
 interface GotoOptions {
     referer?: string;
     timeout?: number;
-    /**
-     * playwright: "load" | "domcontentloaded" | "networkidle" | "commit", "networkidle0" | "networkidle2" => "networkidle";
-     * puppeteer: "load" | "domcontentloaded" | "networkidle0" | "networkidle2", "networkidle" => "networkidle0", "commit" ignored;
-     */
-    waitUntil?: "load" | "domcontentloaded" | "networkidle" | "commit" | "networkidle0" | "networkidle2";
+    waitUntil?: NavigationWaitUntil;
 }
 /**
  * * src takes precedence over selector, at least one of them must be defined
@@ -684,6 +685,33 @@ interface ScreenshotOptions {
      */
     type?: 'png' | 'jpeg';
 }
+type WaitElementState = "attached" | "detached" | "hidden" | "visible";
+interface WaitElementOptions {
+    /**
+     * @default 30_000 ms
+     */
+    timeout?: number;
+    /**
+     * @default "visible"
+     */
+    state?: WaitElementState;
+}
+interface WaitNavigationOptions {
+    /**
+     * only supported in playwright by now
+     * @default ""
+     */
+    url?: string | RegExp;
+    /**
+     * @default 30_000 ms
+     */
+    timeout?: number;
+    /**
+     * @default "visible"
+     */
+    waitUntil?: NavigationWaitUntil;
+}
+type PageEvent = "pageClose" | "pagePopup";
 interface LsdPage extends EventEmitter {
     bringToFront(): Promise<boolean>;
     browserContext(): LsdBrowserContext;
@@ -778,6 +806,17 @@ interface LsdPage extends EventEmitter {
      * 开始使用该page(当前状态必须为free)
      */
     use(): boolean;
+    /**
+     *
+     * @param selector CSS selector, not XPath
+     * @param options
+     */
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    /**
+     *
+     * @param options
+     */
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     /**
      * obj=window?.[key1]...?.[keyn]
      * @return obj ? JSON.stringify(obj) : ""
@@ -806,6 +845,7 @@ interface LsdBrowserContext extends EventEmitter {
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -886,6 +926,7 @@ declare class PlaywrightBrowserContext extends EventEmitter implements LsdBrowse
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -937,6 +978,8 @@ declare class PlaywrightPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     windowMember(keys: string[]): Promise<string>;
 }
 
@@ -990,6 +1033,7 @@ declare class PuppeteerBrowserContext extends EventEmitter implements LsdBrowser
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -1041,6 +1085,8 @@ declare class PuppeteerPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     windowMember(keys: string[]): Promise<string>;
 }
 
@@ -1110,6 +1156,8 @@ declare class CheerioPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(): Promise<boolean>;
+    waitForNavigation(): Promise<boolean>;
     windowMember(): Promise<string>;
 }
 
@@ -1135,4 +1183,4 @@ declare class CheerioElement implements LsdElement {
     scrollIntoView(): Promise<boolean>;
 }
 
-export { type AllBrowser, type AllBrowserContext, type AllFrame, type AllPage, type AllResponse, type BrowserControllerOptions, type BrowserControllerType, type BrowserCreationMethod, type BrowserManager, CheerioElement, type CheerioNode, CheerioPage, type CookieItem, type GotoOptions, type IframeOption, type InputOptions, type KeyInput, type KeyPressOptions, type LocalStorageItem, type LocalStorageOrigin, type LowerCasePaperFormat, type LsdBrowser, type LsdBrowserContext, type LsdBrowserContextOptions, type LsdBrowserController, type LsdBrowserType, type LsdConnectOptions, type LsdElement, type LsdLaunchOptions, type LsdPage, type MouseClickOptions, type PDFMargin, type PDFOptions, type PageExtInPlaywright, type PageExtInPuppeteer, type PageInfo, type PageOpenType, type PageStatus, type PaperFormat, PlaywrightBrowser, PlaywrightBrowserContext, PlaywrightElement, PlaywrightPage, type Proxy, PuppeteerBrowser, PuppeteerBrowserContext, PuppeteerElement, PuppeteerPage, type RequestInterceptionAction, type RequestInterceptionOption, type RequestMatch, type RequestMethod, type RequestResourceType, type ResponseHandler, type ResponseHandlerOptions, type ResponseInterceptionItem, type ResponseInterceptionOption, type ResponseMatch, type ScreenshotOptions, type SelectOptions, type StateData, type ViewportSize, defaultProxy };
+export { type AllBrowser, type AllBrowserContext, type AllFrame, type AllPage, type AllResponse, type BrowserControllerOptions, type BrowserControllerType, type BrowserCreationMethod, type BrowserManager, CheerioElement, type CheerioNode, CheerioPage, type CookieItem, type GotoOptions, type IframeOption, type InputOptions, type KeyInput, type KeyPressOptions, type LocalStorageItem, type LocalStorageOrigin, type LowerCasePaperFormat, type LsdBrowser, type LsdBrowserContext, type LsdBrowserContextOptions, type LsdBrowserController, type LsdBrowserType, type LsdConnectOptions, type LsdElement, type LsdLaunchOptions, type LsdPage, type MouseClickOptions, type NavigationWaitUntil, type PDFMargin, type PDFOptions, type PageEvent, type PageExtInPlaywright, type PageExtInPuppeteer, type PageInfo, type PageOpenType, type PageStatus, type PaperFormat, PlaywrightBrowser, PlaywrightBrowserContext, PlaywrightElement, PlaywrightPage, type Proxy, PuppeteerBrowser, PuppeteerBrowserContext, PuppeteerElement, PuppeteerPage, type RequestInterceptionAction, type RequestInterceptionOption, type RequestMatch, type RequestMethod, type RequestResourceType, type ResponseHandler, type ResponseHandlerOptions, type ResponseInterceptionItem, type ResponseInterceptionOption, type ResponseMatch, type ScreenshotOptions, type SelectOptions, type StateData, type ViewportSize, type WaitElementOptions, type WaitElementState, type WaitNavigationOptions, defaultProxy };

package/dist/index.d.ts

@@ -243,14 +243,15 @@ interface SelectOptions {
      */
     labels?: string[];
 }
+/**
+ * * playwright: "load" | "domcontentloaded" | "networkidle" | "commit", "networkidle0" | "networkidle2" => "networkidle";
+ * * puppeteer: "load" | "domcontentloaded" | "networkidle0" | "networkidle2", "networkidle" => "networkidle0", "commit" ignored;
+ */
+type NavigationWaitUntil = "load" | "domcontentloaded" | "networkidle" | "commit" | "networkidle0" | "networkidle2";
 interface GotoOptions {
     referer?: string;
     timeout?: number;
-    /**
-     * playwright: "load" | "domcontentloaded" | "networkidle" | "commit", "networkidle0" | "networkidle2" => "networkidle";
-     * puppeteer: "load" | "domcontentloaded" | "networkidle0" | "networkidle2", "networkidle" => "networkidle0", "commit" ignored;
-     */
-    waitUntil?: "load" | "domcontentloaded" | "networkidle" | "commit" | "networkidle0" | "networkidle2";
+    waitUntil?: NavigationWaitUntil;
 }
 /**
  * * src takes precedence over selector, at least one of them must be defined
@@ -684,6 +685,33 @@ interface ScreenshotOptions {
      */
     type?: 'png' | 'jpeg';
 }
+type WaitElementState = "attached" | "detached" | "hidden" | "visible";
+interface WaitElementOptions {
+    /**
+     * @default 30_000 ms
+     */
+    timeout?: number;
+    /**
+     * @default "visible"
+     */
+    state?: WaitElementState;
+}
+interface WaitNavigationOptions {
+    /**
+     * only supported in playwright by now
+     * @default ""
+     */
+    url?: string | RegExp;
+    /**
+     * @default 30_000 ms
+     */
+    timeout?: number;
+    /**
+     * @default "visible"
+     */
+    waitUntil?: NavigationWaitUntil;
+}
+type PageEvent = "pageClose" | "pagePopup";
 interface LsdPage extends EventEmitter {
     bringToFront(): Promise<boolean>;
     browserContext(): LsdBrowserContext;
@@ -778,6 +806,17 @@ interface LsdPage extends EventEmitter {
      * 开始使用该page(当前状态必须为free)
      */
     use(): boolean;
+    /**
+     *
+     * @param selector CSS selector, not XPath
+     * @param options
+     */
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    /**
+     *
+     * @param options
+     */
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     /**
      * obj=window?.[key1]...?.[keyn]
      * @return obj ? JSON.stringify(obj) : ""
@@ -806,6 +845,7 @@ interface LsdBrowserContext extends EventEmitter {
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -886,6 +926,7 @@ declare class PlaywrightBrowserContext extends EventEmitter implements LsdBrowse
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -937,6 +978,8 @@ declare class PlaywrightPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     windowMember(keys: string[]): Promise<string>;
 }
 
@@ -990,6 +1033,7 @@ declare class PuppeteerBrowserContext extends EventEmitter implements LsdBrowser
     hasNewPage(pageNum?: number): boolean;
     id(): string;
     isIncognito(): boolean;
+    page(pageIdx: number): LsdPage | null;
     pages(): LsdPage[];
     proxy(): Proxy | null;
     setStateData(stateData: StateData): Promise<boolean>;
@@ -1041,6 +1085,8 @@ declare class PuppeteerPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(selector: string, options?: WaitElementOptions): Promise<boolean>;
+    waitForNavigation(options: WaitNavigationOptions): Promise<boolean>;
     windowMember(keys: string[]): Promise<string>;
 }
 
@@ -1110,6 +1156,8 @@ declare class CheerioPage extends EventEmitter implements LsdPage {
     title(): Promise<string>;
     url(): string;
     use(): boolean;
+    waitForElement(): Promise<boolean>;
+    waitForNavigation(): Promise<boolean>;
     windowMember(): Promise<string>;
 }
 
@@ -1135,4 +1183,4 @@ declare class CheerioElement implements LsdElement {
     scrollIntoView(): Promise<boolean>;
 }
 
-export { type AllBrowser, type AllBrowserContext, type AllFrame, type AllPage, type AllResponse, type BrowserControllerOptions, type BrowserControllerType, type BrowserCreationMethod, type BrowserManager, CheerioElement, type CheerioNode, CheerioPage, type CookieItem, type GotoOptions, type IframeOption, type InputOptions, type KeyInput, type KeyPressOptions, type LocalStorageItem, type LocalStorageOrigin, type LowerCasePaperFormat, type LsdBrowser, type LsdBrowserContext, type LsdBrowserContextOptions, type LsdBrowserController, type LsdBrowserType, type LsdConnectOptions, type LsdElement, type LsdLaunchOptions, type LsdPage, type MouseClickOptions, type PDFMargin, type PDFOptions, type PageExtInPlaywright, type PageExtInPuppeteer, type PageInfo, type PageOpenType, type PageStatus, type PaperFormat, PlaywrightBrowser, PlaywrightBrowserContext, PlaywrightElement, PlaywrightPage, type Proxy, PuppeteerBrowser, PuppeteerBrowserContext, PuppeteerElement, PuppeteerPage, type RequestInterceptionAction, type RequestInterceptionOption, type RequestMatch, type RequestMethod, type RequestResourceType, type ResponseHandler, type ResponseHandlerOptions, type ResponseInterceptionItem, type ResponseInterceptionOption, type ResponseMatch, type ScreenshotOptions, type SelectOptions, type StateData, type ViewportSize, defaultProxy };
+export { type AllBrowser, type AllBrowserContext, type AllFrame, type AllPage, type AllResponse, type BrowserControllerOptions, type BrowserControllerType, type BrowserCreationMethod, type BrowserManager, CheerioElement, type CheerioNode, CheerioPage, type CookieItem, type GotoOptions, type IframeOption, type InputOptions, type KeyInput, type KeyPressOptions, type LocalStorageItem, type LocalStorageOrigin, type LowerCasePaperFormat, type LsdBrowser, type LsdBrowserContext, type LsdBrowserContextOptions, type LsdBrowserController, type LsdBrowserType, type LsdConnectOptions, type LsdElement, type LsdLaunchOptions, type LsdPage, type MouseClickOptions, type NavigationWaitUntil, type PDFMargin, type PDFOptions, type PageEvent, type PageExtInPlaywright, type PageExtInPuppeteer, type PageInfo, type PageOpenType, type PageStatus, type PaperFormat, PlaywrightBrowser, PlaywrightBrowserContext, PlaywrightElement, PlaywrightPage, type Proxy, PuppeteerBrowser, PuppeteerBrowserContext, PuppeteerElement, PuppeteerPage, type RequestInterceptionAction, type RequestInterceptionOption, type RequestMatch, type RequestMethod, type RequestResourceType, type ResponseHandler, type ResponseHandlerOptions, type ResponseInterceptionItem, type ResponseInterceptionOption, type ResponseMatch, type ScreenshotOptions, type SelectOptions, type StateData, type ViewportSize, type WaitElementOptions, type WaitElementState, type WaitNavigationOptions, defaultProxy };

package/dist/index.js

@@ -478,17 +478,19 @@ var PlaywrightPage = class extends EventEmitter {
     });
     page.on("popup", (p) => {
       if (p) {
+        let evtData = null;
         const pageInfo = p.pageInfo;
         let popupPageId = "page";
         if (pageInfo) {
           const { browserIdx, browserContextIdx, pageIdx } = pageInfo;
           popupPageId = `page-${browserIdx}-${browserContextIdx}-${pageIdx}`;
           pageInfo.openType = "popup";
+          evtData = this.browserContext().page(pageIdx);
         } else {
           logerr(`##browser  ${pageId} has popup without page.pageInfo`);
         }
         loginfo(`##browser  ${pageId} has popup ${popupPageId}`);
-        this.emit("pagePopup", pageInfo);
+        this.emit("pagePopup", evtData);
       } else {
         logerr(`##browser  ${pageId} has popup page with null page`);
       }
@@ -648,12 +650,19 @@ var PlaywrightPage = class extends EventEmitter {
     await this.clearResponseInterceptions();
     return true;
   }
+  #getWaitUntil(origWaitUntil) {
+    if (origWaitUntil === "networkidle0" || origWaitUntil === "networkidle2") {
+      return "networkidle";
+    } else {
+      return origWaitUntil;
+    }
+  }
   async goto(url, options) {
     if (!this.#page) {
       throw new Error("No valid page");
     }
     if (options) {
-      const { referer, timeout, waitUntil } = options;
+      const { referer, timeout, waitUntil = "load" } = options;
       const newOptions = {};
       if (referer) {
         newOptions.referer = referer;
@@ -661,9 +670,7 @@ var PlaywrightPage = class extends EventEmitter {
       if (timeout) {
         newOptions.timeout = timeout;
       }
-      if (waitUntil && waitUntil !== "commit") {
-        newOptions.waitUntil = waitUntil === "networkidle" ? "networkidle0" : waitUntil;
-      }
+      newOptions.waitUntil = this.#getWaitUntil(waitUntil);
       await this.#page.goto(url, newOptions);
     } else {
       await this.#page.goto(url);
@@ -996,6 +1003,30 @@ var PlaywrightPage = class extends EventEmitter {
     this.#status = "busy";
     return true;
   }
+  async waitForElement(selector, options = {}) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const locator = this.#page.locator(selector);
+    const { timeout = 3e4, state = "visible" } = options;
+    await locator.waitFor({ state, timeout });
+    return true;
+  }
+  async waitForNavigation(options) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { url = "", timeout = 3e4, waitUntil = "load" } = options;
+    const newWaitUntil = this.#getWaitUntil(waitUntil);
+    if (url) {
+      await this.#page.waitForURL(url, { timeout, waitUntil: newWaitUntil });
+    } else if (newWaitUntil === "commit") {
+      throw new Error("commit is not supported in PlaywrightPage.waitForNavigation");
+    } else {
+      await this.#page.waitForLoadState(newWaitUntil, { timeout });
+    }
+    return true;
+  }
   async windowMember(keys) {
     if (!this.#page) {
       throw new Error("No valid page");
@@ -1218,6 +1249,10 @@ var PlaywrightBrowserContext = class extends EventEmitter2 {
   isIncognito() {
     return this.#incognito;
   }
+  page(pageIdx) {
+    const lsdPage = this.#lsdPages.find((p) => p.pageInfo().pageIdx === pageIdx);
+    return lsdPage ? lsdPage : null;
+  }
   pages() {
     return this.#lsdPages;
   }
@@ -1854,17 +1889,19 @@ var PuppeteerPage = class extends EventEmitter4 {
     });
     page.on("popup", (p) => {
       if (p) {
+        let evtData = null;
         const pageInfo = p.pageInfo;
         let popupPageId = "page";
         if (pageInfo) {
           const { browserIdx, browserContextIdx, pageIdx } = pageInfo;
           popupPageId = `page-${browserIdx}-${browserContextIdx}-${pageIdx}`;
           pageInfo.openType = "popup";
+          evtData = this.browserContext().page(pageIdx);
         } else {
           logerr5(`##browser  ${pageId} has popup without page.pageInfo`);
         }
         loginfo4(`##browser  ${pageId} has popup ${popupPageId}`);
-        this.emit("pagePopup", pageInfo);
+        this.emit("pagePopup", evtData);
       } else {
         logerr5(`##browser  ${pageId} has popup page with null page`);
       }
@@ -2023,12 +2060,21 @@ var PuppeteerPage = class extends EventEmitter4 {
     await this.clearResponseInterceptions();
     return true;
   }
+  #getWaitUntil(origWaitUntil) {
+    if (origWaitUntil === "networkidle") {
+      return "networkidle0";
+    } else if (origWaitUntil === "commit") {
+      throw new Error("commit is not supported in PuppeteerPage");
+    } else {
+      return origWaitUntil;
+    }
+  }
   async goto(url, options) {
     if (!this.#page) {
       throw new Error("No valid page");
     }
     if (options) {
-      const { referer, timeout, waitUntil } = options;
+      const { referer, timeout, waitUntil = "load" } = options;
       const newOptions = {};
       if (referer) {
         newOptions.referer = referer;
@@ -2037,7 +2083,7 @@ var PuppeteerPage = class extends EventEmitter4 {
         newOptions.timeout = timeout;
       }
       if (waitUntil && waitUntil !== "commit") {
-        newOptions.waitUntil = waitUntil === "networkidle" ? "networkidle0" : waitUntil;
+        newOptions.waitUntil = this.#getWaitUntil(waitUntil);
       }
       await this.#page.goto(url, newOptions);
     } else {
@@ -2351,6 +2397,33 @@ var PuppeteerPage = class extends EventEmitter4 {
     this.#status = "busy";
     return true;
   }
+  async waitForElement(selector, options = {}) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { timeout = 3e4, state = "visible" } = options;
+    if (state === "visible") {
+      await this.#page.waitForSelector(selector, { timeout, visible: true });
+    } else if (state === "hidden") {
+      await this.#page.waitForSelector(selector, { timeout, hidden: true });
+    } else {
+      throw new Error(`${state} is not supported in PuppeteerPage.waitForElement`);
+    }
+    return true;
+  }
+  async waitForNavigation(options) {
+    if (!this.#page) {
+      throw new Error("No valid page");
+    }
+    const { url = "", timeout = 3e4, waitUntil = "load" } = options;
+    const newWaitUntil = this.#getWaitUntil(waitUntil);
+    if (url) {
+      throw new Error("url is not supported in PuppeteerPage.waitForNavigation");
+    } else {
+      await this.#page.waitForNavigation({ timeout, waitUntil: newWaitUntil });
+    }
+    return true;
+  }
   async windowMember(keys) {
     if (!this.#page) {
       throw new Error("No valid page");
@@ -2591,6 +2664,10 @@ var PuppeteerBrowserContext = class extends EventEmitter5 {
   isIncognito() {
     return this.#incognito;
   }
+  page(pageIdx) {
+    const lsdPage = this.#lsdPages.find((p) => p.pageInfo().pageIdx === pageIdx);
+    return lsdPage ? lsdPage : null;
+  }
   pages() {
     return this.#lsdPages;
   }
@@ -16927,6 +17004,12 @@ var CheerioPage = class extends EventEmitter7 {
   use() {
     throw new Error("Not supported in CheerioPage.");
   }
+  waitForElement() {
+    throw new Error("Not supported in CheerioPage.");
+  }
+  waitForNavigation() {
+    throw new Error("Not supported in CheerioPage.");
+  }
   async windowMember() {
     throw new Error("Not supported in CheerioPage.");
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@letsscrapedata/controller",
-  "version": "0.0.2",
+  "version": "0.0.4",
   "description": "Unified browser / HTML controller interfaces that support playwright, puppeteer and cheerio",
   "type": "module",
   "main": "./dist/index.mjs",