@letsrunit/playwright 0.18.2 → 0.18.3

package/src/field/slider.ts

@@ -111,10 +111,15 @@ async function getSliderElement(el: Locator, options?: SetOptions): Promise<Loca
   const role = await el.getAttribute('role', options).catch(() => null);
   if (role === 'slider') return el;
 
-  const slider = el.getByRole('slider');
-  if ((await slider.count()) > 0) {
-    return slider.first();
-  }
+  const sliderByRole = el.getByRole('slider');
+  if ((await sliderByRole.count()) > 0) return sliderByRole.first();
+
+  const sliderByAria = el.locator('[aria-valuenow][aria-valuemin][aria-valuemax]');
+  if ((await sliderByAria.count()) > 0) return sliderByAria.first();
+
+  const sliderByValueNow = el.locator('[aria-valuenow]');
+  if ((await sliderByValueNow.count()) > 0) return sliderByValueNow.first();
+
   return null;
 }
 

package/src/field/toggle.ts

@@ -1,15 +1,38 @@
 import type { Loc, SetOptions, Value } from './types';
 
+async function getToggleTarget(el: Loc['el'], options?: SetOptions): Promise<Loc['el'] | null> {
+  const role = await el.getAttribute('role', options).catch(
+    /* v8 ignore next — attribute might be missing or element might have detached during the check */
+    () => null,
+  );
+  if (role === 'checkbox' || role === 'switch') return el;
+
+  const byRole = el.locator('[role="switch"], [role="checkbox"]').first();
+  if ((await byRole.count()) > 0) return byRole;
+
+  const byState = el.locator('[aria-checked]').first();
+  if ((await byState.count()) > 0) return byState;
+
+  return null;
+}
+
 export async function setToggle({ el }: Loc, value: Value, options?: SetOptions): Promise<boolean> {
   if (typeof value !== 'boolean' && value !== null) return false;
 
-  const role = await el.getAttribute('role', options).catch(/* v8 ignore next */ () => null);
-  if (role !== 'checkbox' && role !== 'switch') return false;
+  const target = await getToggleTarget(el, options);
+  if (!target) return false;
 
-  const ariaChecked = await el.getAttribute('aria-checked', options).catch(/* v8 ignore next */ () => null);
+  const ariaChecked = await target.getAttribute('aria-checked', options).catch(
+    /* v8 ignore next — attribute might be missing or element might have detached during the check */
+    () => null,
+  );
   const isChecked = ariaChecked === 'true';
 
-  if (Boolean(value) !== isChecked) await el.click(options);
+  if (Boolean(value) !== isChecked) await target.click(options);
 
-  return true;
+  const nextAriaChecked = await target.getAttribute('aria-checked', options).catch(
+    /* v8 ignore next — attribute might be missing or element might have detached during the check */
+    () => null,
+  );
+  return nextAriaChecked === String(Boolean(value));
 }

package/src/scrub-html.ts

@@ -182,7 +182,7 @@ export async function realScrubHtml(
   const doc = dom.window.document;
 
   if (o.pickMain) pickMain(doc);
-  dropInfraAndSvg(doc, !!o.dropSvg);
+  dropInfraAndSvg(doc, Boolean(o.dropSvg));
   if (o.dropHidden) dropHiddenTrees(doc);
   if (o.stripAttributes) stripAttributesAndSanitize(doc, o.stripAttributes);
   if (o.dropComments) dropHtmlComments(doc);
@@ -199,7 +199,7 @@ export async function realScrubHtml(
 function hasHiddenAncestor(el: Element): boolean {
   let p: Element | null = el.parentElement;
   while (p) {
-    /* v8 ignore next */
+    /* v8 ignore next — JSDOM might not have these attributes/values, but we want to check them if they exist */
     if (p.hasAttribute('hidden') || p.hasAttribute('inert') || p.getAttribute('aria-hidden') === 'true') return true;
 
     const style = p.getAttribute('style') || '';

package/src/suppress-interferences.ts

@@ -79,7 +79,11 @@ async function tryClick(page: Page, selectors: string[], _label: string) {
 }
 
 async function closeNativeJsAlerts(page: Page) {
-  page.on('dialog', /* v8 ignore next */ (d) => d.accept().catch(() => {}));
+  page.on(
+    'dialog',
+    /* v8 ignore next — callback runs in browser context, not Node */
+    (d) => d.accept().catch(() => {}),
+  );
 }
 
 // 1) Known cookie CMPs (quick wins)
@@ -175,7 +179,7 @@ async function sweepOverlays(page: Page, regex: TrRegExps): Promise<boolean> {
 
   return await page
     .evaluate(
-      /* v8 ignore start */
+      /* v8 ignore start — callback runs in browser context, not Node */
       ([source, flags]) => {
         const acceptRx = new RegExp(source, flags);
         const isBig = (el: Element) => {
@@ -227,7 +231,7 @@ async function sweepOverlays(page: Page, regex: TrRegExps): Promise<boolean> {
       /* v8 ignore stop */
       [acceptRxSource, acceptRxFlags],
     )
-    .catch(/* v8 ignore next */ () => false);
+    .catch(() => false);
 }
 
 export async function suppressInterferences(page: Page, opts: Options = {}) {
@@ -268,9 +272,7 @@ export async function suppressInterferences(page: Page, opts: Options = {}) {
 
       // Optional: bail if we are hitting a loop of re-spawning popups
       if (actions >= maxActions) {
-        /* v8 ignore start */
         if (opts.verbose) console.log(`[suppressInterferences] Max actions ${maxActions} reached, stopping.`);
-        /* v8 ignore stop */
         break;
       }
 

package/src/wait.ts

@@ -15,7 +15,7 @@ export async function waitForMeta(page: Page, timeout = 2500) {
 
   await page
     .waitForFunction(
-      /* v8 ignore start */
+      /* v8 ignore start — callback runs in browser context, not Node */
       () => {
         const head = document.head;
         if (!head) return false;
@@ -39,7 +39,7 @@ export async function waitForDomIdle(
   { quiet = 500, timeout = 10_000 }: { quiet?: number; timeout?: number } = {},
 ) {
   await page.waitForFunction(
-    /* v8 ignore start */
+    /* v8 ignore start — callback runs in browser context, not Node */
     (q) =>
       new Promise<boolean>((resolve) => {
         let last = performance.now();
@@ -72,7 +72,7 @@ export async function waitForDomIdle(
 // This helps with libraries that slide months using WAAPI (common in React UI libs).
 export async function waitForAnimationsToFinish(root: Locator) {
   await root.page().waitForFunction(
-    /* v8 ignore start */
+    /* v8 ignore start — callback runs in browser context, not Node */
     (el) => {
       const animations = (el as HTMLElement).getAnimations?.({ subtree: true }) ?? [];
       return animations.every((a) => a.playState !== 'running');
@@ -81,13 +81,20 @@ export async function waitForAnimationsToFinish(root: Locator) {
     await root.elementHandle(),
   );
 
-  /* v8 ignore next */
-  await root.evaluate(() => new Promise<void>((r) => requestAnimationFrame(() => requestAnimationFrame(() => r()))));
+  await root.evaluate(
+    /* v8 ignore next — callback runs in browser context, not Node */
+    () => new Promise<void>((r) => requestAnimationFrame(() => requestAnimationFrame(() => r()))),
+  );
 }
 
 export async function waitForUrlChange(page: Page, prevUrl: string, timeout: number) {
   try {
-    await page.waitForFunction(/* v8 ignore next */ (u) => location.href !== u, prevUrl, { timeout });
+    await page.waitForFunction(
+      /* v8 ignore next — callback runs in browser context, not Node */
+      (u) => location.href !== u,
+      prevUrl,
+      { timeout },
+    );
     return true;
   } catch {
     return false;
@@ -102,7 +109,7 @@ export async function waitUntilEnabled(page: Page, target: Locator, timeout: num
 
   await page
     .waitForFunction(
-      /* v8 ignore start */
+      /* v8 ignore start — callback runs in browser context, not Node */
       (el) => {
         if (!el || !(el as Element).isConnected) return true; // detached → treat as settled
         const aria = (el as HTMLElement).getAttribute('aria-disabled');
@@ -167,7 +174,14 @@ async function elementKind(target: Locator): Promise<'link' | 'button' | 'other'
   if (role === 'link') return 'link';
   if (role === 'button') return 'button';
 
-  const tag = await target.evaluate(/* v8 ignore next */ (el) => el.tagName.toLowerCase(), null, { timeout: PROBE }).catch(() => '');
+  const tag = await target
+    .evaluate(
+      /* v8 ignore next — callback runs in browser context, not Node */
+      (el) => el.tagName.toLowerCase(),
+      null,
+      { timeout: PROBE },
+    )
+    .catch(() => '');
   if (tag === 'a') return 'link';
 
   if (tag === 'button') return 'button';