@letitbexai_root/lexxit-automation-framework 1.0.6 → 1.0.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@letitbexai_root/lexxit-automation-framework",
-  "version": "1.0.6",
+  "version": "1.0.8",
   "description": "Playwright test execution framework with Express API for test execution and reporting.",
   "publishConfig": {
     "access": "public"

package/scripts/deploy/windows/install-lexxit-agent.ps1

@@ -117,6 +117,7 @@ Copy-Item -Path (Join-Path $PSScriptRoot "*.ps1") -Destination $permanentScripts
 # -- 1. The lexxit-runner account --------------------------------------------
 $securePwd = ConvertTo-SecureString $RunnerPassword -AsPlainText -Force
 $existingUser = Get-LocalUser -Name $RunnerUsername -ErrorAction SilentlyContinue
+$isNewRunnerAccount = -not $existingUser
 if (-not $existingUser) {
     Write-Host "[lexxit] Creating local user $RunnerUsername..."
     # New-LocalUser's -Description has a hard 48-char cap (a SAM user-account
@@ -299,22 +300,18 @@ $msiArgs = @(
     # hand-rolling that obfuscation wrong fails silently into the exact same
     # "VNC authentication failed" this script already had to debug once.
     "SET_PASSWORD=1", "VALUE_OF_PASSWORD=$VncPassword",
-    "SET_ALLOWLOOPBACK=1", "VALUE_OF_ALLOWLOOPBACK=1",
-    # Without these, `msiexec /i` on a TightVNC that is ALREADY installed at
-    # the same product version silently no-ops instead of reapplying
-    # properties - VALUE_OF_PASSWORD included. That left a real VM with
-    # TightVNC still on an old password after this script re-ran (e.g. after
-    # someone changed it by hand via TightVNC's own config UI in between),
-    # while the backend had already stored the new one from this run's
-    # install token, causing the live-view proxy's VNC auth to fail with no
-    # indication why. REINSTALL=ALL + REINSTALLMODE=vomus forces msiexec to
-    # treat this as a genuine reinstall - v: run from source, o: reinstall
-    # if older/missing, m/u: rewrite machine+user registry (where TightVNC's
-    # password actually lives), s: rewrite shortcuts - so the password (and
-    # every other property above) is guaranteed to re-apply every single
-    # time this script runs, install or reinstall alike. Confirmed the hard
-    # way: a real VM's live view broke from exactly this gap.
-    "REINSTALL=ALL", "REINSTALLMODE=vomus"
+    "SET_ALLOWLOOPBACK=1", "VALUE_OF_ALLOWLOOPBACK=1"
+    # Deliberately NO REINSTALL=ALL / REINSTALLMODE here. Both were tried
+    # (see git history) and are actively harmful alongside the uninstall
+    # above: REINSTALL=ALL means "reinstall the features that are already
+    # installed", and since the /x just removed them all, that resolves to
+    # "install nothing" - which SILENTLY OVERRIDES the ADDLOCAL=Server
+    # above. Proven from an MSI verbose log on a real VM: every component
+    # came out "Request: Null; Action: Null", with "Skipping action:
+    # RegService (condition is false)" / "Skipping action: StartService
+    # (condition is false)", and msiexec still exited 0 having installed
+    # nothing at all. The uninstall above is what guarantees a genuinely
+    # fresh install, so these flags bought nothing and broke everything.
 )
 $installResult = Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow -PassThru
 if ($installResult.ExitCode -ne 0) {
@@ -477,3 +474,31 @@ Write-Host "  Agent port:        $AgentPort"
 Write-Host "  VNC port:          5900 (TightVNC, service mode)"
 Write-Host "  Scheduled task:    $taskName (At log on of $RunnerUsername)"
 Write-Host "  NOT validated against a real Windows EC2 AMI yet - test every step above before relying on it in production."
+
+# -- 11. Reboot once, automatically, if this is a brand-new runner account --
+# AutoAdminLogon (both the registry fallback above and Sysinternals'
+# autologon.exe) only takes effect at Windows's own boot-time logon prompt -
+# neither can retroactively log an already-running Windows session into a
+# different user. So on a first-time install, lexxit-runner has never
+# actually had an interactive desktop session, which is why Live View (VNC)
+# shows the Windows lock/login screen instead of a usable desktop, even
+# though the agent task itself already reports healthy (confirmed on a real
+# VM: Start-ScheduledTask against an "At log on" trigger for a user who has
+# never logged on still manages to run something that answers /api/health,
+# just not inside a real lexxit-runner desktop session - so the health
+# check above is not a reliable signal that VNC will show anything useful).
+# One automatic reboot here closes that gap completely: the VM comes back
+# up with lexxit-runner already logged in for real, VNC shows its actual
+# desktop, and this never needs a human to remember "oh, it needs a
+# reboot" again. Skipped when lexxit-runner already existed (e.g. a
+# version/password-only re-run on an already-live agent) - no reason to
+# bounce a VM that's already working.
+if ($isNewRunnerAccount) {
+    Write-Host ""
+    Write-Host "[lexxit] $RunnerUsername was just created, so this VM needs one reboot for its auto-logon to"
+    Write-Host "         actually take effect - that's expected, not a failure. Rebooting now; give it a"
+    Write-Host "         couple of minutes, then check Lexxit -> Administration -> VM Agents - Live View"
+    Write-Host "         should show a real desktop instead of the lock screen once it's back."
+    Start-Sleep -Seconds 5
+    Restart-Computer -Force
+}