@letitbexai_root/lexxit-automation-framework 1.0.5 → 1.0.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@letitbexai_root/lexxit-automation-framework",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "Playwright test execution framework with Express API for test execution and reporting.",
   "publishConfig": {
     "access": "public"

package/scripts/deploy/windows/install-lexxit-agent.ps1

@@ -250,10 +250,37 @@ Invoke-WebRequest -Uri $TightVncMsiUrl -OutFile $tvncMsi -UseBasicParsing
 # following /i is always a genuine fresh install, which does apply every
 # property correctly. /x against the same MSI package is a no-op (not an
 # error) when TightVNC isn't installed yet, so this is safe on every run.
-Start-Process msiexec.exe -ArgumentList @("/x", "`"$tvncMsi`"", "/quiet", "/norestart") -Wait -NoNewWindow
+#
+# Both steps below check msiexec's exit code and wait for the service to
+# actually disappear/reappear rather than just firing /x then /i back to
+# back and trusting it. Found the hard way on a real VM: a `msiexec /i`
+# that reports exit code 0 does not guarantee the tvnserver service
+# actually got registered - after enough uninstall/reinstall churn, Windows
+# Installer's own service-management custom actions (InstallServices/
+# RegService/StartService) can silently no-op while the outer process still
+# exits 0, leaving TightVNC uninstalled and NOTHING listening on 5900 (worse
+# than the wrong-password bug this was meant to fix, and invisible under
+# /quiet with no exit-code or service check). A reboot reliably clears
+# whatever Windows-side state causes this; the exit-code and service-wait
+# checks here exist so a silent failure throws loudly instead of leaving a
+# half-broken agent that looks like it installed fine. /l*v below logs the
+# full MSI trace to %TEMP%\tvnc_install.log for exactly this class of
+# "exit 0 but nothing happened" failure, next time it needs debugging.
+$uninstallResult = Start-Process msiexec.exe -ArgumentList @("/x", "`"$tvncMsi`"", "/quiet", "/norestart") -Wait -NoNewWindow -PassThru
+# 1605 = ERROR_UNKNOWN_PRODUCT - not installed yet, not a failure.
+if ($uninstallResult.ExitCode -ne 0 -and $uninstallResult.ExitCode -ne 1605) {
+    Write-Warning "[lexxit] TightVNC uninstall returned exit code $($uninstallResult.ExitCode) - continuing, but the reinstall below may fail too."
+}
+$waited = 0
+while ((Get-Service tvnserver -ErrorAction SilentlyContinue) -and $waited -lt 30) {
+    Start-Sleep -Seconds 1
+    $waited++
+}
 
+$tvncLogPath = Join-Path $env:TEMP "tvnc_install.log"
 $msiArgs = @(
     "/i", "`"$tvncMsi`"", "/quiet", "/norestart",
+    "/l*v", "`"$tvncLogPath`"",
     "ADDLOCAL=Server",
     "SERVER_REGISTER_AS_SERVICE=1",
     "SERVER_ADD_FIREWALL_EXCEPTION=1",
@@ -272,24 +299,31 @@ $msiArgs = @(
     # hand-rolling that obfuscation wrong fails silently into the exact same
     # "VNC authentication failed" this script already had to debug once.
     "SET_PASSWORD=1", "VALUE_OF_PASSWORD=$VncPassword",
-    "SET_ALLOWLOOPBACK=1", "VALUE_OF_ALLOWLOOPBACK=1",
-    # Without these, `msiexec /i` on a TightVNC that is ALREADY installed at
-    # the same product version silently no-ops instead of reapplying
-    # properties - VALUE_OF_PASSWORD included. That left a real VM with
-    # TightVNC still on an old password after this script re-ran (e.g. after
-    # someone changed it by hand via TightVNC's own config UI in between),
-    # while the backend had already stored the new one from this run's
-    # install token, causing the live-view proxy's VNC auth to fail with no
-    # indication why. REINSTALL=ALL + REINSTALLMODE=vomus forces msiexec to
-    # treat this as a genuine reinstall - v: run from source, o: reinstall
-    # if older/missing, m/u: rewrite machine+user registry (where TightVNC's
-    # password actually lives), s: rewrite shortcuts - so the password (and
-    # every other property above) is guaranteed to re-apply every single
-    # time this script runs, install or reinstall alike. Confirmed the hard
-    # way: a real VM's live view broke from exactly this gap.
-    "REINSTALL=ALL", "REINSTALLMODE=vomus"
+    "SET_ALLOWLOOPBACK=1", "VALUE_OF_ALLOWLOOPBACK=1"
+    # Deliberately NO REINSTALL=ALL / REINSTALLMODE here. Both were tried
+    # (see git history) and are actively harmful alongside the uninstall
+    # above: REINSTALL=ALL means "reinstall the features that are already
+    # installed", and since the /x just removed them all, that resolves to
+    # "install nothing" - which SILENTLY OVERRIDES the ADDLOCAL=Server
+    # above. Proven from an MSI verbose log on a real VM: every component
+    # came out "Request: Null; Action: Null", with "Skipping action:
+    # RegService (condition is false)" / "Skipping action: StartService
+    # (condition is false)", and msiexec still exited 0 having installed
+    # nothing at all. The uninstall above is what guarantees a genuinely
+    # fresh install, so these flags bought nothing and broke everything.
 )
-Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow
+$installResult = Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow -PassThru
+if ($installResult.ExitCode -ne 0) {
+    throw "[lexxit] TightVNC install failed with exit code $($installResult.ExitCode) - msiexec /i did not succeed, nothing is listening on 5900. Check $tvncLogPath for details."
+}
+$waited = 0
+while (-not (Get-Service tvnserver -ErrorAction SilentlyContinue) -and $waited -lt 30) {
+    Start-Sleep -Seconds 1
+    $waited++
+}
+if (-not (Get-Service tvnserver -ErrorAction SilentlyContinue)) {
+    throw "[lexxit] TightVNC install reported success but the tvnserver service never appeared after ${waited}s. Check $tvncLogPath for details - a reboot of this VM has resolved this before."
+}
 # TightVNC's "service mode" specifically captures the active CONSOLE
 # session regardless of which account is logged on there - that is the
 # whole point of running it as a service, and it is NOT the generic