@letitbexai_root/lexxit-automation-framework 1.0.4 → 1.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@letitbexai_root/lexxit-automation-framework",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "Playwright test execution framework with Express API for test execution and reporting.",
   "publishConfig": {
     "access": "public"

package/scripts/deploy/windows/install-lexxit-agent.ps1

@@ -237,8 +237,50 @@ New-NetFirewallRule -DisplayName "Lexxit Agent" -Direction Inbound -Protocol TCP
 Write-Host "[lexxit] Installing TightVNC..."
 $tvncMsi = Join-Path $env:TEMP "tightvnc.msi"
 Invoke-WebRequest -Uri $TightVncMsiUrl -OutFile $tvncMsi -UseBasicParsing
+
+# Confirmed on a real Windows EC2 AMI: REINSTALL=ALL + REINSTALLMODE=vomus
+# (tried first, see git history) does NOT reliably make TightVNC's MSI
+# reapply VALUE_OF_PASSWORD on top of an already-installed copy - verified
+# by decrypting the backend's actual stored password for a freshly
+# re-registered agent and running it through the real VNC auth handshake
+# directly: still rejected, even with REINSTALLMODE=vomus on the reinstall
+# that supposedly set it. TightVNC's password-setting custom action
+# evidently gates on something REINSTALLMODE doesn't override. An explicit
+# uninstall first removes that "already installed" state entirely, so the
+# following /i is always a genuine fresh install, which does apply every
+# property correctly. /x against the same MSI package is a no-op (not an
+# error) when TightVNC isn't installed yet, so this is safe on every run.
+#
+# Both steps below check msiexec's exit code and wait for the service to
+# actually disappear/reappear rather than just firing /x then /i back to
+# back and trusting it. Found the hard way on a real VM: a `msiexec /i`
+# that reports exit code 0 does not guarantee the tvnserver service
+# actually got registered - after enough uninstall/reinstall churn, Windows
+# Installer's own service-management custom actions (InstallServices/
+# RegService/StartService) can silently no-op while the outer process still
+# exits 0, leaving TightVNC uninstalled and NOTHING listening on 5900 (worse
+# than the wrong-password bug this was meant to fix, and invisible under
+# /quiet with no exit-code or service check). A reboot reliably clears
+# whatever Windows-side state causes this; the exit-code and service-wait
+# checks here exist so a silent failure throws loudly instead of leaving a
+# half-broken agent that looks like it installed fine. /l*v below logs the
+# full MSI trace to %TEMP%\tvnc_install.log for exactly this class of
+# "exit 0 but nothing happened" failure, next time it needs debugging.
+$uninstallResult = Start-Process msiexec.exe -ArgumentList @("/x", "`"$tvncMsi`"", "/quiet", "/norestart") -Wait -NoNewWindow -PassThru
+# 1605 = ERROR_UNKNOWN_PRODUCT - not installed yet, not a failure.
+if ($uninstallResult.ExitCode -ne 0 -and $uninstallResult.ExitCode -ne 1605) {
+    Write-Warning "[lexxit] TightVNC uninstall returned exit code $($uninstallResult.ExitCode) - continuing, but the reinstall below may fail too."
+}
+$waited = 0
+while ((Get-Service tvnserver -ErrorAction SilentlyContinue) -and $waited -lt 30) {
+    Start-Sleep -Seconds 1
+    $waited++
+}
+
+$tvncLogPath = Join-Path $env:TEMP "tvnc_install.log"
 $msiArgs = @(
     "/i", "`"$tvncMsi`"", "/quiet", "/norestart",
+    "/l*v", "`"$tvncLogPath`"",
     "ADDLOCAL=Server",
     "SERVER_REGISTER_AS_SERVICE=1",
     "SERVER_ADD_FIREWALL_EXCEPTION=1",
@@ -274,7 +316,18 @@ $msiArgs = @(
     # way: a real VM's live view broke from exactly this gap.
     "REINSTALL=ALL", "REINSTALLMODE=vomus"
 )
-Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow
+$installResult = Start-Process msiexec.exe -ArgumentList $msiArgs -Wait -NoNewWindow -PassThru
+if ($installResult.ExitCode -ne 0) {
+    throw "[lexxit] TightVNC install failed with exit code $($installResult.ExitCode) - msiexec /i did not succeed, nothing is listening on 5900. Check $tvncLogPath for details."
+}
+$waited = 0
+while (-not (Get-Service tvnserver -ErrorAction SilentlyContinue) -and $waited -lt 30) {
+    Start-Sleep -Seconds 1
+    $waited++
+}
+if (-not (Get-Service tvnserver -ErrorAction SilentlyContinue)) {
+    throw "[lexxit] TightVNC install reported success but the tvnserver service never appeared after ${waited}s. Check $tvncLogPath for details - a reboot of this VM has resolved this before."
+}
 # TightVNC's "service mode" specifically captures the active CONSOLE
 # session regardless of which account is logged on there - that is the
 # whole point of running it as a service, and it is NOT the generic