@lessonkit/cli 1.1.0 → 1.3.0

package/README.md

@@ -32,6 +32,8 @@ lessonkit package --target scorm12   # LMS artifact
 
 Every project includes a root `lessonkit.json` manifest (`schemaVersion: 1`).
 
+Subprocess timeout defaults to **30 minutes** (`LESSONKIT_CMD_TIMEOUT_MS`). To disable the timeout, pass `timeoutMs: 0` in the exec API (the env var falls back to 30 minutes when set to `0` or omitted).
+
 ## Docs
 
 [CLI reference](https://lessonkit.readthedocs.io/en/latest/reference/cli.html) · [Packaging guide](https://lessonkit.readthedocs.io/en/latest/guides/react-developers/packaging-and-cli.html) · [Template source](https://github.com/eddiethedean/lessonkit/tree/main/templates/vite-react)

package/dist/bin.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 // src/index.ts
-import { createRequire } from "module";
+import { createRequire as createRequire2 } from "module";
 import { Command } from "commander";
 
 // src/commands/init.ts
@@ -54,7 +54,19 @@ ${details}`;
 
 // src/lib/exec.ts
 import { spawn } from "child_process";
+var DEFAULT_CMD_TIMEOUT_MS = 30 * 60 * 1e3;
+function resolveCommandTimeoutMs(explicit) {
+  if (explicit !== void 0) {
+    return explicit > 0 ? explicit : void 0;
+  }
+  const raw = process.env.LESSONKIT_CMD_TIMEOUT_MS;
+  if (raw === void 0 || raw === "") return DEFAULT_CMD_TIMEOUT_MS;
+  const parsed = Number(raw);
+  if (!Number.isFinite(parsed) || parsed <= 0) return DEFAULT_CMD_TIMEOUT_MS;
+  return parsed;
+}
 async function runCommand(command, args, opts) {
+  const timeoutMs = resolveCommandTimeoutMs(opts.timeoutMs);
   await new Promise((resolvePromise, rejectPromise) => {
     const child = spawn(command, args, {
       cwd: opts.cwd,
@@ -62,25 +74,48 @@ async function runCommand(command, args, opts) {
       stdio: "inherit",
       shell: false
     });
+    let timedOut = false;
+    const timer = timeoutMs !== void 0 ? setTimeout(() => {
+      timedOut = true;
+      child.kill("SIGTERM");
+      setTimeout(() => child.kill("SIGKILL"), 5e3).unref?.();
+    }, timeoutMs) : void 0;
+    const settle = (fn) => {
+      if (timer !== void 0) clearTimeout(timer);
+      fn();
+    };
     child.on("error", (err) => {
-      rejectPromise(
-        new CliError(`Failed to run ${command}: ${err.message}`, {
-          code: "RUNTIME",
-          exitCode: EXIT_RUNTIME
-        })
-      );
+      settle(() => {
+        rejectPromise(
+          new CliError(`Failed to run ${command}: ${err.message}`, {
+            code: "RUNTIME",
+            exitCode: EXIT_RUNTIME
+          })
+        );
+      });
     });
     child.on("close", (code) => {
-      if (code === 0) {
-        resolvePromise();
-        return;
-      }
-      rejectPromise(
-        new CliError(`${command} exited with code ${code ?? "unknown"}.`, {
-          code: "RUNTIME",
-          exitCode: EXIT_RUNTIME
-        })
-      );
+      settle(() => {
+        if (timedOut) {
+          rejectPromise(
+            new CliError(`${command} timed out after ${timeoutMs}ms.`, {
+              code: "RUNTIME",
+              exitCode: EXIT_RUNTIME
+            })
+          );
+          return;
+        }
+        if (code === 0) {
+          resolvePromise();
+          return;
+        }
+        rejectPromise(
+          new CliError(`${command} exited with code ${code ?? "unknown"}.`, {
+            code: "RUNTIME",
+            exitCode: EXIT_RUNTIME
+          })
+        );
+      });
     });
   });
 }
@@ -215,6 +250,7 @@ async function runInit(opts, logger) {
 // src/lib/project.ts
 import { readFileSync, existsSync as existsSync2 } from "fs";
 import { readFile as readFile2 } from "fs/promises";
+import { createRequire } from "module";
 import { dirname as dirname2, join as join2, parse, resolve as resolve2 } from "path";
 import { parseLessonkitManifest } from "@lessonkit/lxpack";
 var LESSONKIT_JSON = "lessonkit.json";
@@ -337,14 +373,22 @@ function assertViteProject(pkg, projectRoot) {
     );
   }
 }
+function projectDeclaresVite(pkg) {
+  return !!(pkg.devDependencies?.vite ?? pkg.dependencies?.vite);
+}
 function resolveViteJs(projectRoot) {
-  let dir = resolve2(projectRoot);
-  const fsRoot = parse(dir).root;
-  while (true) {
-    const viteJs = join2(dir, "node_modules", "vite", "bin", "vite.js");
-    if (existsSync2(viteJs)) return viteJs;
-    if (dir === fsRoot) break;
-    dir = dirname2(dir);
+  const root = resolve2(projectRoot);
+  const localViteJs = join2(root, "node_modules", "vite", "bin", "vite.js");
+  if (existsSync2(localViteJs)) return localViteJs;
+  try {
+    const pkg = JSON.parse(readFileSync(join2(root, PACKAGE_JSON), "utf8"));
+    if (projectDeclaresVite(pkg)) {
+      const req = createRequire(join2(root, "package.json"));
+      const vitePkg = req.resolve("vite/package.json");
+      const hoistedViteJs = join2(dirname2(vitePkg), "bin", "vite.js");
+      if (existsSync2(hoistedViteJs)) return hoistedViteJs;
+    }
+  } catch {
   }
   throw new CliError(
     `Vite not found near ${projectRoot}. Run npm install in the project first.`,
@@ -506,6 +550,17 @@ async function runPackage(opts) {
       issues: result.issues
     });
   }
+  const warnings = result.validation?.issues?.filter((issue) => {
+    const severity = issue.severity?.toLowerCase();
+    return severity !== "error" && severity !== "fatal";
+  });
+  if (warnings?.length && !opts.json) {
+    for (const issue of warnings) {
+      const location = issue.path ?? "course";
+      process.stderr.write(`[lessonkit] packaging warning: ${location}: ${issue.message}
+`);
+    }
+  }
   return {
     ok: true,
     command: "package",
@@ -513,7 +568,8 @@ async function runPackage(opts) {
     projectRoot: project.root,
     outputPath: result.outputPath,
     outputDir: result.outputDir,
-    fileCount: result.fileCount
+    fileCount: result.fileCount,
+    ...warnings?.length ? { warnings } : {}
   };
 }
 
@@ -531,7 +587,7 @@ function createLogger(opts) {
 }
 
 // src/index.ts
-var require2 = createRequire(import.meta.url);
+var require2 = createRequire2(import.meta.url);
 var { version } = require2("../package.json");
 async function handleCommand(fn, logger, json) {
   try {

package/dist/index.js

@@ -1,5 +1,5 @@
 // src/index.ts
-import { createRequire } from "module";
+import { createRequire as createRequire2 } from "module";
 import { Command } from "commander";
 
 // src/commands/init.ts
@@ -52,7 +52,19 @@ ${details}`;
 
 // src/lib/exec.ts
 import { spawn } from "child_process";
+var DEFAULT_CMD_TIMEOUT_MS = 30 * 60 * 1e3;
+function resolveCommandTimeoutMs(explicit) {
+  if (explicit !== void 0) {
+    return explicit > 0 ? explicit : void 0;
+  }
+  const raw = process.env.LESSONKIT_CMD_TIMEOUT_MS;
+  if (raw === void 0 || raw === "") return DEFAULT_CMD_TIMEOUT_MS;
+  const parsed = Number(raw);
+  if (!Number.isFinite(parsed) || parsed <= 0) return DEFAULT_CMD_TIMEOUT_MS;
+  return parsed;
+}
 async function runCommand(command, args, opts) {
+  const timeoutMs = resolveCommandTimeoutMs(opts.timeoutMs);
   await new Promise((resolvePromise, rejectPromise) => {
     const child = spawn(command, args, {
       cwd: opts.cwd,
@@ -60,25 +72,48 @@ async function runCommand(command, args, opts) {
       stdio: "inherit",
       shell: false
     });
+    let timedOut = false;
+    const timer = timeoutMs !== void 0 ? setTimeout(() => {
+      timedOut = true;
+      child.kill("SIGTERM");
+      setTimeout(() => child.kill("SIGKILL"), 5e3).unref?.();
+    }, timeoutMs) : void 0;
+    const settle = (fn) => {
+      if (timer !== void 0) clearTimeout(timer);
+      fn();
+    };
     child.on("error", (err) => {
-      rejectPromise(
-        new CliError(`Failed to run ${command}: ${err.message}`, {
-          code: "RUNTIME",
-          exitCode: EXIT_RUNTIME
-        })
-      );
+      settle(() => {
+        rejectPromise(
+          new CliError(`Failed to run ${command}: ${err.message}`, {
+            code: "RUNTIME",
+            exitCode: EXIT_RUNTIME
+          })
+        );
+      });
     });
     child.on("close", (code) => {
-      if (code === 0) {
-        resolvePromise();
-        return;
-      }
-      rejectPromise(
-        new CliError(`${command} exited with code ${code ?? "unknown"}.`, {
-          code: "RUNTIME",
-          exitCode: EXIT_RUNTIME
-        })
-      );
+      settle(() => {
+        if (timedOut) {
+          rejectPromise(
+            new CliError(`${command} timed out after ${timeoutMs}ms.`, {
+              code: "RUNTIME",
+              exitCode: EXIT_RUNTIME
+            })
+          );
+          return;
+        }
+        if (code === 0) {
+          resolvePromise();
+          return;
+        }
+        rejectPromise(
+          new CliError(`${command} exited with code ${code ?? "unknown"}.`, {
+            code: "RUNTIME",
+            exitCode: EXIT_RUNTIME
+          })
+        );
+      });
     });
   });
 }
@@ -213,6 +248,7 @@ async function runInit(opts, logger) {
 // src/lib/project.ts
 import { readFileSync, existsSync as existsSync2 } from "fs";
 import { readFile as readFile2 } from "fs/promises";
+import { createRequire } from "module";
 import { dirname as dirname2, join as join2, parse, resolve as resolve2 } from "path";
 import { parseLessonkitManifest } from "@lessonkit/lxpack";
 var LESSONKIT_JSON = "lessonkit.json";
@@ -335,14 +371,22 @@ function assertViteProject(pkg, projectRoot) {
     );
   }
 }
+function projectDeclaresVite(pkg) {
+  return !!(pkg.devDependencies?.vite ?? pkg.dependencies?.vite);
+}
 function resolveViteJs(projectRoot) {
-  let dir = resolve2(projectRoot);
-  const fsRoot = parse(dir).root;
-  while (true) {
-    const viteJs = join2(dir, "node_modules", "vite", "bin", "vite.js");
-    if (existsSync2(viteJs)) return viteJs;
-    if (dir === fsRoot) break;
-    dir = dirname2(dir);
+  const root = resolve2(projectRoot);
+  const localViteJs = join2(root, "node_modules", "vite", "bin", "vite.js");
+  if (existsSync2(localViteJs)) return localViteJs;
+  try {
+    const pkg = JSON.parse(readFileSync(join2(root, PACKAGE_JSON), "utf8"));
+    if (projectDeclaresVite(pkg)) {
+      const req = createRequire(join2(root, "package.json"));
+      const vitePkg = req.resolve("vite/package.json");
+      const hoistedViteJs = join2(dirname2(vitePkg), "bin", "vite.js");
+      if (existsSync2(hoistedViteJs)) return hoistedViteJs;
+    }
+  } catch {
   }
   throw new CliError(
     `Vite not found near ${projectRoot}. Run npm install in the project first.`,
@@ -504,6 +548,17 @@ async function runPackage(opts) {
       issues: result.issues
     });
   }
+  const warnings = result.validation?.issues?.filter((issue) => {
+    const severity = issue.severity?.toLowerCase();
+    return severity !== "error" && severity !== "fatal";
+  });
+  if (warnings?.length && !opts.json) {
+    for (const issue of warnings) {
+      const location = issue.path ?? "course";
+      process.stderr.write(`[lessonkit] packaging warning: ${location}: ${issue.message}
+`);
+    }
+  }
   return {
     ok: true,
     command: "package",
@@ -511,7 +566,8 @@ async function runPackage(opts) {
     projectRoot: project.root,
     outputPath: result.outputPath,
     outputDir: result.outputDir,
-    fileCount: result.fileCount
+    fileCount: result.fileCount,
+    ...warnings?.length ? { warnings } : {}
   };
 }
 
@@ -529,7 +585,7 @@ function createLogger(opts) {
 }
 
 // src/index.ts
-var require2 = createRequire(import.meta.url);
+var require2 = createRequire2(import.meta.url);
 var { version } = require2("../package.json");
 async function handleCommand(fn, logger, json) {
   try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lessonkit/cli",
-  "version": "1.1.0",
+  "version": "1.3.0",
   "private": false,
   "description": "LessonKit CLI — init, dev, build, and package learning experiences.",
   "license": "Apache-2.0",
@@ -9,7 +9,7 @@
     "url": "git+https://github.com/eddiethedean/lessonkit.git",
     "directory": "packages/cli"
   },
-  "homepage": "https://github.com/eddiethedean/lessonkit",
+  "homepage": "https://lessonkit.readthedocs.io/en/latest/reference/cli.html",
   "bugs": {
     "url": "https://github.com/eddiethedean/lessonkit/issues"
   },
@@ -42,8 +42,8 @@
     "lint": "echo \"(no lint configured yet)\""
   },
   "dependencies": {
-    "@lessonkit/core": "1.1.0",
-    "@lessonkit/lxpack": "1.1.0",
+    "@lessonkit/core": "1.3.0",
+    "@lessonkit/lxpack": "1.3.0",
     "commander": "^14.0.1"
   },
   "engines": {

package/template/vite-react/package.json

@@ -13,16 +13,16 @@
     "test:coverage": "vitest run --coverage --passWithNoTests=false"
   },
   "dependencies": {
-    "@lessonkit/core": "^1.1.0",
-    "@lessonkit/react": "^1.1.0",
-    "@lessonkit/themes": "^1.1.0",
-    "@lessonkit/xapi": "^1.1.0",
+    "@lessonkit/core": "^1.3.0",
+    "@lessonkit/react": "^1.3.0",
+    "@lessonkit/themes": "^1.3.0",
+    "@lessonkit/xapi": "^1.3.0",
     "react": "^18.3.1",
     "react-dom": "^18.3.1"
   },
   "devDependencies": {
-    "@lessonkit/cli": "^1.1.0",
-    "@lessonkit/lxpack": "^1.1.0",
+    "@lessonkit/cli": "^1.3.0",
+    "@lessonkit/lxpack": "^1.3.0",
     "@testing-library/react": "^16.3.0",
     "@types/react": "^18.3.23",
     "@types/react-dom": "^18.3.7",
@@ -30,6 +30,6 @@
     "jsdom": "^26.1.0",
     "typescript": "^5.8.3",
     "vite": "^7.1.3",
-    "vitest": "^3.2.4"
+    "vitest": "^4.1.8"
   }
 }

package/template/vite-react/vitest.config.ts

@@ -8,7 +8,7 @@ export default defineConfig({
       provider: "v8",
       include: ["src/**/*.{ts,tsx}"],
       exclude: ["dist/**", "node_modules/**", "**/*.d.ts", "**/*.d.cts"],
-      thresholds: { statements: 95, branches: 95, functions: 95, lines: 95 },
+      thresholds: { statements: 85, branches: 85, functions: 85, lines: 85 },
     },
   },
 });