@lesliechan721/aw 0.1.0-beta.61 → 0.1.0-beta.63

package/dist/authoring/scripts/validate-plugin.mjs

@@ -6,7 +6,8 @@ import { createRequire } from 'node:module';
 import * as os from 'node:os';
 import * as path from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
-import { AW_RUNTIME_CONFIG_READER_PATH, createNativeToolReaderSource, createRuntimeConfigSnapshot, getPluginAuthoringAcceptedValues as getCorePluginAuthoringAcceptedValues, getSkillFrontmatterCapabilityRegistry, getManagedCommandArtifactTargets, normalizePluginConfigDefinition, parseManagedCommandPlaceholders, replaceManagedCommandPlaceholders, validateCommandEntryFiles, } from '@lesliechan721/aw-plugin-core/manifest';
+import { assertPluginConfigReferenceSchemas, AW_RUNTIME_CONFIG_READER_PATH, createNativeToolReaderSource, createRuntimeConfigSnapshot, getPluginAuthoringAcceptedValues as getCorePluginAuthoringAcceptedValues, getSkillFrontmatterCapabilityRegistry, getManagedCommandArtifactTargets, normalizePluginConfigDefinition, parseManagedCommandPlaceholders, replaceManagedCommandPlaceholders, validateCommandEntryFiles, validatePluginConfigCandidate, formatPluginConfigIssue, } from '@lesliechan721/aw-plugin-core/manifest';
+import { readCatalogWorkspace } from '@lesliechan721/aw-plugin-core';
 import { checkPluginVersions } from './lib/plugin-version-check.mjs';
 import { scanJavaScriptImportSpecifiers } from './lib/javascript-import-scanner.mjs';
 import { assertAuthoringPluginPathFence, assertCanonicalAuthoringPluginRoot, } from './lib/plugin-root.mjs';
@@ -339,6 +340,7 @@ async function tryLoadCliManifestTools() {
         return {
             assertPluginInputTree: manifestModule.assertPluginInputTree ?? null,
             validateSourcePluginManifest: manifestModule.validateSourcePluginManifest ?? null,
+            reservedImports: manifestModule.CLI_RESERVED_IMPORTS,
             readPluginManifest: manifestModule.readPluginManifest ?? null,
             discoverPlugins: manifestModule.discoverPlugins ?? null,
             resolvePluginRequirements: manifestModule.resolvePluginRequirements ?? null,
@@ -1699,11 +1701,13 @@ function listFilesRecursive(rootDir) {
     walk(rootDir);
     return output;
 }
-function validateConfigSchemaLightweight(config) {
+function validateConfigSchemaLightweight(config, manifest) {
     if (config === undefined)
         return;
     try {
-        normalizePluginConfigDefinition(config);
+        normalizePluginConfigDefinition(config, 'config', {
+            plugin: manifest.name, dependencies: manifest.dependencies ?? [],
+        });
     }
     catch (validationError) {
         error(validationError instanceof Error ? validationError.message : String(validationError));
@@ -1725,6 +1729,14 @@ function defaultConfigValues(manifest) {
     }
     return values;
 }
+function hasCrossPluginValueRef(value) {
+    if (!isRecord(value))
+        return false;
+    if (isRecord(value.valueRef) && value.valueRef.plugin !== undefined)
+        return true;
+    return Object.values(value).some((child) => Array.isArray(child)
+        ? child.some(hasCrossPluginValueRef) : hasCrossPluginValueRef(child));
+}
 function configFieldContainsSensitiveValue(field) {
     if (!isRecord(field))
         return false;
@@ -2656,7 +2668,7 @@ function resolveArtifactRendererFixtureRequests(declarations, manifest, requires
     });
     return [...partitionedAwOwned, ...codexNative.values()];
 }
-async function runArtifactRendererFixture(pluginDir, manifest, renderEntry, declarations, resolvedRuntimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput) {
+async function runArtifactRendererFixture(pluginDir, manifest, renderEntry, declarations, resolvedRuntimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput, referenceContext) {
     if (!renderEntry || declarations.length === 0)
         return [];
     const requests = resolveArtifactRendererFixtureRequests(declarations, manifest, requiresNonSensitiveArtifactInput);
@@ -2697,8 +2709,13 @@ async function runArtifactRendererFixture(pluginDir, manifest, renderEntry, decl
                 : [[key, manifest.config.fields[key]]]));
             const scopedValues = Object.fromEntries(refreshKeys.flatMap((key) => Object.prototype.hasOwnProperty.call(values, key) ? [[key, values[key]]] : []));
             try {
+                if (manifest.config) {
+                    const issues = validatePluginConfigCandidate(manifest.config, values, refreshKeys, referenceContext);
+                    if (issues.length > 0)
+                        throw new Error(formatPluginConfigIssue(issues[0]));
+                }
                 for (const target of scopedDeclarations.filter((declaration) => declaration.runtimeConfig)) {
-                    const definition = normalizePluginConfigDefinition(manifest.config);
+                    const definition = manifest.config;
                     createRuntimeConfigSnapshot({
                         installedIdentity: {
                             sourceId: 'authoring',
@@ -2715,6 +2732,7 @@ async function runArtifactRendererFixture(pluginDir, manifest, renderEntry, decl
                         declaration: target.runtimeConfig,
                         definition,
                         values,
+                        referenceContext,
                     });
                 }
             }
@@ -2862,7 +2880,7 @@ async function runArtifactRendererFixture(pluginDir, manifest, renderEntry, decl
     }
     return returnedArtifacts;
 }
-async function validateDynamicArtifactsLightweight(pluginDir, manifest, renderEntry, runtimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput) {
+async function validateDynamicArtifactsLightweight(pluginDir, manifest, renderEntry, runtimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput, referenceContext) {
     const declarations = validateArtifactsConfigLightweight(pluginDir, manifest);
     if (managedContext)
         declarations.push(...getManagedCommandArtifactTargets(managedContext.manifest));
@@ -2874,7 +2892,7 @@ async function validateDynamicArtifactsLightweight(pluginDir, manifest, renderEn
     if (hasRenderer && !hasTargets) {
         error('scripts.artifacts.render requires artifacts.targets or dynamic managedCommands targets');
     }
-    return runArtifactRendererFixture(pluginDir, manifest, renderEntry, declarations, runtimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput);
+    return runArtifactRendererFixture(pluginDir, manifest, renderEntry, declarations, runtimeImports, skillValidationTools, managedContext, requiresNonSensitiveArtifactInput, referenceContext);
 }
 async function validateAuthorManagedCommands(pluginDir, manifest, rendered, context) {
     const { tools, trees } = context;
@@ -2998,7 +3016,7 @@ async function validateAuthorManagedCommands(pluginDir, manifest, rendered, cont
     }
 }
 function validateScriptsLightweight(pluginDir, manifest) {
-    validateConfigSchemaLightweight(manifest.config);
+    validateConfigSchemaLightweight(manifest.config, manifest);
     if (manifest.scripts === undefined)
         return null;
     const scripts = expectRecord(manifest.scripts, 'scripts');
@@ -3593,12 +3611,41 @@ async function validatePluginDir(pluginDir, options) {
         }
     }
     const skillValidationTools = await tryLoadCliSkillValidationTools();
+    const sourceConfig = manifest.config;
     let normalizedManifest;
+    let referenceContext;
     try {
         normalizedManifest = await cliManifestTools.validateSourcePluginManifest(pluginDir, manifest);
         // Renderer fixtures consume the same compiled config as installed runtime consumers.
         if (normalizedManifest.config)
             manifest.config = normalizedManifest.config;
+        // The Workspace is the sole source of dependency definitions and defaults.
+        // No installed plugin or user config can complete an author fixture.
+        if (manifest.config) {
+            let plugins = [{ manifest, rootDir: pluginDir }];
+            if (hasCrossPluginValueRef(sourceConfig)) {
+                if (!options.repoRoot)
+                    throw new Error('Cross-plugin config validation requires the canonical same-source Workspace.');
+                const workspace = await readCatalogWorkspace(options.repoRoot, {
+                    reservedImports: cliManifestTools.reservedImports,
+                });
+                if (!workspace.plugins.some((plugin) => plugin.manifest.name === manifest.name
+                    && plugin.rootDir === fs.realpathSync(pluginDir))) {
+                    throw new Error('Cross-plugin config validation requires the canonical same-source Workspace plugin.');
+                }
+                plugins = workspace.plugins;
+            }
+            referenceContext = {
+                plugin: manifest.name,
+                dependencies: manifest.dependencies ?? [],
+                plugins: Object.fromEntries(plugins.map((plugin) => [plugin.manifest.name, {
+                        definition: plugin.manifest.config ?? { fields: {} },
+                        dependencies: plugin.manifest.dependencies ?? [],
+                        values: defaultConfigValues(plugin.manifest),
+                    }])),
+            };
+            assertPluginConfigReferenceSchemas(manifest.config, referenceContext, sourceConfig);
+        }
         const requirements = await cliManifestTools.resolvePluginRequirements({
             pluginRoot: pluginDir,
             manifest: normalizedManifest,
@@ -3641,7 +3688,7 @@ async function validatePluginDir(pluginDir, options) {
     const managedContext = normalizedManifest
         ? { manifest: normalizedManifest, tools: cliManifestTools, trees: [] }
         : undefined;
-    const rendered = await validateDynamicArtifactsLightweight(pluginDir, manifest, artifactRenderEntry, runtimeImports, skillValidationTools, managedContext, cliManifestTools.requiresNonSensitiveArtifactInput);
+    const rendered = await validateDynamicArtifactsLightweight(pluginDir, manifest, artifactRenderEntry, runtimeImports, skillValidationTools, managedContext, cliManifestTools.requiresNonSensitiveArtifactInput, referenceContext);
     if (managedContext)
         await validateAuthorManagedCommands(pluginDir, normalizedManifest, rendered ?? [], managedContext);
     validateMcpContent(pluginDir, manifest);