@lenne.tech/nest-server 8.6.18 → 8.6.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lenne.tech/nest-server",
-  "version": "8.6.18",
+  "version": "8.6.21",
   "description": "Modern, fast, powerful Node.js web framework in TypeScript based on Nest with a GraphQL API and a connection to MongoDB (or other databases).",
   "keywords": [
     "node",

package/src/config.env.ts

@@ -12,9 +12,11 @@ const config: { [env: string]: IServerOptions } = {
   local: {
     cronJobs: {
       sayHello: {
-        cronTime: CronExpression.EVERY_5_MINUTES,
-        timeZone: 'Europe/Berlin',
+        cronTime: CronExpression.EVERY_10_SECONDS,
         runOnInit: false,
+        runParallel: 1,
+        timeZone: 'Europe/Berlin',
+        throwException: false,
       },
     },
     email: {

package/src/core/common/helpers/common.helper.ts

@@ -0,0 +1,18 @@
+/**
+ * Wait a certain number of milliseconds
+ */
+export function sleep(ms: number) {
+  return new Promise<void>((resolve) => {
+    setTimeout(() => {
+      resolve();
+    }, ms);
+  });
+}
+
+/**
+ * Wait a certain number of milliseconds
+ * Alias of sleep
+ */
+export function wait(ms: number) {
+  return sleep(ms);
+}

package/src/core/common/helpers/model.helper.ts

@@ -175,9 +175,10 @@ export function mapClasses<T = Record<string, any>>(
   }
 
   // Process input
-  for (const [prop, value] of Object.entries(input)) {
-    if (prop in mapping) {
-      const targetClass = mapping[prop] as any;
+  for (const [prop, mapTarget] of Object.entries(mapping)) {
+    if (prop in input) {
+      const targetClass = mapTarget as any;
+      const value = input[prop];
 
       // Process array
       if (Array.isArray(value)) {
@@ -185,13 +186,12 @@ export function mapClasses<T = Record<string, any>>(
         for (const item of value) {
           if (value instanceof targetClass) {
             arr.push(value);
-          }
-          if (value instanceof Types.ObjectId) {
+          } else if (value instanceof Types.ObjectId) {
             arr.push(value);
           } else if (typeof value === 'object') {
             if (targetClass.map) {
               arr.push(targetClass.map(item));
-            } else if (typeof value === 'object') {
+            } else {
               arr.push(plainToInstance(targetClass, item));
             }
           } else {
@@ -210,11 +210,12 @@ export function mapClasses<T = Record<string, any>>(
       else if (typeof value === 'object') {
         if (value instanceof targetClass) {
           target[prop] = value as any;
-        }
-        if (targetClass.map) {
-          target[prop] = targetClass.map(value);
         } else {
-          target[prop] = plainToInstance(targetClass, value) as any;
+          if (targetClass.map) {
+            target[prop] = targetClass.map(value);
+          } else {
+            target[prop] = plainToInstance(targetClass, value) as any;
+          }
         }
       }
 
@@ -250,9 +251,10 @@ export async function mapClassesAsync<T = Record<string, any>>(
   }
 
   // Process input
-  for (const [prop, value] of Object.entries(input)) {
-    if (prop in mapping) {
-      const targetClass = mapping[prop] as any;
+  for (const [prop, mapTarget] of Object.entries(mapping)) {
+    if (prop in input) {
+      const targetClass = mapTarget as any;
+      const value = input[prop];
 
       // Process array
       if (Array.isArray(value)) {
@@ -260,13 +262,12 @@ export async function mapClassesAsync<T = Record<string, any>>(
         for (const item of value) {
           if (value instanceof targetClass) {
             arr.push(value);
-          }
-          if (value instanceof Types.ObjectId) {
+          } else if (value instanceof Types.ObjectId) {
             arr.push(value);
           } else if (typeof value === 'object') {
             if (targetClass.map) {
               arr.push(await targetClass.map(item));
-            } else if (typeof value === 'object') {
+            } else {
               arr.push(plainToInstance(targetClass, item));
             }
           } else {
@@ -285,11 +286,12 @@ export async function mapClassesAsync<T = Record<string, any>>(
       else if (typeof value === 'object') {
         if (value instanceof targetClass) {
           target[prop] = value as any;
-        }
-        if (targetClass.map) {
-          target[prop] = await targetClass.map(value);
         } else {
-          target[prop] = plainToInstance(targetClass, value) as any;
+          if (targetClass.map) {
+            target[prop] = await targetClass.map(value);
+          } else {
+            target[prop] = plainToInstance(targetClass, value) as any;
+          }
         }
       }
 

package/src/core/common/interfaces/cron-job-config.interface.ts

@@ -24,11 +24,24 @@ export interface CronJobConfig {
   onComplete?: CronCommand | null;
 
   /**
-   * This will immediately fire your `onTickfunction as soon as the requisit initialization has happened.
-   * This option is set to ``true``` by default.
+   * This will immediately fire your `onTickfunction` as soon as the requisit initialization has happened.
+   * This option is set to `true` by default.
    */
   runOnInit?: boolean;
 
+  /**
+   * Depending on how long the execution of a job takes, it may happen that several executions take place at the
+   * same time. This can be prevented with `runParallel = false`.This option is set to `true` by default.
+   * If a number is specified, it is used as the number of maximum parallel executions.
+   */
+  runParallel?: boolean | number;
+
+  /**
+   * Whether an exception is thrown or only acknowledged with a console.error.
+   * This option is set to `true` by default.
+   */
+  throwException?: boolean;
+
   /**
    * Specify the timezone for the execution. This will modify the actual time relative to your timezone.
    * If the timezone is invalid, an error is thrown. Can be any string accepted by luxon's `DateTime.setZone()`

package/src/core/common/services/core-cron-jobs.service.ts

@@ -15,6 +15,11 @@ export abstract class CoreCronJobs {
     log: boolean;
   };
 
+  /**
+   * Cron jobs that are currently running
+   */
+  runningJobs: Record<string, Date[]> = {};
+
   // ===================================================================================================================
   // Initializations
   // ===================================================================================================================
@@ -51,18 +56,20 @@ export abstract class CoreCronJobs {
       }
 
       // Prepare config
-      let config: CronExpression | string | Date | Falsy | CronJobConfig = CronExpressionOrConfig;
-      if (typeof config === 'string' || config instanceof Date) {
-        config = {
-          cronTime: config,
+      let conf: CronExpression | string | Date | Falsy | CronJobConfig = CronExpressionOrConfig;
+      if (typeof conf === 'string' || conf instanceof Date) {
+        conf = {
+          cronTime: conf,
         };
       }
 
       // Set defaults
-      config = {
-        timeZone: 'Europe/Berlin',
+      const config: CronJobConfig = {
         runOnInit: true,
-        ...config,
+        runParallel: true,
+        throwException: true,
+        timeZone: 'Europe/Berlin',
+        ...conf,
       };
 
       // Check if cron job should be activated
@@ -81,8 +88,40 @@ export abstract class CoreCronJobs {
       // Init cron job
       const job = new CronJob(
         config.cronTime,
-        () => {
-          this[name]();
+        async () => {
+          // Get current processes of cron job
+          const dates = this.runningJobs[name];
+
+          // Check if parallel execution is allowed and if so how many can run in parallel
+          if (
+            dates?.length &&
+            (!config.runParallel || (typeof config.runParallel === 'number' && dates.length >= config.runParallel))
+          ) {
+            return;
+          }
+
+          // Prepare the acquisition of parallel job executions
+          if (!this.runningJobs[name]) {
+            this.runningJobs[name] = [];
+          }
+          const date = new Date();
+          this.runningJobs[name].push(date);
+
+          // Execute the job and wait until job process is done
+          try {
+            await this[name]();
+          } catch (e) {
+            // Remove job from running list
+            this.runningJobs[name] = this.runningJobs[name].filter((item) => item !== date);
+            if (config.throwException) {
+              throw e;
+            } else {
+              console.error(e);
+            }
+          }
+
+          // Remove job from running list
+          this.runningJobs[name] = this.runningJobs[name].filter((item) => item !== date);
         },
         null,
         true,

package/src/core/common/services/module.service.ts

@@ -107,6 +107,11 @@ export abstract class ModuleService<T extends CoreModel = any> {
       config.input = await this.prepareInput(config.input, opts);
     }
 
+    // Check rights
+    if (config.checkRights && this.checkRights) {
+      await this.checkRights(undefined, config.currentUser as any, config);
+    }
+
     // Get DB object
     if (config.dbObject && config.checkRights && this.checkRights) {
       if (typeof config.dbObject === 'string' || config.dbObject instanceof Types.ObjectId) {
@@ -144,7 +149,7 @@ export abstract class ModuleService<T extends CoreModel = any> {
     }
 
     // Check output rights
-    if (config.checkRights && this.checkRights) {
+    if (config.checkRights && (await this.checkRights(undefined, config.currentUser as any, config))) {
       const opts: any = {
         dbObject: config.dbObject,
         processType: ProcessType.OUTPUT,

package/src/core/common/types/plain-input.type.ts

@@ -1,5 +1,5 @@
 /**
- * Type for plain Inputs
+ * Type for plain inputs with only optional properties
  */
 export type PlainInput<T> = {
   [P in keyof T]?: Partial<T[P]> | Partial<PlainInput<T[P]>>;

package/src/core/common/types/remove-methods.type.ts

@@ -0,0 +1,4 @@
+/**
+ * Type for plain object with only properties and no methods
+ */
+export type RemoveMethods<T> = { [P in keyof T as T[P] extends (...args: any) => any ? never : P]: T[P] };

package/src/core/common/types/string-or-object-id.type.ts

@@ -1,3 +1,6 @@
 import { Types } from 'mongoose';
 
-export type StringOrObjectId = string | Types.ObjectId | any;
+/**
+ * Everything which will be used by getStringIds or getObjectIds (see helpers/db.helper.ts)
+ */
+export type StringOrObjectId<T = any> = string | Types.ObjectId | T;

package/src/core/modules/file/core-file.service.ts

@@ -1,5 +1,5 @@
 import { NotFoundException } from '@nestjs/common';
-import { GridFSBucket, GridFSBucketReadStreamOptions } from 'mongodb';
+import { GridFSBucket, GridFSBucketReadStream, GridFSBucketReadStreamOptions } from 'mongodb';
 import { Connection, Types } from 'mongoose';
 import { createBucket, MongoGridFSOptions, MongooseGridFS } from 'mongoose-gridfs';
 import { FilterArgs } from '../../common/args/filter.args';
@@ -115,7 +115,7 @@ export abstract class CoreFileService {
     if (!(await this.checkRights(id, { ...serviceOptions, checkInputType: 'id' }))) {
       return null;
     }
-    return this.files.openDownloadStream(getObjectIds(id));
+    return this.files.openDownloadStream(getObjectIds(id)) as GridFSBucketReadStream;
   }
 
   /**

package/src/core/modules/file/interfaces/file-service-options.interface.ts

@@ -3,5 +3,6 @@
  */
 export interface FileServiceOptions {
   currentUser?: { id: any; hasRole: (roles: string[]) => boolean };
+  force?: boolean;
   roles?: string | string[];
 }

package/src/index.ts

@@ -18,6 +18,7 @@ export * from './core/common/enums/logical-operator.enum';
 export * from './core/common/enums/process-type.enum';
 export * from './core/common/enums/role.enum';
 export * from './core/common/enums/sort-order.emum';
+export * from './core/common/helpers/common.helper';
 export * from './core/common/helpers/config.helper';
 export * from './core/common/helpers/context.helper';
 export * from './core/common/helpers/db.helper';
@@ -61,6 +62,7 @@ export * from './core/common/types/field-selection.type';
 export * from './core/common/types/ids.type';
 export * from './core/common/types/maybe-promise.type';
 export * from './core/common/types/plain-input.type';
+export * from './core/common/types/remove-methods.type';
 export * from './core/common/types/require-only-one.type';
 export * from './core/common/types/required-at-least-one.type';
 export * from './core/common/types/string-or-object-id.type';

package/src/server/common/services/cron-jobs.service.ts

@@ -20,7 +20,10 @@ export class CronJobs extends CoreCronJobs {
   // Cron jobs
   // ===================================================================================================================
 
-  protected sayHello() {
+  protected async sayHello() {
     console.log('Hello :)');
+    await new Promise<void>((resolve) => {
+      setTimeout(() => resolve(), 30000);
+    });
   }
 }