@lenne.tech/nest-server 11.24.1 → 11.24.3

package/src/core/common/helpers/register-enum.helper.ts

@@ -2,6 +2,18 @@ import { registerEnumType } from '@nestjs/graphql';
 
 import { enumNameRegistry } from '../decorators/unified-field.decorator';
 
+/**
+ * Tracks which enum objects have been registered for GraphQL via registerEnum/registerEnums.
+ * Used to prevent duplicate registerEnumType() calls which cause schema build errors.
+ * Separate from enumNameRegistry (Swagger) because GraphQL registration is a distinct concern.
+ *
+ * @internal Consumers should use {@link enumNameRegistry} (from unified-field.decorator) to
+ * verify Swagger/name registration. This registry is exported for advanced use cases
+ * (e.g. checking if an enum is already registered for GraphQL before calling registerEnumType
+ * directly), but most projects should not need to interact with it.
+ */
+export const graphqlEnumRegistry = new WeakSet<object>();
+
 /**
  * Interface defining options for the registerEnum helper
  */
@@ -83,11 +95,87 @@ export function registerEnum<T extends object = any>(enumRef: T, options: Regist
   }
 
   // Register for GraphQL if enabled
-  if (graphql) {
+  if (graphql && !graphqlEnumRegistry.has(enumRef)) {
     registerEnumType(enumRef, {
       description,
       name,
       valuesMap,
     });
+    graphqlEnumRegistry.add(enumRef);
+  }
+}
+
+/**
+ * Options for {@link registerEnums} bulk registration.
+ *
+ * Controls which API layers the enums are registered for (GraphQL and/or Swagger/REST).
+ * When omitted, enums are registered for both layers.
+ */
+export interface RegisterEnumsOptions {
+  /**
+   * Whether to register enums for GraphQL using registerEnumType.
+   * @default true
+   */
+  graphql?: boolean;
+
+  /**
+   * Whether to register enums in the enumNameRegistry for Swagger/REST.
+   * When enabled, enum names are auto-detected by {@link UnifiedField} decorators
+   * for the `enumName` property in Swagger/OpenAPI schemas.
+   * @default true
+   */
+  swagger?: boolean;
+}
+
+/**
+ * Bulk-register all enums from a barrel-export namespace object.
+ *
+ * Uses the **export key names** as enum names — no manual name repetition
+ * needed. Call this once per project, typically in your module setup.
+ *
+ * @example
+ * ```typescript
+ * // src/server/common/enums/index.ts (barrel file)
+ * export { ContactStatusEnum } from './contact-status.enum';
+ * export { IndustryEnum } from './industry.enum';
+ * export { NotifyViaEnum } from './notify-via.enum';
+ *
+ * // src/server/server.module.ts (one line)
+ * import * as Enums from './common/enums';
+ * registerEnums(Enums);
+ *
+ * // Result: ContactStatusEnum, IndustryEnum, NotifyViaEnum are all
+ * // registered for both GraphQL and Swagger auto-detection.
+ * ```
+ *
+ * Only plain objects with string/number values (enum-like objects) are
+ * registered. Non-enum exports (functions, classes, strings) are skipped.
+ *
+ * @param namespace - The barrel-export namespace object (`import * as X from '...'`)
+ * @param options - Optional: control GraphQL/Swagger registration
+ */
+export function registerEnums(namespace: Record<string, any>, options?: RegisterEnumsOptions): void {
+  const { graphql = true, swagger = true } = options ?? {};
+
+  for (const [name, value] of Object.entries(namespace)) {
+    // Skip non-objects (functions, strings, numbers, etc.)
+    if (typeof value !== 'object' || value === null || Array.isArray(value)) {
+      continue;
+    }
+
+    // Skip if already registered for all requested targets
+    const alreadySwagger = !swagger || enumNameRegistry.has(value);
+    const alreadyGraphql = !graphql || graphqlEnumRegistry.has(value);
+    if (alreadySwagger && alreadyGraphql) {
+      continue;
+    }
+
+    // Verify it looks like an enum: all own values are strings or numbers
+    const vals = Object.values(value);
+    if (vals.length === 0 || !vals.every((v) => typeof v === 'string' || typeof v === 'number')) {
+      continue;
+    }
+
+    registerEnum(value, { graphql, name, swagger });
   }
 }

package/src/core/common/inputs/combined-filter.input.ts

@@ -18,7 +18,7 @@ export class CombinedFilterInput extends CoreInput {
    */
   @UnifiedField({
     description: 'Logical Operator to combine filters',
-    enum: { enum: LogicalOperatorEnum },
+    enum: LogicalOperatorEnum,
     roles: RoleEnum.S_EVERYONE,
   })
   logicalOperator: LogicalOperatorEnum = undefined;

package/src/core/common/inputs/single-filter.input.ts

@@ -58,7 +58,7 @@ export class SingleFilterInput extends CoreInput {
    */
   @UnifiedField({
     description: '[Comparison operator](https://docs.mongodb.com/manual/reference/operator/query-comparison/)',
-    enum: { enum: ComparisonOperatorEnum },
+    enum: ComparisonOperatorEnum,
     roles: RoleEnum.S_EVERYONE,
   })
   operator: ComparisonOperatorEnum = undefined;

package/src/core/common/inputs/sort.input.ts

@@ -26,7 +26,7 @@ export class SortInput extends CoreInput {
    */
   @UnifiedField({
     description: 'SortInput order of the field',
-    enum: { enum: SortOrderEnum },
+    enum: SortOrderEnum,
     roles: RoleEnum.S_EVERYONE,
   })
   order: SortOrderEnum = undefined;

package/src/core/common/interfaces/server-options.interface.ts

@@ -10,7 +10,12 @@ import { MongoosePingCheckSettings } from '@nestjs/terminus/dist/health-indicato
 import { DiskHealthIndicatorOptions } from '@nestjs/terminus/dist/health-indicator/disk/disk-health-options.type';
 import compression from 'compression';
 import { CollationOptions } from 'mongodb';
+import type * as JSONTransport from 'nodemailer/lib/json-transport';
+import type * as SendmailTransport from 'nodemailer/lib/sendmail-transport';
+import type * as SESTransport from 'nodemailer/lib/ses-transport';
+import type * as SMTPPool from 'nodemailer/lib/smtp-pool';
 import * as SMTPTransport from 'nodemailer/lib/smtp-transport';
+import type * as StreamTransport from 'nodemailer/lib/stream-transport';
 
 import { Falsy } from '../types/falsy.type';
 import { IPermissions } from '../../modules/permissions/interfaces/permissions.interface';
@@ -24,6 +29,29 @@ import { MailjetOptions } from './mailjet-options.interface';
  */
 export type BetterAuthFieldType = 'boolean' | 'date' | 'json' | 'number' | 'number[]' | 'string' | 'string[]';
 
+/**
+ * All transport configurations accepted by `nodemailer.createTransport()`.
+ *
+ * Covers every built-in transport nodemailer ships with. `JSONTransport` is
+ * particularly useful in CI / e2e tests: `{ jsonTransport: true }` serializes
+ * outgoing mail to a JSON string and returns a valid response without any
+ * network I/O — no SMTP server, no credentials, no flakiness.
+ */
+export type MailTransportOptions =
+  | JSONTransport
+  | JSONTransport.Options
+  | SendmailTransport
+  | SendmailTransport.Options
+  | SESTransport
+  | SESTransport.Options
+  | SMTPPool
+  | SMTPPool.Options
+  | SMTPTransport
+  | SMTPTransport.Options
+  | StreamTransport
+  | StreamTransport.Options
+  | string;
+
 /**
  * Interface for Auth configuration
  *
@@ -1147,9 +1175,13 @@ export interface IServerOptions {
     passwordResetLink?: string;
 
     /**
-     * SMTP configuration for nodemailer
+     * Mail transport configuration for nodemailer.
+     *
+     * Accepts any transport type supported by `nodemailer.createTransport()`.
+     * See {@link MailTransportOptions} for the full list including
+     * `JSONTransport` / `{ jsonTransport: true }` for CI and e2e tests.
      */
-    smtp?: SMTPTransport | SMTPTransport.Options | string;
+    smtp?: MailTransportOptions;
 
     /**
      * Verification link for email

package/src/core/common/services/email.service.ts

@@ -1,11 +1,10 @@
-import type SMTPPool = require('nodemailer/lib/smtp-pool');
-
 import { createHash } from 'crypto';
 import { Injectable, OnModuleDestroy } from '@nestjs/common';
 import nodemailer = require('nodemailer');
 import { Attachment } from 'nodemailer/lib/mailer';
 
 import { isNonEmptyString, isTrue, returnFalse } from '../helpers/input.helper';
+import { MailTransportOptions } from '../interfaces/server-options.interface';
 import { ConfigService } from './config.service';
 import { TemplateService } from './template.service';
 
@@ -49,7 +48,7 @@ export class EmailService implements OnModuleDestroy {
       htmlTemplate?: string;
       senderEmail?: string;
       senderName?: string;
-      smtp?: SMTPPool | SMTPPool.Options;
+      smtp?: MailTransportOptions;
       templateData?: { [key: string]: any };
       text?: string;
       textTemplate?: string;
@@ -90,6 +89,21 @@ export class EmailService implements OnModuleDestroy {
       isNonEmptyString(html);
     }
 
+    // Guard: JSONTransport silently discards all mail — block in production / staging
+    // to prevent accidental misconfiguration that causes password-reset, 2FA, and
+    // verification emails to vanish without error.
+    // Uses truthy check (not strict === true) because nodemailer activates
+    // JSONTransport for any truthy value of options.jsonTransport.
+    const env = this.configService.getFastButReadOnly<string>('env');
+    if (env === 'production' || env === 'staging') {
+      if (typeof smtp === 'object' && smtp !== null && !!(smtp as Record<string, unknown>).jsonTransport) {
+        throw new Error(
+          'JSONTransport (jsonTransport: true) is not permitted in production/staging environments. ' +
+            'It silently discards all outgoing email. Check email.smtp in your config.',
+        );
+      }
+    }
+
     // Reuse transporter if SMTP config hasn't changed (avoids creating new connections per email)
     // Use hash instead of raw JSON to avoid keeping credentials as a string in memory
     const smtpKey = createHash('sha256').update(JSON.stringify(smtp)).digest('hex');