@lendi/act-credit-decisions-transform 2.0.16 → 2.0.18

package/lib/logger.d.ts

@@ -1,4 +1 @@
-export declare const logger: import("pino").Logger<{
-    name: string;
-    messageKey: string;
-}>;
+export declare const logger: import("pino").Logger<never>;

package/lib/schemas/public-asset-event.json

@@ -529,11 +529,14 @@
         "properties": {
           "type": {
             "type": "string",
+            "description": "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX is deprecated.",
             "enum": [
               "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
               "PRIMARY_RESIDENCE_RUNNING_COSTS",
               "INVESTMENT_PROPERTY_RUNNING_COSTS",
-              "SECONDARY_RESIDENCE_RUNNING_COSTS"
+              "SECONDARY_RESIDENCE_RUNNING_COSTS",
+              "STRATA_BODY_CORPORATE_FEES",
+              "LAND_TAX"
             ]
           },
           "amount": {

package/lib/schemas/public-expense-event.json

@@ -67,6 +67,7 @@
         "properties": {
           "type": {
             "type": "string",
+            "description": "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX has been deprecated",
             "enum": [
               "RENT_UTILITIES",
               "LIVING_EXPENSES_ESTIMATE",
@@ -81,7 +82,6 @@
               "TELEPHONE_INTERNET_PAY_TV_AND_MEDIA_STREAMING_SUBSCRIPTIONS",
               "PET_CARE",
               "TRANSPORT",
-              "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
               "PRIMARY_RESIDENCE_RUNNING_COSTS",
               "INVESTMENT_PROPERTY_RUNNING_COSTS",
               "SECONDARY_RESIDENCE_RUNNING_COSTS",
@@ -91,7 +91,10 @@
               "MEDICAL_AND_HEALTH",
               "RENT",
               "BOARD",
-              "OTHER"
+              "OTHER",
+              "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
+              "STRATA_BODY_CORPORATE_FEES",
+              "LAND_TAX"
             ]
           },
           "amount": {

package/lib/transform-events/transform-asset.js

@@ -263,7 +263,7 @@ exports.getAssetMapping = getAssetMapping;
  */
 function generateLivingExpenses(percentOwned, assetId, propertyExpenses) {
     let livingExpenses = [];
-    const filteredPropertyExpenses = propertyExpenses.filter((expense) => expense.amount !== undefined);
+    const filteredPropertyExpenses = preSumUpStrataExpense(propertyExpenses.filter((expense) => expense.amount !== undefined));
     percentOwned.owners.forEach((owner) => {
         const expenses = filteredPropertyExpenses.map((expense) => {
             normalizeAmounts(expense);
@@ -287,6 +287,32 @@ function generateLivingExpenses(percentOwned, assetId, propertyExpenses) {
     return livingExpenses;
 }
 exports.generateLivingExpenses = generateLivingExpenses;
+/**
+ * Pre-sum the body strata and land tax amount into one record.
+ * When the BodyCorporateFeesStrataFeesAndLandTax is fully deprecated, we can remove this function to let the StrataBodyCorporateFees and LandTax to flow out as normal
+ *
+ * @param expenses
+ */
+function preSumUpStrataExpense(expenses) {
+    const summingTypes = [
+        public_asset_1.PropertyExpenseType.BodyCorporateFeesStrataFeesAndLandTax,
+        public_asset_1.PropertyExpenseType.StrataBodyCorporateFees,
+        public_asset_1.PropertyExpenseType.LandTax,
+    ];
+    const effectedExpenses = expenses.filter((expense) => summingTypes.includes(expense.type));
+    const unEffectedExpenses = expenses.filter((expense) => !summingTypes.includes(expense.type));
+    if (!effectedExpenses.length)
+        return unEffectedExpenses;
+    const sumEffectedExpenses = (0, lodash_1.sumBy)(effectedExpenses, 'amount');
+    return [
+        ...(sumEffectedExpenses > 0
+            ? [
+                Object.assign(Object.assign({}, effectedExpenses[0]), { type: public_asset_1.PropertyExpenseType.BodyCorporateFeesStrataFeesAndLandTax, amount: sumEffectedExpenses }),
+            ]
+            : []),
+        ...unEffectedExpenses,
+    ];
+}
 /**
  * Creates PropertyExpense array on RealEstateAsset from the same array on the event.
  *

package/lib/transform-events/transform-expenses.js

@@ -6,6 +6,7 @@ const application_paths_1 = require("@lendi/act-eac-integrations-protocol/lib/ut
 const lodash_1 = require("lodash");
 const enum_mappings_1 = require("../types/enum-mappings/");
 const public_expense_1 = require("../types/events/public-expense");
+const uniqueid_tools_1 = require("../utils/uniqueid-tools");
 exports.otherCommitmentExpenseTypes = [
     public_expense_1.ExpenseType.Board,
     public_expense_1.ExpenseType.ChildAndSpousalMaintenance,
@@ -14,6 +15,8 @@ exports.otherCommitmentExpenseTypes = [
 const propertyExpenseCategories = [
     public_expense_1.ExpenseType.InvestmentPropertyRunningCosts,
     public_expense_1.ExpenseType.BodyCorporateFeesStrataFeesAndLandTax,
+    public_expense_1.ExpenseType.StrataBodyCorporateFees,
+    public_expense_1.ExpenseType.LandTax,
     public_expense_1.ExpenseType.SecondaryResidenceRunningCosts,
     public_expense_1.ExpenseType.PrimaryResidenceRunningCosts,
 ];
@@ -29,7 +32,7 @@ function transformExpenses(expense) {
         return partialApplication;
     }
     const normalisedExpenses = expenses.map(normaliseExpenseAmount);
-    const filteredLivingExpensesWithAmount = normalisedExpenses.filter((expense) => expense.amount || !propertyExpenseCategories.includes(expense.type));
+    const filteredLivingExpensesWithAmount = preSumUpStrataExpense(normalisedExpenses.filter((expense) => expense.amount || !propertyExpenseCategories.includes(expense.type)));
     const livingExpenseEstimate = filteredLivingExpensesWithAmount.find(isLivingExpenseEstimate);
     const otherCommitments = filteredLivingExpensesWithAmount.filter(isOtherCommitment);
     const expenseBreakdown = filteredLivingExpensesWithAmount.filter((item) => !(isOtherCommitment(item) || isLivingExpenseEstimate(item)));
@@ -73,7 +76,8 @@ function transformExpense(expense, applicantId, index, id) {
         '@Amount': expense.amount,
         '@Category': enum_mappings_1.livingExpenseMapping[expense.type],
         '@Description': expense.type,
-        '@UniqueID': isOtherCommitment(expense) ? `${id}-commitment-${index}` : `${id}-living-expense-${index}`,
+        // '@UniqueID': isOtherCommitment(expense) ? `${id}-commitment-${index}` : `${id}-living-expense-${index}`,
+        '@UniqueID': (0, uniqueid_tools_1.truncateUniqueId)(id + '-' + applicantId + '-' + expense.type),
         '@Frequency': enum_mappings_1.frequencyMapping[expense.frequency],
         PercentResponsible: {
             Owner: [
@@ -103,6 +107,32 @@ function normaliseExpenseAmount(expense) {
     return expense;
 }
 exports.normaliseExpenseAmount = normaliseExpenseAmount;
+/**
+ * Pre-sum the body strata and land tax amount into one record.
+ * When the BodyCorporateFeesStrataFeesAndLandTax is fully deprecated, we can remove this function to let the StrataBodyCorporateFees and LandTax to flow out as normal
+ *
+ * @param expenses
+ */
+function preSumUpStrataExpense(expenses) {
+    const summingTypes = [
+        public_expense_1.ExpenseType.BodyCorporateFeesStrataFeesAndLandTax,
+        public_expense_1.ExpenseType.StrataBodyCorporateFees,
+        public_expense_1.ExpenseType.LandTax,
+    ];
+    const effectedExpenses = expenses.filter((expense) => summingTypes.includes(expense.type));
+    const unEffectedExpenses = expenses.filter((expense) => !summingTypes.includes(expense.type));
+    if (!effectedExpenses.length)
+        return unEffectedExpenses;
+    const sumEffectedExpenses = (0, lodash_1.sumBy)(effectedExpenses, 'amount');
+    return [
+        ...(sumEffectedExpenses > 0
+            ? [
+                Object.assign(Object.assign({}, effectedExpenses[0]), { type: public_expense_1.ExpenseType.BodyCorporateFeesStrataFeesAndLandTax, amount: (0, lodash_1.sumBy)(effectedExpenses, 'amount') }),
+            ]
+            : []),
+        ...unEffectedExpenses,
+    ];
+}
 /**
  * @description Verify if expense is an OtherCommitment.
  * @param {Expense} expense Any Expense item.

package/lib/types/enum-mappings/living-expense.js

@@ -5,7 +5,6 @@ const lixi_internal_request_1 = require("@lendi/act-eac-integrations-protocol/li
 const public_expense_1 = require("../events/public-expense");
 exports.livingExpenseMapping = {
     [public_expense_1.ExpenseType.Board]: lixi_internal_request_1.OtherCommitmentCategoryList.Board,
-    [public_expense_1.ExpenseType.BodyCorporateFeesStrataFeesAndLandTax]: lixi_internal_request_1.LivingExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTaxOnOwnerOccupiedPrincipalPlaceOfResidence,
     [public_expense_1.ExpenseType.ChildAndSpousalMaintenance]: lixi_internal_request_1.OtherCommitmentCategoryList.ChildAndSpousalMaintenance,
     [public_expense_1.ExpenseType.Childcare]: lixi_internal_request_1.LivingExpenseCategoryList.Childcare,
     [public_expense_1.ExpenseType.ClothingAndPersonalCare]: lixi_internal_request_1.LivingExpenseCategoryList.ClothingAndPersonalCare,
@@ -28,4 +27,7 @@ exports.livingExpenseMapping = {
     [public_expense_1.ExpenseType.SecondaryResidenceRunningCosts]: lixi_internal_request_1.LivingExpenseCategoryList.SecondaryResidenceRunningCosts,
     [public_expense_1.ExpenseType.TelephoneInternetPayTvAndMediaStreamingSubscriptions]: lixi_internal_request_1.LivingExpenseCategoryList.TelephoneInternetPayTVAndMediaStreamingSubscriptions,
     [public_expense_1.ExpenseType.Transport]: lixi_internal_request_1.LivingExpenseCategoryList.Transport,
+    [public_expense_1.ExpenseType.BodyCorporateFeesStrataFeesAndLandTax]: lixi_internal_request_1.LivingExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTaxOnOwnerOccupiedPrincipalPlaceOfResidence,
+    [public_expense_1.ExpenseType.StrataBodyCorporateFees]: lixi_internal_request_1.LivingExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTaxOnOwnerOccupiedPrincipalPlaceOfResidence,
+    [public_expense_1.ExpenseType.LandTax]: lixi_internal_request_1.LivingExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTaxOnOwnerOccupiedPrincipalPlaceOfResidence,
 };

package/lib/types/enum-mappings/property-expense-category.js

@@ -8,4 +8,6 @@ exports.propertyExpenseCategoryMapping = {
     [public_asset_1.PropertyExpenseType.InvestmentPropertyRunningCosts]: lixi_internal_request_1.PropertyExpenseCategoryList.RunningCosts,
     [public_asset_1.PropertyExpenseType.PrimaryResidenceRunningCosts]: lixi_internal_request_1.PropertyExpenseCategoryList.RunningCosts,
     [public_asset_1.PropertyExpenseType.SecondaryResidenceRunningCosts]: lixi_internal_request_1.PropertyExpenseCategoryList.RunningCosts,
+    [public_asset_1.PropertyExpenseType.StrataBodyCorporateFees]: lixi_internal_request_1.PropertyExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTax,
+    [public_asset_1.PropertyExpenseType.LandTax]: lixi_internal_request_1.PropertyExpenseCategoryList.BodyCorporateFeesStrataFeesAndLandTax,
 };

package/lib/types/events/public-asset.d.ts

@@ -426,7 +426,12 @@ export declare enum Frequency {
     Yearly = "YEARLY"
 }
 export declare enum PropertyExpenseType {
+    /**
+     * @deprecated The field has been deprecated and replaced with StrataBodyCorporateFees and LandTax
+     */
     BodyCorporateFeesStrataFeesAndLandTax = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
+    StrataBodyCorporateFees = "STRATA_BODY_CORPORATE_FEES",
+    LandTax = "LAND_TAX",
     InvestmentPropertyRunningCosts = "INVESTMENT_PROPERTY_RUNNING_COSTS",
     PrimaryResidenceRunningCosts = "PRIMARY_RESIDENCE_RUNNING_COSTS",
     SecondaryResidenceRunningCosts = "SECONDARY_RESIDENCE_RUNNING_COSTS"

package/lib/types/events/public-asset.js

@@ -279,7 +279,12 @@ var Frequency;
 })(Frequency || (exports.Frequency = Frequency = {}));
 var PropertyExpenseType;
 (function (PropertyExpenseType) {
+    /**
+     * @deprecated The field has been deprecated and replaced with StrataBodyCorporateFees and LandTax
+     */
     PropertyExpenseType["BodyCorporateFeesStrataFeesAndLandTax"] = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX";
+    PropertyExpenseType["StrataBodyCorporateFees"] = "STRATA_BODY_CORPORATE_FEES";
+    PropertyExpenseType["LandTax"] = "LAND_TAX";
     PropertyExpenseType["InvestmentPropertyRunningCosts"] = "INVESTMENT_PROPERTY_RUNNING_COSTS";
     PropertyExpenseType["PrimaryResidenceRunningCosts"] = "PRIMARY_RESIDENCE_RUNNING_COSTS";
     PropertyExpenseType["SecondaryResidenceRunningCosts"] = "SECONDARY_RESIDENCE_RUNNING_COSTS";

package/lib/types/events/public-expense.d.ts

@@ -34,7 +34,6 @@ export declare enum Frequency {
 }
 export declare enum ExpenseType {
     Board = "BOARD",
-    BodyCorporateFeesStrataFeesAndLandTax = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
     ChildAndSpousalMaintenance = "CHILD_AND_SPOUSAL_MAINTENANCE",
     Childcare = "CHILDCARE",
     ClothingAndPersonalCare = "CLOTHING_AND_PERSONAL_CARE",
@@ -56,7 +55,13 @@ export declare enum ExpenseType {
     RentUtilities = "RENT_UTILITIES",
     SecondaryResidenceRunningCosts = "SECONDARY_RESIDENCE_RUNNING_COSTS",
     TelephoneInternetPayTvAndMediaStreamingSubscriptions = "TELEPHONE_INTERNET_PAY_TV_AND_MEDIA_STREAMING_SUBSCRIPTIONS",
-    Transport = "TRANSPORT"
+    Transport = "TRANSPORT",
+    /**
+     * @deprecated The field has been deprecated and replaced with StrataBodyCorporateFees and LandTax
+     */
+    BodyCorporateFeesStrataFeesAndLandTax = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX",
+    StrataBodyCorporateFees = "STRATA_BODY_CORPORATE_FEES",
+    LandTax = "LAND_TAX"
 }
 /**
  * The metadata of the alieo

package/lib/types/events/public-expense.js

@@ -12,7 +12,6 @@ var Frequency;
 var ExpenseType;
 (function (ExpenseType) {
     ExpenseType["Board"] = "BOARD";
-    ExpenseType["BodyCorporateFeesStrataFeesAndLandTax"] = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX";
     ExpenseType["ChildAndSpousalMaintenance"] = "CHILD_AND_SPOUSAL_MAINTENANCE";
     ExpenseType["Childcare"] = "CHILDCARE";
     ExpenseType["ClothingAndPersonalCare"] = "CLOTHING_AND_PERSONAL_CARE";
@@ -35,6 +34,12 @@ var ExpenseType;
     ExpenseType["SecondaryResidenceRunningCosts"] = "SECONDARY_RESIDENCE_RUNNING_COSTS";
     ExpenseType["TelephoneInternetPayTvAndMediaStreamingSubscriptions"] = "TELEPHONE_INTERNET_PAY_TV_AND_MEDIA_STREAMING_SUBSCRIPTIONS";
     ExpenseType["Transport"] = "TRANSPORT";
+    /**
+     * @deprecated The field has been deprecated and replaced with StrataBodyCorporateFees and LandTax
+     */
+    ExpenseType["BodyCorporateFeesStrataFeesAndLandTax"] = "BODY_CORPORATE_FEES_STRATA_FEES_AND_LAND_TAX";
+    ExpenseType["StrataBodyCorporateFees"] = "STRATA_BODY_CORPORATE_FEES";
+    ExpenseType["LandTax"] = "LAND_TAX";
 })(ExpenseType || (exports.ExpenseType = ExpenseType = {}));
 /**
  * role of the user that made the action

package/lib/utils/uniqueid-tools.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Guarantee that the uniqueId is no more than maxLength length
+ *
+ * @param id
+ * @param maxLength Maximum length limit. For ANZ it should be 100.
+ * @returns
+ */
+export declare const truncateUniqueId: (id: string, maxLength?: number) => string;

package/lib/utils/uniqueid-tools.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.truncateUniqueId = void 0;
+/**
+ * Guarantee that the uniqueId is no more than maxLength length
+ *
+ * @param id
+ * @param maxLength Maximum length limit. For ANZ it should be 100.
+ * @returns
+ */
+const truncateUniqueId = (id, maxLength = 100) => {
+    return id.length > maxLength ? id.substring(0, maxLength - 1) : id;
+};
+exports.truncateUniqueId = truncateUniqueId;

package/package.json

@@ -1,6 +1,7 @@
 {
   "name": "@lendi/act-credit-decisions-transform",
-  "version": "2.0.16",
+  "version": "2.0.18",
+  "private": false,
   "description": "Library for kafka event data transforming",
   "author": "Integrations <integrations@lendi.com.au>",
   "homepage": "https://bitbucket.org/lendi-dev/integrations-shared-packages#readme",
@@ -22,13 +23,14 @@
   },
   "dependencies": {
     "@lendi/integrations-credit-protocol": "1.18.8",
-    "@lendi/act-eac-integrations-protocol": "3.1.6",
+    "@lendi/act-eac-integrations-protocol": "3.1.8",
     "clean-deep": "^3.4.0",
     "date-fns": "2.19.0",
     "lodash": "^4.17.15"
   },
   "peerDependencies": {
-    "pino": "^8.1.0"
+    "pino": "^8.1.0",
+    "uuid": "^8.3.2"
   },
   "devDependencies": {
     "@lendi/prettier-config": "^1.0.0",