@legalplace/conditions-runner 2.4.9 → 2.4.11

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.4.11](https://git.legalplace.eu/legalplace/monorepo/compare/@legalplace/conditions-runner@2.4.10...@legalplace/conditions-runner@2.4.11) (2026-10-05)
+
+### Bug Fixes
+
+- ignore groupMeta when evaluating conditions ([3bb571a](https://git.legalplace.eu/legalplace/monorepo/commits/3bb571a97381aa96d07a7f226d75c9a64d476851)), closes [api#124j4fvk6w6](https://git.legalplace.eu/api/issues/124j4fvk6w6)
+
+## [2.4.10](https://git.legalplace.eu/legalplace/monorepo/compare/@legalplace/conditions-runner@2.4.9...@legalplace/conditions-runner@2.4.10) (2026-10-01)
+
+**Note:** Version bump only for package @legalplace/conditions-runner
+
 ## [2.4.9](https://git.legalplace.eu/legalplace/monorepo/compare/@legalplace/conditions-runner@2.4.8...@legalplace/conditions-runner@2.4.9) (2026-10-01)
 
 **Note:** Version bump only for package @legalplace/conditions-runner

package/dist/ConditionsRunner.js

@@ -87,7 +87,7 @@ class ConditionsRunner {
         const deps = { references: this.references, ovc: this.ovc };
         const aggregatedConditions = (0, ScopedLeafEvaluator_1.aggregateScopedLeaves)((0, referencesparser_1.lowerScope)(condition.conditions), new DataPopulator_1.default(this, this.references, this.ovc, condition.dataMap).getData(), resolverContext, deps);
         const resolvedConditions = (0, ComparatorResolver_1.resolveConditionComparators)(aggregatedConditions, resolverContext, deps);
-        const result = (0, lplogic_1.default)(resolvedConditions, currentData);
+        const result = (0, lplogic_1.default)((0, referencesparser_1.stripConditionUiMetadata)(resolvedConditions), currentData);
         this.executeConditionMemo[memoizedKey] = result;
         return result;
     }

package/dist/ConditionsRunner.test.js

@@ -302,6 +302,68 @@ describe("resolveConditionComparators", () => {
         });
     });
 });
+const buildMandatDocumentReferences = () => ({
+    options: {
+        3068: {
+            meta: { id: 3068, type: "static", label: "Section", step: "*" },
+            options: [],
+            variables: [3515],
+        },
+    },
+    variables: {
+        3515: {
+            meta: { id: 3515, type: "list", label: "MASTER CREATION avec LP" },
+            options: [],
+        },
+    },
+    outputs: {},
+    boxes: {},
+    documents: {
+        "mandat-2": { name: "Mandat", params: { formats: { pdf: true } } },
+    },
+    sections: {},
+    relations: {
+        options: {
+            3068: {
+                ...emptyOptionRelations,
+                children: { options: [], variables: [3515] },
+            },
+        },
+        variables: {
+            3515: { ...emptyOptionRelations, parents: [3068] },
+        },
+        sections: {},
+    },
+    conditions: {
+        options: {},
+        variables: {},
+        documents: {},
+        sections: { main: {} },
+        prefillers: {},
+        validators: { options: {}, variables: {} },
+    },
+    defaults: {},
+    evaluations: {},
+    optionTags: {},
+    variableTags: {},
+});
+const mandatCondition = {
+    and: [{ "<>": [{ var: "v.3515" }, "non"] }],
+    groupMeta: { label: "", collapsed: false },
+};
+describe("document conditions carrying groupMeta", () => {
+    const runner = new ConditionsRunner_1.default(buildMandatDocumentReferences(), {
+        options: {},
+        variables: { 3515: ["oui"] },
+    });
+    it("returns true for the same rule when the AND group has no groupMeta", () => {
+        const { groupMeta: _groupMeta, ...rule } = mandatCondition;
+        expect(runner.executeCondition(mappedCondition(rule), 0, 0, "documents", "mandat-2")).toBe(true);
+    });
+    it("returns true for 3515 <> non when the AND group also has groupMeta", () => {
+        expect(runner.executeCondition(mappedCondition(mandatCondition), 0, 0, "documents", "mandat-2")).toBe(true);
+    });
+});
 describe("includes / does-not-include operators", () => {
     it("should lower the operator to includes-any when the scope is any", () => {
         expect((0, referencesparser_1.lowerScope)({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@legalplace/conditions-runner",
-  "version": "2.4.9",
+  "version": "2.4.11",
   "description": "Package containing method to execute conditions",
   "license": "MIT",
   "main": "dist/ConditionsRunner.js",
@@ -22,13 +22,13 @@
   "prettier": "@legalplace/prettier-config",
   "dependencies": {
     "@legalplace/lplogic": "2.4.1",
-    "@legalplace/models-v3-types": "^5.20.3",
-    "@legalplace/referencesparser": "^3.4.10"
+    "@legalplace/models-v3-types": "^5.20.4",
+    "@legalplace/referencesparser": "^3.4.11"
   },
   "devDependencies": {
     "@legalplace/eslint-config": "^2.3.1",
     "@legalplace/prettier-config": "^2.1.3",
-    "@legalplace/types": "^2.25.2",
+    "@legalplace/types": "^2.25.3",
     "@swc-node/jest": "^1.4.3",
     "@types/jest": "^27.0.2",
     "identity-obj-proxy": "^3.0.0",
@@ -38,5 +38,5 @@
     "jest-junit": "^13.0.0",
     "ts-node": "^10.8.1"
   },
-  "gitHead": "1aa0a03a3384200f84f98311277f22f93a7fb1f2"
+  "gitHead": "01a1d60bb5aeedd8f0582816e7e81d6c55be2600"
 }

package/src/ConditionsRunner.test.ts

@@ -389,6 +389,82 @@ describe("resolveConditionComparators", () => {
   });
 });
 
+/**
+ * Document condition as published for Mandat: variable 3515 is "oui",
+ * and the ET/OU group carries the editor's groupMeta.
+ */
+const buildMandatDocumentReferences = (): Types.ReferencesType =>
+  ({
+    options: {
+      3068: {
+        meta: { id: 3068, type: "static", label: "Section", step: "*" },
+        options: [],
+        variables: [3515],
+      },
+    },
+    variables: {
+      3515: {
+        meta: { id: 3515, type: "list", label: "MASTER CREATION avec LP" },
+        options: [],
+      },
+    },
+    outputs: {},
+    boxes: {},
+    documents: {
+      "mandat-2": { name: "Mandat", params: { formats: { pdf: true } } },
+    },
+    sections: {},
+    relations: {
+      options: {
+        3068: {
+          ...emptyOptionRelations,
+          children: { options: [], variables: [3515] },
+        },
+      },
+      variables: {
+        3515: { ...emptyOptionRelations, parents: [3068] },
+      },
+      sections: {},
+    },
+    conditions: {
+      options: {},
+      variables: {},
+      documents: {},
+      sections: { main: {} },
+      prefillers: {},
+      validators: { options: {}, variables: {} },
+    },
+    defaults: {},
+    evaluations: {},
+    optionTags: {},
+    variableTags: {},
+  } as unknown as Types.ReferencesType);
+
+const mandatCondition = {
+  and: [{ "<>": [{ var: "v.3515" }, "non"] }],
+  groupMeta: { label: "", collapsed: false },
+} as ConditionV3;
+
+describe("document conditions carrying groupMeta", () => {
+  const runner = new ConditionsRunner(buildMandatDocumentReferences(), {
+    options: {},
+    variables: { 3515: ["oui"] },
+  });
+
+  it("returns true for the same rule when the AND group has no groupMeta", () => {
+    const { groupMeta: _groupMeta, ...rule } = mandatCondition;
+    expect(runner.executeCondition(mappedCondition(rule), 0, 0, "documents", "mandat-2")).toBe(
+      true
+    );
+  });
+
+  it("returns true for 3515 <> non when the AND group also has groupMeta", () => {
+    expect(
+      runner.executeCondition(mappedCondition(mandatCondition), 0, 0, "documents", "mandat-2")
+    ).toBe(true);
+  });
+});
+
 describe("includes / does-not-include operators", () => {
   it("should lower the operator to includes-any when the scope is any", () => {
     expect(

package/src/ConditionsRunner.ts

@@ -1,7 +1,10 @@
 /* eslint-disable max-len */
 import LpLogic from "@legalplace/lplogic";
 import type { Types } from "@legalplace/referencesparser";
-import { lowerScope } from "@legalplace/referencesparser";
+import {
+  lowerScope,
+  stripConditionUiMetadata,
+} from "@legalplace/referencesparser";
 import type { ConditionV3 } from "@legalplace/models-v3-types";
 import type InputsType from "@legalplace/types/dist/inputs";
 import DataPopulator from "./DataPopulator";
@@ -224,7 +227,10 @@ class ConditionsRunner {
       deps
     );
 
-    const result = LpLogic(resolvedConditions, currentData);
+    const result = LpLogic(
+      stripConditionUiMetadata(resolvedConditions as ConditionV3 | boolean),
+      currentData
+    );
     this.executeConditionMemo[memoizedKey] = result;
     return result;
   }