@leeovery/claude-technical-workflows 2.1.4 → 2.1.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/implementation-polish.md +188 -0
- package/package.json +1 -1
- package/skills/link-dependencies/SKILL.md +2 -2
- package/skills/migrate/SKILL.md +2 -2
- package/skills/start-discussion/SKILL.md +2 -2
- package/skills/start-implementation/SKILL.md +2 -2
- package/skills/start-planning/SKILL.md +2 -2
- package/skills/start-review/SKILL.md +2 -2
- package/skills/start-specification/SKILL.md +2 -2
- package/skills/technical-discussion/SKILL.md +1 -0
- package/skills/technical-implementation/SKILL.md +80 -4
- package/skills/technical-implementation/references/environment-setup.md +1 -1
- package/skills/technical-implementation/references/steps/invoke-executor.md +3 -3
- package/skills/technical-implementation/references/steps/invoke-polish.md +51 -0
- package/skills/technical-implementation/references/steps/invoke-reviewer.md +1 -1
- package/skills/technical-planning/SKILL.md +1 -0
- package/skills/technical-planning/references/steps/analyze-task-graph.md +1 -1
- package/skills/technical-planning/references/steps/author-tasks.md +4 -4
- package/skills/technical-planning/references/steps/define-phases.md +4 -4
- package/skills/technical-planning/references/steps/define-tasks.md +3 -3
- package/skills/technical-research/SKILL.md +1 -0
- package/skills/technical-review/SKILL.md +1 -0
- package/skills/technical-specification/SKILL.md +1 -0
- package/skills/view-plan/SKILL.md +1 -1
|
@@ -0,0 +1,188 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: implementation-polish
|
|
3
|
+
description: Performs holistic quality analysis over a completed implementation, discovering cross-task issues through multi-pass analysis and orchestrating fixes via the executor and reviewer agents. Invoked by technical-implementation skill after all tasks complete.
|
|
4
|
+
tools: Read, Glob, Grep, Bash, Task
|
|
5
|
+
model: opus
|
|
6
|
+
---
|
|
7
|
+
|
|
8
|
+
# Implementation Polish
|
|
9
|
+
|
|
10
|
+
Act as a **senior developer** performing a holistic quality pass over a plan's implementation. This plan is one piece of a larger system — it implements a specific feature or capability, not the entire application. Other plans handle other features. Your scope is strictly what this plan built, not what the broader system might be missing.
|
|
11
|
+
|
|
12
|
+
You've inherited a codebase built by a team — each member did solid work on their piece, but nobody has reviewed the whole picture. You discover issues through focused analysis, then orchestrate fixes through the executor and reviewer agents.
|
|
13
|
+
|
|
14
|
+
## Your Input
|
|
15
|
+
|
|
16
|
+
You receive file paths and context via the orchestrator's prompt:
|
|
17
|
+
|
|
18
|
+
1. **code-quality.md path** — Quality standards (also passed to executor)
|
|
19
|
+
2. **tdd-workflow.md path** — TDD cycle rules (passed to executor)
|
|
20
|
+
3. **Specification path** — What was intended — design decisions and rationale
|
|
21
|
+
4. **Plan file path** — What was built — the full task landscape
|
|
22
|
+
5. **Plan format reading.md path** — How to read tasks from the plan (format-specific adapter)
|
|
23
|
+
6. **Integration context file path** — Accumulated decisions and patterns from every task
|
|
24
|
+
7. **Project skill paths** — Framework conventions
|
|
25
|
+
|
|
26
|
+
On **re-invocation after user feedback**, additionally include:
|
|
27
|
+
|
|
28
|
+
8. **User feedback** — the user's comments on what to change or focus on
|
|
29
|
+
|
|
30
|
+
## Hard Rules
|
|
31
|
+
|
|
32
|
+
**MANDATORY. No exceptions. Violating these rules invalidates the work.**
|
|
33
|
+
|
|
34
|
+
1. **No direct code changes** — dispatch the executor for all modifications. You are discovery and orchestration.
|
|
35
|
+
2. **No new features** — only improve what exists. Nothing that isn't in the plan.
|
|
36
|
+
3. **Plan scope only** — work within the plan's boundary. Do not flag missing features that belong to other plans (e.g., "this app lacks authentication" when authentication is a separate plan). Do not look outward for gaps in the broader system — only inward at what this plan built.
|
|
37
|
+
4. **No git writes** — do not commit, stage, or interact with git. Reading git history and diffs is fine. The orchestrator handles all git operations.
|
|
38
|
+
5. **Proportional** — prioritize high-impact changes. Don't spend effort on trivial style differences.
|
|
39
|
+
6. **Existing tests are protected** — if a refactor breaks existing tests, the refactor is wrong. Only mechanical test updates (renames, moves) and new integration tests are allowed.
|
|
40
|
+
7. **Minimum 2 cycles** — always complete at least 2 full discovery-fix cycles. A single pass is never sufficient.
|
|
41
|
+
|
|
42
|
+
---
|
|
43
|
+
|
|
44
|
+
## Step 1: Absorb Context
|
|
45
|
+
|
|
46
|
+
Read and absorb the following. Do not write any code or dispatch any agents during this step.
|
|
47
|
+
|
|
48
|
+
1. **Read code-quality.md** — absorb quality standards
|
|
49
|
+
2. **Read specification** (if provided) — understand design intent
|
|
50
|
+
3. **Read project skills** — absorb framework conventions
|
|
51
|
+
4. **Read the plan format's reading.md** — understand how to retrieve tasks from the plan
|
|
52
|
+
5. **Read the plan** — follow the reading adapter's instructions to retrieve all completed tasks. Understand the full scope: phases, tasks, acceptance criteria, what was built
|
|
53
|
+
6. **Read the integration context file** — understand patterns, helpers, and conventions from all tasks
|
|
54
|
+
|
|
55
|
+
→ Proceed to **Step 2**.
|
|
56
|
+
|
|
57
|
+
---
|
|
58
|
+
|
|
59
|
+
## Step 2: Identify Implementation Scope
|
|
60
|
+
|
|
61
|
+
Find all files changed during implementation. Use git history, the plan's task list, and the integration context to build a complete picture of what was touched. Read and understand the full implemented codebase.
|
|
62
|
+
|
|
63
|
+
Build a definitive list of implementation files. This list is passed to analysis sub-agents in subsequent steps.
|
|
64
|
+
|
|
65
|
+
→ Proceed to **Step 3**.
|
|
66
|
+
|
|
67
|
+
---
|
|
68
|
+
|
|
69
|
+
## Step 3: Discovery-Fix Loop
|
|
70
|
+
|
|
71
|
+
Execute discovery-fix cycles. Minimum **2** cycles, maximum **5** cycles. Each cycle follows stages A through G sequentially. Always start at **A. Cycle Gate**.
|
|
72
|
+
|
|
73
|
+
### A. Cycle Gate
|
|
74
|
+
|
|
75
|
+
Increment the cycle count.
|
|
76
|
+
|
|
77
|
+
If cycle count > 5 → exit loop, proceed to **Step 4**.
|
|
78
|
+
|
|
79
|
+
If cycle count > 2 and the previous cycle's discovery found zero actionable issues → exit loop, proceed to **Step 4**.
|
|
80
|
+
|
|
81
|
+
Otherwise → proceed to **B. Dispatch Fixed Analysis Passes**.
|
|
82
|
+
|
|
83
|
+
### B. Dispatch Fixed Analysis Passes
|
|
84
|
+
|
|
85
|
+
Dispatch all three analysis sub-agents **in parallel** via Task tool. Each sub-agent receives:
|
|
86
|
+
- The list of implementation files (from Step 2)
|
|
87
|
+
- The specific analysis focus (below)
|
|
88
|
+
- Instruction to return findings as a structured list with file:line references
|
|
89
|
+
|
|
90
|
+
**Sub-agent 1 — Code Cleanup:**
|
|
91
|
+
Analyze all implementation files for: unused imports/variables/dead code, naming quality (abbreviation overuse, unclear names, inconsistent naming across files), formatting inconsistencies across the implementation. Compare naming conventions between files written by different tasks — flag drift.
|
|
92
|
+
|
|
93
|
+
**Sub-agent 2 — Structural Cohesion:**
|
|
94
|
+
Analyze all implementation files for: duplicated logic across task boundaries that should be extracted, class/module responsibilities (too much in one class, or unnecessarily fragmented across many), design patterns that are now obvious with the full picture but weren't visible to individual task executors, over-engineering (abstractions nobody uses) or under-engineering (raw code that should be extracted).
|
|
95
|
+
|
|
96
|
+
**Sub-agent 3 — Cross-Task Integration:**
|
|
97
|
+
Analyze all implementation files for: shared code paths where multiple tasks contributed behavior — verify the merged result is correct, workflow seams where one task's output feeds another's input — verify the handoff works, interface mismatches between producer and consumer (type mismatches, missing fields, wrong assumptions), gaps in integration test coverage for cross-task workflows.
|
|
98
|
+
|
|
99
|
+
**STOP.** Do not proceed until all three sub-agents have returned their findings.
|
|
100
|
+
|
|
101
|
+
→ Proceed to **C. Dispatch Dynamic Analysis Passes**.
|
|
102
|
+
|
|
103
|
+
### C. Dispatch Dynamic Analysis Passes
|
|
104
|
+
|
|
105
|
+
Review the findings from the fixed passes and the codebase. Based on what you find — language, framework, project conventions, areas flagged by fixed passes — determine whether additional targeted analysis is needed.
|
|
106
|
+
|
|
107
|
+
If no dynamic passes are needed → proceed to **D. Synthesize Findings**.
|
|
108
|
+
|
|
109
|
+
If dynamic passes are needed, dispatch sub-agents for deeper analysis. Examples: language-specific idiom checks, convention consistency across early and late tasks, deeper investigation into specific areas. Each dynamic sub-agent receives the relevant file subset and a focused analysis prompt, same as fixed passes.
|
|
110
|
+
|
|
111
|
+
**STOP.** Do not proceed until all dynamic sub-agents have returned their findings.
|
|
112
|
+
|
|
113
|
+
→ Proceed to **D. Synthesize Findings**.
|
|
114
|
+
|
|
115
|
+
### D. Synthesize Findings
|
|
116
|
+
|
|
117
|
+
Collect findings from all analysis passes (fixed and dynamic). Deduplicate, discard low-value nitpicks, and prioritize by impact.
|
|
118
|
+
|
|
119
|
+
If no actionable findings remain → proceed to **G. Cycle Complete** (no fix needed this cycle).
|
|
120
|
+
|
|
121
|
+
If actionable findings exist → proceed to **E. Invoke Executor**.
|
|
122
|
+
|
|
123
|
+
### E. Invoke Executor
|
|
124
|
+
|
|
125
|
+
Craft a task description covering the prioritized fixes. Include the following **test rules** in the task description — these constrain what test changes the executor may make during polish:
|
|
126
|
+
- Write NEW integration tests for cross-task workflows — yes
|
|
127
|
+
- Modify existing tests for mechanical changes (renames, moves) — yes
|
|
128
|
+
- Modify existing tests semantically (different behavior) — no. If a refactor breaks existing tests, the refactor is wrong. Revert it.
|
|
129
|
+
|
|
130
|
+
Invoke the `implementation-task-executor` agent (`implementation-task-executor.md`) with:
|
|
131
|
+
- The crafted task description (including test rules) as task content
|
|
132
|
+
- tdd-workflow.md path
|
|
133
|
+
- code-quality.md path
|
|
134
|
+
- Specification path (if available)
|
|
135
|
+
- Project skill paths
|
|
136
|
+
- Plan file path
|
|
137
|
+
- Integration context file path
|
|
138
|
+
|
|
139
|
+
**STOP.** Do not proceed until the executor has returned its result.
|
|
140
|
+
|
|
141
|
+
On receipt of result, route on STATUS:
|
|
142
|
+
- `blocked` or `failed` → record in SKIPPED with the executor's ISSUES. Proceed to **G. Cycle Complete**.
|
|
143
|
+
- `complete` → proceed to **F. Invoke Reviewer**.
|
|
144
|
+
|
|
145
|
+
### F. Invoke Reviewer
|
|
146
|
+
|
|
147
|
+
Invoke the `implementation-task-reviewer` agent (`implementation-task-reviewer.md`) to independently verify the executor's work. Include the test rules in the reviewer's prompt so it can flag violations. Pass:
|
|
148
|
+
- Specification path
|
|
149
|
+
- The same task description used for the executor (including test rules)
|
|
150
|
+
- Project skill paths
|
|
151
|
+
- Integration context file path
|
|
152
|
+
|
|
153
|
+
**STOP.** Do not proceed until the reviewer has returned its result.
|
|
154
|
+
|
|
155
|
+
On receipt of result, route on VERDICT:
|
|
156
|
+
- `approved` → proceed to **G. Cycle Complete**
|
|
157
|
+
- `needs-changes` → return to **E. Invoke Executor** with the reviewer's feedback. Maximum 3 fix attempts per cycle — if not converged after 3, record remaining issues in SKIPPED and proceed to **G. Cycle Complete**.
|
|
158
|
+
|
|
159
|
+
### G. Cycle Complete
|
|
160
|
+
|
|
161
|
+
Record what was discovered and fixed this cycle.
|
|
162
|
+
|
|
163
|
+
→ Return to **A. Cycle Gate**.
|
|
164
|
+
|
|
165
|
+
---
|
|
166
|
+
|
|
167
|
+
## Step 4: Return Report
|
|
168
|
+
|
|
169
|
+
Return a structured report:
|
|
170
|
+
|
|
171
|
+
```
|
|
172
|
+
STATUS: complete | blocked
|
|
173
|
+
SUMMARY: {overview — what was analyzed, key findings, what was fixed}
|
|
174
|
+
CYCLES: {number of discovery-fix cycles completed}
|
|
175
|
+
DISCOVERY:
|
|
176
|
+
- {findings from analysis passes, organized by category}
|
|
177
|
+
FIXES_APPLIED:
|
|
178
|
+
- {what was changed and why, with file:line references}
|
|
179
|
+
TESTS_ADDED:
|
|
180
|
+
- {integration tests written, what workflows they exercise}
|
|
181
|
+
SKIPPED:
|
|
182
|
+
- {issues found but not addressed — too risky, needs design decision, or low impact}
|
|
183
|
+
TEST_RESULTS: {all passing | failures — details}
|
|
184
|
+
```
|
|
185
|
+
|
|
186
|
+
- If STATUS is `blocked`, SUMMARY **must** explain what decision is needed.
|
|
187
|
+
- If STATUS is `complete`, all applied fixes must have passing tests.
|
|
188
|
+
- SKIPPED captures issues that were found but intentionally not addressed — too risky, needs a design decision, or low impact relative to effort.
|
package/package.json
CHANGED
|
@@ -102,7 +102,7 @@ For each unresolved dependency:
|
|
|
102
102
|
|
|
103
103
|
2. **If plan exists**: Load the format's reading reference
|
|
104
104
|
- Read `format:` from the dependency plan's frontmatter
|
|
105
|
-
- Load
|
|
105
|
+
- Load `../technical-planning/references/output-formats/{format}/reading.md`
|
|
106
106
|
- Use the task extraction instructions to search for matching tasks
|
|
107
107
|
|
|
108
108
|
3. **Handle ambiguous matches**:
|
|
@@ -117,7 +117,7 @@ For each resolved match:
|
|
|
117
117
|
- Change the dependency's `state: unresolved` to `state: resolved` and add `task_id: {task-id}`
|
|
118
118
|
|
|
119
119
|
2. **Create dependency in output format**:
|
|
120
|
-
- Load
|
|
120
|
+
- Load `../technical-planning/references/output-formats/{format}/graph.md`
|
|
121
121
|
- Follow the "Adding a Dependency" section to create the blocking relationship
|
|
122
122
|
|
|
123
123
|
## Step 6: Bidirectional Check
|
package/skills/migrate/SKILL.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: migrate
|
|
3
3
|
description: "Run migrations to keep workflow files in sync with the current system design. This skill is mandatory before running any workflow skill."
|
|
4
|
-
allowed-tools: Bash(
|
|
4
|
+
allowed-tools: Bash(../../scripts/migrate.sh)
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
# Migrate
|
|
@@ -13,7 +13,7 @@ Keeps your workflow files up to date with how the system is designed to work. Ru
|
|
|
13
13
|
Run the migration script:
|
|
14
14
|
|
|
15
15
|
```bash
|
|
16
|
-
|
|
16
|
+
../../scripts/migrate.sh
|
|
17
17
|
```
|
|
18
18
|
|
|
19
19
|
### If files were updated
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: start-discussion
|
|
3
3
|
description: "Start a technical discussion. Discovers research and existing discussions, offers multiple entry paths, and invokes the technical-discussion skill."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
allowed-tools: Bash(
|
|
5
|
+
allowed-tools: Bash(../../scripts/discovery-for-discussion.sh), Bash(mkdir -p docs/workflow/.cache), Bash(rm docs/workflow/.cache/research-analysis.md)
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
Invoke the **technical-discussion** skill for this conversation.
|
|
@@ -55,7 +55,7 @@ Invoke the `/migrate` skill and assess its output.
|
|
|
55
55
|
Run the discovery script to gather current state:
|
|
56
56
|
|
|
57
57
|
```bash
|
|
58
|
-
|
|
58
|
+
../../scripts/discovery-for-discussion.sh
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
This outputs structured YAML. Parse it to understand:
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: start-implementation
|
|
3
3
|
description: "Start an implementation session from an existing plan. Discovers available plans, checks environment setup, and invokes the technical-implementation skill."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
allowed-tools: Bash(
|
|
5
|
+
allowed-tools: Bash(../../scripts/discovery-for-implementation-and-review.sh)
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
Invoke the **technical-implementation** skill for this conversation.
|
|
@@ -55,7 +55,7 @@ Invoke the `/migrate` skill and assess its output.
|
|
|
55
55
|
Run the discovery script to gather current state:
|
|
56
56
|
|
|
57
57
|
```bash
|
|
58
|
-
|
|
58
|
+
../../scripts/discovery-for-implementation-and-review.sh
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
This outputs structured YAML. Parse it to understand:
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: start-planning
|
|
3
3
|
description: "Start a planning session from an existing specification. Discovers available specifications, gathers context, and invokes the technical-planning skill."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
allowed-tools: Bash(
|
|
5
|
+
allowed-tools: Bash(../../scripts/discovery-for-planning.sh)
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
Invoke the **technical-planning** skill for this conversation.
|
|
@@ -55,7 +55,7 @@ Invoke the `/migrate` skill and assess its output.
|
|
|
55
55
|
Run the discovery script to gather current state:
|
|
56
56
|
|
|
57
57
|
```bash
|
|
58
|
-
|
|
58
|
+
../../scripts/discovery-for-planning.sh
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
This outputs structured YAML. Parse it to understand:
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: start-review
|
|
3
3
|
description: "Start a review session from an existing plan and implementation. Discovers available plans, validates implementation exists, and invokes the technical-review skill."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
allowed-tools: Bash(
|
|
5
|
+
allowed-tools: Bash(../../scripts/discovery-for-implementation-and-review.sh)
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
Invoke the **technical-review** skill for this conversation.
|
|
@@ -55,7 +55,7 @@ Invoke the `/migrate` skill and assess its output.
|
|
|
55
55
|
Run the discovery script to gather current state:
|
|
56
56
|
|
|
57
57
|
```bash
|
|
58
|
-
|
|
58
|
+
../../scripts/discovery-for-implementation-and-review.sh
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
This outputs structured YAML. Parse it to understand:
|
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
name: start-specification
|
|
3
3
|
description: "Start a specification session from existing discussions. Discovers available discussions, offers consolidation assessment for multiple discussions, and invokes the technical-specification skill."
|
|
4
4
|
disable-model-invocation: true
|
|
5
|
-
allowed-tools: Bash(
|
|
5
|
+
allowed-tools: Bash(../../scripts/discovery-for-specification.sh), Bash(mkdir -p docs/workflow/.cache), Bash(rm docs/workflow/.cache/discussion-consolidation-analysis.md)
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
Invoke the **technical-specification** skill for this conversation.
|
|
@@ -55,7 +55,7 @@ Invoke the `/migrate` skill and assess its output.
|
|
|
55
55
|
Run the discovery script to gather current state:
|
|
56
56
|
|
|
57
57
|
```bash
|
|
58
|
-
|
|
58
|
+
../../scripts/discovery-for-specification.sh
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
This outputs structured YAML. Parse it to understand:
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-discussion
|
|
3
3
|
description: "Document technical discussions as expert architect and meeting assistant. Capture context, decisions, edge cases, debates, and rationale without jumping to specification or implementation. Use when: (1) Users discuss/explore/debate architecture or design, (2) Working through edge cases before specification, (3) Need to document technical decisions and their rationale, (4) Capturing competing solutions and why choices were made. Creates documentation in docs/workflow/discussion/{topic}.md that can be used to build validated specifications."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Discussion
|
|
@@ -1,14 +1,15 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-implementation
|
|
3
3
|
description: "Orchestrate implementation of plans using agent-based TDD workflow with per-task review and approval gate (auto mode available). Use when: (1) Implementing a plan from docs/workflow/planning/{topic}.md, (2) User says 'implement', 'build', or 'code this' with a plan available, (3) Ad hoc coding that should follow TDD and quality standards, (4) Bug fixes or features benefiting from structured implementation. Dispatches executor and reviewer agents per task, commits after review approval."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Implementation
|
|
7
8
|
|
|
8
9
|
Orchestrate implementation by dispatching **executor** and **reviewer** agents per task. Each agent invocation starts fresh — flat context, no accumulated state.
|
|
9
10
|
|
|
10
|
-
- **Executor** (
|
|
11
|
-
- **Reviewer** (
|
|
11
|
+
- **Executor** (`../../agents/implementation-task-executor.md`) — implements one task via strict TDD
|
|
12
|
+
- **Reviewer** (`../../agents/implementation-task-reviewer.md`) — independently verifies the task (opus)
|
|
12
13
|
|
|
13
14
|
The orchestrator owns: plan reading, task extraction, agent invocation, git operations, tracking, task gates.
|
|
14
15
|
|
|
@@ -100,7 +101,7 @@ Save their instructions to `docs/workflow/environment-setup.md` (or "No special
|
|
|
100
101
|
|
|
101
102
|
1. Read the plan from the provided location (typically `docs/workflow/planning/{topic}.md`)
|
|
102
103
|
2. Plans can be stored in various formats. The `format` field in the plan's frontmatter identifies which format this plan uses.
|
|
103
|
-
3. Load the format's per-concern adapter files from
|
|
104
|
+
3. Load the format's per-concern adapter files from `../technical-planning/references/output-formats/{format}/`:
|
|
104
105
|
- **reading.md** — how to read tasks from the plan
|
|
105
106
|
- **updating.md** — how to write progress to the plan
|
|
106
107
|
4. If no `format` field exists, ask the user which format the plan uses.
|
|
@@ -209,7 +210,81 @@ Load **[steps/task-loop.md](references/steps/task-loop.md)** and follow its inst
|
|
|
209
210
|
|
|
210
211
|
---
|
|
211
212
|
|
|
212
|
-
## Step 6:
|
|
213
|
+
## Step 6: Polish
|
|
214
|
+
|
|
215
|
+
If the task loop exited early (user chose `stop`), skip to **Step 7**.
|
|
216
|
+
|
|
217
|
+
**Git checkpoint** — ensure a clean working tree before invoking the polish agent. Run `git status`. If there are unstaged changes or untracked files, commit them:
|
|
218
|
+
|
|
219
|
+
```
|
|
220
|
+
impl({topic}): pre-polish checkpoint
|
|
221
|
+
```
|
|
222
|
+
|
|
223
|
+
This ensures all prior work is safely committed. The polish agent makes no git operations — all its changes will exist as unstaged modifications. If the user discards polish, the working tree resets cleanly to this checkpoint.
|
|
224
|
+
|
|
225
|
+
**Invoke the polish agent:**
|
|
226
|
+
|
|
227
|
+
1. Load **[steps/invoke-polish.md](references/steps/invoke-polish.md)** and follow its instructions.
|
|
228
|
+
2. **STOP.** Do not proceed until the polish agent has returned its result.
|
|
229
|
+
3. Route on STATUS:
|
|
230
|
+
- `blocked` → present SUMMARY to the user, ask how to proceed
|
|
231
|
+
- `complete` → present the report below
|
|
232
|
+
|
|
233
|
+
> **Implementation polish complete** ({N} cycles)
|
|
234
|
+
>
|
|
235
|
+
> {SUMMARY}
|
|
236
|
+
>
|
|
237
|
+
> Findings:
|
|
238
|
+
> {DISCOVERY}
|
|
239
|
+
>
|
|
240
|
+
> Fixes applied:
|
|
241
|
+
> {FIXES_APPLIED}
|
|
242
|
+
>
|
|
243
|
+
> Integration tests added:
|
|
244
|
+
> {TESTS_ADDED}
|
|
245
|
+
>
|
|
246
|
+
> Skipped (not addressed):
|
|
247
|
+
> {SKIPPED}
|
|
248
|
+
>
|
|
249
|
+
> Test results: {TEST_RESULTS}
|
|
250
|
+
>
|
|
251
|
+
> · · ·
|
|
252
|
+
>
|
|
253
|
+
> - **`y`/`yes`** — Approve and commit polish changes
|
|
254
|
+
> - **`s`/`skip`** — Discard polish changes, mark complete as-is
|
|
255
|
+
> - **Comment** — Feedback (re-invokes polish agent with your notes)
|
|
256
|
+
|
|
257
|
+
**STOP.** Wait for user input.
|
|
258
|
+
|
|
259
|
+
#### If `yes`
|
|
260
|
+
|
|
261
|
+
Commit all polish changes:
|
|
262
|
+
|
|
263
|
+
```
|
|
264
|
+
impl({topic}): polish — {brief description}
|
|
265
|
+
```
|
|
266
|
+
|
|
267
|
+
→ Proceed to **Step 7**.
|
|
268
|
+
|
|
269
|
+
#### If `skip`
|
|
270
|
+
|
|
271
|
+
Discard all polish changes. Reset the working tree to the pre-polish checkpoint:
|
|
272
|
+
|
|
273
|
+
```
|
|
274
|
+
git checkout . && git clean -fd
|
|
275
|
+
```
|
|
276
|
+
|
|
277
|
+
This is safe because the checkpoint commit captured all prior work. Only polish-created changes are discarded. Gitignored files are untouched.
|
|
278
|
+
|
|
279
|
+
→ Proceed to **Step 7**.
|
|
280
|
+
|
|
281
|
+
#### If comment
|
|
282
|
+
|
|
283
|
+
→ Re-invoke the polish agent with the user's feedback. Return to the top of **Step 6** (after the git checkpoint — do not re-checkpoint).
|
|
284
|
+
|
|
285
|
+
---
|
|
286
|
+
|
|
287
|
+
## Step 7: Mark Implementation Complete
|
|
213
288
|
|
|
214
289
|
Update the tracking file (`docs/workflow/implementation/{topic}.md`):
|
|
215
290
|
- Set `status: completed`
|
|
@@ -226,6 +301,7 @@ Commit: `impl({topic}): complete implementation`
|
|
|
226
301
|
- **[steps/task-loop.md](references/steps/task-loop.md)** — Task execution loop, task gates, tracking, commits
|
|
227
302
|
- **[steps/invoke-executor.md](references/steps/invoke-executor.md)** — How to invoke the executor agent
|
|
228
303
|
- **[steps/invoke-reviewer.md](references/steps/invoke-reviewer.md)** — How to invoke the reviewer agent
|
|
304
|
+
- **[steps/invoke-polish.md](references/steps/invoke-polish.md)** — How to invoke the polish agent
|
|
229
305
|
- **[task-normalisation.md](references/task-normalisation.md)** — Normalised task shape for agent invocation
|
|
230
306
|
- **[tdd-workflow.md](references/tdd-workflow.md)** — TDD cycle (passed to executor agent)
|
|
231
307
|
- **[code-quality.md](references/code-quality.md)** — Quality standards (passed to executor agent)
|
|
@@ -55,7 +55,7 @@ If the environment setup document contains only "No special setup required" (or
|
|
|
55
55
|
Some plan formats require specific tools. Check the plan's `format` field and load the format's about file for setup instructions:
|
|
56
56
|
|
|
57
57
|
```
|
|
58
|
-
|
|
58
|
+
../../technical-planning/references/output-formats/{format}/about.md
|
|
59
59
|
```
|
|
60
60
|
|
|
61
61
|
Each format's about.md contains prerequisites and installation instructions.
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step invokes the `implementation-task-executor` agent (
|
|
7
|
+
This step invokes the `implementation-task-executor` agent (`../../../../agents/implementation-task-executor.md`) to implement one task.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -12,8 +12,8 @@ This step invokes the `implementation-task-executor` agent (`.claude/agents/impl
|
|
|
12
12
|
|
|
13
13
|
**Every invocation** — initial or re-attempt — includes these file paths:
|
|
14
14
|
|
|
15
|
-
1. **tdd-workflow.md**:
|
|
16
|
-
2. **code-quality.md**:
|
|
15
|
+
1. **tdd-workflow.md**: `../tdd-workflow.md`
|
|
16
|
+
2. **code-quality.md**: `../code-quality.md`
|
|
17
17
|
3. **Specification path**: from the plan's frontmatter (if available)
|
|
18
18
|
4. **Project skill paths**: from `project_skills` in the implementation tracking file
|
|
19
19
|
5. **Task content**: normalised task content (see [task-normalisation.md](../task-normalisation.md))
|
|
@@ -0,0 +1,51 @@
|
|
|
1
|
+
# Invoke Polish
|
|
2
|
+
|
|
3
|
+
*Reference for **[technical-implementation](../../SKILL.md)***
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
This step invokes the `implementation-polish` agent (`../../../../agents/implementation-polish.md`) to perform holistic quality analysis and orchestrate fixes after all tasks are complete.
|
|
8
|
+
|
|
9
|
+
---
|
|
10
|
+
|
|
11
|
+
## Invoke the Agent
|
|
12
|
+
|
|
13
|
+
**Every invocation** includes these file paths:
|
|
14
|
+
|
|
15
|
+
1. **code-quality.md**: `../code-quality.md`
|
|
16
|
+
2. **tdd-workflow.md**: `../tdd-workflow.md`
|
|
17
|
+
3. **Specification path**: from the plan's frontmatter (if available)
|
|
18
|
+
4. **Plan file path**: the implementation plan
|
|
19
|
+
5. **Plan format reading.md**: `../../../technical-planning/references/output-formats/{format}/reading.md` (format from plan frontmatter)
|
|
20
|
+
6. **Integration context file**: `docs/workflow/implementation/{topic}-context.md`
|
|
21
|
+
7. **Project skill paths**: from `project_skills` in the implementation tracking file
|
|
22
|
+
|
|
23
|
+
**Re-invocation after user feedback** additionally includes:
|
|
24
|
+
|
|
25
|
+
8. **User feedback**: the user's comments on what to change or focus on
|
|
26
|
+
|
|
27
|
+
The polish agent is stateless — each invocation starts fresh. Always pass all inputs.
|
|
28
|
+
|
|
29
|
+
---
|
|
30
|
+
|
|
31
|
+
## Expected Result
|
|
32
|
+
|
|
33
|
+
The agent returns a structured report:
|
|
34
|
+
|
|
35
|
+
```
|
|
36
|
+
STATUS: complete | blocked
|
|
37
|
+
SUMMARY: {overview — what was analyzed, key findings, what was fixed}
|
|
38
|
+
CYCLES: {number of discovery-fix cycles completed}
|
|
39
|
+
DISCOVERY:
|
|
40
|
+
- {findings from analysis passes, organized by category}
|
|
41
|
+
FIXES_APPLIED:
|
|
42
|
+
- {what was changed and why, with file:line references}
|
|
43
|
+
TESTS_ADDED:
|
|
44
|
+
- {integration tests written, what workflows they exercise}
|
|
45
|
+
SKIPPED:
|
|
46
|
+
- {issues found but not addressed — too risky, needs design decision, or low impact}
|
|
47
|
+
TEST_RESULTS: {all passing | failures — details}
|
|
48
|
+
```
|
|
49
|
+
|
|
50
|
+
- `complete`: all applied fixes have passing tests, discovery-fix loop finished
|
|
51
|
+
- `blocked`: SUMMARY explains what decision is needed
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step invokes the `implementation-task-reviewer` agent (
|
|
7
|
+
This step invokes the `implementation-task-reviewer` agent (`../../../../agents/implementation-task-reviewer.md`) to independently verify a completed task.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-planning
|
|
3
3
|
description: "Transform specifications into actionable implementation plans with phases, tasks, and acceptance criteria. Use when: (1) User asks to create/write an implementation plan, (2) User asks to plan implementation from a specification, (3) Converting specifications from docs/workflow/specification/{topic}.md into implementation plans, (4) User says 'plan this' or 'create a plan', (5) Need to structure how to build something with phases and concrete steps. Creates plans in docs/workflow/planning/{topic}.md that can be executed via strict TDD."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Planning
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step uses the `planning-dependency-grapher` agent (
|
|
7
|
+
This step uses the `planning-dependency-grapher` agent (`../../../../agents/planning-dependency-grapher.md`) to analyze all authored tasks, establish internal dependencies, assign priorities, and detect cycles. You invoke the agent, present its output, and handle the approval gate.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step uses the `planning-task-author` agent (
|
|
7
|
+
This step uses the `planning-task-author` agent (`../../../../agents/planning-task-author.md`) to write full detail for a single task. You invoke the agent, present its output, and handle the approval gate.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -14,14 +14,14 @@ This step uses the `planning-task-author` agent (`.claude/agents/planning-task-a
|
|
|
14
14
|
|
|
15
15
|
Invoke `planning-task-author` with these file paths:
|
|
16
16
|
|
|
17
|
-
1. **read-specification.md**:
|
|
17
|
+
1. **read-specification.md**: `../read-specification.md`
|
|
18
18
|
2. **Specification**: path from the Plan Index File's `specification:` field
|
|
19
19
|
3. **Cross-cutting specs**: paths from the Plan Index File's `cross_cutting_specs:` field (if any)
|
|
20
|
-
4. **task-design.md**:
|
|
20
|
+
4. **task-design.md**: `../task-design.md`
|
|
21
21
|
5. **All approved phases**: the complete phase structure from the Plan Index File body
|
|
22
22
|
6. **Task list for current phase**: the approved task table
|
|
23
23
|
7. **Target task**: the task name, edge cases, and ID from the table
|
|
24
|
-
8. **Output format authoring reference**: path to the format's `authoring.md` (e.g.,
|
|
24
|
+
8. **Output format authoring reference**: path to the format's `authoring.md` (e.g., `../output-formats/{format}/authoring.md`)
|
|
25
25
|
|
|
26
26
|
### Present the Output
|
|
27
27
|
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step uses the `planning-phase-designer` agent (
|
|
7
|
+
This step uses the `planning-phase-designer` agent (`../../../../agents/planning-phase-designer.md`) to define or review the phase structure. Whether phases are being designed for the first time or reviewed from a previous session, the process converges on the same approval gate.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -30,11 +30,11 @@ Orient the user:
|
|
|
30
30
|
|
|
31
31
|
Invoke `planning-phase-designer` with these file paths:
|
|
32
32
|
|
|
33
|
-
1. **read-specification.md**:
|
|
33
|
+
1. **read-specification.md**: `../read-specification.md`
|
|
34
34
|
2. **Specification**: path from the Plan Index File's `specification:` field
|
|
35
35
|
3. **Cross-cutting specs**: paths from the Plan Index File's `cross_cutting_specs:` field (if any)
|
|
36
|
-
4. **phase-design.md**:
|
|
37
|
-
5. **task-design.md**:
|
|
36
|
+
4. **phase-design.md**: `../phase-design.md`
|
|
37
|
+
5. **task-design.md**: `../task-design.md`
|
|
38
38
|
|
|
39
39
|
The agent returns a complete phase structure. Write it directly to the Plan Index File body.
|
|
40
40
|
|
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
7
|
-
This step uses the `planning-task-designer` agent (
|
|
7
|
+
This step uses the `planning-task-designer` agent (`../../../../agents/planning-task-designer.md`) to design a task list for a single phase. You invoke the agent, present its output, and handle the approval gate.
|
|
8
8
|
|
|
9
9
|
---
|
|
10
10
|
|
|
@@ -18,10 +18,10 @@ Orient the user:
|
|
|
18
18
|
|
|
19
19
|
Invoke `planning-task-designer` with these file paths:
|
|
20
20
|
|
|
21
|
-
1. **read-specification.md**:
|
|
21
|
+
1. **read-specification.md**: `../read-specification.md`
|
|
22
22
|
2. **Specification**: path from the Plan Index File's `specification:` field
|
|
23
23
|
3. **Cross-cutting specs**: paths from the Plan Index File's `cross_cutting_specs:` field (if any)
|
|
24
|
-
4. **task-design.md**:
|
|
24
|
+
4. **task-design.md**: `../task-design.md`
|
|
25
25
|
5. **All approved phases**: the complete phase structure from the Plan Index File body
|
|
26
26
|
6. **Target phase number**: the phase being broken into tasks
|
|
27
27
|
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-research
|
|
3
3
|
description: "Explore ideas, validate concepts, and research broadly across technical, business, and market domains. Use when: (1) User has a new idea to explore, (2) Need to research a topic deeply, (3) Validating feasibility - technical, business, or market, (4) Learning and exploration without necessarily building anything, (5) User says 'research this' or 'explore this idea', (6) Brain dumping early thoughts before formal discussion. Creates research documents in docs/workflow/research/ that may feed into discussion or specification."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Research
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-review
|
|
3
3
|
description: "Validate completed implementation against plan tasks and acceptance criteria. Use when: (1) Implementation is complete, (2) User wants validation before merging/shipping, (3) Quality gate check needed after implementation. Reviews ALL plan tasks for implementation correctness, test adequacy, and code quality. Produces structured feedback (approve, request changes, or comments) - does NOT fix code."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Review
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: technical-specification
|
|
3
3
|
description: "Build validated specifications from source material through collaborative refinement. Use when: (1) User asks to create/build a specification from source material, (2) User wants to validate and refine content before planning, (3) Converting source material (discussions, research, requirements) into standalone specifications, (4) User says 'specify this' or 'create a spec', (5) Need to filter hallucinations and enrich gaps before formal planning. Creates specifications in docs/workflow/specification/{topic}.md that can be used to build implementation plans."
|
|
4
|
+
user-invocable: false
|
|
4
5
|
---
|
|
5
6
|
|
|
6
7
|
# Technical Specification
|
|
@@ -25,7 +25,7 @@ Read the plan file from `docs/workflow/planning/{topic}.md` and check the `forma
|
|
|
25
25
|
Load the format's reading reference:
|
|
26
26
|
|
|
27
27
|
```
|
|
28
|
-
|
|
28
|
+
../technical-planning/references/output-formats/{format}/reading.md
|
|
29
29
|
```
|
|
30
30
|
|
|
31
31
|
This file contains instructions for reading plans in that format.
|