@leeovery/claude-technical-workflows 2.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +21 -0
- package/README.md +283 -0
- package/agents/chain-verifier.md +129 -0
- package/commands/interview.md +54 -0
- package/commands/start-discussion.md +36 -0
- package/commands/start-implementation.md +107 -0
- package/commands/start-planning.md +92 -0
- package/commands/start-research.md +21 -0
- package/commands/start-specification.md +89 -0
- package/package.json +24 -0
- package/skills/.gitkeep +0 -0
- package/skills/technical-discussion/SKILL.md +68 -0
- package/skills/technical-discussion/references/guidelines.md +86 -0
- package/skills/technical-discussion/references/meeting-assistant.md +102 -0
- package/skills/technical-discussion/references/template.md +127 -0
- package/skills/technical-implementation/SKILL.md +167 -0
- package/skills/technical-implementation/references/code-quality.md +41 -0
- package/skills/technical-implementation/references/environment-setup.md +97 -0
- package/skills/technical-implementation/references/plan-execution.md +49 -0
- package/skills/technical-implementation/references/tdd-workflow.md +63 -0
- package/skills/technical-planning/SKILL.md +46 -0
- package/skills/technical-planning/references/formal-planning.md +118 -0
- package/skills/technical-planning/references/output-backlog-md.md +227 -0
- package/skills/technical-planning/references/output-beads.md +302 -0
- package/skills/technical-planning/references/output-formats.md +14 -0
- package/skills/technical-planning/references/output-linear.md +211 -0
- package/skills/technical-planning/references/output-local-markdown.md +185 -0
- package/skills/technical-research/SKILL.md +81 -0
- package/skills/technical-review/SKILL.md +107 -0
- package/skills/technical-review/references/review-checklist.md +155 -0
- package/skills/technical-review/references/template.md +46 -0
- package/skills/technical-specification/SKILL.md +51 -0
- package/skills/technical-specification/references/specification-guide.md +170 -0
|
@@ -0,0 +1,211 @@
|
|
|
1
|
+
# Output: Linear
|
|
2
|
+
|
|
3
|
+
*Output adapter for **[technical-planning](../SKILL.md)***
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
Use this output format when you want **Linear as the source of truth** for plan management. The user can update tasks directly in Linear's UI, and implementation will query Linear for the current state.
|
|
8
|
+
|
|
9
|
+
## Setup
|
|
10
|
+
|
|
11
|
+
Requires the Linear MCP server to be configured in Claude Code.
|
|
12
|
+
|
|
13
|
+
Check if Linear MCP is available by looking for Linear tools. If not configured, inform the user that Linear MCP is required for this format.
|
|
14
|
+
|
|
15
|
+
Ask the user: **Which team should own this project?**
|
|
16
|
+
|
|
17
|
+
## Linear Structure Mapping
|
|
18
|
+
|
|
19
|
+
| Planning Concept | Linear Entity |
|
|
20
|
+
|------------------|---------------|
|
|
21
|
+
| Plan | Project |
|
|
22
|
+
| Phase | Label (e.g., `phase-1`, `phase-2`) |
|
|
23
|
+
| Task | Issue |
|
|
24
|
+
|
|
25
|
+
## Output Process
|
|
26
|
+
|
|
27
|
+
### 1. Create Linear Project
|
|
28
|
+
|
|
29
|
+
Via MCP, create a project with:
|
|
30
|
+
|
|
31
|
+
- **Name**: Match the specification topic name
|
|
32
|
+
- **Description**: Brief summary + link to specification file
|
|
33
|
+
- **Team**: As specified by user
|
|
34
|
+
|
|
35
|
+
### 2. Create Labels for Phases
|
|
36
|
+
|
|
37
|
+
Create labels to denote phases (if they don't already exist):
|
|
38
|
+
|
|
39
|
+
- `phase-1`
|
|
40
|
+
- `phase-2`
|
|
41
|
+
- etc.
|
|
42
|
+
|
|
43
|
+
Document the phase goals and acceptance criteria in a pinned issue or the project description:
|
|
44
|
+
|
|
45
|
+
```
|
|
46
|
+
Phase 1: Core Authentication
|
|
47
|
+
Goal: Implement basic login/logout flow
|
|
48
|
+
Acceptance:
|
|
49
|
+
- [ ] User can log in with email/password
|
|
50
|
+
- [ ] Session persists across page refresh
|
|
51
|
+
- [ ] Logout clears session
|
|
52
|
+
|
|
53
|
+
Phase 2: ...
|
|
54
|
+
```
|
|
55
|
+
|
|
56
|
+
### 3. Create Issues for Tasks
|
|
57
|
+
|
|
58
|
+
For each task, create an issue and apply the appropriate phase label:
|
|
59
|
+
|
|
60
|
+
**Title**: Clear action statement
|
|
61
|
+
|
|
62
|
+
**Description** (use this structure):
|
|
63
|
+
```markdown
|
|
64
|
+
## Goal
|
|
65
|
+
[What this task accomplishes - one sentence]
|
|
66
|
+
|
|
67
|
+
## Implementation
|
|
68
|
+
[The "Do" from planning - specific files, methods, approach]
|
|
69
|
+
|
|
70
|
+
## Tests (Micro Acceptance)
|
|
71
|
+
- `it does expected behavior`
|
|
72
|
+
- `it handles edge case X`
|
|
73
|
+
|
|
74
|
+
## Edge Cases
|
|
75
|
+
- [Specific edge cases for this task]
|
|
76
|
+
|
|
77
|
+
## Context
|
|
78
|
+
Specification: `docs/workflow/specification/{topic}.md`
|
|
79
|
+
[Optional: link to specific decision if relevant]
|
|
80
|
+
```
|
|
81
|
+
|
|
82
|
+
**Labels**:
|
|
83
|
+
- **Required**: `phase-1`, `phase-2`, etc. - denotes which phase the task belongs to
|
|
84
|
+
- **Optional**:
|
|
85
|
+
- `needs-info` - task requires additional information before implementation
|
|
86
|
+
- `edge-case` - for edge case handling tasks
|
|
87
|
+
- `foundation` - for setup/infrastructure tasks
|
|
88
|
+
- `refactor` - for cleanup tasks
|
|
89
|
+
|
|
90
|
+
### Using `needs-info` Label
|
|
91
|
+
|
|
92
|
+
When creating issues, if something is unclear or missing from the specification:
|
|
93
|
+
|
|
94
|
+
1. **Create the issue anyway** - don't block planning
|
|
95
|
+
2. **Apply `needs-info` label** - makes gaps visible
|
|
96
|
+
3. **Note what's missing** in description - be specific about what needs clarifying
|
|
97
|
+
4. **Continue planning** - don't stop and circle back
|
|
98
|
+
|
|
99
|
+
This allows iterative refinement. Create all issues, identify gaps, circle back to specification if needed, then update issues with missing detail. Plans don't have to be perfect on first pass.
|
|
100
|
+
|
|
101
|
+
### 4. Create Local Plan File
|
|
102
|
+
|
|
103
|
+
Create `docs/workflow/planning/{topic}.md`:
|
|
104
|
+
|
|
105
|
+
```markdown
|
|
106
|
+
---
|
|
107
|
+
format: linear
|
|
108
|
+
project: {PROJECT_NAME}
|
|
109
|
+
project_id: {ID from MCP response}
|
|
110
|
+
team: {TEAM_NAME}
|
|
111
|
+
---
|
|
112
|
+
|
|
113
|
+
# Plan Reference: {Topic Name}
|
|
114
|
+
|
|
115
|
+
**Specification**: `docs/workflow/specification/{topic}.md`
|
|
116
|
+
**Created**: {DATE}
|
|
117
|
+
|
|
118
|
+
## About This Plan
|
|
119
|
+
|
|
120
|
+
This plan is managed in Linear. The source of truth for tasks and progress is the Linear project referenced above.
|
|
121
|
+
|
|
122
|
+
## How to Use
|
|
123
|
+
|
|
124
|
+
**To view/edit the plan**: Open Linear and navigate to the project.
|
|
125
|
+
|
|
126
|
+
**Implementation will**:
|
|
127
|
+
1. Read this file to find the Linear project
|
|
128
|
+
2. Query Linear for project issues
|
|
129
|
+
3. Work through tasks in phase order (by label)
|
|
130
|
+
4. Update issue status as tasks complete
|
|
131
|
+
|
|
132
|
+
**To add tasks**: Create issues in the Linear project. They'll be picked up automatically.
|
|
133
|
+
|
|
134
|
+
## Key Decisions
|
|
135
|
+
|
|
136
|
+
[Summary of key decisions from specification - for quick reference]
|
|
137
|
+
```
|
|
138
|
+
|
|
139
|
+
## Frontmatter
|
|
140
|
+
|
|
141
|
+
The frontmatter contains all information needed to query Linear:
|
|
142
|
+
|
|
143
|
+
```yaml
|
|
144
|
+
---
|
|
145
|
+
format: linear
|
|
146
|
+
project: USER-AUTH-FEATURE
|
|
147
|
+
project_id: abc123-def456
|
|
148
|
+
team: Engineering
|
|
149
|
+
---
|
|
150
|
+
```
|
|
151
|
+
|
|
152
|
+
## Issue Content Guidelines
|
|
153
|
+
|
|
154
|
+
Issues should be **fully self-contained**. Include all context directly so humans and agents can execute without referencing other files.
|
|
155
|
+
|
|
156
|
+
**Include in each issue**:
|
|
157
|
+
- Goal and rationale (the "why" from the specification)
|
|
158
|
+
- What to implement (specific files/methods)
|
|
159
|
+
- Test names (micro acceptance)
|
|
160
|
+
- Edge cases for this specific task
|
|
161
|
+
- Relevant decisions and constraints
|
|
162
|
+
- Any code examples for complex patterns
|
|
163
|
+
|
|
164
|
+
**Specification reference**: The specification at `docs/workflow/specification/{topic}.md` remains available for resolving ambiguity or getting additional context, but issues should contain all information needed for execution.
|
|
165
|
+
|
|
166
|
+
The goal: anyone (Claude or human) could pick up the issue and execute it without opening another document.
|
|
167
|
+
|
|
168
|
+
## Benefits
|
|
169
|
+
|
|
170
|
+
- Visual tracking with real-time progress updates
|
|
171
|
+
- Team collaboration with shared visibility
|
|
172
|
+
- Update tasks directly in Linear UI without editing markdown
|
|
173
|
+
- Integrates with existing Linear workflows
|
|
174
|
+
|
|
175
|
+
## Resulting Structure
|
|
176
|
+
|
|
177
|
+
After planning:
|
|
178
|
+
|
|
179
|
+
```
|
|
180
|
+
docs/workflow/
|
|
181
|
+
├── discussion/{topic}.md # Phase 2 output
|
|
182
|
+
├── specification/{topic}.md # Phase 3 output
|
|
183
|
+
└── planning/{topic}.md # Phase 4 output (format: linear - pointer)
|
|
184
|
+
|
|
185
|
+
Linear:
|
|
186
|
+
└── Project: {topic}
|
|
187
|
+
├── Issue: Task 1 [label: phase-1]
|
|
188
|
+
├── Issue: Task 2 [label: phase-1]
|
|
189
|
+
└── Issue: Task 3 [label: phase-2]
|
|
190
|
+
```
|
|
191
|
+
|
|
192
|
+
## Implementation
|
|
193
|
+
|
|
194
|
+
### Reading Plans
|
|
195
|
+
|
|
196
|
+
1. Extract `project_id` from frontmatter
|
|
197
|
+
2. Query Linear MCP for project issues
|
|
198
|
+
3. Filter issues by phase label (e.g., `phase-1`, `phase-2`)
|
|
199
|
+
4. Process in phase order
|
|
200
|
+
|
|
201
|
+
### Updating Progress
|
|
202
|
+
|
|
203
|
+
- Update issue status in Linear via MCP after each task
|
|
204
|
+
- User sees real-time progress in Linear UI
|
|
205
|
+
|
|
206
|
+
### Fallback
|
|
207
|
+
|
|
208
|
+
If Linear MCP is unavailable:
|
|
209
|
+
- Inform the user
|
|
210
|
+
- Cannot proceed without MCP access
|
|
211
|
+
- Suggest checking MCP configuration or switching to local markdown
|
|
@@ -0,0 +1,185 @@
|
|
|
1
|
+
# Output: Local Markdown
|
|
2
|
+
|
|
3
|
+
*Output adapter for **[technical-planning](../SKILL.md)***
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
Use this format for simple features or when you want everything in a single version-controlled file.
|
|
8
|
+
|
|
9
|
+
## Benefits
|
|
10
|
+
|
|
11
|
+
- No external tools or dependencies required
|
|
12
|
+
- Everything in a single version-controlled file
|
|
13
|
+
- Human-readable and easy to edit
|
|
14
|
+
- Works offline with any text editor
|
|
15
|
+
- Simplest setup - just create a markdown file
|
|
16
|
+
|
|
17
|
+
## Setup
|
|
18
|
+
|
|
19
|
+
No external tools required. This format uses plain markdown files stored in the repository.
|
|
20
|
+
|
|
21
|
+
## Output Location
|
|
22
|
+
|
|
23
|
+
```
|
|
24
|
+
docs/workflow/planning/
|
|
25
|
+
└── {topic}.md
|
|
26
|
+
```
|
|
27
|
+
|
|
28
|
+
This is a single file per topic in the planning directory.
|
|
29
|
+
|
|
30
|
+
## Template
|
|
31
|
+
|
|
32
|
+
Create `{topic}.md` with this structure:
|
|
33
|
+
|
|
34
|
+
```markdown
|
|
35
|
+
---
|
|
36
|
+
format: local-markdown
|
|
37
|
+
---
|
|
38
|
+
|
|
39
|
+
# Implementation Plan: {Feature/Project Name}
|
|
40
|
+
|
|
41
|
+
**Date**: YYYY-MM-DD
|
|
42
|
+
**Status**: Draft | Ready | In Progress | Completed
|
|
43
|
+
**Specification**: `docs/workflow/specification/{topic}.md`
|
|
44
|
+
|
|
45
|
+
## Overview
|
|
46
|
+
|
|
47
|
+
**Goal**: What we're building and why (one sentence)
|
|
48
|
+
|
|
49
|
+
**Done when**:
|
|
50
|
+
- Measurable outcome 1
|
|
51
|
+
- Measurable outcome 2
|
|
52
|
+
|
|
53
|
+
**Key Decisions** (from specification):
|
|
54
|
+
- Decision 1: Rationale
|
|
55
|
+
- Decision 2: Rationale
|
|
56
|
+
|
|
57
|
+
## Architecture
|
|
58
|
+
|
|
59
|
+
- Components
|
|
60
|
+
- Data flow
|
|
61
|
+
- Integration points
|
|
62
|
+
|
|
63
|
+
## Phases
|
|
64
|
+
|
|
65
|
+
Each phase is independently testable with clear acceptance criteria.
|
|
66
|
+
Each task is a single TDD cycle: write test → implement → commit.
|
|
67
|
+
|
|
68
|
+
---
|
|
69
|
+
|
|
70
|
+
### Phase 1: {Name}
|
|
71
|
+
|
|
72
|
+
**Goal**: What this phase accomplishes
|
|
73
|
+
|
|
74
|
+
**Acceptance**:
|
|
75
|
+
- [ ] Criterion 1
|
|
76
|
+
- [ ] Criterion 2
|
|
77
|
+
|
|
78
|
+
**Tasks**:
|
|
79
|
+
|
|
80
|
+
1. **{Task Name}**
|
|
81
|
+
- **Do**: What to implement
|
|
82
|
+
- **Test**: `"it does expected behavior"`
|
|
83
|
+
- **Edge cases**: (if any)
|
|
84
|
+
|
|
85
|
+
2. **{Task Name}**
|
|
86
|
+
- **Do**: What to implement
|
|
87
|
+
- **Test**: `"it does expected behavior"`
|
|
88
|
+
|
|
89
|
+
---
|
|
90
|
+
|
|
91
|
+
### Phase 2: {Name}
|
|
92
|
+
|
|
93
|
+
**Goal**: What this phase accomplishes
|
|
94
|
+
|
|
95
|
+
**Acceptance**:
|
|
96
|
+
- [ ] Criterion 1
|
|
97
|
+
- [ ] Criterion 2
|
|
98
|
+
|
|
99
|
+
**Tasks**:
|
|
100
|
+
|
|
101
|
+
1. **{Task Name}**
|
|
102
|
+
- **Do**: What to implement
|
|
103
|
+
- **Test**: `"it does expected behavior"`
|
|
104
|
+
|
|
105
|
+
(Continue pattern for remaining phases)
|
|
106
|
+
|
|
107
|
+
---
|
|
108
|
+
|
|
109
|
+
## Edge Cases
|
|
110
|
+
|
|
111
|
+
Map edge cases from specification to specific tasks:
|
|
112
|
+
|
|
113
|
+
| Edge Case | Solution | Phase.Task | Test |
|
|
114
|
+
|-----------|----------|------------|------|
|
|
115
|
+
| {From specification} | How handled | 1.2 | `"it handles X"` |
|
|
116
|
+
|
|
117
|
+
## Testing Strategy
|
|
118
|
+
|
|
119
|
+
**Unit**: What to test per component
|
|
120
|
+
**Integration**: What flows to verify
|
|
121
|
+
**Manual**: (if needed)
|
|
122
|
+
|
|
123
|
+
## Data Models (if applicable)
|
|
124
|
+
|
|
125
|
+
Tables, schemas, API contracts
|
|
126
|
+
|
|
127
|
+
## Dependencies
|
|
128
|
+
|
|
129
|
+
- Prerequisites for Phase 1
|
|
130
|
+
- Phase dependencies
|
|
131
|
+
- External blockers
|
|
132
|
+
|
|
133
|
+
## Rollback (if applicable)
|
|
134
|
+
|
|
135
|
+
Triggers and steps
|
|
136
|
+
|
|
137
|
+
## Log
|
|
138
|
+
|
|
139
|
+
| Date | Change |
|
|
140
|
+
|------|--------|
|
|
141
|
+
| YYYY-MM-DD | Created from specification |
|
|
142
|
+
```
|
|
143
|
+
|
|
144
|
+
## Frontmatter
|
|
145
|
+
|
|
146
|
+
The `format: local-markdown` frontmatter tells implementation that the full plan content is in this file.
|
|
147
|
+
|
|
148
|
+
## Flagging Incomplete Tasks
|
|
149
|
+
|
|
150
|
+
When information is missing, mark clearly with `[needs-info]`:
|
|
151
|
+
|
|
152
|
+
```markdown
|
|
153
|
+
### Task 3: Configure rate limiting [needs-info]
|
|
154
|
+
|
|
155
|
+
**Do**: Set up rate limiting for the API endpoint
|
|
156
|
+
**Test**: `it throttles requests exceeding limit`
|
|
157
|
+
|
|
158
|
+
**Needs clarification**:
|
|
159
|
+
- What's the rate limit threshold?
|
|
160
|
+
- Per-user or per-IP?
|
|
161
|
+
```
|
|
162
|
+
|
|
163
|
+
## Resulting Structure
|
|
164
|
+
|
|
165
|
+
After planning:
|
|
166
|
+
|
|
167
|
+
```
|
|
168
|
+
docs/workflow/
|
|
169
|
+
├── discussion/{topic}.md # Phase 2 output
|
|
170
|
+
├── specification/{topic}.md # Phase 3 output
|
|
171
|
+
└── planning/{topic}.md # Phase 4 output (format: local-markdown)
|
|
172
|
+
```
|
|
173
|
+
|
|
174
|
+
## Implementation
|
|
175
|
+
|
|
176
|
+
### Reading Plans
|
|
177
|
+
|
|
178
|
+
1. Read the plan file - all content is inline
|
|
179
|
+
2. Phases and tasks are in the document
|
|
180
|
+
3. Follow phase order as written
|
|
181
|
+
|
|
182
|
+
### Updating Progress
|
|
183
|
+
|
|
184
|
+
- Check off acceptance criteria in the plan file
|
|
185
|
+
- Update phase status as phases complete
|
|
@@ -0,0 +1,81 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: technical-research
|
|
3
|
+
description: "Explore ideas, validate concepts, and research broadly across technical, business, and market domains. Preliminary phase before discussion-specification-plan-implement-review workflow. Use when: (1) User has a new idea to explore, (2) Need to research a topic deeply, (3) Validating feasibility - technical, business, or market, (4) Learning and exploration without necessarily building anything, (5) User says 'research this' or 'explore this idea', (6) Brain dumping early thoughts before formal discussion. Creates research documents in docs/workflow/research/ that may seed the technical-discussion phase."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Technical Research
|
|
7
|
+
|
|
8
|
+
Act as **research partner** with broad expertise spanning technical, product, business, and market domains. Your role is learning, exploration, and discovery.
|
|
9
|
+
|
|
10
|
+
## Six-Phase Workflow
|
|
11
|
+
|
|
12
|
+
1. **Research** (YOU): EXPLORE - ideas, feasibility, market, business, learning
|
|
13
|
+
2. **Discussion** (next): WHAT and WHY - decisions, architecture, edge cases
|
|
14
|
+
3. **Specification** (after): REFINE - validate and build standalone spec
|
|
15
|
+
4. **Planning** (after): HOW - phases, tasks, acceptance criteria
|
|
16
|
+
5. **Implementation** (after): DOING - tests first, then code
|
|
17
|
+
6. **Review** (final): VALIDATING - check work against artifacts
|
|
18
|
+
|
|
19
|
+
You're at step 1. Explore freely.
|
|
20
|
+
|
|
21
|
+
## Your Expertise
|
|
22
|
+
|
|
23
|
+
You bring knowledge across the full landscape:
|
|
24
|
+
|
|
25
|
+
- **Technical**: Feasibility, architecture approaches, time to market, complexity
|
|
26
|
+
- **Business**: Pricing models, profitability, business models, unit economics
|
|
27
|
+
- **Market**: Competitors, market fit, timing, gaps, positioning
|
|
28
|
+
- **Product**: User needs, value proposition, differentiation
|
|
29
|
+
|
|
30
|
+
Don't constrain yourself. Research goes wherever it needs to go.
|
|
31
|
+
|
|
32
|
+
## Exploration Mindset
|
|
33
|
+
|
|
34
|
+
**Follow tangents**: If something interesting comes up, pursue it.
|
|
35
|
+
|
|
36
|
+
**Go broad**: Technical feasibility, pricing, competitors, timing, market fit - explore whatever's relevant.
|
|
37
|
+
|
|
38
|
+
**Learning is valid**: Not everything leads to building something. Understanding has value on its own.
|
|
39
|
+
|
|
40
|
+
**Be honest**: If something seems flawed or risky, say so. Challenge assumptions.
|
|
41
|
+
|
|
42
|
+
## Questioning
|
|
43
|
+
|
|
44
|
+
Use `/interview` for structured questioning. Good research questions:
|
|
45
|
+
|
|
46
|
+
- Reveal hidden complexity
|
|
47
|
+
- Surface concerns early
|
|
48
|
+
- Challenge comfortable assumptions
|
|
49
|
+
- Probe the "why" behind ideas
|
|
50
|
+
|
|
51
|
+
Ask one question at a time. Wait for the answer. Document. Then ask the next.
|
|
52
|
+
|
|
53
|
+
## File Strategy
|
|
54
|
+
|
|
55
|
+
**Output**: `docs/workflow/research/exploration.md`
|
|
56
|
+
|
|
57
|
+
Start with one file. Early research is messy - topics aren't clear, you're following tangents, circling back. Don't force structure too early.
|
|
58
|
+
|
|
59
|
+
**Let themes emerge**: Over multiple sessions, topics may become distinct. When they do, split into semantic files (`market-landscape.md`, `technical-feasibility.md`).
|
|
60
|
+
|
|
61
|
+
**Periodic review**: Every few sessions, assess: are themes emerging? Split them out. Still fuzzy? Keep exploring. Ready for deeper discussion? Move to `docs/workflow/discussion/`.
|
|
62
|
+
|
|
63
|
+
## Documentation Loop
|
|
64
|
+
|
|
65
|
+
Research without documentation is wasted. Follow this loop:
|
|
66
|
+
|
|
67
|
+
1. **Ask** a question
|
|
68
|
+
2. **Discuss** the answer
|
|
69
|
+
3. **Document** the insight
|
|
70
|
+
4. **Commit and push** immediately
|
|
71
|
+
5. **Repeat**
|
|
72
|
+
|
|
73
|
+
**Don't batch**. Every insight gets pushed before the next question. Context can refresh at any time—unpushed work is lost.
|
|
74
|
+
|
|
75
|
+
## Critical Rules
|
|
76
|
+
|
|
77
|
+
**Don't hallucinate**: Only document what was actually discussed.
|
|
78
|
+
|
|
79
|
+
**Don't expand**: Capture what was said, don't embellish.
|
|
80
|
+
|
|
81
|
+
**Verify before refreshing**: If context is running low, commit and push everything first.
|
|
@@ -0,0 +1,107 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: technical-review
|
|
3
|
+
description: "Validate completed implementation against plan tasks and acceptance criteria. Sixth phase of research-discussion-specification-plan-implement-review workflow. Use when: (1) Implementation phase is complete, (2) User wants validation before merging/shipping, (3) Quality gate check needed after implementation. Reviews ALL plan tasks for implementation correctness, test adequacy, and code quality. Produces structured feedback (approve, request changes, or comments) - does NOT fix code."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Technical Review
|
|
7
|
+
|
|
8
|
+
Act as a **senior software architect** with deep experience in code review. You haven't seen this code before. Your job is to verify that **every plan task** was implemented correctly, tested adequately, and meets professional quality standards.
|
|
9
|
+
|
|
10
|
+
This is **product review**, **feature review**, **test review**, AND **code review**. Not just "does the code work?" but "was every task done correctly, tested properly, and built to professional standards?"
|
|
11
|
+
|
|
12
|
+
## Six-Phase Workflow
|
|
13
|
+
|
|
14
|
+
1. **Research** (artifact): EXPLORE - ideas, feasibility, market, business, learning
|
|
15
|
+
2. **Discussion** (artifact): WHAT and WHY - decisions, architecture, rationale
|
|
16
|
+
3. **Specification** (artifact): REFINE - validated, standalone specification
|
|
17
|
+
4. **Planning** (artifact): HOW - phases, tasks, acceptance criteria
|
|
18
|
+
5. **Implementation** (completed): DOING - tests and code
|
|
19
|
+
6. **Review** (YOU): VALIDATING - verify every task
|
|
20
|
+
|
|
21
|
+
You're at step 6. The code exists. Your job is comprehensive verification.
|
|
22
|
+
|
|
23
|
+
## Review Approach
|
|
24
|
+
|
|
25
|
+
Start from the **plan** - it contains the granular tasks and acceptance criteria. Use the **specification** for context. Verify **all** tasks, not a sample.
|
|
26
|
+
|
|
27
|
+
```
|
|
28
|
+
Plan (tasks + acceptance criteria)
|
|
29
|
+
↓
|
|
30
|
+
For EACH task:
|
|
31
|
+
→ Load Spec Context (deeper understanding)
|
|
32
|
+
→ Verify Implementation (code exists, correct)
|
|
33
|
+
→ Verify Tests (adequate, not over/under tested)
|
|
34
|
+
→ Check Code Quality (readable, conventions)
|
|
35
|
+
```
|
|
36
|
+
|
|
37
|
+
**Use parallel `chain-verifier` subagents** to verify ALL plan tasks simultaneously. Each verifier checks one task for implementation, tests, and quality. This enables comprehensive review without sequential bottlenecks.
|
|
38
|
+
|
|
39
|
+
## What You Verify (Per Task)
|
|
40
|
+
|
|
41
|
+
### Implementation
|
|
42
|
+
|
|
43
|
+
- Is the task implemented?
|
|
44
|
+
- Does it match the acceptance criteria?
|
|
45
|
+
- Does it align with spec context?
|
|
46
|
+
- Any drift from what was planned?
|
|
47
|
+
|
|
48
|
+
### Tests
|
|
49
|
+
|
|
50
|
+
Evaluate test coverage critically - both directions:
|
|
51
|
+
|
|
52
|
+
- **Not under-tested**: Does a test exist? Does it verify acceptance criteria? Are edge cases covered?
|
|
53
|
+
- **Not over-tested**: Are tests focused and necessary? No redundant or bloated checks?
|
|
54
|
+
- Would the test fail if the feature broke?
|
|
55
|
+
|
|
56
|
+
### Code Quality
|
|
57
|
+
|
|
58
|
+
Review as a senior architect would:
|
|
59
|
+
|
|
60
|
+
**Project conventions** (check `.claude/skills/` for project-specific guidance):
|
|
61
|
+
- Framework and architecture guidelines
|
|
62
|
+
- Code style and patterns specific to the project
|
|
63
|
+
|
|
64
|
+
**General principles** (always apply):
|
|
65
|
+
- **SOLID**: Single responsibility, open/closed, Liskov substitution, interface segregation, dependency inversion
|
|
66
|
+
- **DRY**: No unnecessary duplication (without premature abstraction)
|
|
67
|
+
- **Low complexity**: Reasonable cyclomatic complexity, clear code paths
|
|
68
|
+
- **Modern idioms**: Uses current language features appropriately
|
|
69
|
+
- **Readability**: Self-documenting code, clear intent
|
|
70
|
+
- **Security**: No obvious vulnerabilities
|
|
71
|
+
- **Performance**: No obvious inefficiencies
|
|
72
|
+
|
|
73
|
+
## Review Process
|
|
74
|
+
|
|
75
|
+
1. **Read the plan** - Understand all phases, tasks, and acceptance criteria
|
|
76
|
+
2. **Read the specification** - Load context for the feature being reviewed
|
|
77
|
+
3. **Extract all tasks** - List every task from every phase
|
|
78
|
+
4. **Spawn chain-verifiers in parallel** - One subagent per task, all running simultaneously
|
|
79
|
+
5. **Aggregate findings** - Collect reports from all chain-verifiers
|
|
80
|
+
6. **Check project skills** - Framework/language conventions
|
|
81
|
+
7. **Produce review** - Structured feedback covering all tasks
|
|
82
|
+
|
|
83
|
+
See **[review-checklist.md](references/review-checklist.md)** for detailed checklist.
|
|
84
|
+
|
|
85
|
+
## Hard Rules
|
|
86
|
+
|
|
87
|
+
1. **Review ALL tasks** - Don't sample; verify every planned task
|
|
88
|
+
2. **Don't fix code** - Identify problems, don't solve them
|
|
89
|
+
3. **Don't re-implement** - You're reviewing, not building
|
|
90
|
+
4. **Be specific** - "Test doesn't cover X" not "tests need work"
|
|
91
|
+
5. **Reference artifacts** - Link findings to plan/spec with file:line references
|
|
92
|
+
6. **Balanced test review** - Flag both under-testing AND over-testing
|
|
93
|
+
7. **Fresh perspective** - You haven't seen this code before; question everything
|
|
94
|
+
|
|
95
|
+
## What Happens After Review
|
|
96
|
+
|
|
97
|
+
Your review feedback can be:
|
|
98
|
+
- Addressed by implementation (same or new session)
|
|
99
|
+
- Delegated to an agent for fixes
|
|
100
|
+
- Overridden by user ("ship it anyway")
|
|
101
|
+
|
|
102
|
+
You produce feedback. User decides what to do with it.
|
|
103
|
+
|
|
104
|
+
## References
|
|
105
|
+
|
|
106
|
+
- **[template.md](references/template.md)** - Review output structure and verdict guidelines
|
|
107
|
+
- **[review-checklist.md](references/review-checklist.md)** - Detailed review checklist
|