@leejungkiin/awkit 1.1.1 → 1.1.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/bin/awk.js +215 -72
- package/bin/cline-generators.js +73 -0
- package/bin/codex-generators.js +108 -0
- package/core/GEMINI.md +14 -17
- package/package.json +2 -2
- package/skill-packs/superpowers/README.md +59 -0
- package/skill-packs/superpowers/pack.json +15 -0
- package/skill-packs/superpowers/skills/brainstorming/SKILL.md +96 -0
- package/skill-packs/superpowers/skills/executing-plans/SKILL.md +100 -0
- package/skill-packs/superpowers/skills/finishing-a-development-branch/SKILL.md +213 -0
- package/skill-packs/superpowers/skills/receiving-code-review/SKILL.md +213 -0
- package/skill-packs/superpowers/skills/requesting-code-review/SKILL.md +115 -0
- package/skill-packs/superpowers/skills/requesting-code-review/code-reviewer.md +146 -0
- package/skill-packs/superpowers/skills/single-flow-task-execution/SKILL.md +359 -0
- package/skill-packs/superpowers/skills/single-flow-task-execution/code-quality-reviewer-prompt.md +20 -0
- package/skill-packs/superpowers/skills/single-flow-task-execution/implementer-prompt.md +78 -0
- package/skill-packs/superpowers/skills/single-flow-task-execution/spec-reviewer-prompt.md +61 -0
- package/skill-packs/superpowers/skills/systematic-debugging/CREATION-LOG.md +119 -0
- package/skill-packs/superpowers/skills/systematic-debugging/SKILL.md +296 -0
- package/skill-packs/superpowers/skills/systematic-debugging/condition-based-waiting-example.ts +158 -0
- package/skill-packs/superpowers/skills/systematic-debugging/condition-based-waiting.md +115 -0
- package/skill-packs/superpowers/skills/systematic-debugging/defense-in-depth.md +122 -0
- package/skill-packs/superpowers/skills/systematic-debugging/find-polluter.sh +63 -0
- package/skill-packs/superpowers/skills/systematic-debugging/root-cause-tracing.md +169 -0
- package/skill-packs/superpowers/skills/systematic-debugging/test-academic.md +14 -0
- package/skill-packs/superpowers/skills/systematic-debugging/test-pressure-1.md +58 -0
- package/skill-packs/superpowers/skills/systematic-debugging/test-pressure-2.md +68 -0
- package/skill-packs/superpowers/skills/systematic-debugging/test-pressure-3.md +69 -0
- package/skill-packs/superpowers/skills/test-driven-development/SKILL.md +371 -0
- package/skill-packs/superpowers/skills/test-driven-development/testing-anti-patterns.md +299 -0
- package/skill-packs/superpowers/skills/using-git-worktrees/SKILL.md +223 -0
- package/skill-packs/superpowers/skills/using-superpowers/SKILL.md +97 -0
- package/skill-packs/superpowers/skills/verification-before-completion/SKILL.md +139 -0
- package/skill-packs/superpowers/skills/writing-plans/SKILL.md +108 -0
- package/skill-packs/superpowers/skills/writing-skills/SKILL.md +716 -0
- package/skill-packs/superpowers/skills/writing-skills/antigravity-best-practices.md +1173 -0
- package/skill-packs/superpowers/skills/writing-skills/examples/AGENTS_MD_TESTING.md +189 -0
- package/skill-packs/superpowers/skills/writing-skills/graphviz-conventions.dot +172 -0
- package/skill-packs/superpowers/skills/writing-skills/persuasion-principles.md +187 -0
- package/skill-packs/superpowers/skills/writing-skills/render-graphs.js +175 -0
- package/skill-packs/superpowers/skills/writing-skills/testing-skills-with-subagents.md +384 -0
- package/skills/CATALOG.md +7 -0
- package/skills/orchestrator/SKILL.md +0 -4
- package/skills/symphony-enforcer/SKILL.md +188 -53
- package/templates/specs/PROJECT.md +50 -0
- package/templates/specs/ROADMAP.md +79 -0
- package/templates/specs/TECH-SPEC.md +81 -0
- package/templates/specs/task-spec-template.xml +65 -0
- package/workflows/lifecycle/init.md +103 -91
- package/core/AGENTS.md +0 -38
- package/skills/beads-manager/SKILL.md +0 -459
- package/workflows/_uncategorized/AGENTS.md +0 -38
|
@@ -0,0 +1,59 @@
|
|
|
1
|
+
# 🦸 Superpowers Skill Pack
|
|
2
|
+
|
|
3
|
+
> Structured development workflows ported from Claude Code Superpowers.
|
|
4
|
+
|
|
5
|
+
Origin: [skainguyen1412/antigravity-superpowers](https://github.com/skainguyen1412/antigravity-superpowers)
|
|
6
|
+
|
|
7
|
+
---
|
|
8
|
+
|
|
9
|
+
## Install
|
|
10
|
+
|
|
11
|
+
```bash
|
|
12
|
+
awk enable-pack superpowers
|
|
13
|
+
```
|
|
14
|
+
|
|
15
|
+
Installs 13 skills into `~/.gemini/antigravity/skills/`:
|
|
16
|
+
|
|
17
|
+
| # | Skill | Purpose |
|
|
18
|
+
|---|-------|---------|
|
|
19
|
+
| 1 | `brainstorming` | Design-first exploration before creative work |
|
|
20
|
+
| 2 | `executing-plans` | Load and execute plans with review checkpoints |
|
|
21
|
+
| 3 | `finishing-a-development-branch` | Structured branch completion: merge/PR/keep/discard |
|
|
22
|
+
| 4 | `receiving-code-review` | Technical evaluation of review feedback |
|
|
23
|
+
| 5 | `requesting-code-review` | Structured review pass before merge |
|
|
24
|
+
| 6 | `single-flow-task-execution` | **One-task-at-a-time with two-stage review loop** |
|
|
25
|
+
| 7 | `systematic-debugging` | Root cause analysis before fixing |
|
|
26
|
+
| 8 | `test-driven-development` | Red-Green-Refactor TDD cycle |
|
|
27
|
+
| 9 | `using-git-worktrees` | Isolated workspaces via git worktrees |
|
|
28
|
+
| 10 | `using-superpowers` | Skill-first routing and loading |
|
|
29
|
+
| 11 | `verification-before-completion` | Evidence-based completion claims |
|
|
30
|
+
| 12 | `writing-plans` | Create bite-sized implementation plans |
|
|
31
|
+
| 13 | `writing-skills` | TDD-based skill authoring |
|
|
32
|
+
|
|
33
|
+
---
|
|
34
|
+
|
|
35
|
+
## Key Feature: Two-Stage Review Loop
|
|
36
|
+
|
|
37
|
+
The `single-flow-task-execution` skill introduces a disciplined review process:
|
|
38
|
+
|
|
39
|
+
1. **Implement** → Self-review → Commit
|
|
40
|
+
2. **Spec compliance review** → "Did we build what was requested?"
|
|
41
|
+
3. **Code quality review** → "Is the code clean and maintainable?"
|
|
42
|
+
4. Both pass → Next task
|
|
43
|
+
|
|
44
|
+
This prevents the common failure of "code is clean but doesn't match requirements."
|
|
45
|
+
|
|
46
|
+
---
|
|
47
|
+
|
|
48
|
+
## Overlap with AWF Skills
|
|
49
|
+
|
|
50
|
+
| Superpowers Skill | AWF Equivalent | Recommendation |
|
|
51
|
+
|-------------------|---------------|----------------|
|
|
52
|
+
| `brainstorming` | `brainstorm-agent` | AWF version is more comprehensive (3 modes, Vietnamese) |
|
|
53
|
+
| `using-superpowers` | `orchestrator` | AWF version has Symphony + NeuralMemory integration |
|
|
54
|
+
|
|
55
|
+
Both versions can coexist — they have different names and slightly different trigger patterns.
|
|
56
|
+
|
|
57
|
+
---
|
|
58
|
+
|
|
59
|
+
*Superpowers Skill Pack for AWK · Ported from Claude Code*
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "superpowers",
|
|
3
|
+
"auto_install": false,
|
|
4
|
+
"description": "Structured development workflows ported from Claude Code Superpowers: TDD, code review, planning, debugging, git worktree isolation, and two-stage review loops",
|
|
5
|
+
"origin": "https://github.com/skainguyen1412/antigravity-superpowers",
|
|
6
|
+
"requires": [],
|
|
7
|
+
"post_install": [],
|
|
8
|
+
"notes": {
|
|
9
|
+
"overlap": [
|
|
10
|
+
"brainstorming ↔ brainstorm-agent (AWF version is more comprehensive)",
|
|
11
|
+
"using-superpowers ↔ orchestrator (AWF version has Symphony integration)"
|
|
12
|
+
],
|
|
13
|
+
"key_skill": "single-flow-task-execution — Two-stage review loop (spec compliance → code quality)"
|
|
14
|
+
}
|
|
15
|
+
}
|
|
@@ -0,0 +1,96 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: brainstorming
|
|
3
|
+
description: "You MUST use this before any creative work - creating features, building components, adding functionality, or modifying behavior. Explores user intent, requirements and design before implementation."
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Brainstorming Ideas Into Designs
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
Help turn ideas into fully formed designs and specs through natural collaborative dialogue.
|
|
11
|
+
|
|
12
|
+
Start by understanding the current project context, then ask questions one at a time to refine the idea. Once you understand what you're building, present the design and get user approval.
|
|
13
|
+
|
|
14
|
+
<HARD-GATE>
|
|
15
|
+
Do NOT invoke any implementation skill, write any code, scaffold any project, or take any implementation action until you have presented a design and the user has approved it. This applies to EVERY project regardless of perceived simplicity.
|
|
16
|
+
</HARD-GATE>
|
|
17
|
+
|
|
18
|
+
## Anti-Pattern: "This Is Too Simple To Need A Design"
|
|
19
|
+
|
|
20
|
+
Every project goes through this process. A todo list, a single-function utility, a config change — all of them. "Simple" projects are where unexamined assumptions cause the most wasted work. The design can be short (a few sentences for truly simple projects), but you MUST present it and get approval.
|
|
21
|
+
|
|
22
|
+
## Checklist
|
|
23
|
+
|
|
24
|
+
You MUST create a task for each of these items and complete them in order:
|
|
25
|
+
|
|
26
|
+
1. **Explore project context** — check files, docs, recent commits
|
|
27
|
+
2. **Ask clarifying questions** — one at a time, understand purpose/constraints/success criteria
|
|
28
|
+
3. **Propose 2-3 approaches** — with trade-offs and your recommendation
|
|
29
|
+
4. **Present design** — in sections scaled to their complexity, get user approval after each section
|
|
30
|
+
5. **Write design doc** — save to `docs/plans/YYYY-MM-DD-<topic>-design.md` and commit
|
|
31
|
+
6. **Transition to implementation** — invoke writing-plans skill to create implementation plan
|
|
32
|
+
|
|
33
|
+
## Process Flow
|
|
34
|
+
|
|
35
|
+
```dot
|
|
36
|
+
digraph brainstorming {
|
|
37
|
+
"Explore project context" [shape=box];
|
|
38
|
+
"Ask clarifying questions" [shape=box];
|
|
39
|
+
"Propose 2-3 approaches" [shape=box];
|
|
40
|
+
"Present design sections" [shape=box];
|
|
41
|
+
"User approves design?" [shape=diamond];
|
|
42
|
+
"Write design doc" [shape=box];
|
|
43
|
+
"Invoke writing-plans skill" [shape=doublecircle];
|
|
44
|
+
|
|
45
|
+
"Explore project context" -> "Ask clarifying questions";
|
|
46
|
+
"Ask clarifying questions" -> "Propose 2-3 approaches";
|
|
47
|
+
"Propose 2-3 approaches" -> "Present design sections";
|
|
48
|
+
"Present design sections" -> "User approves design?";
|
|
49
|
+
"User approves design?" -> "Present design sections" [label="no, revise"];
|
|
50
|
+
"User approves design?" -> "Write design doc" [label="yes"];
|
|
51
|
+
"Write design doc" -> "Invoke writing-plans skill";
|
|
52
|
+
}
|
|
53
|
+
```
|
|
54
|
+
|
|
55
|
+
**The terminal state is invoking writing-plans.** Do NOT invoke frontend-design, mcp-builder, or any other implementation skill. The ONLY skill you invoke after brainstorming is writing-plans.
|
|
56
|
+
|
|
57
|
+
## The Process
|
|
58
|
+
|
|
59
|
+
**Understanding the idea:**
|
|
60
|
+
- Check out the current project state first (files, docs, recent commits)
|
|
61
|
+
- Ask questions one at a time to refine the idea
|
|
62
|
+
- Prefer multiple choice questions when possible, but open-ended is fine too
|
|
63
|
+
- Only one question per message - if a topic needs more exploration, break it into multiple questions
|
|
64
|
+
- Focus on understanding: purpose, constraints, success criteria
|
|
65
|
+
|
|
66
|
+
**Exploring approaches:**
|
|
67
|
+
- Propose 2-3 different approaches with trade-offs
|
|
68
|
+
- Present options conversationally with your recommendation and reasoning
|
|
69
|
+
- Lead with your recommended option and explain why
|
|
70
|
+
|
|
71
|
+
**Presenting the design:**
|
|
72
|
+
- Once you believe you understand what you're building, present the design
|
|
73
|
+
- Scale each section to its complexity: a few sentences if straightforward, up to 200-300 words if nuanced
|
|
74
|
+
- Ask after each section whether it looks right so far
|
|
75
|
+
- Cover: architecture, components, data flow, error handling, testing
|
|
76
|
+
- Be ready to go back and clarify if something doesn't make sense
|
|
77
|
+
|
|
78
|
+
## After the Design
|
|
79
|
+
|
|
80
|
+
**Documentation:**
|
|
81
|
+
- Write the validated design to `docs/plans/YYYY-MM-DD-<topic>-design.md`
|
|
82
|
+
- Use elements-of-style:writing-clearly-and-concisely skill if available
|
|
83
|
+
- Commit the design document to git
|
|
84
|
+
|
|
85
|
+
**Implementation:**
|
|
86
|
+
- Invoke the writing-plans skill to create a detailed implementation plan
|
|
87
|
+
- Do NOT invoke any other skill. writing-plans is the next step.
|
|
88
|
+
|
|
89
|
+
## Key Principles
|
|
90
|
+
|
|
91
|
+
- **One question at a time** - Don't overwhelm with multiple questions
|
|
92
|
+
- **Multiple choice preferred** - Easier to answer than open-ended when possible
|
|
93
|
+
- **YAGNI ruthlessly** - Remove unnecessary features from all designs
|
|
94
|
+
- **Explore alternatives** - Always propose 2-3 approaches before settling
|
|
95
|
+
- **Incremental validation** - Present design, get approval before moving on
|
|
96
|
+
- **Be flexible** - Go back and clarify when something doesn't make sense
|
|
@@ -0,0 +1,100 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: executing-plans
|
|
3
|
+
description: Use when you have a written implementation plan and need to execute it in Antigravity single-flow mode
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Executing Plans
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
Load plan, review critically, execute tasks in batches, report for review between batches.
|
|
11
|
+
|
|
12
|
+
**Core principle:** Batch execution with checkpoints for architect review.
|
|
13
|
+
**Entrypoint principle:** This is the standard execution entrypoint. Do not offer alternate execution modes.
|
|
14
|
+
|
|
15
|
+
**Announce at start:** "I'm using the executing-plans skill to implement this plan."
|
|
16
|
+
|
|
17
|
+
## The Process
|
|
18
|
+
|
|
19
|
+
### Step 1: Load and Review Plan
|
|
20
|
+
|
|
21
|
+
1. Read plan file
|
|
22
|
+
2. Review critically - identify any questions or concerns about the plan
|
|
23
|
+
3. If concerns: Raise them with your human partner before starting
|
|
24
|
+
4. If no concerns: follow the single-flow execution model from `.agent/skills/single-flow-task-execution/SKILL.md`
|
|
25
|
+
5. Update `<project-root>/docs/plans/task.md` (table-only tracker) and proceed
|
|
26
|
+
|
|
27
|
+
### Step 2: Execute Batch
|
|
28
|
+
|
|
29
|
+
**Default: First 3 tasks**
|
|
30
|
+
|
|
31
|
+
For each task:
|
|
32
|
+
|
|
33
|
+
1. Mark as in_progress
|
|
34
|
+
2. Follow each step exactly (plan has bite-sized steps)
|
|
35
|
+
3. Run verifications as specified
|
|
36
|
+
4. Mark as completed
|
|
37
|
+
|
|
38
|
+
### Step 3: Report
|
|
39
|
+
|
|
40
|
+
When batch complete:
|
|
41
|
+
|
|
42
|
+
- Show what was implemented
|
|
43
|
+
- Show verification output
|
|
44
|
+
- Say: "Ready for feedback."
|
|
45
|
+
|
|
46
|
+
### Step 4: Continue
|
|
47
|
+
|
|
48
|
+
Based on feedback:
|
|
49
|
+
|
|
50
|
+
- Apply changes if needed
|
|
51
|
+
- Execute next batch
|
|
52
|
+
- Repeat until complete
|
|
53
|
+
|
|
54
|
+
### Step 5: Complete Development
|
|
55
|
+
|
|
56
|
+
After all tasks complete and verified:
|
|
57
|
+
|
|
58
|
+
- Announce: "I'm using the finishing-a-development-branch skill to complete this work."
|
|
59
|
+
- **REQUIRED SKILL:** Use `.agent/skills/finishing-a-development-branch/SKILL.md`
|
|
60
|
+
- Follow that skill to verify tests, present options, execute choice
|
|
61
|
+
|
|
62
|
+
## When to Stop and Ask for Help
|
|
63
|
+
|
|
64
|
+
**STOP executing immediately when:**
|
|
65
|
+
|
|
66
|
+
- Hit a blocker mid-batch (missing dependency, test fails, instruction unclear)
|
|
67
|
+
- Plan has critical gaps preventing starting
|
|
68
|
+
- You don't understand an instruction
|
|
69
|
+
- Verification fails repeatedly
|
|
70
|
+
|
|
71
|
+
**Ask for clarification rather than guessing.**
|
|
72
|
+
|
|
73
|
+
## When to Revisit Earlier Steps
|
|
74
|
+
|
|
75
|
+
**Return to Review (Step 1) when:**
|
|
76
|
+
|
|
77
|
+
- Partner updates the plan based on your feedback
|
|
78
|
+
- Fundamental approach needs rethinking
|
|
79
|
+
|
|
80
|
+
**Don't force through blockers** - stop and ask.
|
|
81
|
+
|
|
82
|
+
## Remember
|
|
83
|
+
|
|
84
|
+
- Review plan critically first
|
|
85
|
+
- Follow plan steps exactly
|
|
86
|
+
- Don't skip verifications
|
|
87
|
+
- Reference skills when plan says to
|
|
88
|
+
- Between batches: just report and wait
|
|
89
|
+
- Stop when blocked, don't guess
|
|
90
|
+
- Never start implementation on main/master branch without explicit user consent
|
|
91
|
+
- Use `task_boundary` for coding tasks; use `browser_subagent` only for browser tasks
|
|
92
|
+
|
|
93
|
+
## Integration
|
|
94
|
+
|
|
95
|
+
**Required workflow skills:**
|
|
96
|
+
|
|
97
|
+
- **`.agent/skills/using-git-worktrees/SKILL.md`** - REQUIRED: Set up isolated workspace before starting
|
|
98
|
+
- **`.agent/skills/writing-plans/SKILL.md`** - Creates the plan this skill executes
|
|
99
|
+
- **`.agent/skills/single-flow-task-execution/SKILL.md`** - REQUIRED: Enforce single-flow execution with two-stage review
|
|
100
|
+
- **`.agent/skills/finishing-a-development-branch/SKILL.md`** - Complete development after all tasks
|
|
@@ -0,0 +1,213 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: finishing-a-development-branch
|
|
3
|
+
description: Use when implementation is complete, all tests pass, and you need to decide how to integrate the work - guides completion of development work by presenting structured options for merge, PR, or cleanup
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Finishing a Development Branch
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
Guide completion of development work by presenting clear options and handling chosen workflow.
|
|
11
|
+
|
|
12
|
+
**Core principle:** Verify tests → Present options → Execute choice → Clean up.
|
|
13
|
+
|
|
14
|
+
**Announce at start:** "I'm using the finishing-a-development-branch skill to complete this work."
|
|
15
|
+
|
|
16
|
+
## The Process
|
|
17
|
+
|
|
18
|
+
### Step 1: Verify Tests
|
|
19
|
+
|
|
20
|
+
**Before presenting options, verify tests pass:**
|
|
21
|
+
|
|
22
|
+
```bash
|
|
23
|
+
# Run project's test suite
|
|
24
|
+
npm test / cargo test / pytest / go test ./...
|
|
25
|
+
```
|
|
26
|
+
|
|
27
|
+
**If tests fail:**
|
|
28
|
+
|
|
29
|
+
```
|
|
30
|
+
Tests failing (<N> failures). Must fix before completing:
|
|
31
|
+
|
|
32
|
+
[Show failures]
|
|
33
|
+
|
|
34
|
+
Cannot proceed with merge/PR until tests pass.
|
|
35
|
+
```
|
|
36
|
+
|
|
37
|
+
Stop. Don't proceed to Step 2.
|
|
38
|
+
|
|
39
|
+
**If tests pass:** Continue to Step 2.
|
|
40
|
+
|
|
41
|
+
### Step 2: Determine Base Branch
|
|
42
|
+
|
|
43
|
+
```bash
|
|
44
|
+
# Try common base branches
|
|
45
|
+
git merge-base HEAD main 2>/dev/null || git merge-base HEAD master 2>/dev/null
|
|
46
|
+
```
|
|
47
|
+
|
|
48
|
+
Or ask: "This branch split from main - is that correct?"
|
|
49
|
+
|
|
50
|
+
### Step 3: Present Options
|
|
51
|
+
|
|
52
|
+
Present exactly these 4 options:
|
|
53
|
+
|
|
54
|
+
```
|
|
55
|
+
Implementation complete. What would you like to do?
|
|
56
|
+
|
|
57
|
+
1. Merge back to <base-branch> locally
|
|
58
|
+
2. Push and create a Pull Request
|
|
59
|
+
3. Keep the branch as-is (I'll handle it later)
|
|
60
|
+
4. Discard this work
|
|
61
|
+
|
|
62
|
+
Which option?
|
|
63
|
+
```
|
|
64
|
+
|
|
65
|
+
**Don't add explanation** - keep options concise.
|
|
66
|
+
|
|
67
|
+
### Step 4: Execute Choice
|
|
68
|
+
|
|
69
|
+
#### Option 1: Merge Locally
|
|
70
|
+
|
|
71
|
+
```bash
|
|
72
|
+
# Switch to base branch
|
|
73
|
+
git checkout <base-branch>
|
|
74
|
+
|
|
75
|
+
# Pull latest
|
|
76
|
+
git pull
|
|
77
|
+
|
|
78
|
+
# Merge feature branch
|
|
79
|
+
git merge <feature-branch>
|
|
80
|
+
|
|
81
|
+
# Verify tests on merged result
|
|
82
|
+
<test command>
|
|
83
|
+
|
|
84
|
+
# If tests pass
|
|
85
|
+
git branch -d <feature-branch>
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
Then: Cleanup worktree (Step 5)
|
|
89
|
+
|
|
90
|
+
#### Option 2: Push and Create PR
|
|
91
|
+
|
|
92
|
+
```bash
|
|
93
|
+
# Push branch
|
|
94
|
+
git push -u origin <feature-branch>
|
|
95
|
+
|
|
96
|
+
# Create PR
|
|
97
|
+
gh pr create --title "<title>" --body "$(cat <<'EOF'
|
|
98
|
+
## Summary
|
|
99
|
+
<2-3 bullets of what changed>
|
|
100
|
+
|
|
101
|
+
## Test Plan
|
|
102
|
+
- [ ] <verification steps>
|
|
103
|
+
EOF
|
|
104
|
+
)"
|
|
105
|
+
```
|
|
106
|
+
|
|
107
|
+
Then: Cleanup worktree (Step 5)
|
|
108
|
+
|
|
109
|
+
#### Option 3: Keep As-Is
|
|
110
|
+
|
|
111
|
+
Report: "Keeping branch <name>. Worktree preserved at <path>."
|
|
112
|
+
|
|
113
|
+
**Don't cleanup worktree.**
|
|
114
|
+
|
|
115
|
+
#### Option 4: Discard
|
|
116
|
+
|
|
117
|
+
**Confirm first:**
|
|
118
|
+
|
|
119
|
+
```
|
|
120
|
+
This will permanently delete:
|
|
121
|
+
- Branch <name>
|
|
122
|
+
- All commits: <commit-list>
|
|
123
|
+
- Worktree at <path>
|
|
124
|
+
|
|
125
|
+
Type 'discard' to confirm.
|
|
126
|
+
```
|
|
127
|
+
|
|
128
|
+
Wait for exact confirmation.
|
|
129
|
+
|
|
130
|
+
If confirmed:
|
|
131
|
+
|
|
132
|
+
```bash
|
|
133
|
+
git checkout <base-branch>
|
|
134
|
+
git branch -D <feature-branch>
|
|
135
|
+
```
|
|
136
|
+
|
|
137
|
+
Then: Cleanup worktree (Step 5)
|
|
138
|
+
|
|
139
|
+
### Step 5: Cleanup Worktree
|
|
140
|
+
|
|
141
|
+
**For Options 1, 2, 4:**
|
|
142
|
+
|
|
143
|
+
Check if in worktree:
|
|
144
|
+
|
|
145
|
+
```bash
|
|
146
|
+
git worktree list | grep $(git branch --show-current)
|
|
147
|
+
```
|
|
148
|
+
|
|
149
|
+
If yes:
|
|
150
|
+
|
|
151
|
+
```bash
|
|
152
|
+
git worktree remove <worktree-path>
|
|
153
|
+
```
|
|
154
|
+
|
|
155
|
+
**For Option 3:** Keep worktree.
|
|
156
|
+
|
|
157
|
+
## Quick Reference
|
|
158
|
+
|
|
159
|
+
| Option | Merge | Push | Keep Worktree | Cleanup Branch |
|
|
160
|
+
| ---------------- | ----- | ---- | ------------- | -------------- |
|
|
161
|
+
| 1. Merge locally | ✓ | - | - | ✓ |
|
|
162
|
+
| 2. Create PR | - | ✓ | ✓ | - |
|
|
163
|
+
| 3. Keep as-is | - | - | ✓ | - |
|
|
164
|
+
| 4. Discard | - | - | - | ✓ (force) |
|
|
165
|
+
|
|
166
|
+
## Common Mistakes
|
|
167
|
+
|
|
168
|
+
**Skipping test verification**
|
|
169
|
+
|
|
170
|
+
- **Problem:** Merge broken code, create failing PR
|
|
171
|
+
- **Fix:** Always verify tests before offering options
|
|
172
|
+
|
|
173
|
+
**Open-ended questions**
|
|
174
|
+
|
|
175
|
+
- **Problem:** "What should I do next?" → ambiguous
|
|
176
|
+
- **Fix:** Present exactly 4 structured options
|
|
177
|
+
|
|
178
|
+
**Automatic worktree cleanup**
|
|
179
|
+
|
|
180
|
+
- **Problem:** Remove worktree when might need it (Option 2, 3)
|
|
181
|
+
- **Fix:** Only cleanup for Options 1 and 4
|
|
182
|
+
|
|
183
|
+
**No confirmation for discard**
|
|
184
|
+
|
|
185
|
+
- **Problem:** Accidentally delete work
|
|
186
|
+
- **Fix:** Require typed "discard" confirmation
|
|
187
|
+
|
|
188
|
+
## Red Flags
|
|
189
|
+
|
|
190
|
+
**Never:**
|
|
191
|
+
|
|
192
|
+
- Proceed with failing tests
|
|
193
|
+
- Merge without verifying tests on result
|
|
194
|
+
- Delete work without confirmation
|
|
195
|
+
- Force-push without explicit request
|
|
196
|
+
|
|
197
|
+
**Always:**
|
|
198
|
+
|
|
199
|
+
- Verify tests before offering options
|
|
200
|
+
- Present exactly 4 options
|
|
201
|
+
- Get typed confirmation for Option 4
|
|
202
|
+
- Clean up worktree for Options 1 & 4 only
|
|
203
|
+
|
|
204
|
+
## Integration
|
|
205
|
+
|
|
206
|
+
**Called by:**
|
|
207
|
+
|
|
208
|
+
- **single-flow-task-execution** (final step) - After all tasks complete
|
|
209
|
+
- **executing-plans** (Step 5) - After all batches complete
|
|
210
|
+
|
|
211
|
+
**Pairs with:**
|
|
212
|
+
|
|
213
|
+
- **using-git-worktrees** - Cleans up worktree created by that skill
|
|
@@ -0,0 +1,213 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: receiving-code-review
|
|
3
|
+
description: Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Code Review Reception
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
Code review requires technical evaluation, not emotional performance.
|
|
11
|
+
|
|
12
|
+
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
|
|
13
|
+
|
|
14
|
+
## The Response Pattern
|
|
15
|
+
|
|
16
|
+
```
|
|
17
|
+
WHEN receiving code review feedback:
|
|
18
|
+
|
|
19
|
+
1. READ: Complete feedback without reacting
|
|
20
|
+
2. UNDERSTAND: Restate requirement in own words (or ask)
|
|
21
|
+
3. VERIFY: Check against codebase reality
|
|
22
|
+
4. EVALUATE: Technically sound for THIS codebase?
|
|
23
|
+
5. RESPOND: Technical acknowledgment or reasoned pushback
|
|
24
|
+
6. IMPLEMENT: One item at a time, test each
|
|
25
|
+
```
|
|
26
|
+
|
|
27
|
+
## Forbidden Responses
|
|
28
|
+
|
|
29
|
+
**NEVER:**
|
|
30
|
+
- "You're absolutely right!" (explicit `.agent/AGENTS.md` style violation)
|
|
31
|
+
- "Great point!" / "Excellent feedback!" (performative)
|
|
32
|
+
- "Let me implement that now" (before verification)
|
|
33
|
+
|
|
34
|
+
**INSTEAD:**
|
|
35
|
+
- Restate the technical requirement
|
|
36
|
+
- Ask clarifying questions
|
|
37
|
+
- Push back with technical reasoning if wrong
|
|
38
|
+
- Just start working (actions > words)
|
|
39
|
+
|
|
40
|
+
## Handling Unclear Feedback
|
|
41
|
+
|
|
42
|
+
```
|
|
43
|
+
IF any item is unclear:
|
|
44
|
+
STOP - do not implement anything yet
|
|
45
|
+
ASK for clarification on unclear items
|
|
46
|
+
|
|
47
|
+
WHY: Items may be related. Partial understanding = wrong implementation.
|
|
48
|
+
```
|
|
49
|
+
|
|
50
|
+
**Example:**
|
|
51
|
+
```
|
|
52
|
+
your human partner: "Fix 1-6"
|
|
53
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
54
|
+
|
|
55
|
+
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
|
|
56
|
+
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
## Source-Specific Handling
|
|
60
|
+
|
|
61
|
+
### From your human partner
|
|
62
|
+
- **Trusted** - implement after understanding
|
|
63
|
+
- **Still ask** if scope unclear
|
|
64
|
+
- **No performative agreement**
|
|
65
|
+
- **Skip to action** or technical acknowledgment
|
|
66
|
+
|
|
67
|
+
### From External Reviewers
|
|
68
|
+
```
|
|
69
|
+
BEFORE implementing:
|
|
70
|
+
1. Check: Technically correct for THIS codebase?
|
|
71
|
+
2. Check: Breaks existing functionality?
|
|
72
|
+
3. Check: Reason for current implementation?
|
|
73
|
+
4. Check: Works on all platforms/versions?
|
|
74
|
+
5. Check: Does reviewer understand full context?
|
|
75
|
+
|
|
76
|
+
IF suggestion seems wrong:
|
|
77
|
+
Push back with technical reasoning
|
|
78
|
+
|
|
79
|
+
IF can't easily verify:
|
|
80
|
+
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
|
|
81
|
+
|
|
82
|
+
IF conflicts with your human partner's prior decisions:
|
|
83
|
+
Stop and discuss with your human partner first
|
|
84
|
+
```
|
|
85
|
+
|
|
86
|
+
**your human partner's rule:** "External feedback - be skeptical, but check carefully"
|
|
87
|
+
|
|
88
|
+
## YAGNI Check for "Professional" Features
|
|
89
|
+
|
|
90
|
+
```
|
|
91
|
+
IF reviewer suggests "implementing properly":
|
|
92
|
+
grep codebase for actual usage
|
|
93
|
+
|
|
94
|
+
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
|
|
95
|
+
IF used: Then implement properly
|
|
96
|
+
```
|
|
97
|
+
|
|
98
|
+
**your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
|
|
99
|
+
|
|
100
|
+
## Implementation Order
|
|
101
|
+
|
|
102
|
+
```
|
|
103
|
+
FOR multi-item feedback:
|
|
104
|
+
1. Clarify anything unclear FIRST
|
|
105
|
+
2. Then implement in this order:
|
|
106
|
+
- Blocking issues (breaks, security)
|
|
107
|
+
- Simple fixes (typos, imports)
|
|
108
|
+
- Complex fixes (refactoring, logic)
|
|
109
|
+
3. Test each fix individually
|
|
110
|
+
4. Verify no regressions
|
|
111
|
+
```
|
|
112
|
+
|
|
113
|
+
## When To Push Back
|
|
114
|
+
|
|
115
|
+
Push back when:
|
|
116
|
+
- Suggestion breaks existing functionality
|
|
117
|
+
- Reviewer lacks full context
|
|
118
|
+
- Violates YAGNI (unused feature)
|
|
119
|
+
- Technically incorrect for this stack
|
|
120
|
+
- Legacy/compatibility reasons exist
|
|
121
|
+
- Conflicts with your human partner's architectural decisions
|
|
122
|
+
|
|
123
|
+
**How to push back:**
|
|
124
|
+
- Use technical reasoning, not defensiveness
|
|
125
|
+
- Ask specific questions
|
|
126
|
+
- Reference working tests/code
|
|
127
|
+
- Involve your human partner if architectural
|
|
128
|
+
|
|
129
|
+
**Signal if uncomfortable pushing back out loud:** "Strange things are afoot at the Circle K"
|
|
130
|
+
|
|
131
|
+
## Acknowledging Correct Feedback
|
|
132
|
+
|
|
133
|
+
When feedback IS correct:
|
|
134
|
+
```
|
|
135
|
+
✅ "Fixed. [Brief description of what changed]"
|
|
136
|
+
✅ "Good catch - [specific issue]. Fixed in [location]."
|
|
137
|
+
✅ [Just fix it and show in the code]
|
|
138
|
+
|
|
139
|
+
❌ "You're absolutely right!"
|
|
140
|
+
❌ "Great point!"
|
|
141
|
+
❌ "Thanks for catching that!"
|
|
142
|
+
❌ "Thanks for [anything]"
|
|
143
|
+
❌ ANY gratitude expression
|
|
144
|
+
```
|
|
145
|
+
|
|
146
|
+
**Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
|
|
147
|
+
|
|
148
|
+
**If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
|
|
149
|
+
|
|
150
|
+
## Gracefully Correcting Your Pushback
|
|
151
|
+
|
|
152
|
+
If you pushed back and were wrong:
|
|
153
|
+
```
|
|
154
|
+
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
|
|
155
|
+
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
|
|
156
|
+
|
|
157
|
+
❌ Long apology
|
|
158
|
+
❌ Defending why you pushed back
|
|
159
|
+
❌ Over-explaining
|
|
160
|
+
```
|
|
161
|
+
|
|
162
|
+
State the correction factually and move on.
|
|
163
|
+
|
|
164
|
+
## Common Mistakes
|
|
165
|
+
|
|
166
|
+
| Mistake | Fix |
|
|
167
|
+
|---------|-----|
|
|
168
|
+
| Performative agreement | State requirement or just act |
|
|
169
|
+
| Blind implementation | Verify against codebase first |
|
|
170
|
+
| Batch without testing | One at a time, test each |
|
|
171
|
+
| Assuming reviewer is right | Check if breaks things |
|
|
172
|
+
| Avoiding pushback | Technical correctness > comfort |
|
|
173
|
+
| Partial implementation | Clarify all items first |
|
|
174
|
+
| Can't verify, proceed anyway | State limitation, ask for direction |
|
|
175
|
+
|
|
176
|
+
## Real Examples
|
|
177
|
+
|
|
178
|
+
**Performative Agreement (Bad):**
|
|
179
|
+
```
|
|
180
|
+
Reviewer: "Remove legacy code"
|
|
181
|
+
❌ "You're absolutely right! Let me remove that..."
|
|
182
|
+
```
|
|
183
|
+
|
|
184
|
+
**Technical Verification (Good):**
|
|
185
|
+
```
|
|
186
|
+
Reviewer: "Remove legacy code"
|
|
187
|
+
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
|
|
188
|
+
```
|
|
189
|
+
|
|
190
|
+
**YAGNI (Good):**
|
|
191
|
+
```
|
|
192
|
+
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
|
|
193
|
+
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
|
|
194
|
+
```
|
|
195
|
+
|
|
196
|
+
**Unclear Item (Good):**
|
|
197
|
+
```
|
|
198
|
+
your human partner: "Fix items 1-6"
|
|
199
|
+
You understand 1,2,3,6. Unclear on 4,5.
|
|
200
|
+
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
|
|
201
|
+
```
|
|
202
|
+
|
|
203
|
+
## GitHub Thread Replies
|
|
204
|
+
|
|
205
|
+
When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
|
|
206
|
+
|
|
207
|
+
## The Bottom Line
|
|
208
|
+
|
|
209
|
+
**External feedback = suggestions to evaluate, not orders to follow.**
|
|
210
|
+
|
|
211
|
+
Verify. Question. Then implement.
|
|
212
|
+
|
|
213
|
+
No performative agreement. Technical rigor always.
|