@lee-jisoo/n8n-nodes-mediafx 1.6.4 → 1.6.5

package/dist/nodes/MediaFX/operations/addSubtitle.js

@@ -93,7 +93,10 @@ function isASSFile(filePath) {
  * Build force_style string for subtitles filter
  */
 function buildForceStyle(fontName, fontSize, primaryColor, outlineColor, outlineWidth, backColor, enableBackground, alignment, marginV) {
-    const borderStyle = enableBackground ? 4 : 1;
+    // BorderStyle: 1=outline+shadow, 3=opaque box, 4=translucent box (limited support)
+    // For background box, use BorderStyle=3 with BackColour
+    const borderStyle = enableBackground ? 3 : 1;
+    const shadow = enableBackground ? 4 : 0; // Add shadow for box effect
     const styleParams = [
         `FontName=${fontName}`,
         `FontSize=${fontSize}`,
@@ -103,8 +106,8 @@ function buildForceStyle(fontName, fontSize, primaryColor, outlineColor, outline
         `Bold=0`,
         `Italic=0`,
         `BorderStyle=${borderStyle}`,
-        `Outline=${outlineWidth}`,
-        `Shadow=0`,
+        `Outline=${enableBackground ? 0 : outlineWidth}`,
+        `Shadow=${shadow}`,
         `Alignment=${alignment}`,
         `MarginV=${marginV}`,
     ];
@@ -139,27 +142,16 @@ async function executeAddSubtitle(video, subtitleFile, style, itemIndex) {
         paddingY = (_d = style.paddingY) !== null && _d !== void 0 ? _d : 20;
     }
     const alignment = getASSAlignment(horizontalAlign, verticalAlign);
-    // Get video height for accurate MarginV calculation
-    let videoHeight = 1080; // default fallback
-    try {
-        const videoInfo = await (0, utils_1.getVideoStreamInfo)(video);
-        if (videoInfo && videoInfo.height) {
-            videoHeight = videoInfo.height;
-        }
-    }
-    catch (e) {
-        // Use default if ffprobe fails
-        console.warn('Could not get video height, using default 1080');
-    }
-    // Calculate MarginV based on vertical alignment and video height
-    // ASS MarginV is the distance from the alignment edge
-    // For middle alignment, we calculate the margin to center the subtitle
+    // Calculate MarginV based on vertical alignment
+    // For SRT files, middle alignment (4,5,6) doesn't work reliably with force_style
+    // So we use bottom alignment (2) with large MarginV to simulate middle position
     let marginV = paddingY;
+    let effectiveAlignment = alignment;
     if (verticalAlign === 'middle') {
-        // For middle alignment (4,5,6), MarginV pushes from bottom
-        // To center: marginV = (videoHeight / 2) - fontSize - some_offset
-        // Simplified: use ~37% of video height as margin from bottom
-        marginV = Math.round(videoHeight * 0.37);
+        // Use bottom-center alignment but push up with MarginV
+        // For middle position, we want subtitle at ~45% from bottom
+        effectiveAlignment = horizontalAlign === 'left' ? 1 : horizontalAlign === 'right' ? 3 : 2;
+        marginV = 350; // Works for most video heights (720p-1080p)
     }
     else if (verticalAlign === 'top') {
         marginV = paddingY;
@@ -181,7 +173,7 @@ async function executeAddSubtitle(video, subtitleFile, style, itemIndex) {
     }
     else {
         // SRT file: apply force_style
-        const forceStyle = buildForceStyle(fontName, fontSize, primaryColorASS, outlineColorASS, outlineWidth, backColorASS, enableBackground, alignment, marginV);
+        const forceStyle = buildForceStyle(fontName, fontSize, primaryColorASS, outlineColorASS, outlineWidth, backColorASS, enableBackground, effectiveAlignment, marginV);
         subtitlesFilter = `subtitles='${escapedPath}':force_style='${forceStyle}'`;
     }
     const command = ffmpeg(video)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lee-jisoo/n8n-nodes-mediafx",
-  "version": "1.6.4",
+  "version": "1.6.5",
   "description": "N8N custom nodes for video editing and media processing (Enhanced fork with Speed control and Subtitle fixes)",
   "license": "MIT",
   "author": {