@ledgerhq/live-common 34.54.0 → 34.55.0-nightly.20251210114107

package/src/families/stacks/__tests__/sync.integration.test.ts

@@ -16,10 +16,10 @@ describe("sync for token transfers", () => {
   });
 
   test("sync build operations only for transfer type txn", async () => {
-    const rawTxs = await fetchFullTxs(address);
+    const [transfers] = await fetchFullTxs(address);
 
     // Contains operations for txn of type token_transfer
-    const operations = flatMap(rawTxs, mapTxToOps(accountId, address));
+    const operations = flatMap(transfers, mapTxToOps(accountId, address));
 
     expect(operations.length).toBeTruthy();
   });

package/src/families/stacks/constants.ts

@@ -1,2 +1,2 @@
 // Encapsulate for LLD & LLM
-export * from "@ledgerhq/coin-stacks/contants";
+export * from "@ledgerhq/coin-stacks/constants";

package/src/families/stellar/__snapshots__/bridge.integration.test.ts.snap

@@ -16,7 +16,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "311064932",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": true,
     "xpub": "GAT4LBXYJGJJJRSNK74NPFLO55CDDXSYVMQODSEAAH3M6EY4S7LPH5GV",
   },
@@ -31,10 +31,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 43,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "79999759",
+    "spendableBalance": "79999760",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": true,
     "xpub": "GAIXIJBMYPTSF2CDVQ35WOTULCLZIE4W2SDEK3RQGAA3A22BPWY7R53Z",
   },
@@ -49,10 +49,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 38,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "44999261",
+    "spendableBalance": "44999262",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": true,
     "xpub": "GCDDN6T2LJN3T7SPWJQV6BCCL5KNY5GBN7X4CMSZLDEXDHXAH32TOAHS",
   },
@@ -67,10 +67,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 17,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "10145720",
+    "spendableBalance": "10145721",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": true,
     "xpub": "GAHQKL7UW5DSNJXWNA4ASJ6D2I7JYFWVHDFWYJZK3WDR4BUTG27K2PWC",
   },
@@ -88,7 +88,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "0",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": true,
     "xpub": "GBQMOU2WYJUP6AKY53FFKZJGQMDWCMTWSOUTZ5DVIAQPVW7AJUHSX2M5",
   },
@@ -106,7 +106,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "0",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x1431ef5f",
+    "syncHash": "0x8a6ee88a",
     "used": false,
     "xpub": "GAJEKFXY76YWDSKJESDOKS2EGKRMCHSIC5AU32SU7OF54E5VVREUHXLH",
   },

package/src/featureFlags/FeatureToggle.tsx

@@ -9,7 +9,7 @@ type Props = {
   children?: ReactNode;
 };
 
-const FeatureToggle = ({ featureId, fallback, children }: Props): JSX.Element => {
+const FeatureToggle = ({ featureId, fallback, children }: Props): React.JSX.Element => {
   const feature = useFeature(featureId);
 
   if (!feature || !feature.enabled) {

package/src/featureFlags/defaultFeatures.ts

@@ -8,6 +8,7 @@ import {
 import reduce from "lodash/reduce";
 import { BUY_SELL_UI_APP_ID } from "../wallet-api/constants";
 import { formatToFirebaseFeatureId } from "./firebaseFeatureFlags";
+import { DeviceModelId } from "@ledgerhq/types-devices";
 
 /**
  * Default disabled feature.
@@ -109,6 +110,8 @@ export const CURRENCY_DEFAULT_FEATURES = {
   currencyMonadTestnet: DEFAULT_FEATURE,
   currencySomnia: DEFAULT_FEATURE,
   currencyZeroGravity: DEFAULT_FEATURE,
+  currencyConcordium: DEFAULT_FEATURE,
+  currencyConcordiumTestnet: DEFAULT_FEATURE,
 };
 
 /**
@@ -215,6 +218,18 @@ export const DEFAULT_FEATURES: Features = {
       protectId: "protect-simu",
     },
   },
+  recoverUpsellPostOnboarding: {
+    ...DEFAULT_FEATURE,
+    params: {
+      deviceIds: [
+        DeviceModelId.nanoSP,
+        DeviceModelId.nanoX,
+        DeviceModelId.stax,
+        DeviceModelId.europa,
+        DeviceModelId.apex,
+      ],
+    },
+  },
 
   storyly: {
     enabled: false,
@@ -583,6 +598,8 @@ export const DEFAULT_FEATURES: Features = {
       postOnboarding: true,
     },
   },
+  lwmLedgerSyncOptimisation: DEFAULT_FEATURE,
+  lwdLedgerSyncOptimisation: DEFAULT_FEATURE,
   lldNanoSUpsellBanners: {
     ...DEFAULT_FEATURE,
     params: {
@@ -667,8 +684,8 @@ export const DEFAULT_FEATURES: Features = {
       chains: ["ethereum", "polygon", "base", "arbitrum"],
     },
   },
-  ldmkConnectApp: DEFAULT_FEATURE,
   ldmkSolanaSigner: DEFAULT_FEATURE,
+  ldmkConnectApp: DEFAULT_FEATURE,
   lldNetworkBasedAddAccount: DEFAULT_FEATURE,
   llmDatadog: {
     ...DEFAULT_FEATURE,
@@ -718,6 +735,10 @@ export const DEFAULT_FEATURES: Features = {
     },
   },
   zcashShielded: DEFAULT_FEATURE,
+  llmNanoOnboardingFundWallet: DEFAULT_FEATURE,
+  lldRebornABtest: DEFAULT_FEATURE,
+  llmRebornABtest: DEFAULT_FEATURE,
+  lifiSolana: DEFAULT_FEATURE,
 };
 
 // Firebase SDK treat JSON values as strings

package/src/featureFlags/firebaseFeatureFlags.ts

@@ -59,7 +59,7 @@ export const isFeature = (key: string): boolean => {
       return false;
     }
     return true;
-  } catch (error) {
+  } catch {
     console.error(`Failed to check if feature "${key}" exists`);
     return false;
   }

package/src/featureFlags/stakePrograms/index.ts

@@ -44,7 +44,7 @@ export const getBitcoinYieldSetting = (stakePrograms: Feature_StakePrograms | nu
 };
 
 export const getEthDepositScreenSetting = (stakePrograms: Feature_StakePrograms | null): string => {
-  /** Check if Ethereum has "earn" provider configured in redirects with cohort. */
+  /** Check if Ethereum has "earn" provider configured in redirects with ethDepositCohort. */
   const ethereumRedirect = stakePrograms?.enabled
     ? stakePrograms?.params?.redirects?.["ethereum"]
     : undefined;
@@ -55,8 +55,8 @@ export const getEthDepositScreenSetting = (stakePrograms: Feature_StakePrograms
     return "standard";
   }
 
-  // Extract cohort from queryParams
-  const cohort = ethereumRedirect.queryParams?.cohort;
+  // Extract ethDepositCohort from queryParams
+  const ethDepositCohort = ethereumRedirect.queryParams?.ethDepositCohort;
 
-  return cohort ?? "missing_cohort_value";
+  return ethDepositCohort ?? "missing_cohort_value";
 };

package/src/featureFlags/useHasOverriddenFeatureFlags.ts

@@ -15,7 +15,7 @@ export function useHasLocallyOverriddenFeatureFlags(): boolean {
         try {
           const val = getFeature(featureId as FeatureId);
           return val?.overridesRemote || val?.overriddenByEnv;
-        } catch (e) {
+        } catch {
           return false;
         }
       }),

package/src/generated/bridge/js.ts

@@ -6,7 +6,6 @@ import { bridge as casper } from "../../families/casper/setup";
 import { bridge as canton } from "../../families/canton/setup";
 import { bridge as celo } from "../../families/celo/setup";
 import { bridge as cosmos } from "../../families/cosmos/setup";
-import { bridge as evm } from "../../families/evm/setup";
 import { bridge as hedera } from "../../families/hedera/setup";
 import { bridge as filecoin } from "../../families/filecoin/setup";
 import { bridge as internet_computer } from "../../families/internet_computer/setup";
@@ -32,7 +31,6 @@ export default {
   canton,
   celo,
   cosmos,
-  evm,
   hedera,
   filecoin,
   internet_computer,

package/src/helpers/cryptoIconSize.ts

@@ -0,0 +1,25 @@
+// Utility to map any size to valid crypto-icons sizes
+// For React Native (returns numbers)
+export const getValidCryptoIconSizeNative = (size: number): 16 | 20 | 24 | 32 | 40 | 48 | 56 => {
+  if (size <= 16) return 16;
+  if (size <= 20) return 20;
+  if (size <= 24) return 24;
+  if (size <= 32) return 32;
+  if (size <= 40) return 40;
+  if (size <= 48) return 48;
+  return 56;
+};
+
+// Utility to map any size to valid crypto-icons sizes
+// For React/Web (returns strings with "px")
+export const getValidCryptoIconSize = (
+  size: number,
+): "16px" | "20px" | "24px" | "32px" | "40px" | "48px" | "56px" => {
+  if (size <= 16) return "16px";
+  if (size <= 20) return "20px";
+  if (size <= 24) return "24px";
+  if (size <= 32) return "32px";
+  if (size <= 40) return "40px";
+  if (size <= 48) return "48px";
+  return "56px";
+};

package/src/helpers.ts

@@ -15,3 +15,5 @@ export function reverseRecord<T extends PropertyKey, U extends PropertyKey>(
 ): Record<U, T> {
   return Object.fromEntries(Object.entries(input).map(([key, value]) => [value, key]));
 }
+
+export * from "./helpers/cryptoIconSize";

package/src/hooks/__tests__/useHtmlLinkSegments.test.ts

@@ -0,0 +1,105 @@
+import {
+  buildHtmlDisplaySegments,
+  splitHtmlLinkSegments,
+  validateLedgerUrl,
+} from "../useHtmlLinkSegments";
+
+describe("splitHtmlLinkSegments", () => {
+  it("returns an empty array when input is empty", () => {
+    expect(splitHtmlLinkSegments("")).toEqual([]);
+  });
+
+  it("returns only text segments when there are no anchors", () => {
+    const segments = splitHtmlLinkSegments("simple text without links");
+    expect(segments).toEqual([{ type: "text", content: "simple text without links" }]);
+  });
+
+  it("splits text into text and link segments", () => {
+    const segments = splitHtmlLinkSegments('Hello <a href="https://ledger.com">Ledger</a> !');
+
+    expect(segments).toEqual([
+      { type: "text", content: "Hello " },
+      { type: "link", label: "Ledger", href: "https://ledger.com" },
+      { type: "text", content: " !" },
+    ]);
+  });
+
+  it("keeps whitespace-only text segments", () => {
+    const segments = splitHtmlLinkSegments(
+      '<a href="https://ledger.com">Ledger</a> <a href="https://support.ledger.com">Support</a>',
+    );
+
+    expect(segments).toEqual([
+      { type: "link", label: "Ledger", href: "https://ledger.com" },
+      { type: "text", content: " " },
+      { type: "link", label: "Support", href: "https://support.ledger.com" },
+    ]);
+  });
+});
+
+describe("buildHtmlDisplaySegments", () => {
+  it("keeps valid ledger links clickable", () => {
+    const segments = buildHtmlDisplaySegments(
+      'Visit <a href="https://support.ledger.com">support</a> docs',
+    );
+
+    expect(segments).toEqual([
+      { type: "text", content: "Visit " },
+      { type: "link", href: "https://support.ledger.com", label: "support" },
+      { type: "text", content: " docs" },
+    ]);
+  });
+
+  it("falls back to text segments for non-ledger links", () => {
+    const segments = buildHtmlDisplaySegments('Check <a href="https://example.com">here</a>');
+
+    expect(segments).toEqual([
+      { type: "text", content: "Check " },
+      { type: "text", content: "here" },
+    ]);
+  });
+
+  it("ignores invalid protocols", () => {
+    const segments = buildHtmlDisplaySegments('Bad <a href="javascript:alert(1)">click</a>');
+
+    expect(segments).toEqual([
+      { type: "text", content: "Bad " },
+      { type: "text", content: "click" },
+    ]);
+  });
+});
+
+describe("validateLedgerUrl", () => {
+  it("accepts ledger http(s) URLs", () => {
+    expect(validateLedgerUrl("https://ledger.com")).toEqual({
+      isHttp: true,
+      isAllowedLedgerDomain: true,
+    });
+
+    expect(validateLedgerUrl("https://support.ledger.com/hc/en-us")).toEqual({
+      isHttp: true,
+      isAllowedLedgerDomain: true,
+    });
+  });
+
+  it("rejects non-http protocols", () => {
+    expect(validateLedgerUrl("ledgerlive://settings")).toEqual({
+      isHttp: false,
+      isAllowedLedgerDomain: false,
+    });
+  });
+
+  it("rejects non-ledger domains", () => {
+    expect(validateLedgerUrl("https://example.com")).toEqual({
+      isHttp: true,
+      isAllowedLedgerDomain: false,
+    });
+  });
+
+  it("rejects invalid URLs", () => {
+    expect(validateLedgerUrl("not a url")).toEqual({
+      isHttp: false,
+      isAllowedLedgerDomain: false,
+    });
+  });
+});

package/src/hooks/useHtmlLinkSegments.ts

@@ -0,0 +1,158 @@
+import { useMemo } from "react";
+
+export type HtmlLinkSegment =
+  | {
+      type: "text";
+      content: string;
+    }
+  | {
+      type: "link";
+      label: string;
+      href: string;
+    };
+
+const ANCHOR_OPEN_REGEX = /<a\b[^>]*>/gi;
+const HREF_ATTR_REGEX = /href\s*=\s*(?:"([^"]*)"|'([^']*)'|([^\s'">]+))/i;
+const CLOSING_ANCHOR = "</a>";
+
+export const splitHtmlLinkSegments = (input: string): HtmlLinkSegment[] => {
+  const segments: HtmlLinkSegment[] = [];
+
+  if (!input) {
+    return segments;
+  }
+
+  const lowerInput = input.toLowerCase();
+  let cursor = 0;
+  ANCHOR_OPEN_REGEX.lastIndex = 0;
+
+  const extractHrefValue = (tag: string): string | null => {
+    const match = HREF_ATTR_REGEX.exec(tag);
+    if (!match) return null;
+    return match[1] ?? match[2] ?? match[3] ?? null;
+  };
+
+  let match: RegExpExecArray | null;
+  while ((match = ANCHOR_OPEN_REGEX.exec(input)) !== null) {
+    const startIndex = match.index;
+    const tag = match[0];
+    const contentStartIndex = startIndex + tag.length;
+    const closingIndex = lowerInput.indexOf(CLOSING_ANCHOR, contentStartIndex);
+
+    if (closingIndex === -1) {
+      break;
+    }
+
+    if (startIndex > cursor) {
+      const textBefore = input.slice(cursor, startIndex);
+      if (textBefore) {
+        segments.push({
+          type: "text",
+          content: textBefore,
+        });
+      }
+    }
+
+    const href = extractHrefValue(tag);
+    if (href) {
+      const label = input.slice(contentStartIndex, closingIndex);
+      segments.push({
+        type: "link",
+        href,
+        label,
+      });
+    } else {
+      const fallbackText = input.slice(startIndex, closingIndex + CLOSING_ANCHOR.length);
+      segments.push({
+        type: "text",
+        content: fallbackText,
+      });
+    }
+
+    cursor = closingIndex + CLOSING_ANCHOR.length;
+    ANCHOR_OPEN_REGEX.lastIndex = cursor;
+  }
+
+  if (cursor < input.length) {
+    const textAfter = input.slice(cursor);
+    if (textAfter) {
+      segments.push({
+        type: "text",
+        content: textAfter,
+      });
+    }
+  }
+
+  return segments;
+};
+
+export const validateLedgerUrl = (
+  href: string,
+): { isHttp: boolean; isAllowedLedgerDomain: boolean } => {
+  try {
+    const url = new URL(href);
+    const isHttp = url.protocol === "http:" || url.protocol === "https:";
+
+    if (!isHttp) {
+      return {
+        isHttp: false,
+        isAllowedLedgerDomain: false,
+      };
+    }
+
+    const hostname = url.hostname.toLowerCase();
+    const isAllowedLedgerDomain = hostname === "ledger.com" || hostname.endsWith(".ledger.com");
+
+    return {
+      isHttp,
+      isAllowedLedgerDomain,
+    };
+  } catch {
+    return {
+      isHttp: false,
+      isAllowedLedgerDomain: false,
+    };
+  }
+};
+
+export const buildHtmlDisplaySegments = (input: string): HtmlLinkSegment[] => {
+  return splitHtmlLinkSegments(input).map(segment => {
+    if (segment.type === "link") {
+      const { isHttp, isAllowedLedgerDomain } = validateLedgerUrl(segment.href);
+
+      if (isHttp && isAllowedLedgerDomain) {
+        return segment;
+      }
+
+      return {
+        type: "text",
+        content: segment.label,
+      };
+    }
+
+    return segment;
+  });
+};
+
+export const useHtmlLinkSegments = (
+  html?: string | null,
+): {
+  segments: HtmlLinkSegment[];
+  hasLinks: boolean;
+} => {
+  return useMemo(() => {
+    if (!html) {
+      return {
+        segments: [],
+        hasLinks: false,
+      };
+    }
+
+    const segments = buildHtmlDisplaySegments(html);
+
+    return {
+      segments,
+      hasLinks: segments.some(segment => segment.type === "link"),
+    };
+  }, [html]);
+};

package/src/hw/getAppAndVersion.ts

@@ -2,12 +2,13 @@ import { GetAppAndVersionUnsupportedFormat } from "../errors";
 import Transport from "@ledgerhq/hw-transport";
 export default async (
   transport: Transport,
+  { abortTimeoutMs }: { abortTimeoutMs?: number } = {},
 ): Promise<{
   name: string;
   version: string;
   flags: number | Buffer;
 }> => {
-  const r = await transport.send(0xb0, 0x01, 0x00, 0x00);
+  const r = await transport.send(0xb0, 0x01, 0x00, 0x00, undefined, undefined, { abortTimeoutMs });
   let i = 0;
   const format = r[i++];
 

package/src/hw/getBitcoinLikeInfo.ts

@@ -26,7 +26,7 @@ const getBitcoinLikeInfo = (
         message,
         short,
       };
-    } catch (e) {
+    } catch {
       // in such case, we are in an old firmware we no longer support
       return null;
     }

package/src/hw/isFirmwareUpdateVersionSupported.test.ts

@@ -1,22 +1,34 @@
 import { DeviceModelId } from "@ledgerhq/devices";
 import { DeviceInfo } from "@ledgerhq/types-live";
-import isFirmwareUpdateVersionSupported from "./isFirmwareUpdateVersionSupported";
-import { setEnv } from "@ledgerhq/live-env";
+import { isBleUpdateSupported, isUsbUpdateSupported } from "./isFirmwareUpdateVersionSupported";
 
-const goodDataset: { [key in DeviceModelId]?: string[] } = {
+const usbSupportedDataset: { [key in DeviceModelId]?: string[] } = {
   nanoS: ["2.0.0", "3.0.0"],
   nanoX: ["1.3.0", "1.3.0-rc1"],
   nanoSP: ["1.0.0", "1.0.0-0", "1.1.1", "1.4.0", "1.1.0-rc1", "1.1.0-rc2"],
   stax: ["1.0.0", "1.0.0rc2", "2.0.2-il0", "1.0.0-rc4"],
 };
 
-const badDataset: { [key in DeviceModelId]?: string[] } = {
+const usbNotSupportedDataset: { [key in DeviceModelId]?: string[] } = {
   nanoS: ["1.6.0", "1.5.5", "1.5.5-wadus"],
   nanoX: ["1.2.4-5", "1.0.0"],
   nanoSP: ["0.9.9", "0.9.0-rc3"],
   stax: ["0.4.6", "0.0.9-rc.2"],
 };
 
+const bleSupportedDataset: { [key in DeviceModelId]?: string[] } = {
+  nanoX: ["2.4.0", "2.4.0-rc1"],
+  stax: ["0.0.0", "0.0.0-rc1"],
+  europa: ["0.0.0", "0.0.0-rc1"],
+  apex: ["0.0.0", "0.0.0-rc1"],
+};
+
+const bleNotSupportedDataset: { [key in DeviceModelId]?: string[] } = {
+  nanoX: ["2.3.0", "2.3.0-rc1"],
+  nanoSP: ["1.0.0", "1.0.0-rc1"],
+  nanoS: ["1.6.1", "1.6.0"],
+};
+
 describe("Firmware update version availability checks", () => {
   const getDeviceInfo = (version): DeviceInfo => ({
     version,
@@ -31,50 +43,42 @@ describe("Firmware update version availability checks", () => {
     seFlags: Buffer.alloc(0),
   });
 
-  describe("Fails with bad values", () => {
-    beforeEach(() => {
-      setEnv("DISABLE_FW_UPDATE_VERSION_CHECK", false);
-    });
-
-    Object.keys(badDataset).forEach(deviceModelId => {
-      badDataset[deviceModelId].forEach(version => {
+  describe("USB update not supported", () => {
+    Object.keys(usbNotSupportedDataset).forEach(deviceModelId => {
+      usbNotSupportedDataset[deviceModelId].forEach(version => {
         const deviceInfo = getDeviceInfo(version);
         it(`testing ${version} for ${deviceModelId}`, () =>
-          expect(isFirmwareUpdateVersionSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(
-            false,
-          ));
+          expect(isUsbUpdateSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(false));
       });
     });
   });
 
-  describe("Good values should pass", () => {
-    beforeEach(() => {
-      setEnv("DISABLE_FW_UPDATE_VERSION_CHECK", false);
-    });
-
-    Object.keys(goodDataset).forEach(deviceModelId => {
-      goodDataset[deviceModelId].forEach(version => {
+  describe("USB update supported", () => {
+    Object.keys(usbSupportedDataset).forEach(deviceModelId => {
+      usbSupportedDataset[deviceModelId].forEach(version => {
         const deviceInfo = getDeviceInfo(version);
         it(`testing ${version} for ${deviceModelId}`, () =>
-          expect(isFirmwareUpdateVersionSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(
-            true,
-          ));
+          expect(isUsbUpdateSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(true));
       });
     });
   });
 
-  describe("Everything goes if DISABLE_FW_UPDATE_VERSION_CHECK is true", () => {
-    beforeEach(() => {
-      setEnv("DISABLE_FW_UPDATE_VERSION_CHECK", true);
+  describe("BLE update not supported", () => {
+    Object.keys(bleNotSupportedDataset).forEach(deviceModelId => {
+      bleNotSupportedDataset[deviceModelId].forEach(version => {
+        const deviceInfo = getDeviceInfo(version);
+        it(`testing ${version} for ${deviceModelId}`, () =>
+          expect(isBleUpdateSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(false));
+      });
     });
+  });
 
-    Object.keys(badDataset).forEach(deviceModelId => {
-      badDataset[deviceModelId].forEach(version => {
+  describe("BLE update supported", () => {
+    Object.keys(bleSupportedDataset).forEach(deviceModelId => {
+      bleSupportedDataset[deviceModelId].forEach(version => {
         const deviceInfo = getDeviceInfo(version);
         it(`testing ${version} for ${deviceModelId}`, () =>
-          expect(isFirmwareUpdateVersionSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(
-            true,
-          ));
+          expect(isBleUpdateSupported(deviceInfo, deviceModelId as DeviceModelId)).toBe(true));
       });
     });
   });