@ledgerhq/live-common 34.54.0-nightly.20251209023841 → 34.54.0

package/src/families/stacks/__tests__/sync.integration.test.ts

@@ -16,10 +16,10 @@ describe("sync for token transfers", () => {
   });
 
   test("sync build operations only for transfer type txn", async () => {
-    const [transfers] = await fetchFullTxs(address);
+    const rawTxs = await fetchFullTxs(address);
 
     // Contains operations for txn of type token_transfer
-    const operations = flatMap(transfers, mapTxToOps(accountId, address));
+    const operations = flatMap(rawTxs, mapTxToOps(accountId, address));
 
     expect(operations.length).toBeTruthy();
   });

package/src/families/stacks/constants.ts

@@ -1,2 +1,2 @@
 // Encapsulate for LLD & LLM
-export * from "@ledgerhq/coin-stacks/constants";
+export * from "@ledgerhq/coin-stacks/contants";

package/src/families/stellar/__snapshots__/bridge.integration.test.ts.snap

@@ -16,7 +16,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "311064932",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": true,
     "xpub": "GAT4LBXYJGJJJRSNK74NPFLO55CDDXSYVMQODSEAAH3M6EY4S7LPH5GV",
   },
@@ -31,10 +31,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 43,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "79999760",
+    "spendableBalance": "79999759",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": true,
     "xpub": "GAIXIJBMYPTSF2CDVQ35WOTULCLZIE4W2SDEK3RQGAA3A22BPWY7R53Z",
   },
@@ -49,10 +49,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 38,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "44999262",
+    "spendableBalance": "44999261",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": true,
     "xpub": "GCDDN6T2LJN3T7SPWJQV6BCCL5KNY5GBN7X4CMSZLDEXDHXAH32TOAHS",
   },
@@ -67,10 +67,10 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "operationsCount": 17,
     "pendingOperations": [],
     "seedIdentifier": "27c586f8499294c64d57f8d7956eef4431de58ab20e1c88001f6cf131c97d6f3",
-    "spendableBalance": "10145721",
+    "spendableBalance": "10145720",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": true,
     "xpub": "GAHQKL7UW5DSNJXWNA4ASJ6D2I7JYFWVHDFWYJZK3WDR4BUTG27K2PWC",
   },
@@ -88,7 +88,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "0",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": true,
     "xpub": "GBQMOU2WYJUP6AKY53FFKZJGQMDWCMTWSOUTZ5DVIAQPVW7AJUHSX2M5",
   },
@@ -106,7 +106,7 @@ exports[`stellar currency bridge scanAccounts stellar seed 1 1`] = `
     "spendableBalance": "0",
     "subAccounts": [],
     "swapHistory": [],
-    "syncHash": "0x8a6ee88a",
+    "syncHash": "0x1431ef5f",
     "used": false,
     "xpub": "GAJEKFXY76YWDSKJESDOKS2EGKRMCHSIC5AU32SU7OF54E5VVREUHXLH",
   },

package/src/featureFlags/defaultFeatures.ts

@@ -8,7 +8,6 @@ import {
 import reduce from "lodash/reduce";
 import { BUY_SELL_UI_APP_ID } from "../wallet-api/constants";
 import { formatToFirebaseFeatureId } from "./firebaseFeatureFlags";
-import { DeviceModelId } from "@ledgerhq/types-devices";
 
 /**
  * Default disabled feature.
@@ -216,18 +215,6 @@ export const DEFAULT_FEATURES: Features = {
       protectId: "protect-simu",
     },
   },
-  recoverUpsellPostOnboarding: {
-    ...DEFAULT_FEATURE,
-    params: {
-      deviceIds: [
-        DeviceModelId.nanoSP,
-        DeviceModelId.nanoX,
-        DeviceModelId.stax,
-        DeviceModelId.europa,
-        DeviceModelId.apex,
-      ],
-    },
-  },
 
   storyly: {
     enabled: false,
@@ -596,8 +583,6 @@ export const DEFAULT_FEATURES: Features = {
       postOnboarding: true,
     },
   },
-  lwmLedgerSyncOptimisation: DEFAULT_FEATURE,
-  lwdLedgerSyncOptimisation: DEFAULT_FEATURE,
   lldNanoSUpsellBanners: {
     ...DEFAULT_FEATURE,
     params: {
@@ -682,8 +667,8 @@ export const DEFAULT_FEATURES: Features = {
       chains: ["ethereum", "polygon", "base", "arbitrum"],
     },
   },
-  ldmkSolanaSigner: DEFAULT_FEATURE,
   ldmkConnectApp: DEFAULT_FEATURE,
+  ldmkSolanaSigner: DEFAULT_FEATURE,
   lldNetworkBasedAddAccount: DEFAULT_FEATURE,
   llmDatadog: {
     ...DEFAULT_FEATURE,
@@ -733,9 +718,6 @@ export const DEFAULT_FEATURES: Features = {
     },
   },
   zcashShielded: DEFAULT_FEATURE,
-  llmNanoOnboardingFundWallet: DEFAULT_FEATURE,
-  lldRebornABtest: DEFAULT_FEATURE,
-  llmRebornABtest: DEFAULT_FEATURE,
 };
 
 // Firebase SDK treat JSON values as strings

package/src/featureFlags/firebaseFeatureFlags.ts

@@ -59,7 +59,7 @@ export const isFeature = (key: string): boolean => {
       return false;
     }
     return true;
-  } catch {
+  } catch (error) {
     console.error(`Failed to check if feature "${key}" exists`);
     return false;
   }

package/src/featureFlags/stakePrograms/index.ts

@@ -44,7 +44,7 @@ export const getBitcoinYieldSetting = (stakePrograms: Feature_StakePrograms | nu
 };
 
 export const getEthDepositScreenSetting = (stakePrograms: Feature_StakePrograms | null): string => {
-  /** Check if Ethereum has "earn" provider configured in redirects with ethDepositCohort. */
+  /** Check if Ethereum has "earn" provider configured in redirects with cohort. */
   const ethereumRedirect = stakePrograms?.enabled
     ? stakePrograms?.params?.redirects?.["ethereum"]
     : undefined;
@@ -55,8 +55,8 @@ export const getEthDepositScreenSetting = (stakePrograms: Feature_StakePrograms
     return "standard";
   }
 
-  // Extract ethDepositCohort from queryParams
-  const ethDepositCohort = ethereumRedirect.queryParams?.ethDepositCohort;
+  // Extract cohort from queryParams
+  const cohort = ethereumRedirect.queryParams?.cohort;
 
-  return ethDepositCohort ?? "missing_cohort_value";
+  return cohort ?? "missing_cohort_value";
 };

package/src/featureFlags/useHasOverriddenFeatureFlags.ts

@@ -15,7 +15,7 @@ export function useHasLocallyOverriddenFeatureFlags(): boolean {
         try {
           const val = getFeature(featureId as FeatureId);
           return val?.overridesRemote || val?.overriddenByEnv;
-        } catch {
+        } catch (e) {
           return false;
         }
       }),

package/src/generated/bridge/js.ts

@@ -6,6 +6,7 @@ import { bridge as casper } from "../../families/casper/setup";
 import { bridge as canton } from "../../families/canton/setup";
 import { bridge as celo } from "../../families/celo/setup";
 import { bridge as cosmos } from "../../families/cosmos/setup";
+import { bridge as evm } from "../../families/evm/setup";
 import { bridge as hedera } from "../../families/hedera/setup";
 import { bridge as filecoin } from "../../families/filecoin/setup";
 import { bridge as internet_computer } from "../../families/internet_computer/setup";
@@ -31,6 +32,7 @@ export default {
   canton,
   celo,
   cosmos,
+  evm,
   hedera,
   filecoin,
   internet_computer,

package/src/helpers.ts

@@ -15,5 +15,3 @@ export function reverseRecord<T extends PropertyKey, U extends PropertyKey>(
 ): Record<U, T> {
   return Object.fromEntries(Object.entries(input).map(([key, value]) => [value, key]));
 }
-
-export * from "./helpers/cryptoIconSize";

package/src/hw/getAppAndVersion.ts

@@ -2,13 +2,12 @@ import { GetAppAndVersionUnsupportedFormat } from "../errors";
 import Transport from "@ledgerhq/hw-transport";
 export default async (
   transport: Transport,
-  { abortTimeoutMs }: { abortTimeoutMs?: number } = {},
 ): Promise<{
   name: string;
   version: string;
   flags: number | Buffer;
 }> => {
-  const r = await transport.send(0xb0, 0x01, 0x00, 0x00, undefined, undefined, { abortTimeoutMs });
+  const r = await transport.send(0xb0, 0x01, 0x00, 0x00);
   let i = 0;
   const format = r[i++];
 

package/src/hw/getBitcoinLikeInfo.ts

@@ -26,7 +26,7 @@ const getBitcoinLikeInfo = (
         message,
         short,
       };
-    } catch {
+    } catch (e) {
       // in such case, we are in an old firmware we no longer support
       return null;
     }

package/src/load/speculos.ts

@@ -28,7 +28,6 @@ export { closeAllSpeculosDevices, releaseSpeculosDevice, createSpeculosDevice };
 export type { SpeculosTransport };
 
 const modelMapPriority: Record<string, number> = {
-  apex_p: 7,
   flex: 6,
   stax: 5,
   nanos: 4,

package/src/mock/account.ts

@@ -199,7 +199,7 @@ export function genAccount(id: number | string, opts: GenAccountOptions = {}): A
             if (initAccount) {
               initAccount(account);
             }
-          } catch {
+          } catch (e: any) {
             // to fix /src/__tests__/cross.ts, skip bridge error if there is no bridge in such currency
           }
         }

package/src/operation.ts

@@ -5,16 +5,8 @@ import {
   isStuckOperation as isStuckOperationEvm,
   getStuckAccountAndOperation as getStuckAccountAndOperationEvm,
 } from "@ledgerhq/coin-evm/operation";
-import { getCurrencyConfiguration } from "./config";
-import { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
-import { EvmConfigInfo } from "@ledgerhq/coin-evm/config";
 export * from "@ledgerhq/coin-framework/operation";
 
-function hasGasTracker(currency: CryptoCurrency): boolean {
-  const config = getCurrencyConfiguration<EvmConfigInfo>(currency);
-  return !!config.gasTracker;
-}
-
 /**
  * Return weather an operation is editable or not.
  */
@@ -26,7 +18,7 @@ export const isEditableOperation = ({
   operation: Operation;
 }): boolean => {
   if (account.currency.family === "evm") {
-    return isEditableOperationEvm(account, operation, hasGasTracker);
+    return isEditableOperationEvm(account, operation);
   }
 
   return false;
@@ -66,7 +58,7 @@ export const getStuckAccountAndOperation = (
   const mainAccount = getMainAccount(account, parentAccount);
 
   if (mainAccount.currency.family === "evm") {
-    return getStuckAccountAndOperationEvm(account, parentAccount, hasGasTracker);
+    return getStuckAccountAndOperationEvm(account, parentAccount);
   }
 
   return undefined;

package/src/react.tsx

@@ -0,0 +1,43 @@
+import React from "react";
+import type { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
+import * as icons from "@ledgerhq/crypto-icons-ui/react";
+import { inferCryptoCurrencyIcon } from "./currencies/cryptoIcons";
+
+type Icon = React.ComponentType<{
+  size: number;
+  color?: string;
+}>;
+
+const polyfillMappingCache = new WeakMap<Icon, Icon>();
+/**
+ * thin wrapper from the crypto-icons lib to the format expected by ledger-live-common
+ * @deprecated prefer using @ledgerhq/crypto-icons-ui directly + mapping provided by @ledgerhq/live-common/currencies/cryptoIcons
+ */
+function polyfillIconComponent(IconComponent: Icon | null | undefined): Icon | null | undefined {
+  if (!IconComponent) return IconComponent;
+  if (polyfillMappingCache.has(IconComponent)) return polyfillMappingCache.get(IconComponent);
+  const PolyfillIconComponent = (props: { size: number; color?: string }) =>
+    props.color === undefined ? (
+      // in the previous behavior, we were fallbacking on "currentColor"
+      // if you need this behavior, it will be preferrable to explicit set it. as we will drop this polyfill implementation.
+      <IconComponent {...props} color="currentColor" />
+    ) : (
+      <IconComponent {...props} />
+    );
+  polyfillMappingCache.set(IconComponent, PolyfillIconComponent);
+  return PolyfillIconComponent;
+}
+
+/**
+ * @deprecated prefer using @ledgerhq/crypto-icons-ui directly + mapping provided by @ledgerhq/live-common/currencies/cryptoIcons
+ */
+export function getCryptoCurrencyIcon(currency: CryptoCurrency): Icon | null | undefined {
+  return polyfillIconComponent(inferCryptoCurrencyIcon(icons, currency));
+}
+
+/**
+ * @deprecated prefer using @ledgerhq/crypto-icons-ui directly + mapping provided by @ledgerhq/live-common/currencies/cryptoIcons
+ */
+export function getTokenCurrencyIcon(token: TokenCurrency): Icon | null | undefined {
+  return polyfillIconComponent(inferCryptoCurrencyIcon(icons, token));
+}

package/src/reactNative.ts

@@ -0,0 +1,23 @@
+import React from "react";
+import * as icons from "@ledgerhq/crypto-icons-ui/native";
+import type { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
+import { inferCryptoCurrencyIcon } from "./currencies/cryptoIcons";
+
+type Icon = React.ComponentType<{
+  size: number;
+  color: string;
+}>;
+
+/**
+ * @deprecated prefer using @ledgerhq/crypto-icons-ui directly + mapping provided by @ledgerhq/live-common/currencies/cryptoIcons
+ */
+export function getCryptoCurrencyIcon(currency: CryptoCurrency): Icon | null | undefined {
+  return inferCryptoCurrencyIcon(icons, currency);
+}
+
+/**
+ * @deprecated prefer using @ledgerhq/crypto-icons-ui directly + mapping provided by @ledgerhq/live-common/currencies/cryptoIcons
+ */
+export function getTokenCurrencyIcon(token: TokenCurrency): Icon | null | undefined {
+  return inferCryptoCurrencyIcon(icons, token);
+}

package/src/reactNativeSvg.d.ts

@@ -0,0 +1,19 @@
+declare module "react-native-svg" {
+  import * as React from "react";
+
+  export default class Svg extends React.Component<any, any> {}
+  export class Path extends React.Component<any, any> {}
+  export class Rect extends React.Component<any, any> {}
+  export class Text extends React.Component<any, any> {}
+  export class Defs extends React.Component<any, any> {}
+  export class ClipPath extends React.Component<any, any> {}
+  export class G extends React.Component<any, any> {}
+  export class Stop extends React.Component<any, any> {}
+  export class Mask extends React.Component<any, any> {}
+  export class LinearGradient extends React.Component<any, any> {}
+  export class Ellipse extends React.Component<any, any> {}
+  export class Circle extends React.Component<any, any> {}
+  export class Polygon extends React.Component<any, any> {}
+  export class Polyline extends React.Component<any, any> {}
+  export class Line extends React.Component<any, any> {}
+}

package/src/wallet-api/Exchange/server.ts

@@ -53,8 +53,6 @@ import { getSwapStepFromError } from "../../exchange/error";
 import { postSwapCancelled } from "../../exchange/swap";
 import { DeviceModelId } from "@ledgerhq/types-devices";
 import { setBroadcastTransaction } from "../../exchange/swap/setBroadcastTransaction";
-import { Transaction as EvmTransaction } from "@ledgerhq/coin-evm/types/index";
-import { padHexString } from "@ledgerhq/hw-app-eth";
 
 export { ExchangeType };
 
@@ -390,13 +388,11 @@ export const handlers = ({
         customFeeConfig,
         swapAppVersion,
         sponsored,
-        isEmbedded,
       } = params;
 
       const trackingParams = {
         provider: params.provider,
         exchangeType: params.exchangeType,
-        isEmbeddedSwap: isEmbedded,
       };
 
       tracking.startExchangeRequested(trackingParams);
@@ -474,7 +470,6 @@ export const handlers = ({
       const trackingCompleteParams = {
         provider: params.provider,
         exchangeType: params.exchangeType,
-        isEmbeddedSwap: isEmbedded,
       };
       tracking.completeExchangeRequested(trackingCompleteParams);
 
@@ -604,9 +599,6 @@ export const handlers = ({
               fromAmount,
               seedIdFrom: mainFromAccount.seedIdentifier,
               seedIdTo: toParentAccount?.seedIdentifier || (toAccount as Account)?.seedIdentifier,
-              data: (transaction as EvmTransaction).data
-                ? `0x${padHexString((transaction as EvmTransaction).data?.toString("hex") || "")}`
-                : "0x",
             });
 
             reject(error);

package/src/wallet-api/Exchange/tracking.ts

@@ -14,15 +14,8 @@ type TrackExchange = (
 interface TrackEventPayload {
   exchangeType: "SELL" | "FUND" | "SWAP";
   provider: string;
-  isEmbeddedSwap?: boolean;
 }
 
-/**
- * Converts isEmbeddedSwap boolean to string for analytics consistency
- */
-const formatIsEmbeddedSwap = (isEmbeddedSwap?: boolean): string | undefined =>
-  isEmbeddedSwap !== undefined ? String(isEmbeddedSwap) : undefined;
-
 function getEventData(manifest: AppManifest) {
   return { walletAPI: manifest.name };
 }
@@ -36,46 +29,24 @@ function getEventData(manifest: AppManifest) {
 // in order to get the exact type matching the tracking wrapper API
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export default function trackingWrapper(trackCall: TrackExchange) {
-  const track = (event: string, properties: Record<string, string | undefined> | null) => {
-    // Filter out undefined values before passing to trackCall
-    if (!properties) {
-      return trackCall(event, null, null);
-    }
-    const filteredProperties: Record<string, string> = {};
-    for (const [key, value] of Object.entries(properties)) {
-      if (value !== undefined) {
-        filteredProperties[key] = value;
-      }
-    }
-    return trackCall(event, filteredProperties, null);
+  const track = (event: string, properties: Record<string, string> | null) => {
+    return trackCall(event, properties, null);
   };
 
   return {
     // Generate Exchange nonce modal open
-    startExchangeRequested: ({ provider, exchangeType, isEmbeddedSwap }: TrackEventPayload) => {
-      track(`Starts Exchange ${exchangeType} Nonce request`, {
-        provider,
-        exchangeType,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+    startExchangeRequested: ({ provider, exchangeType }: TrackEventPayload) => {
+      track(`Starts Exchange ${exchangeType} Nonce request`, { provider, exchangeType });
     },
 
     // Successfully generated an Exchange app nonce
-    startExchangeSuccess: ({ provider, exchangeType, isEmbeddedSwap }: TrackEventPayload) => {
-      track(`Starts Exchange ${exchangeType} Nonce success`, {
-        provider,
-        exchangeType,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+    startExchangeSuccess: ({ provider, exchangeType }: TrackEventPayload) => {
+      track(`Starts Exchange ${exchangeType} Nonce success`, { provider, exchangeType });
     },
 
     // Failed to generate an Exchange app nonce
-    startExchangeFail: ({ provider, exchangeType, isEmbeddedSwap }: TrackEventPayload) => {
-      track(`Starts Exchange ${exchangeType} Nonce fail`, {
-        provider,
-        exchangeType,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+    startExchangeFail: ({ provider, exchangeType }: TrackEventPayload) => {
+      track(`Starts Exchange ${exchangeType} Nonce fail`, { provider, exchangeType });
     },
 
     // No Params to generate an Exchange app nonce
@@ -83,12 +54,8 @@ export default function trackingWrapper(trackCall: TrackExchange) {
       track("Starts Exchange no params", getEventData(manifest));
     },
 
-    completeExchangeRequested: ({ provider, exchangeType, isEmbeddedSwap }: TrackEventPayload) => {
-      track(`Completes Exchange ${exchangeType} requested`, {
-        provider,
-        exchangeType,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+    completeExchangeRequested: ({ provider, exchangeType }: TrackEventPayload) => {
+      track(`Completes Exchange ${exchangeType} requested`, { provider, exchangeType });
     },
 
     // Successfully completed an Exchange
@@ -96,23 +63,13 @@ export default function trackingWrapper(trackCall: TrackExchange) {
       provider,
       exchangeType,
       currency,
-      isEmbeddedSwap,
     }: TrackEventPayload & { currency: string }) => {
-      track(`Completes Exchange ${exchangeType} success`, {
-        provider,
-        exchangeType,
-        currency,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+      track(`Completes Exchange ${exchangeType} success`, { provider, exchangeType, currency });
     },
 
     // Failed to complete an Exchange
-    completeExchangeFail: ({ provider, exchangeType, isEmbeddedSwap }: TrackEventPayload) => {
-      track(`Completes Exchange ${exchangeType} Nonce fail`, {
-        provider,
-        exchangeType,
-        isEmbeddedSwap: formatIsEmbeddedSwap(isEmbeddedSwap),
-      });
+    completeExchangeFail: ({ provider, exchangeType }: TrackEventPayload) => {
+      track(`Completes Exchange ${exchangeType} Nonce fail`, { provider, exchangeType });
     },
 
     // No Params to complete an Exchange

package/src/wallet-api/logic.ts

@@ -88,25 +88,24 @@ export async function signTransactionLogic(
     },
   ) => Promise<SignedOperation>,
   tokenCurrency?: string,
-  isEmbeddedSwap?: boolean,
 ): Promise<SignedOperation> {
-  tracking.signTransactionRequested(manifest, isEmbeddedSwap);
+  tracking.signTransactionRequested(manifest);
 
   if (!transaction) {
-    tracking.signTransactionFail(manifest, isEmbeddedSwap);
+    tracking.signTransactionFail(manifest);
     throw new Error("Transaction required");
   }
 
   const accountId = getAccountIdFromWalletAccountId(walletAccountId);
   if (!accountId) {
-    tracking.signTransactionFail(manifest, isEmbeddedSwap);
+    tracking.signTransactionFail(manifest);
     throw new Error(`accountId ${walletAccountId} unknown`);
   }
 
   const account = accounts.find(account => account.id === accountId);
 
   if (!account) {
-    tracking.signTransactionFail(manifest, isEmbeddedSwap);
+    tracking.signTransactionFail(manifest);
     throw new Error("Account required");
   }
 

package/src/wallet-api/react.ts

@@ -806,12 +806,8 @@ export function useWalletAPIServer({
 
     server.setHandler(
       "transaction.signAndBroadcast",
-      async ({ accountId, tokenCurrency, transaction, options, meta }) => {
+      async ({ accountId, tokenCurrency, transaction, options }) => {
         const sponsored = transaction.family === "ethereum" && transaction.sponsored;
-        // isEmbedded is passed via meta (not transaction) as it's a tracking param, not a tx property
-        const isEmbeddedSwap =
-          transaction.family === "ethereum" &&
-          (meta as { isEmbedded?: boolean } | undefined)?.isEmbedded;
 
         const signedTransaction = await signTransactionLogic(
           { manifest, accounts, tracking },
@@ -828,19 +824,18 @@ export function useWalletAPIServer({
                 onSuccess: signedOperation => {
                   if (done) return;
                   done = true;
-                  tracking.signTransactionSuccess(manifest, isEmbeddedSwap);
+                  tracking.signTransactionSuccess(manifest);
                   resolve(signedOperation);
                 },
                 onError: error => {
                   if (done) return;
                   done = true;
-                  tracking.signTransactionFail(manifest, isEmbeddedSwap);
+                  tracking.signTransactionFail(manifest);
                   reject(error);
                 },
               });
             }),
           tokenCurrency,
-          isEmbeddedSwap,
         );
 
         return broadcastTransactionLogic(
@@ -863,9 +858,9 @@ export function useWalletAPIServer({
                     sponsored,
                   },
                 });
-                tracking.broadcastSuccess(manifest, isEmbeddedSwap);
+                tracking.broadcastSuccess(manifest);
               } catch (error) {
-                tracking.broadcastFail(manifest, isEmbeddedSwap);
+                tracking.broadcastFail(manifest);
                 throw error;
               }
             }