@ledgerhq/live-common 34.53.0 → 34.54.0-nightly.20251126023856

package/src/__tests__/accounts/groupPerDay.ts

@@ -2,8 +2,7 @@ import flatMap from "lodash/flatMap";
 import { fromAccountRaw, groupAccountOperationsByDay } from "../../account";
 import { TezosAccountRaw } from "../../families/tezos/types";
 import { setSupportedCurrencies } from "../../currencies";
-import type { CryptoAssetsStore } from "@ledgerhq/types-live";
-import { setup } from "../../bridge/impl";
+import { setupMockCryptoAssetsStore } from "@ledgerhq/cryptoassets/cal-client/test-helpers";
 import { LiveConfig } from "@ledgerhq/live-config/LiveConfig";
 setSupportedCurrencies(["tezos"]);
 
@@ -14,8 +13,7 @@ LiveConfig.setConfig({
   },
 });
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-setup({} as CryptoAssetsStore);
+setupMockCryptoAssetsStore();
 
 let account: Awaited<ReturnType<typeof fromAccountRaw>>;
 

package/src/__tests__/csvExport.ts

@@ -5,10 +5,10 @@ import { getCryptoCurrencyById } from "../currencies";
 import { accountsOpToCSV } from "../csvExport";
 import { initialState, loadCountervalues } from "@ledgerhq/live-countervalues/logic";
 import { getFiatCurrencyByTicker, setSupportedCurrencies } from "../currencies";
-import { initializeLegacyTokens } from "@ledgerhq/cryptoassets/legacy/legacy-data";
-import { addTokens } from "@ledgerhq/cryptoassets/legacy/legacy-utils";
+import { setupMockCryptoAssetsStore } from "@ledgerhq/cryptoassets/cal-client/test-helpers";
 
-initializeLegacyTokens(addTokens);
+// Setup mock store for unit tests
+setupMockCryptoAssetsStore();
 setSupportedCurrencies(["ethereum", "ripple"]);
 setEnv("MOCK", "1");
 setEnv("MOCK_COUNTERVALUES", "1");

package/src/__tests__/currencies.ts

@@ -1,6 +1,5 @@
 import { BigNumber } from "bignumber.js";
 import {
-  listTokens,
   getCryptoCurrencyById,
   getFiatCurrencyByTicker,
   formatCurrencyUnit,
@@ -10,43 +9,6 @@ import {
   encodeURIScheme,
   sanitizeValueString,
 } from "../currencies";
-import { byContractAddressAndChainId } from "@ledgerhq/hw-app-eth/erc20";
-
-/*
-  skipped because ledgerjs data is now lighter (from the POV of hw-app-eth)
-  (using cryptoassets-evm-signatures instead of cryptoassets)
-*/
-test.skip("erc20 are all consistent with those on ledgerjs side", () => {
-  const normalList = listTokens();
-  const delistedList = listTokens({
-    withDelisted: true,
-  });
-  expect(delistedList.length).toBeGreaterThan(normalList.length);
-
-  for (const token of delistedList) {
-    if (token.delisted) {
-      expect(normalList.find(o => o.id === token.id)).toBeUndefined();
-    }
-
-    if (token.tokenType === "erc20") {
-      if (token.parentCurrency.family === "filecoin") {
-        continue;
-      }
-      const tokenData = byContractAddressAndChainId(
-        token.contractAddress,
-        token.parentCurrency.ethereumLikeInfo?.chainId || 0,
-      );
-
-      if (!tokenData) {
-        throw new Error(token.name + " not available in ledgerjs data");
-      }
-
-      expect(token.ticker.toLowerCase()).toBe(tokenData.ticker.toLowerCase());
-      expect(token.contractAddress.toLowerCase()).toBe(tokenData.contractAddress.toLowerCase());
-      expect(token.units[0].magnitude).toBe(tokenData.decimals);
-    }
-  }
-});
 
 test("can format a currency unit", () => {
   const btc = getCryptoCurrencyById("bitcoin").units[0];
@@ -320,6 +282,11 @@ test("decodeURIScheme", () => {
     amount: new BigNumber(0.0647).times(10 ** 18),
     gasPrice: new BigNumber(77000000000),
   });
+  expect(
+    decodeURIScheme("ldg::1220691e945dc1b210f3b6be9fbad73efaf642bfb96022552f66c9e2b83b00cb20e8"),
+  ).toMatchObject({
+    address: "ldg::1220691e945dc1b210f3b6be9fbad73efaf642bfb96022552f66c9e2b83b00cb20e8",
+  });
 });
 test("sanitizeValueString", () => {
   const bitcoin = getCryptoCurrencyById("bitcoin");

package/src/__tests__/migration/account-migration.ts

@@ -101,6 +101,9 @@ setSupportedCurrencies([
   "ton",
   "mina",
   "monad",
+  "monad_testnet",
+  "somnia",
+  "zero_gravity",
 ]);
 
 LiveConfig.setConfig(liveConfig);

package/src/__tests__/test-helpers/bridge.ts

@@ -468,7 +468,6 @@ export function testBridge<T extends TransactionCommon>(data: DatasetTest<T>): v
               };
               const bridge = await getBridge();
               const synced = await syncAccount(bridge, copy);
-              if (initialAccountId.includes("ripple")) return; // ripple wont work because of the current implementation of pagination
               expect(synced.operations.length).toBe(account.operations.length);
               // same ops are restored
               expect(synced.operations).toEqual(account.operations);
@@ -481,7 +480,6 @@ export function testBridge<T extends TransactionCommon>(data: DatasetTest<T>): v
             });
             makeTest("pendingOperations are cleaned up", async () => {
               const account = await getSynced();
-              if (initialAccountId.includes("ripple")) return; // ripple wont work because of the current implementation of pagination
 
               if (account.operations.length) {
                 const operations = account.operations.slice(1);

package/src/__tests__/test-helpers/environment.ts

@@ -124,6 +124,9 @@ setSupportedCurrencies([
   "canton_network_testnet",
   "kaspa",
   "monad",
+  "monad_testnet",
+  "somnia",
+  "zero_gravity",
 ]);
 LiveConfig.setConfig(liveConfig);
 

package/src/__tests__/test-helpers/setup.integration.ts

@@ -0,0 +1,17 @@
+import { setupCalClientStore } from "../../test-helpers/cryptoAssetsStore";
+import "./environment";
+import BigNumber from "bignumber.js";
+
+// Integration tests use the real CAL API
+setupCalClientStore();
+
+jest.setTimeout(360000);
+
+expect.extend({
+  toBeBigNumber(value) {
+    const pass = BigNumber.isBigNumber(value);
+    const message = pass ? () => `${value} is a BigNumber` : () => `${value} is not a BigNumber`;
+
+    return { message, pass };
+  },
+});

package/src/__tests__/test-helpers/setup.ts

@@ -1,11 +1,9 @@
-import { setCryptoAssetsStore as setCryptoAssetsStoreForCoinFramework } from "@ledgerhq/coin-framework/crypto-assets/index";
-import { legacyCryptoAssetsStore } from "@ledgerhq/cryptoassets/legacy/legacy-store";
-import { initializeLegacyTokens } from "@ledgerhq/cryptoassets/legacy/legacy-data";
-import { addTokens } from "@ledgerhq/cryptoassets/legacy/legacy-utils";
+import { setupMockCryptoAssetsStore } from "../../test-helpers/cryptoAssetsStore";
 import "./environment";
 import BigNumber from "bignumber.js";
 
-initializeLegacyTokens(addTokens);
+// Unit tests use mock store
+setupMockCryptoAssetsStore();
 
 jest.setTimeout(360000);
 
@@ -17,6 +15,3 @@ expect.extend({
     return { message, pass };
   },
 });
-
-// Use legacyCryptoAssetsStore for integration tests so tokens can be found
-setCryptoAssetsStoreForCoinFramework(legacyCryptoAssetsStore);

package/src/account/helpers.test.ts

@@ -1,8 +1,8 @@
 import { loadBlacklistedTokenSections } from "./helpers";
-import { getCryptoAssetsStore } from "../bridge/crypto-assets/index";
+import { getCryptoAssetsStore } from "@ledgerhq/cryptoassets/state";
 import type { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
 
-jest.mock("../bridge/crypto-assets/index");
+jest.mock("@ledgerhq/cryptoassets/state");
 
 const mockGetCryptoAssetsStore = getCryptoAssetsStore as jest.MockedFunction<
   typeof getCryptoAssetsStore

package/src/account/helpers.ts

@@ -12,10 +12,11 @@ import {
   type TronAccount,
 } from "@ledgerhq/coin-tron/index";
 import { isAccountEmpty as isVechainAccountEmpty } from "@ledgerhq/coin-vechain/index";
+import { isAccountEmpty as isCantonAccountEmpty } from "@ledgerhq/coin-canton";
 import type { Account, AccountLike } from "@ledgerhq/types-live";
 import { isAccountDelegating } from "../families/tezos/staking";
 import type { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
-import { getCryptoAssetsStore } from "../bridge/crypto-assets/index";
+import { getCryptoAssetsStore } from "@ledgerhq/cryptoassets/state";
 
 // TODO: remove this export and prefer import from root file.
 export {
@@ -46,6 +47,9 @@ export const isAccountEmpty = (a: AccountLike): boolean => {
     if (a.currency.family == "vechain") {
       return isVechainAccountEmpty(a);
     }
+    if (a.currency.family == "canton") {
+      return isCantonAccountEmpty(a);
+    }
   }
 
   return commonIsAccountEmpty(a);

package/src/account/serialization.test.ts

@@ -3,7 +3,7 @@ import { genAccount, genTokenAccount } from "@ledgerhq/coin-framework/mocks/acco
 import { toAccountRaw, fromAccountRaw } from "./serialization";
 import { setWalletAPIVersion } from "../wallet-api/version";
 import { WALLET_API_VERSION } from "../wallet-api/constants";
-import { setCryptoAssetsStore as setCryptoAssetsStoreForCoinFramework } from "@ledgerhq/coin-framework/crypto-assets/index";
+import { setCryptoAssetsStore } from "@ledgerhq/cryptoassets/state";
 import type { CryptoAssetsStore } from "@ledgerhq/types-live";
 import solanaSplTokenData from "../__fixtures__/solana-spl-epjfwdd5aufqssqem2qn1xzybapc8g4weggkzwytdt1v.json";
 import { TokenCurrency } from "@ledgerhq/types-cryptoassets";
@@ -17,7 +17,7 @@ const Solana = getCryptoCurrencyById("solana");
 const USDC = solanaSplTokenData as TokenCurrency;
 
 // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-setCryptoAssetsStoreForCoinFramework({
+setCryptoAssetsStore({
   findTokenById: async (id: string) => {
     if (id === "solana/spl/epjfwdd5aufqssqem2qn1xzybapc8g4weggkzwytdt1v") {
       return USDC;

package/src/bridge/crypto-assets/index.test.ts

@@ -1,54 +1,19 @@
-import { LiveConfig } from "@ledgerhq/live-config/LiveConfig";
-import { getCryptoAssetsStore, setCryptoAssetsStore } from ".";
-import { legacyCryptoAssetsStore } from "@ledgerhq/cryptoassets/legacy/legacy-store";
+import { getCryptoAssetsStore, setCryptoAssetsStore } from "@ledgerhq/cryptoassets/state";
 import type { CryptoAssetsStore } from "@ledgerhq/types-live";
+import { setupMockCryptoAssetsStore } from "@ledgerhq/cryptoassets/cal-client/test-helpers";
 
 describe("Testing CryptoAssetStore", () => {
-  it("should return the default methods from cryptoassets libs when feature flag does not exists", () => {
-    LiveConfig.setConfig({
-      some_other_feature: {
-        type: "boolean",
-        default: true,
-      },
-    });
-
-    const store = getCryptoAssetsStore();
-    expect(store).toBe(legacyCryptoAssetsStore);
-  });
-
-  it("should return the default methods from cryptoassets libs when feature flag is disabled", () => {
-    LiveConfig.setConfig({
-      feature_cal_lazy_loading: {
-        type: "boolean",
-        default: false,
-      },
-    });
-
-    const store = getCryptoAssetsStore();
-    expect(store).toBe(legacyCryptoAssetsStore);
+  beforeEach(() => {
+    // Reset the store before each test
+    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
+    setCryptoAssetsStore(undefined as unknown as CryptoAssetsStore);
   });
 
-  it("should throw an error when no store is set and feature flag is enabled", () => {
-    LiveConfig.setConfig({
-      feature_cal_lazy_loading: {
-        type: "boolean",
-        default: true,
-      },
-    });
-
-    expect(() => getCryptoAssetsStore()).toThrow(
-      "CryptoAssetsStore is not set. Please call setCryptoAssetsStore first.",
-    );
+  it("should throw an error when no store is set", () => {
+    expect(() => getCryptoAssetsStore()).toThrow("CryptoAssetsStore is not set");
   });
 
-  it("should throw return the new store when feature flag is enabled", () => {
-    LiveConfig.setConfig({
-      feature_cal_lazy_loading: {
-        type: "boolean",
-        default: true,
-      },
-    });
-
+  it("should return the store when it is set", () => {
     // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
     const newStore = {} as unknown as CryptoAssetsStore;
     setCryptoAssetsStore(newStore);
@@ -56,4 +21,10 @@ describe("Testing CryptoAssetStore", () => {
     const store = getCryptoAssetsStore();
     expect(store).toBe(newStore);
   });
+
+  it("should work with mock store", () => {
+    const mockStore = setupMockCryptoAssetsStore();
+    const store = getCryptoAssetsStore();
+    expect(store).toBe(mockStore);
+  });
 });

package/src/bridge/generic-alpaca/getAccountShape.ts

@@ -1,4 +1,4 @@
-import { encodeAccountId } from "@ledgerhq/coin-framework/account/index";
+import { encodeAccountId, getSyncHash } from "@ledgerhq/coin-framework/account/index";
 import { GetAccountShape, mergeOps } from "@ledgerhq/coin-framework/bridge/jsHelpers";
 import { encodeOperationId } from "@ledgerhq/coin-framework/operation";
 import BigNumber from "bignumber.js";
@@ -8,6 +8,7 @@ import { inferSubOperations } from "@ledgerhq/coin-framework/serialization";
 import { buildSubAccounts, mergeSubAccounts } from "./buildSubAccounts";
 import type { Operation, Pagination } from "@ledgerhq/coin-framework/api/types";
 import type { OperationCommon } from "./types";
+import type { Account } from "@ledgerhq/types-live";
 
 function isNftCoreOp(operation: Operation): boolean {
   return (
@@ -52,14 +53,13 @@ export function genericGetAccountShape(network: string, kind: string): GetAccoun
         : { ...op, accountId, id: encodeOperationId(accountId, op.hash, op.type) },
     );
     const lastPagingToken = oldOps[0]?.extra?.pagingToken || "";
+    const syncHash = await getSyncHash(currency.id, syncConfig.blacklistedTokenIds);
+    const syncFromScratch = !initialAccount?.blockHeight || initialAccount?.syncHash !== syncHash;
 
     // Calculate minHeight for pagination
-    let minHeight: number = 0;
-    if (oldOps.length > 0 && initialAccount?.blockHeight !== 0) {
-      minHeight = (oldOps[0].blockHeight ?? 0) + 1;
-    }
+    const minHeight = syncFromScratch ? 0 : (oldOps[0]?.blockHeight ?? 0) + 1;
     const paginationParams: Pagination = { minHeight, order: "asc" };
-    if (lastPagingToken) {
+    if (lastPagingToken && !syncFromScratch) {
       paginationParams.lastPagingToken = lastPagingToken;
     }
 
@@ -81,7 +81,9 @@ export function genericGetAccountShape(network: string, kind: string): GetAccoun
       operations: newAssetOperations,
       getTokenFromAsset: alpacaApi.getTokenFromAsset,
     });
-    const subAccounts = mergeSubAccounts(initialAccount?.subAccounts ?? [], newSubAccounts);
+    const subAccounts = syncFromScratch
+      ? newSubAccounts
+      : mergeSubAccounts(initialAccount?.subAccounts ?? [], newSubAccounts);
 
     const newOpsWithSubs = newOps.map(op => {
       const subOperations = inferSubOperations(op.hash, newSubAccounts);
@@ -95,12 +97,12 @@ export function genericGetAccountShape(network: string, kind: string): GetAccoun
       alpacaApi.refreshOperations && initialAccount?.pendingOperations.length
         ? await alpacaApi.refreshOperations(initialAccount.pendingOperations)
         : [];
-    const operations = mergeOps(oldOps, [
-      ...confirmedOperations,
-      ...newOpsWithSubs,
-    ]) as OperationCommon[];
+    const newOperations = [...confirmedOperations, ...newOpsWithSubs];
+    const operations = syncFromScratch
+      ? newOperations
+      : (mergeOps(oldOps, newOperations) as OperationCommon[]);
 
-    const res = {
+    const res: Partial<Account> = {
       id: accountId,
       xpub: address,
       blockHeight: operations.length === 0 ? 0 : blockInfo.height || initialAccount?.blockHeight,
@@ -109,6 +111,7 @@ export function genericGetAccountShape(network: string, kind: string): GetAccoun
       operations,
       subAccounts,
       operationsCount: operations.length,
+      syncHash,
     };
     return res;
   };

package/src/bridge/generic-alpaca/tests/getAccountShape.test.ts

@@ -1,8 +1,10 @@
 import BigNumber from "bignumber.js";
 import { genericGetAccountShape } from "../getAccountShape";
 
+const getSyncHashMock = jest.fn();
 jest.mock("@ledgerhq/coin-framework/account/index", () => ({
   encodeAccountId: jest.fn(() => "accId"),
+  getSyncHash: (...args: any[]) => getSyncHashMock(...args),
 }));
 
 const mergeOpsMock = jest.fn();
@@ -63,105 +65,16 @@ describe("genericGetAccountShape", () => {
   });
 
   describe.each(chains)("$currency.id", ({ currency, network }) => {
-    test("builds account shape with existing operations, pagination and sub accounts", async () => {
-      const oldOp = {
-        hash: "h1",
-        blockHeight: 10,
-        type: "OPT_IN",
-        extra: { pagingToken: "pt1", assetReference: "ar1", assetOwner: "ow1" },
-      };
-      const pendingOp = {
-        hash: "h0",
-        blockHeight: 10,
-        type: "OUT",
-      };
-      const initialAccount = {
-        operations: [oldOp],
-        pendingOperations: [pendingOp],
-        blockHeight: 10,
-      };
-
-      extractBalanceMock.mockReturnValue({ value: "1000", locked: "300" });
-      getBalanceMock.mockResolvedValue([
-        { asset: { type: "native" }, value: "1000", locked: "300" },
-        { asset: { type: "token", symbol: "TOK1" }, value: "42" },
-        { asset: { type: "token", symbol: "TOK_IGNORE" }, value: "5" },
-      ]);
-
-      getTokenFromAssetMock.mockImplementation(asset =>
-        asset.symbol === "TOK1" ? { id: `${currency.id}_token1` } : null,
-      );
-
-      const coreOp = { hash: "h2", height: 12 };
-      listOperationsMock.mockResolvedValue([[coreOp]]);
-      refreshOperationsMock.mockImplementation(ops => {
-        const op = ops[0];
-        if (op?.hash === "h0") {
-          return [{ ...op, blockHeight: 12 }];
-        }
-        return [];
-      });
-
-      adaptCoreOperationToLiveOperationMock.mockImplementation((_accId, op) => ({
-        hash: op.hash,
-        type: "IN",
-        blockHeight: 12,
-        extra: { assetReference: "ar2", assetOwner: "ow2" },
-      }));
-
-      mergeOpsMock.mockImplementation((oldOps, newOps) => [...newOps, ...oldOps]);
-      cleanedOperationMock.mockImplementation(operation => operation);
-      mergeSubAccountsMock.mockImplementation((oldSubAccounts, newSubAccounts) => [
-        ...newSubAccounts,
-        ...oldSubAccounts,
-      ]);
-
-      buildSubAccountsMock.mockReturnValue([
-        { id: `${currency.id}_subAcc1`, type: "TokenAccount" },
-      ]);
-
-      inferSubOperationsMock.mockImplementation(hash =>
-        hash === "h2" ? [{ id: `${currency.id}_subOp1` }] : [],
-      );
-
-      lastBlockMock.mockResolvedValue({ height: 123 });
-
-      const getShape = genericGetAccountShape(network, currency.id);
-      const result = await getShape(
+    test.each([
+      [
+        "an up-to-date sync hash",
+        "sync-hash",
         {
-          address: `${currency.id}_addr1`,
-          initialAccount,
-          currency,
-          derivationMode: "",
-        } as any,
-        { paginationConfig: {} as any },
-      );
-
-      expect(chainSpecificGetAccountShapeMock).toHaveBeenCalledWith(`${currency.id}_addr1`);
-
-      expect(listOperationsMock).toHaveBeenCalledWith(`${currency.id}_addr1`, {
-        minHeight: 11,
-        order: "asc",
-        lastPagingToken: "pt1",
-      });
-
-      const assetsBalancePassed = buildSubAccountsMock.mock.calls[0][0].allTokenAssetsBalances;
-      expect(assetsBalancePassed).toEqual([
-        { asset: { symbol: "TOK1", type: "token" }, value: "42" },
-        { asset: { symbol: "TOK_IGNORE", type: "token" }, value: "5" },
-      ]);
-
-      const assetOpsPassed = buildSubAccountsMock.mock.calls[0][0].operations;
-      expect(assetOpsPassed).toHaveLength(1);
-      expect(assetOpsPassed[0].hash).toBe("h2");
-
-      expect(result).toMatchObject({
-        balance: new BigNumber(1000),
-        spendableBalance: new BigNumber(700),
-        blockHeight: 123,
-        operationsCount: 3,
-        subAccounts: [{ id: `${currency.id}_subAcc1`, type: "TokenAccount" }],
-        operations: [
+          minHeight: 11,
+          order: "asc",
+          lastPagingToken: "pt1",
+        },
+        [
           {
             hash: "h0",
             type: "OUT",
@@ -174,10 +87,138 @@ describe("genericGetAccountShape", () => {
             subOperations: [{ id: `${currency.id}_subOp1` }],
             extra: { assetReference: "ar2", assetOwner: "ow2" },
           },
-          oldOp,
+          {
+            hash: "h1",
+            blockHeight: 10,
+            type: "OPT_IN",
+            extra: { pagingToken: "pt1", assetReference: "ar1", assetOwner: "ow1" },
+          },
         ],
-      });
-    });
+      ],
+      [
+        "an outdated sync hash",
+        "outdated-sync-hash",
+        {
+          minHeight: 0,
+          order: "asc",
+        },
+        [
+          {
+            hash: "h0",
+            type: "OUT",
+            blockHeight: 12,
+          },
+          {
+            hash: "h2",
+            type: "IN",
+            blockHeight: 12,
+            subOperations: [{ id: `${currency.id}_subOp1` }],
+            extra: { assetReference: "ar2", assetOwner: "ow2" },
+          },
+        ],
+      ],
+    ])(
+      "builds account shape with existing operations, pagination and sub accounts from %s",
+      async (_s, syncHash, expectedPagination, expectedOperations) => {
+        const oldOp = {
+          hash: "h1",
+          blockHeight: 10,
+          type: "OPT_IN",
+          extra: { pagingToken: "pt1", assetReference: "ar1", assetOwner: "ow1" },
+        };
+        const pendingOp = {
+          hash: "h0",
+          blockHeight: 10,
+          type: "OUT",
+        };
+        const initialAccount = {
+          operations: [oldOp],
+          pendingOperations: [pendingOp],
+          blockHeight: 10,
+          syncHash,
+        };
+
+        getSyncHashMock.mockReturnValue("sync-hash");
+        extractBalanceMock.mockReturnValue({ value: "1000", locked: "300" });
+        getBalanceMock.mockResolvedValue([
+          { asset: { type: "native" }, value: "1000", locked: "300" },
+          { asset: { type: "token", symbol: "TOK1" }, value: "42" },
+          { asset: { type: "token", symbol: "TOK_IGNORE" }, value: "5" },
+        ]);
+
+        getTokenFromAssetMock.mockImplementation(asset =>
+          asset.symbol === "TOK1" ? { id: `${currency.id}_token1` } : null,
+        );
+
+        const coreOp = { hash: "h2", height: 12 };
+        listOperationsMock.mockResolvedValue([[coreOp]]);
+        refreshOperationsMock.mockImplementation(ops => {
+          const op = ops[0];
+          if (op?.hash === "h0") {
+            return [{ ...op, blockHeight: 12 }];
+          }
+          return [];
+        });
+
+        adaptCoreOperationToLiveOperationMock.mockImplementation((_accId, op) => ({
+          hash: op.hash,
+          type: "IN",
+          blockHeight: 12,
+          extra: { assetReference: "ar2", assetOwner: "ow2" },
+        }));
+
+        mergeOpsMock.mockImplementation((oldOps, newOps) => [...newOps, ...oldOps]);
+        cleanedOperationMock.mockImplementation(operation => operation);
+        mergeSubAccountsMock.mockImplementation((oldSubAccounts, newSubAccounts) => [
+          ...newSubAccounts,
+          ...oldSubAccounts,
+        ]);
+
+        buildSubAccountsMock.mockReturnValue([
+          { id: `${currency.id}_subAcc1`, type: "TokenAccount" },
+        ]);
+
+        inferSubOperationsMock.mockImplementation(hash =>
+          hash === "h2" ? [{ id: `${currency.id}_subOp1` }] : [],
+        );
+
+        lastBlockMock.mockResolvedValue({ height: 123 });
+
+        const getShape = genericGetAccountShape(network, currency.id);
+        const result = await getShape(
+          {
+            address: `${currency.id}_addr1`,
+            initialAccount,
+            currency,
+            derivationMode: "",
+          } as any,
+          { paginationConfig: {} as any },
+        );
+
+        expect(chainSpecificGetAccountShapeMock).toHaveBeenCalledWith(`${currency.id}_addr1`);
+
+        expect(listOperationsMock).toHaveBeenCalledWith(`${currency.id}_addr1`, expectedPagination);
+
+        const assetsBalancePassed = buildSubAccountsMock.mock.calls[0][0].allTokenAssetsBalances;
+        expect(assetsBalancePassed).toEqual([
+          { asset: { symbol: "TOK1", type: "token" }, value: "42" },
+          { asset: { symbol: "TOK_IGNORE", type: "token" }, value: "5" },
+        ]);
+
+        const assetOpsPassed = buildSubAccountsMock.mock.calls[0][0].operations;
+        expect(assetOpsPassed).toHaveLength(1);
+        expect(assetOpsPassed[0].hash).toBe("h2");
+
+        expect(result).toMatchObject({
+          balance: new BigNumber(1000),
+          spendableBalance: new BigNumber(700),
+          blockHeight: 123,
+          operationsCount: expectedOperations.length,
+          subAccounts: [{ id: `${currency.id}_subAcc1`, type: "TokenAccount" }],
+          operations: expectedOperations,
+        });
+      },
+    );
 
     test("handles empty operations (no old ops, no new ops) and blockHeight=0", async () => {
       getBalanceMock.mockResolvedValue([{ asset: { type: "native" }, value: "0", locked: "0" }]);

package/src/bridge/generic-alpaca/utils.test.ts

@@ -466,8 +466,7 @@ describe("Alpaca utils", () => {
         ...baseOp,
         type: "OUT",
         value: BigInt(100),
-        tx: { ...baseOp.tx, fees: BigInt(25) },
-        details: { status: "failed" },
+        tx: { ...baseOp.tx, fees: BigInt(25), failed: true },
       };
 
       const result = adaptCoreOperationToLiveOperation(accountId, failedOp);

package/src/bridge/generic-alpaca/utils.ts

@@ -107,7 +107,7 @@ export function adaptCoreOperationToLiveOperation(accountId: string, op: CoreOpe
     extra.memo = op.details.memo as string;
   }
   const bnFees = new BigNumber(op.tx.fees.toString());
-  const hasFailed = op.details?.status === "failed";
+  const hasFailed = op.tx.failed;
 
   let value: BigNumber;
   if (hasFailed) {