@ledgerhq/live-common 34.52.0-nightly.20251031094135 → 34.52.0-nightly.20251101023821

package/src/bridge/generic-alpaca/types.ts

@@ -1,4 +1,9 @@
-import type { Operation, TransactionCommon } from "@ledgerhq/types-live";
+import type {
+  Operation,
+  OperationRaw,
+  TransactionCommon,
+  TransactionCommonRaw,
+} from "@ledgerhq/types-live";
 import BigNumber from "bignumber.js";
 import type { Unit } from "@ledgerhq/types-cryptoassets";
 
@@ -6,6 +11,34 @@ type NetworkInfo = {
   fees: BigNumber;
 };
 
+type NetworkInfoRaw = {
+  fees: string;
+};
+
+type Strategy = "slow" | "medium" | "fast";
+
+export type FeeData = {
+  maxFeePerGas: BigNumber | null;
+  maxPriorityFeePerGas: BigNumber | null;
+  gasPrice: BigNumber | null;
+  nextBaseFee: BigNumber | null;
+};
+
+export type FeeDataRaw = {
+  maxFeePerGas: string | null;
+  maxPriorityFeePerGas: string | null;
+  gasPrice: string | null;
+  nextBaseFee: string | null;
+};
+
+export type GasOptions = {
+  [key in Strategy]: FeeData;
+};
+
+export type GasOptionsRaw = {
+  [key in Strategy]: FeeDataRaw;
+};
+
 export type GenericTransaction = TransactionCommon & {
   family: string;
   fees?: BigNumber | null;
@@ -14,6 +47,7 @@ export type GenericTransaction = TransactionCommon & {
     parameters: { fees?: BigNumber | null };
   };
   tag?: number | null | undefined;
+  nonce?: number | null | undefined;
   feeCustomUnit?: Unit | null | undefined;
   memoType?: string | null;
   memoValue?: string | null;
@@ -31,13 +65,52 @@ export type GenericTransaction = TransactionCommon & {
   assetReference?: string;
   assetOwner?: string;
   networkInfo?: NetworkInfo | null;
-  chainId?: number;
+  chainId?: number | null;
   gasLimit?: BigNumber | null;
   gasPrice?: BigNumber | null;
   maxFeePerGas?: BigNumber | null;
   maxPriorityFeePerGas?: BigNumber | null;
+  gasOptions?: GasOptions;
+};
+
+export type GenericTransactionRaw = TransactionCommonRaw & {
+  family: string;
+  fees?: string | null;
+  storageLimit?: string | null;
+  customFees?: {
+    parameters: { fees?: string | null };
+  };
+  tag?: number | null | undefined;
+  nonce?: number | null | undefined;
+  feeCustomUnit?: Unit | null | undefined;
+  memoType?: string | null;
+  memoValue?: string | null;
+  data?: string;
+  mode?:
+    | "send"
+    | "changeTrust"
+    | "send-legacy"
+    | "send-eip1559"
+    | "delegate"
+    | "stake"
+    | "undelegate"
+    | "unstake";
+  type?: number | null;
+  assetReference?: string | null;
+  assetOwner?: string | null;
+  networkInfo?: NetworkInfoRaw | null;
+  chainId?: number | null;
+  gasLimit?: string | null;
+  gasPrice?: string | null;
+  maxFeePerGas?: string | null;
+  maxPriorityFeePerGas?: string | null;
+  gasOptions?: GasOptionsRaw;
 };
 
 export interface OperationCommon extends Operation {
   extra: Record<string, any>;
 }
+
+export interface OperationCommonRaw extends OperationRaw {
+  extra: Record<string, any>;
+}

package/src/bridge/generic-alpaca/utils.test.ts

@@ -22,6 +22,7 @@ describe("Alpaca utils", () => {
           parentType: "OPT_IN",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -32,6 +33,7 @@ describe("Alpaca utils", () => {
           parentType: "DELEGATE",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -42,6 +44,7 @@ describe("Alpaca utils", () => {
           parentType: "DELEGATE",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -52,6 +55,7 @@ describe("Alpaca utils", () => {
           parentType: "UNDELEGATE",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -62,6 +66,7 @@ describe("Alpaca utils", () => {
           parentType: "UNDELEGATE",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -72,6 +77,7 @@ describe("Alpaca utils", () => {
           parentType: "OUT",
           subType: undefined,
           parentValue: new BigNumber(50),
+          parentRecipient: "recipient-address",
         },
       ],
       [
@@ -82,6 +88,7 @@ describe("Alpaca utils", () => {
           parentType: "FEES",
           subType: "OPT_IN",
           parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
         },
       ],
       [
@@ -92,6 +99,7 @@ describe("Alpaca utils", () => {
           parentType: "FEES",
           subType: "DELEGATE",
           parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
         },
       ],
       [
@@ -102,6 +110,7 @@ describe("Alpaca utils", () => {
           parentType: "FEES",
           subType: "DELEGATE",
           parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
         },
       ],
       [
@@ -112,6 +121,7 @@ describe("Alpaca utils", () => {
           parentType: "FEES",
           subType: "UNDELEGATE",
           parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
         },
       ],
       [
@@ -122,20 +132,26 @@ describe("Alpaca utils", () => {
           parentType: "FEES",
           subType: "UNDELEGATE",
           parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
         },
       ],
       [
         "token",
         "send",
         { subAccountId: "sub-account-id" },
-        { parentType: "FEES", subType: "OUT", parentValue: new BigNumber(12) },
+        {
+          parentType: "FEES",
+          subType: "OUT",
+          parentValue: new BigNumber(12),
+          parentRecipient: "contract-address",
+        },
       ],
     ])("builds an optimistic %s operation with %s mode ", (_s, mode, params, expected) => {
       const operation = buildOptimisticOperation(
         {
           id: "parent-account-id",
           freshAddress: "account-address",
-          subAccounts: [{ id: "sub-account-id" }],
+          subAccounts: [{ id: "sub-account-id", token: { contractAddress: "contract-address" } }],
         } as Account,
         {
           mode,
@@ -156,6 +172,11 @@ describe("Alpaca utils", () => {
         fee: new BigNumber(12),
         blockHash: null,
         blockHeight: null,
+        transactionRaw: {
+          amount: expected.subType ? "0" : expected.parentValue.toFixed(),
+          fees: "12",
+          recipient: expected.parentRecipient,
+        },
         ...(expected.subType
           ? {
               subOperations: [
@@ -168,6 +189,11 @@ describe("Alpaca utils", () => {
                   value: new BigNumber(50),
                   blockHash: null,
                   blockHeight: null,
+                  transactionRaw: {
+                    amount: "50",
+                    fees: "12",
+                    recipient: "recipient-address",
+                  },
                 },
               ],
             }

package/src/bridge/generic-alpaca/utils.ts

@@ -9,7 +9,15 @@ import {
 } from "@ledgerhq/coin-framework/api/types";
 import { findCryptoCurrencyById } from "@ledgerhq/cryptoassets/currencies";
 import { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
-import { GenericTransaction, OperationCommon } from "./types";
+import {
+  FeeData,
+  FeeDataRaw,
+  GasOptions,
+  GasOptionsRaw,
+  GenericTransaction,
+  GenericTransactionRaw,
+  OperationCommon,
+} from "./types";
 
 export function findCryptoCurrencyByNetwork(network: string): CryptoCurrency | undefined {
   const networksRemap = {
@@ -189,6 +197,7 @@ export function transactionToIntent(
     data: Buffer.isBuffer(transaction.data)
       ? { type: "buffer", value: transaction.data }
       : { type: "none" },
+    sequence: transaction.nonce ?? undefined,
   };
   if (transaction.assetReference && transaction.assetOwner) {
     const { subAccountId } = transaction;
@@ -216,6 +225,105 @@ export function transactionToIntent(
   return res;
 }
 
+function toFeeDataRaw(data: FeeData): FeeDataRaw {
+  return {
+    gasPrice: data.gasPrice?.toFixed() ?? null,
+    maxFeePerGas: data.maxFeePerGas?.toFixed() ?? null,
+    maxPriorityFeePerGas: data.maxPriorityFeePerGas?.toFixed() ?? null,
+    nextBaseFee: data.nextBaseFee?.toFixed() ?? null,
+  };
+}
+
+function toGasOptionRaw(options: GasOptions): GasOptionsRaw {
+  return {
+    fast: toFeeDataRaw(options.fast),
+    medium: toFeeDataRaw(options.medium),
+    slow: toFeeDataRaw(options.slow),
+  };
+}
+
+function toGenericTransactionRaw(transaction: GenericTransaction): GenericTransactionRaw {
+  const raw: GenericTransactionRaw = {
+    amount: transaction.amount.toString(),
+    recipient: transaction.recipient,
+    family: transaction.family,
+  };
+
+  if ("useAllAmount" in transaction) {
+    raw.useAllAmount = transaction.useAllAmount;
+  }
+
+  const stringFieldsToPropagate = [
+    "memoType",
+    "memoValue",
+    "assetReference",
+    "assetOwner",
+  ] as const;
+  for (const field of stringFieldsToPropagate) {
+    if (field in transaction) {
+      raw[field] = transaction[field];
+    }
+  }
+
+  const numberFieldsToPropagate = ["tag", "nonce", "type", "chainId"] as const;
+  for (const field of numberFieldsToPropagate) {
+    if (field in transaction) {
+      raw[field] = transaction[field];
+    }
+  }
+
+  const bigNumberFieldsToPropagate = [
+    "fees",
+    "storageLimit",
+    "gasLimit",
+    "gasPrice",
+    "maxFeePerGas",
+    "maxPriorityFeePerGas",
+  ] as const;
+  for (const field of bigNumberFieldsToPropagate) {
+    if (field in transaction) {
+      raw[field] = transaction[field]?.toFixed();
+    }
+  }
+
+  if ("customFees" in transaction) {
+    raw.customFees =
+      transaction.customFees && "fees" in transaction.customFees.parameters
+        ? {
+            parameters: { fees: transaction.customFees.parameters.fees?.toFixed() },
+          }
+        : { parameters: {} };
+  }
+
+  if ("feesStrategy" in transaction) {
+    raw.feesStrategy = transaction.feesStrategy;
+  }
+
+  if ("mode" in transaction) {
+    raw.mode = transaction.mode;
+  }
+
+  if ("feeCustomUnit" in transaction) {
+    raw.feeCustomUnit = transaction.feeCustomUnit;
+  }
+
+  if ("data" in transaction) {
+    raw.data = transaction.data?.toString("hex");
+  }
+
+  if ("networkInfo" in transaction) {
+    raw.networkInfo = transaction.networkInfo && {
+      fees: transaction.networkInfo.fees.toFixed(),
+    };
+  }
+
+  if ("gasOptions" in transaction) {
+    raw.gasOptions = transaction.gasOptions && toGasOptionRaw(transaction.gasOptions);
+  }
+
+  return raw;
+}
+
 export const buildOptimisticOperation = (
   account: Account,
   transaction: GenericTransaction,
@@ -242,6 +350,7 @@ export const buildOptimisticOperation = (
   const { subAccountId } = transaction;
   const { subAccounts } = account;
   const parentType = subAccountId ? "FEES" : type;
+  const tokenAccount = subAccountId ? subAccounts?.find(ta => ta.id === subAccountId) : null;
 
   const operation: Operation = {
     id: encodeOperationId(account.id, "", parentType),
@@ -256,6 +365,13 @@ export const buildOptimisticOperation = (
     transactionSequenceNumber: sequenceNumber ?? 0,
     accountId: account.id,
     date: new Date(),
+    transactionRaw: toGenericTransactionRaw({
+      ...transaction,
+      nonce: sequenceNumber,
+      ...(tokenAccount
+        ? { recipient: tokenAccount.token.contractAddress, amount: new BigNumber(0) }
+        : {}),
+    }),
     extra: {
       ledgerOpType: type,
       blockTime: new Date(),
@@ -263,7 +379,6 @@ export const buildOptimisticOperation = (
     },
   };
 
-  const tokenAccount = subAccountId ? subAccounts?.find(ta => ta.id === subAccountId) : null;
   if (tokenAccount && subAccountId) {
     operation.subOperations = [
       {
@@ -278,6 +393,10 @@ export const buildOptimisticOperation = (
         recipients: [transaction.recipient],
         accountId: subAccountId,
         date: new Date(),
+        transactionRaw: toGenericTransactionRaw({
+          ...transaction,
+          nonce: sequenceNumber,
+        }),
         extra: {
           ledgerOpType: type,
         },

package/src/e2e/speculosAppVersion.ts

@@ -16,6 +16,7 @@ export function getSpeculosModel(): DeviceModelId {
     case CryptoWallet.STAX.name:
       return DeviceModelId.stax;
     case CryptoWallet.FLEX.name:
+    case DeviceModelId.europa:
       return DeviceModelId.europa;
     case CryptoWallet.LNSP.name:
     default:

package/src/featureFlags/defaultFeatures.ts

@@ -568,6 +568,7 @@ export const DEFAULT_FEATURES: Features = {
       accounts: true,
       settings: true,
       onboarding: true,
+      postOnboarding: true,
     },
   },
   lldNanoSUpsellBanners: {

package/src/market/hooks/useMarketDataProvider.ts

@@ -18,7 +18,7 @@ import { REFETCH_TIME_ONE_MINUTE, BASIC_REFETCH, ONE_DAY } from "../utils/timers
 import {
   MarketCurrencyRequestParams,
   MarketListRequestParams,
-  CurrencyData,
+  MarketCurrencyData,
   HashMapBody,
   MarketItemResponse,
   MarketListRequestResult,
@@ -118,7 +118,7 @@ export function useMarketData(props: MarketListRequestParams): MarketListRequest
 function combineMarketData(
   results: UseQueryResult<
     {
-      formattedData: CurrencyData[];
+      formattedData: MarketCurrencyData[];
       page: number;
     },
     Error

package/src/market/utils/currencyFormatter.ts

@@ -1,6 +1,6 @@
 import { CryptoCurrency, TokenCurrency } from "@ledgerhq/types-cryptoassets";
 import {
-  CurrencyData,
+  MarketCurrencyData,
   KeysPriceChange,
   MarketItemPerformer,
   MarketItemResponse,
@@ -48,14 +48,14 @@ function sparklineAsSvgData(points: number[]): SparklineSvgData {
 export function currencyFormatter(
   data: MarketItemResponse[],
   cryptoCurrenciesList: (CryptoCurrency | TokenCurrency)[],
-): CurrencyData[] {
+): MarketCurrencyData[] {
   return data.map((currency: MarketItemResponse) => format(currency, cryptoCurrenciesList));
 }
 
 export const format = (
   currency: MarketItemResponse,
   cryptoCurrenciesList?: (CryptoCurrency | TokenCurrency)[],
-): CurrencyData => {
+): MarketCurrencyData => {
   const ledgerIdsSet = new Set(currency.ledgerIds.map(id => id.toLowerCase()));
 
   const internalCurrency = cryptoCurrenciesList?.find(({ id }) =>

package/src/market/utils/queryKeys.ts

@@ -1,5 +1,4 @@
 export const QUERY_KEY = {
-  CurrencyData: "CurrencyData",
   CurrencyDataRaw: "CurrencyDataRaw",
   CurrencyChartData: "CurrencyChartData",
   SupportedCounterCurrencies: "SupportedCounterCurrencies",

package/src/market/utils/types.ts

@@ -33,7 +33,7 @@ export type MarketListRequestParams = {
 };
 
 export type MarketListRequestResult = {
-  data: CurrencyData[];
+  data: MarketCurrencyData[];
   isPending: boolean;
   isLoading: boolean;
   isError: boolean;
@@ -45,7 +45,7 @@ export type HashMapBody = {
   refetch: (options?: RefetchOptions | undefined) => Promise<
     QueryObserverResult<
       {
-        formattedData: CurrencyData[];
+        formattedData: MarketCurrencyData[];
         page: number;
       },
       Error
@@ -80,7 +80,7 @@ export enum KeysPriceChange {
   year = "1y",
 }
 
-export type CurrencyData = {
+export type MarketCurrencyData = {
   id: string;
   ledgerIds: string[];
   name: string;
@@ -113,13 +113,13 @@ export type SingleCoinState = {
   loadingChart: boolean;
   error?: Error;
   supportedCounterCurrencies: string[];
-  selectedCoinData?: CurrencyData;
+  selectedCoinData?: MarketCurrencyData;
   counterCurrency?: string;
 };
 
 export type State = SingleCoinState & {
   ready: boolean;
-  marketData?: CurrencyData[];
+  marketData?: MarketCurrencyData[];
   requestParams: MarketListRequestParams;
   page: number;
   endOfList: boolean;
@@ -187,7 +187,7 @@ export type MarketItemPerformer = {
 
 export type MarketDataApi = {
   setSupportedCoinsList: () => Promise<SupportedCoins>;
-  listPaginated: (params: MarketListRequestParams) => Promise<CurrencyData[]>;
+  listPaginated: (params: MarketListRequestParams) => Promise<MarketCurrencyData[]>;
   supportedCounterCurrencies: () => Promise<string[]>;
   currencyChartData: (
     params: MarketCurrencyChartDataRequestParams,

package/src/postOnboarding/hooks/usePostOnboardingHubState.test.ts

@@ -4,7 +4,11 @@
 import { useFeatureFlags } from "../../featureFlags";
 import { hubStateSelector } from "../reducer";
 import { usePostOnboardingContext } from "./usePostOnboardingContext";
-import { getPostOnboardingAction, mockedFeatureIdToTest } from "../mock";
+import {
+  getPostOnboardingAction,
+  mockedFeatureIdToTest,
+  mockedFeatureParamIdToTest,
+} from "../mock";
 import { renderHook } from "@testing-library/react";
 import { DeviceModelId } from "@ledgerhq/types-devices";
 import { PostOnboardingActionId } from "@ledgerhq/types-live";
@@ -19,10 +23,16 @@ jest.mock("../reducer");
 
 const mockedUseFeatureFlags = jest.mocked(useFeatureFlags);
 
-const mockedGetFeatureWithMockFeatureEnabled = enabled => ({
+const mockedGetFeatureWithMockFeatureEnabled = (enabled, paramEnabled = true) => ({
   isFeature: () => true,
   getFeature: id => {
-    if (id === mockedFeatureIdToTest) return { enabled };
+    if (id === mockedFeatureIdToTest)
+      return {
+        enabled,
+        params: {
+          [mockedFeatureParamIdToTest]: paramEnabled,
+        },
+      };
     return { enabled: true };
   },
   overrideFeature: () => {},
@@ -134,6 +144,23 @@ describe("usePostOnboardingHubState", () => {
     expect(lastActionCompleted).toBe(null);
   });
 
+  it("should not return actions that have a disabled feature param flag ", () => {
+    const state = stateAllCompleted;
+    mockedHubStateSelector.mockReturnValue(state);
+    mockedUseFeatureFlags.mockReturnValue(mockedGetFeatureWithMockFeatureEnabled(true, false));
+
+    const {
+      result: {
+        current: { actionsState, lastActionCompleted },
+      },
+    } = renderHook(() => usePostOnboardingHubState());
+
+    expect(actionsState.find(action => action.featureFlagId === mockedFeatureIdToTest)).toBe(
+      undefined,
+    );
+    expect(lastActionCompleted).toBe(null);
+  });
+
   it("should return actions that have a feature flag enabled", () => {
     const state = stateAllCompleted;
     mockedHubStateSelector.mockReturnValue(state);

package/src/postOnboarding/hooks/usePostOnboardingHubState.ts

@@ -1,10 +1,23 @@
 import { useSelector } from "react-redux";
 import { useMemo } from "react";
-import { PostOnboardingHubState } from "@ledgerhq/types-live";
-import { useFeatureFlags } from "../../featureFlags";
+import { PostOnboardingAction, PostOnboardingHubState } from "@ledgerhq/types-live";
+import { FeatureFlagsContextValue, useFeatureFlags } from "../../featureFlags";
 import { hubStateSelector } from "../reducer";
 import { usePostOnboardingContext } from "./usePostOnboardingContext";
 
+const getIsFeatureEnabled = (
+  action: PostOnboardingAction | undefined,
+  getFeature: FeatureFlagsContextValue["getFeature"],
+) => {
+  if (!action) return false;
+  if (!action.featureFlagId) return true;
+
+  const flag = getFeature(action.featureFlagId);
+  if (!flag?.enabled) return false;
+
+  return !action.featureFlagParamId || !!flag.params?.[action.featureFlagParamId];
+};
+
 /**
  * @returns an object representing the state that should be rendered on the post
  * onboarding hub screen.
@@ -26,9 +39,12 @@ export function usePostOnboardingHubState(): PostOnboardingHubState {
         actionsState: [],
         postOnboardingInProgress: hubState.postOnboardingInProgress,
       };
+
     const actionsState = hubState.actionsToComplete.flatMap(actionId => {
       const action = getPostOnboardingAction(actionId);
-      if (!action || (action.featureFlagId && !getFeature(action.featureFlagId)?.enabled)) {
+      const isFeatureEnabled = getIsFeatureEnabled(action, getFeature);
+
+      if (!action || !isFeatureEnabled) {
         return [];
       }
       return [{ ...action, completed: !!hubState.actionsCompleted[actionId] }];
@@ -38,9 +54,7 @@ export function usePostOnboardingHubState(): PostOnboardingHubState {
       : null;
 
     const isLastActionCompletedEnabled =
-      lastActionCompleted &&
-      (!lastActionCompleted.featureFlagId ||
-        getFeature(lastActionCompleted.featureFlagId)?.enabled);
+      lastActionCompleted && getIsFeatureEnabled(lastActionCompleted, getFeature);
 
     return {
       deviceModelId: hubState.deviceModelId,

package/src/postOnboarding/mock.ts

@@ -5,6 +5,7 @@ import { FeatureId, PostOnboardingAction, PostOnboardingActionId } from "@ledger
 const MockIcon = () => null;
 
 export const mockedFeatureIdToTest: FeatureId = "mockFeature";
+export const mockedFeatureParamIdToTest: string = "mockFeatureParam";
 
 export const claimTestMock: PostOnboardingAction = {
   id: PostOnboardingActionId.claimMock,
@@ -21,6 +22,7 @@ export const personalizeTestMock: PostOnboardingAction = {
   id: PostOnboardingActionId.personalizeMock,
   Icon: MockIcon,
   featureFlagId: mockedFeatureIdToTest,
+  featureFlagParamId: mockedFeatureParamIdToTest,
   title: `Personalize my device`,
   titleCompleted: `Personalize my device`,
   description: "By customizing the screen.",