@ledgerhq/live-common 34.52.0-nightly.20251031023756 → 34.52.0-nightly.20251101023821

package/src/postOnboarding/hooks/usePostOnboardingHubState.ts

@@ -1,10 +1,23 @@
 import { useSelector } from "react-redux";
 import { useMemo } from "react";
-import { PostOnboardingHubState } from "@ledgerhq/types-live";
-import { useFeatureFlags } from "../../featureFlags";
+import { PostOnboardingAction, PostOnboardingHubState } from "@ledgerhq/types-live";
+import { FeatureFlagsContextValue, useFeatureFlags } from "../../featureFlags";
 import { hubStateSelector } from "../reducer";
 import { usePostOnboardingContext } from "./usePostOnboardingContext";
 
+const getIsFeatureEnabled = (
+  action: PostOnboardingAction | undefined,
+  getFeature: FeatureFlagsContextValue["getFeature"],
+) => {
+  if (!action) return false;
+  if (!action.featureFlagId) return true;
+
+  const flag = getFeature(action.featureFlagId);
+  if (!flag?.enabled) return false;
+
+  return !action.featureFlagParamId || !!flag.params?.[action.featureFlagParamId];
+};
+
 /**
  * @returns an object representing the state that should be rendered on the post
  * onboarding hub screen.
@@ -26,9 +39,12 @@ export function usePostOnboardingHubState(): PostOnboardingHubState {
         actionsState: [],
         postOnboardingInProgress: hubState.postOnboardingInProgress,
       };
+
     const actionsState = hubState.actionsToComplete.flatMap(actionId => {
       const action = getPostOnboardingAction(actionId);
-      if (!action || (action.featureFlagId && !getFeature(action.featureFlagId)?.enabled)) {
+      const isFeatureEnabled = getIsFeatureEnabled(action, getFeature);
+
+      if (!action || !isFeatureEnabled) {
         return [];
       }
       return [{ ...action, completed: !!hubState.actionsCompleted[actionId] }];
@@ -38,9 +54,7 @@ export function usePostOnboardingHubState(): PostOnboardingHubState {
       : null;
 
     const isLastActionCompletedEnabled =
-      lastActionCompleted &&
-      (!lastActionCompleted.featureFlagId ||
-        getFeature(lastActionCompleted.featureFlagId)?.enabled);
+      lastActionCompleted && getIsFeatureEnabled(lastActionCompleted, getFeature);
 
     return {
       deviceModelId: hubState.deviceModelId,

package/src/postOnboarding/mock.ts

@@ -5,6 +5,7 @@ import { FeatureId, PostOnboardingAction, PostOnboardingActionId } from "@ledger
 const MockIcon = () => null;
 
 export const mockedFeatureIdToTest: FeatureId = "mockFeature";
+export const mockedFeatureParamIdToTest: string = "mockFeatureParam";
 
 export const claimTestMock: PostOnboardingAction = {
   id: PostOnboardingActionId.claimMock,
@@ -21,6 +22,7 @@ export const personalizeTestMock: PostOnboardingAction = {
   id: PostOnboardingActionId.personalizeMock,
   Icon: MockIcon,
   featureFlagId: mockedFeatureIdToTest,
+  featureFlagParamId: mockedFeatureParamIdToTest,
   title: `Personalize my device`,
   titleCompleted: `Personalize my device`,
   description: "By customizing the screen.",