@ledgerhq/live-common 34.46.0-nightly.3 → 34.46.0-nightly.5

package/src/bridge/generic-alpaca/estimateMaxSpendable.ts

@@ -19,18 +19,24 @@ export function genericEstimateMaxSpendable(
       ...transaction,
       amount: mainAccount.spendableBalance,
       useAllAmount: true,
-      fees: transaction?.fees ? BigInt(transaction.fees.toString()) : 0n,
     };
-    const fees = await getAlpacaApi(network, kind).estimateFees(
-      transactionToIntent(mainAccount, draftTransaction),
-    );
+
+    let fees = transaction?.fees;
+    if (transaction?.fees === null || transaction?.fees === undefined) {
+      fees = (
+        await getAlpacaApi(network, kind).estimateFees(
+          transactionToIntent(mainAccount, draftTransaction),
+        )
+      ).value;
+    }
     const { amount } = await getAlpacaApi(network, kind).validateIntent(
       transactionToIntent(account, { ...draftTransaction }),
+      { value: transaction?.fees ? BigInt(transaction.fees.toString()) : 0n },
     );
     if (network === "stellar") {
       return amount > 0 ? new BigNumber(amount.toString()) : new BigNumber(0);
     }
-    const bnFee = BigNumber(fees.value.toString());
+    const bnFee = BigNumber(fees.toString());
     return BigNumber.max(0, account.spendableBalance.minus(bnFee));
   };
 }

package/src/bridge/generic-alpaca/getTransactionStatus.ts

@@ -3,6 +3,7 @@ import { AccountAwaitingSendPendingOperations } from "@ledgerhq/errors";
 import BigNumber from "bignumber.js";
 import { getAlpacaApi } from "./alpaca";
 import { transactionToIntent } from "./utils";
+// import { FeeEstimation } from "@ledgerhq/coin-framework/api/types";
 
 // => alpaca validateIntent
 export function genericGetTransactionStatus(
@@ -26,7 +27,6 @@ export function genericGetTransactionStatus(
       mode: transaction?.mode,
       recipient: transaction.recipient,
       amount: transaction.amount ?? new BigNumber(0),
-      fees: transaction.fees ? BigInt(transaction.fees.toString()) : 0n,
       useAllAmount: !!transaction.useAllAmount,
       assetReference: transaction.assetReference || "",
       assetOwner: transaction.assetOwner || "",
@@ -46,6 +46,7 @@ export function genericGetTransactionStatus(
 
     const { errors, warnings, estimatedFees, amount, totalSpent } = await alpacaApi.validateIntent(
       transactionToIntent(account, draftTransaction),
+      { value: transaction.fees ? BigInt(transaction.fees.toString()) : 0n },
     );
 
     return Promise.resolve({

package/src/bridge/generic-alpaca/prepareTransaction.ts

@@ -2,7 +2,7 @@ import { Account, AccountBridge, TransactionCommon } from "@ledgerhq/types-live"
 import { getAlpacaApi } from "./alpaca";
 import { transactionToIntent } from "./utils";
 import BigNumber from "bignumber.js";
-import { NetworkInfo } from "./createTransaction";
+import { FeeEstimation } from "@ledgerhq/coin-framework/api/types";
 
 function bnEq(a: BigNumber | null | undefined, b: BigNumber | null | undefined): boolean {
   return !a && !b ? true : !a || !b ? false : a.eq(b);
@@ -16,31 +16,35 @@ export function genericPrepareTransaction(
     account,
     transaction: TransactionCommon & {
       fees: BigNumber | null | undefined;
+      customFees?: FeeEstimation;
       assetReference?: string;
       assetOwner?: string;
       subAccountId?: string;
-      networkInfo?: NetworkInfo | null;
     },
   ) => {
     const [assetReference, assetOwner] = getAssetInfos(transaction);
-    const fees = await getAlpacaApi(network, kind).estimateFees(
-      transactionToIntent(account, {
-        ...transaction,
-        fees: transaction.fees ? BigInt(transaction.fees.toString()) : 0n,
-      }),
-    );
-    // NOTE: this is problematic, we should maybe have a method / object that lists what field warrant an update per chain
-    // for reference, stellar checked this:
-    // transaction.networkInfo !== networkInfo ||
-    // transaction.baseReserve !== baseReserve
-    if (!bnEq(transaction.fees, new BigNumber(fees.value.toString()))) {
+
+    let fees = transaction.customFees?.parameters?.fees || null;
+    if (fees === null) {
+      fees = (
+        await getAlpacaApi(network, kind).estimateFees(
+          transactionToIntent(account, {
+            ...transaction,
+          }),
+        )
+      ).value;
+    }
+
+    if (!bnEq(transaction.fees, new BigNumber(fees.toString()))) {
       return {
         ...transaction,
-        fees: new BigNumber(fees.value.toString()),
+        fees: new BigNumber(fees.toString()),
         assetReference,
         assetOwner,
-        networkInfo: {
-          fees: new BigNumber(fees.value.toString()),
+        customFees: {
+          parameters: {
+            fees: new BigNumber(fees.toString()),
+          },
         },
       };
     }

package/src/bridge/generic-alpaca/signOperation.ts

@@ -95,7 +95,6 @@ export const genericSignOperation =
           const draftTransaction = {
             recipient: transaction.recipient,
             amount: transaction.amount ?? 0,
-            fees: fees,
             useAllAmount: !!transaction.useAllAmount,
             assetReference: transaction?.["assetReference"] || "",
             assetOwner: transaction?.["assetOwner"] || "",
@@ -103,6 +102,7 @@ export const genericSignOperation =
           };
           const { amount } = await getAlpacaApi(network, kind).validateIntent(
             transactionToIntent(account, draftTransaction),
+            { value: fees },
           );
           transaction.amount = new BigNumber(amount.toString());
         }
@@ -110,7 +110,7 @@ export const genericSignOperation =
           const derivationPath = account.freshAddressPath;
           const { publicKey } = (await signer.getAddress(derivationPath)) as Result;
 
-          let transactionIntent = transactionToIntent(account, { ...transaction, fees });
+          let transactionIntent = transactionToIntent(account, { ...transaction });
           transactionIntent.senderPublicKey = publicKey;
 
           // Enrich with memo and asset information
@@ -125,6 +125,7 @@ export const genericSignOperation =
           /* Craft unsigned blob via Alpaca */
           const unsigned: string = await getAlpacaApi(network, kind).craftTransaction(
             transactionIntent,
+            { value: fees },
           );
 
           /* Notify UI that the device is now showing the tx */

package/src/bridge/generic-alpaca/tests/prepareTransaction.test.ts

@@ -47,7 +47,7 @@ describe("genericPrepareTransaction", () => {
     expect((result as any).fees.toString()).toBe(newFee.toString());
     expect(transactionToIntent).toHaveBeenCalledWith(
       account,
-      expect.objectContaining({ ...baseTransaction, fees: 500n }),
+      expect.objectContaining(baseTransaction),
     );
   });
 

package/src/bridge/generic-alpaca/utils.ts

@@ -94,7 +94,6 @@ export function transactionToIntent(
     assetOwner?: string;
     assetReference?: string;
     mode?: string;
-    fees?: bigint | null | undefined;
     memoType?: string;
     memoValue?: string;
     useAllAmount?: boolean;
@@ -114,7 +113,6 @@ export function transactionToIntent(
     }
   }
   const res: TransactionIntent & { memo?: { type: string; value?: string } } = {
-    fees: transaction?.fees ? transaction.fees : null,
     type: transactionType,
     sender: account.freshAddress,
     recipient: transaction.recipient,

package/src/currencies/index.ts

@@ -28,7 +28,6 @@ export {
   sanitizeValueString,
   formatCurrencyUnit,
   type formatCurrencyUnitOptions,
-  findCurrencyByTicker,
   parseCurrencyUnit,
   toLocaleString,
   isCurrencySupported,

package/src/currencies/sortByMarketcap.test.ts

@@ -1,9 +1,10 @@
 import { sortCurrenciesByIds } from "./sortByMarketcap";
-import { findCurrencyByTicker, listCryptoCurrencies, listTokens } from ".";
+import { listCryptoCurrencies, listTokens } from ".";
 import { getBTCValues } from "@ledgerhq/live-countervalues/mock";
 import { CURRENCIES_LIST, IDS } from "./mock";
 import { setCryptoAssetsStore as setCryptoAssetsStoreForCoinFramework } from "@ledgerhq/coin-framework/crypto-assets/index";
 import type { CryptoAssetsStore } from "@ledgerhq/types-live";
+import { findCurrencyByTicker } from "@ledgerhq/live-countervalues/findCurrencyByTicker";
 
 // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
 setCryptoAssetsStoreForCoinFramework({

package/src/domain/getTokensWithFunds.test.ts

@@ -1,5 +1,5 @@
 import { genAccount } from "@ledgerhq/coin-framework/lib/mocks/account";
-import { getCryptoCurrencyById } from "@ledgerhq/live-common/currencies/index";
+import { getCryptoCurrencyById } from "../currencies/index";
 import { Account } from "@ledgerhq/types-live";
 import BigNumber from "bignumber.js";
 import { getTokensWithFunds } from "./getTokensWithFunds";

package/src/e2e/enum/AppInfos.ts

@@ -1,4 +1,4 @@
-export type AppInfosType = AppInfos;
+export type SpeculosAppType = AppInfos;
 
 export class AppInfos {
   constructor(public readonly name: string) {}

package/src/e2e/enum/Provider.ts

@@ -16,8 +16,8 @@ export class Provider {
   static readonly LIFI = new Provider("lifi", "LI.FI", false, true, false);
   static readonly CIC = new Provider("cic", "CIC", false, true, true);
   static readonly COINBASE = new Provider("coinbase", "Coinbase", false, true, true);
-  static readonly KILN = new Provider("kiln", "Kiln staking Pool", false, true, true);
-  static readonly STADER_LABS = new Provider("stader", "Stader Labs", false, true, true);
+  static readonly KILN = new Provider("kiln_pooling", "Kiln staking Pool", false, true, true);
+  static readonly STADER_LABS = new Provider("stader-eth", "Stader Labs", false, true, true);
   static readonly LIDO = new Provider("lido", "Lido", false, true, true);
   static readonly TRANSAK = new Provider("transak", "Transak", false, true, true);
 

package/src/e2e/speculos.ts

@@ -14,13 +14,13 @@ import { CryptoCurrency } from "@ledgerhq/types-cryptoassets";
 import axios, { AxiosError, AxiosResponse } from "axios";
 import { getEnv } from "@ledgerhq/live-env";
 import { getCryptoCurrencyById } from "../currencies";
-import { DeviceLabels } from "../e2e/enum/DeviceLabels";
+import { DeviceLabels } from "./enum/DeviceLabels";
 import { Account } from "./enum/Account";
 import { Device as CryptoWallet } from "./enum/Device";
 import { Currency } from "./enum/Currency";
 import expect from "expect";
 import { sendBTCBasedCoin } from "./families/bitcoin";
-import { sendEVM, sendEvmNFT } from ".//families/evm";
+import { sendEVM, sendEvmNFT } from "./families/evm";
 import { sendPolkadot } from "./families/polkadot";
 import { sendAlgorand } from "./families/algorand";
 import { sendTron } from "./families/tron";
@@ -385,13 +385,12 @@ export async function startSpeculos(
     onSpeculosDeviceCreated,
   };
   try {
-    const device = isSpeculosRemote
+    return isSpeculosRemote
       ? await createSpeculosDeviceCI(deviceParams)
       : await createSpeculosDevice(deviceParams).then(device => {
           invariant(device.ports.apiPort, "[E2E] Speculos apiPort is not defined");
           return { id: device.id, port: device.ports.apiPort };
         });
-    return device;
   } catch (e: unknown) {
     console.error(e);
     log("engine", `test ${testName} failed with ${String(e)}`);

package/src/e2e/speculosCI.ts

@@ -21,6 +21,14 @@ function uniqueId(): string {
   return timestamp + randomString;
 }
 
+function slugify(name: string): string {
+  return name
+    .toLowerCase()
+    .trim()
+    .replace(/[^a-z0-9]+/g, "-")
+    .replace(/^-+|-+$/g, "");
+}
+
 /**
  * Helper function to make API requests with error handling
  */
@@ -58,10 +66,14 @@ async function githubApiRequest<T = unknown>({
   }
 }
 
-function waitForSpeculosReady(url: string, { interval = 2000, timeout = 300_000 } = {}) {
+export function waitForSpeculosReady(
+  deviceId: string,
+  { interval = 2_000, timeout = 150_000 } = {},
+) {
   return new Promise((resolve, reject) => {
     const startTime = Date.now();
     let currentRequest: ReturnType<typeof https.get> | null = null;
+    const url = getSpeculosAddress(deviceId);
 
     function cleanup() {
       if (currentRequest) {
@@ -151,22 +163,22 @@ function createStartPayload(deviceParams: DeviceParams, runId: string) {
 export async function createSpeculosDeviceCI(
   deviceParams: DeviceParams,
 ): Promise<SpeculosDevice | undefined> {
+  const runId = `${slugify(deviceParams.appName)}-${uniqueId()}`;
   try {
-    const runId = uniqueId();
-    console.warn("Creating remote speculos:", runId);
     const data = createStartPayload(deviceParams, runId);
     await githubApiRequest({ urlSuffix: START_WORKFLOW_ID, data });
-    await waitForSpeculosReady(getSpeculosAddress(runId));
-
     return {
       id: runId,
       port: speculosPort,
     };
   } catch (e: unknown) {
-    console.error(e);
     console.warn(
       `Creating remote speculos ${deviceParams.appName}:${deviceParams.appVersion} failed with ${String(e)}`,
     );
+    return {
+      id: runId,
+      port: 0,
+    };
   }
 }
 

package/src/families/evm/setup.ts

@@ -21,6 +21,15 @@ import { type DeviceManagementKit } from "@ledgerhq/device-management-kit";
 import { DmkSignerEth, LegacySignerEth } from "@ledgerhq/live-signer-evm";
 import { EvmSigner } from "@ledgerhq/coin-evm/types/signer";
 import { getCryptoAssetsStore } from "../../bridge/crypto-assets";
+import { LiveConfig } from "@ledgerhq/live-config/LiveConfig";
+import { setShouldSkipTokenLoading } from "@ledgerhq/coin-evm/bridge/preload";
+
+try {
+  const isCALLazyLoadingEnabled = LiveConfig.getValueByKey("feature_cal_lazy_loading") === "true";
+  setShouldSkipTokenLoading(Boolean(isCALLazyLoadingEnabled));
+} catch (error) {
+  setShouldSkipTokenLoading(false);
+}
 
 const createSigner: CreateSigner<EvmSigner> = (transport: Transport) => {
   if (isDmkTransport(transport)) {